[INFO] crate xmlhelper 0.1.0 is already in cache [INFO] extracting crate xmlhelper 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/xmlhelper/0.1.0 [INFO] extracting crate xmlhelper 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlhelper/0.1.0 [INFO] validating manifest of xmlhelper-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xmlhelper-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xmlhelper-0.1.0 [INFO] finished frobbing xmlhelper-0.1.0 [INFO] frobbed toml for xmlhelper-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/xmlhelper/0.1.0/Cargo.toml [INFO] started frobbing xmlhelper-0.1.0 [INFO] finished frobbing xmlhelper-0.1.0 [INFO] frobbed toml for xmlhelper-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlhelper/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xmlhelper-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xmlhelper/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15f910a70b6e9711448796ae13973f56ba7de049ba858115954221d802bd24cd [INFO] running `"docker" "start" "-a" "15f910a70b6e9711448796ae13973f56ba7de049ba858115954221d802bd24cd"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking xml-rs v0.6.1 [INFO] [stderr] Checking backtrace-sys v0.1.28 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking xmlhelper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:153:7 [INFO] [stderr] | [INFO] [stderr] 153 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:155:7 [INFO] [stderr] | [INFO] [stderr] 155 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:153:7 [INFO] [stderr] | [INFO] [stderr] 153 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:155:7 [INFO] [stderr] | [INFO] [stderr] 155 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | self.level = self.level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 41 | | match $stream.next() { [INFO] [stderr] 42 | | Some(Ok($pattern)) => (), [INFO] [stderr] 43 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 255 | Ok(try_consume_event!(stream, XmlEvent::StartDocument { .. })) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 40 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 41 | | match $stream.next() { [INFO] [stderr] 42 | | Some(Ok($pattern)) => (), [INFO] [stderr] 43 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 260 | Ok(try_consume_event!(stream, XmlEvent::EndDocument)) [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 40 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decode.rs:295:10 [INFO] [stderr] | [INFO] [stderr] 295 | if let None = stream.peek() { [INFO] [stderr] | ___- ^^^^ [INFO] [stderr] 296 | | return "".parse().map_err(|err| { [INFO] [stderr] 297 | | ErrorKind::ParseString("".to_owned(), format!("{}", err)).into() [INFO] [stderr] 298 | | }); [INFO] [stderr] 299 | | } [INFO] [stderr] | |___- help: try this: `if stream.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:312:50 [INFO] [stderr] | [INFO] [stderr] 312 | Some(Ok(XmlEvent::StartElement { .. })) => depth = depth + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:313:48 [INFO] [stderr] | [INFO] [stderr] 313 | Some(Ok(XmlEvent::EndElement { .. })) => depth = depth - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | self.level = self.level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 41 | | match $stream.next() { [INFO] [stderr] 42 | | Some(Ok($pattern)) => (), [INFO] [stderr] 43 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 255 | Ok(try_consume_event!(stream, XmlEvent::StartDocument { .. })) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 40 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:40:11 [INFO] [stderr] | [INFO] [stderr] 40 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 41 | | match $stream.next() { [INFO] [stderr] 42 | | Some(Ok($pattern)) => (), [INFO] [stderr] 43 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 260 | Ok(try_consume_event!(stream, XmlEvent::EndDocument)) [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 40 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decode.rs:295:10 [INFO] [stderr] | [INFO] [stderr] 295 | if let None = stream.peek() { [INFO] [stderr] | ___- ^^^^ [INFO] [stderr] 296 | | return "".parse().map_err(|err| { [INFO] [stderr] 297 | | ErrorKind::ParseString("".to_owned(), format!("{}", err)).into() [INFO] [stderr] 298 | | }); [INFO] [stderr] 299 | | } [INFO] [stderr] | |___- help: try this: `if stream.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:312:50 [INFO] [stderr] | [INFO] [stderr] 312 | Some(Ok(XmlEvent::StartElement { .. })) => depth = depth + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode.rs:313:48 [INFO] [stderr] | [INFO] [stderr] 313 | Some(Ok(XmlEvent::EndElement { .. })) => depth = depth - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.24s [INFO] running `"docker" "inspect" "15f910a70b6e9711448796ae13973f56ba7de049ba858115954221d802bd24cd"` [INFO] running `"docker" "rm" "-f" "15f910a70b6e9711448796ae13973f56ba7de049ba858115954221d802bd24cd"` [INFO] [stdout] 15f910a70b6e9711448796ae13973f56ba7de049ba858115954221d802bd24cd