[INFO] crate xmlJSON 0.2.0 is already in cache [INFO] extracting crate xmlJSON 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xmlJSON/0.2.0 [INFO] extracting crate xmlJSON 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlJSON/0.2.0 [INFO] validating manifest of xmlJSON-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xmlJSON-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xmlJSON-0.2.0 [INFO] finished frobbing xmlJSON-0.2.0 [INFO] frobbed toml for xmlJSON-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xmlJSON/0.2.0/Cargo.toml [INFO] started frobbing xmlJSON-0.2.0 [INFO] finished frobbing xmlJSON-0.2.0 [INFO] frobbed toml for xmlJSON-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xmlJSON/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xmlJSON-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xmlJSON/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e12c406d12359581cc4f57565662a50ab7a20a7f1c7c24a605181751c3f0821 [INFO] running `"docker" "start" "-a" "7e12c406d12359581cc4f57565662a50ab7a20a7f1c7c24a605181751c3f0821"` [INFO] [stderr] Checking xmlJSON v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | .map(|(data, _)| XmlDocument{ data: data } ) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | .map(|(data, _)| XmlDocument{ data: data } ) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 206 | | if current.is_some() { [INFO] [stderr] 207 | | Err("Invalid end tag".to_string()) [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | Ok((current_vec, Vec::new())) [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if current.is_some() { [INFO] [stderr] 206 | Err("Invalid end tag".to_string()) [INFO] [stderr] 207 | } else { [INFO] [stderr] 208 | Ok((current_vec, Vec::new())) [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 206 | | if current.is_some() { [INFO] [stderr] 207 | | Err("Invalid end tag".to_string()) [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | Ok((current_vec, Vec::new())) [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if current.is_some() { [INFO] [stderr] 206 | Err("Invalid end tag".to_string()) [INFO] [stderr] 207 | } else { [INFO] [stderr] 208 | Ok((current_vec, Vec::new())) [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | let mut parser = EventReader::new(source); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `xmlJSON` should have a snake case name such as `xml_json` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | .map_err(|e| ParseXmlError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseXmlError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | let mut parser = EventReader::new(source); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `xmlJSON` should have a snake case name such as `xml_json` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | .map_err(|e| ParseXmlError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseXmlError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "7e12c406d12359581cc4f57565662a50ab7a20a7f1c7c24a605181751c3f0821"` [INFO] running `"docker" "rm" "-f" "7e12c406d12359581cc4f57565662a50ab7a20a7f1c7c24a605181751c3f0821"` [INFO] [stdout] 7e12c406d12359581cc4f57565662a50ab7a20a7f1c7c24a605181751c3f0821