[INFO] crate xlsx_reader 2.7.0 is already in cache [INFO] extracting crate xlsx_reader 2.7.0 into work/ex/clippy-test-run/sources/stable/reg/xlsx_reader/2.7.0 [INFO] extracting crate xlsx_reader 2.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xlsx_reader/2.7.0 [INFO] validating manifest of xlsx_reader-2.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xlsx_reader-2.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xlsx_reader-2.7.0 [INFO] finished frobbing xlsx_reader-2.7.0 [INFO] frobbed toml for xlsx_reader-2.7.0 written to work/ex/clippy-test-run/sources/stable/reg/xlsx_reader/2.7.0/Cargo.toml [INFO] started frobbing xlsx_reader-2.7.0 [INFO] finished frobbing xlsx_reader-2.7.0 [INFO] frobbed toml for xlsx_reader-2.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xlsx_reader/2.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xlsx_reader-2.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xlsx_reader/2.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4e5fb2a4e764dda5a147b33fbc752514b13bed758f103fcb88f0922e3997e48 [INFO] running `"docker" "start" "-a" "c4e5fb2a4e764dda5a147b33fbc752514b13bed758f103fcb88f0922e3997e48"` [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Checking serde-xml-rs v0.2.1 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Checking xlsx_reader v2.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | let n = (4 * l) / 146097; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | let i = (4000 * (l + 1)) / 1461001; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | let j = (80 * l) / 2447; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | let n = (4 * l) / 146097; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | let i = (4000 * (l + 1)) / 1461001; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/reader.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | let j = (80 * l) / 2447; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 38 | | if file.name() == "xl/worksheets/sheet1.xml" { [INFO] [stderr] 39 | | match file.read_to_string(&mut sheet_content) { [INFO] [stderr] 40 | | Ok(_) => (), Err(err) => return Err(format!("Can't read sheet file: {:?}", err)) [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if file.name() == "xl/worksheets/sheet1.xml" { [INFO] [stderr] 38 | match file.read_to_string(&mut sheet_content) { [INFO] [stderr] 39 | Ok(_) => (), Err(err) => return Err(format!("Can't read sheet file: {:?}", err)) [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if let Some(ref sirs) = si.r { [INFO] [stderr] 85 | | if let Some(ref sir) = sirs.get(0) { [INFO] [stderr] 86 | | if let Some(ref sirt) = sir.t { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if let Some(ref sirs) = si.r { [INFO] [stderr] 84 | if let Some(ref sir) = sirs.get(0) { [INFO] [stderr] 85 | if let Some(ref sirt) = sir.t { [INFO] [stderr] 86 | map.insert(i, sirt.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] 87 | } [INFO] [stderr] 88 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:222:43 [INFO] [stderr] | [INFO] [stderr] 222 | let mut l = (days as isize) + 68569 + 2415019; [INFO] [stderr] | ^^^^^^^ help: consider: `2_415_019` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:223:23 [INFO] [stderr] | [INFO] [stderr] 223 | let n = (4 * l) / 146097; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | l = l - ((146097 * n + 3) / 4); [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:225:32 [INFO] [stderr] | [INFO] [stderr] 225 | let i = (4000 * (l + 1)) / 1461001; [INFO] [stderr] | ^^^^^^^ help: consider: `1_461_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 38 | | if file.name() == "xl/worksheets/sheet1.xml" { [INFO] [stderr] 39 | | match file.read_to_string(&mut sheet_content) { [INFO] [stderr] 40 | | Ok(_) => (), Err(err) => return Err(format!("Can't read sheet file: {:?}", err)) [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if file.name() == "xl/worksheets/sheet1.xml" { [INFO] [stderr] 38 | match file.read_to_string(&mut sheet_content) { [INFO] [stderr] 39 | Ok(_) => (), Err(err) => return Err(format!("Can't read sheet file: {:?}", err)) [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if let Some(ref sirs) = si.r { [INFO] [stderr] 85 | | if let Some(ref sir) = sirs.get(0) { [INFO] [stderr] 86 | | if let Some(ref sirt) = sir.t { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if let Some(ref sirs) = si.r { [INFO] [stderr] 84 | if let Some(ref sir) = sirs.get(0) { [INFO] [stderr] 85 | if let Some(ref sirt) = sir.t { [INFO] [stderr] 86 | map.insert(i, sirt.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] 87 | } [INFO] [stderr] 88 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:222:43 [INFO] [stderr] | [INFO] [stderr] 222 | let mut l = (days as isize) + 68569 + 2415019; [INFO] [stderr] | ^^^^^^^ help: consider: `2_415_019` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:223:23 [INFO] [stderr] | [INFO] [stderr] 223 | let n = (4 * l) / 146097; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | l = l - ((146097 * n + 3) / 4); [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:225:32 [INFO] [stderr] | [INFO] [stderr] 225 | let i = (4000 * (l + 1)) / 1461001; [INFO] [stderr] | ^^^^^^^ help: consider: `1_461_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse_xlsx(data: &Vec, date_columns: Option>) -> Result>, String> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn parse_xlsx_file_to_parts(data: &Vec) -> Result<(String, String), String> [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse_xlsx(data: &Vec, date_columns: Option>) -> Result>, String> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn parse_xlsx_file_to_parts(data: &Vec) -> Result<(String, String), String> [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | map.insert(i, sit.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:87:44 [INFO] [stderr] | [INFO] [stderr] 87 | map.insert(i, sirt.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | map.insert(i, sit.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:87:44 [INFO] [stderr] | [INFO] [stderr] 87 | map.insert(i, sirt.val.clone().unwrap_or("".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/reader.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_parsed_xlsx(strings_map: HashMap, sheet_content: String, date_columns: Option>) -> Result>, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_parsed_xlsx(strings_map: HashMap, sheet_content: String, date_columns: Option>) -> Result>, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 141 | let mut tr: HashMap = HashMap::with_capacity_and_hasher(cells.len(), Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/reader.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | let known_date_columns: Vec = date_columns.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `date_columns.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:171:38 [INFO] [stderr] | [INFO] [stderr] 171 | let t = cell.t.clone().unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:197:7 [INFO] [stderr] | [INFO] [stderr] 197 | ir = ir + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ir += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reader.rs:210:3 [INFO] [stderr] | [INFO] [stderr] 210 | / let y: isize; [INFO] [stderr] 211 | | if days == 60.0 { [INFO] [stderr] 212 | | d = 29; [INFO] [stderr] 213 | | m = 2; [INFO] [stderr] ... | [INFO] [stderr] 231 | | y = 100 * (n - 49) + i + l; [INFO] [stderr] 232 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let y = if days == 60.0 { ..; 1900 } else { ..; 100 * (n - 49) + i + l };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/reader.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | if days == 60.0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(days - 60.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/reader.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | if days == 60.0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | l = l - ((146097 * n + 3) / 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `l -= ((146097 * n + 3) / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/reader.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_parsed_xlsx(strings_map: HashMap, sheet_content: String, date_columns: Option>) -> Result>, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_parsed_xlsx(strings_map: HashMap, sheet_content: String, date_columns: Option>) -> Result>, String> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 141 | let mut tr: HashMap = HashMap::with_capacity_and_hasher(cells.len(), Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/tests.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | Err(_) => panic!("Test file not found") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tests.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | let ref row1 = table[&2]; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let row1 = &table[&2];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/reader.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | let known_date_columns: Vec = date_columns.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `date_columns.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tests.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | let ref row2 = table[&3]; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let row2 = &table[&3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/reader.rs:171:38 [INFO] [stderr] | [INFO] [stderr] 171 | let t = cell.t.clone().unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tests.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | let ref row3 = table[&4]; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let row3 = &table[&4];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:197:7 [INFO] [stderr] | [INFO] [stderr] 197 | ir = ir + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ir += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reader.rs:210:3 [INFO] [stderr] | [INFO] [stderr] 210 | / let y: isize; [INFO] [stderr] 211 | | if days == 60.0 { [INFO] [stderr] 212 | | d = 29; [INFO] [stderr] 213 | | m = 2; [INFO] [stderr] ... | [INFO] [stderr] 231 | | y = 100 * (n - 49) + i + l; [INFO] [stderr] 232 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let y = if days == 60.0 { ..; 1900 } else { ..; 100 * (n - 49) + i + l };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/reader.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | if days == 60.0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(days - 60.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/reader.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | if days == 60.0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | l = l - ((146097 * n + 3) / 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `l -= ((146097 * n + 3) / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xlsx_reader`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `xlsx_reader`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c4e5fb2a4e764dda5a147b33fbc752514b13bed758f103fcb88f0922e3997e48"` [INFO] running `"docker" "rm" "-f" "c4e5fb2a4e764dda5a147b33fbc752514b13bed758f103fcb88f0922e3997e48"` [INFO] [stdout] c4e5fb2a4e764dda5a147b33fbc752514b13bed758f103fcb88f0922e3997e48