[INFO] crate xlsx2csv 0.1.1 is already in cache [INFO] extracting crate xlsx2csv 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/xlsx2csv/0.1.1 [INFO] extracting crate xlsx2csv 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xlsx2csv/0.1.1 [INFO] validating manifest of xlsx2csv-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xlsx2csv-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xlsx2csv-0.1.1 [INFO] finished frobbing xlsx2csv-0.1.1 [INFO] frobbed toml for xlsx2csv-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/xlsx2csv/0.1.1/Cargo.toml [INFO] started frobbing xlsx2csv-0.1.1 [INFO] finished frobbing xlsx2csv-0.1.1 [INFO] frobbed toml for xlsx2csv-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xlsx2csv/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xlsx2csv-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xlsx2csv/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e7885e63b96616a2958d7f8a50d6ae4f52f308183c75fc58b40de47a8305869 [INFO] running `"docker" "start" "-a" "2e7885e63b96616a2958d7f8a50d6ae4f52f308183c75fc58b40de47a8305869"` [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.1 [INFO] [stderr] Checking miniz_oxide v0.2.1 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking csv-core v0.1.5 [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Checking quick-xml v0.10.1 [INFO] [stderr] Checking calamine v0.12.1 [INFO] [stderr] Checking xlsx2csv v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | .unwrap_or(workbook.sheet_names().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| workbook.sheet_names().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:118:54 [INFO] [stderr] | [INFO] [stderr] 118 | let range = workbook.worksheet_range(&sheet).expect(&format!("find sheet {}", sheet)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("find sheet {}", sheet))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:137:48 [INFO] [stderr] | [INFO] [stderr] 137 | DataType::String(ref c) => format!("{}", c), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | .unwrap_or(workbook.sheet_names().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| workbook.sheet_names().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:118:54 [INFO] [stderr] | [INFO] [stderr] 118 | let range = workbook.worksheet_range(&sheet).expect(&format!("find sheet {}", sheet)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("find sheet {}", sheet))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:137:48 [INFO] [stderr] | [INFO] [stderr] 137 | DataType::String(ref c) => format!("{}", c), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.40s [INFO] running `"docker" "inspect" "2e7885e63b96616a2958d7f8a50d6ae4f52f308183c75fc58b40de47a8305869"` [INFO] running `"docker" "rm" "-f" "2e7885e63b96616a2958d7f8a50d6ae4f52f308183c75fc58b40de47a8305869"` [INFO] [stdout] 2e7885e63b96616a2958d7f8a50d6ae4f52f308183c75fc58b40de47a8305869