[INFO] crate xl2txt 0.1.1 is already in cache [INFO] extracting crate xl2txt 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/xl2txt/0.1.1 [INFO] extracting crate xl2txt 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xl2txt/0.1.1 [INFO] validating manifest of xl2txt-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xl2txt-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xl2txt-0.1.1 [INFO] finished frobbing xl2txt-0.1.1 [INFO] frobbed toml for xl2txt-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/xl2txt/0.1.1/Cargo.toml [INFO] started frobbing xl2txt-0.1.1 [INFO] finished frobbing xl2txt-0.1.1 [INFO] frobbed toml for xl2txt-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xl2txt/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xl2txt-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xl2txt/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9335147f8d2389857950fb43a106d4186040d5cec40767e027a3013b0c559776 [INFO] running `"docker" "start" "-a" "9335147f8d2389857950fb43a106d4186040d5cec40767e027a3013b0c559776"` [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Checking quick-xml v0.9.4 [INFO] [stderr] Checking calamine v0.11.8 [INFO] [stderr] Checking xl2txt v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | orig: orig, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | formula: formula, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | orig: orig, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | formula: formula, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | let file = args.by_ref().skip(1).next().expect("USAGE: xl2txt file [root]"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | for c in scol..ecol+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `scol..=ecol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | let file = args.by_ref().skip(1).next().expect("USAGE: xl2txt file [root]"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | for c in scol..ecol+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `scol..=ecol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.83s [INFO] running `"docker" "inspect" "9335147f8d2389857950fb43a106d4186040d5cec40767e027a3013b0c559776"` [INFO] running `"docker" "rm" "-f" "9335147f8d2389857950fb43a106d4186040d5cec40767e027a3013b0c559776"` [INFO] [stdout] 9335147f8d2389857950fb43a106d4186040d5cec40767e027a3013b0c559776