[INFO] crate xkcd 0.3.0 is already in cache [INFO] extracting crate xkcd 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/xkcd/0.3.0 [INFO] extracting crate xkcd 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xkcd/0.3.0 [INFO] validating manifest of xkcd-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xkcd-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xkcd-0.3.0 [INFO] finished frobbing xkcd-0.3.0 [INFO] frobbed toml for xkcd-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/xkcd/0.3.0/Cargo.toml [INFO] started frobbing xkcd-0.3.0 [INFO] finished frobbing xkcd-0.3.0 [INFO] frobbed toml for xkcd-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xkcd/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xkcd-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xkcd/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d1cf98be5b205df12d50a5f0c5f6d0a86b5acd25fce287362c6bdad7eec8c8c [INFO] running `"docker" "start" "-a" "1d1cf98be5b205df12d50a5f0c5f6d0a86b5acd25fce287362c6bdad7eec8c8c"` [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking xkcd v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/random.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | random_in_range(client, (1..latest_comic.num + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | random_in_range(client, (1..latest_comic.num + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=latest_comic.num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/random.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | random_in_range(client, (1..latest_comic.num + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/random.rs:70:56 [INFO] [stderr] | [INFO] [stderr] 70 | let result = core.run(random_in_range(&client, (1..1573))).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | random_in_range(client, (1..latest_comic.num + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=latest_comic.num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.73s [INFO] running `"docker" "inspect" "1d1cf98be5b205df12d50a5f0c5f6d0a86b5acd25fce287362c6bdad7eec8c8c"` [INFO] running `"docker" "rm" "-f" "1d1cf98be5b205df12d50a5f0c5f6d0a86b5acd25fce287362c6bdad7eec8c8c"` [INFO] [stdout] 1d1cf98be5b205df12d50a5f0c5f6d0a86b5acd25fce287362c6bdad7eec8c8c