[INFO] crate xkb 0.2.0 is already in cache [INFO] extracting crate xkb 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xkb/0.2.0 [INFO] extracting crate xkb 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xkb/0.2.0 [INFO] validating manifest of xkb-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xkb-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xkb-0.2.0 [INFO] finished frobbing xkb-0.2.0 [INFO] frobbed toml for xkb-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xkb/0.2.0/Cargo.toml [INFO] started frobbing xkb-0.2.0 [INFO] finished frobbing xkb-0.2.0 [INFO] frobbed toml for xkb-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xkb/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xkb-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xkb/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f962522f070e11449c8428e72a1af66495316e0d39884de0ef74c37981e108a [INFO] running `"docker" "start" "-a" "9f962522f070e11449c8428e72a1af66495316e0d39884de0ef74c37981e108a"` [INFO] [stderr] Compiling xkbcommon-sys v0.7.4 [INFO] [stderr] Checking xkb v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/mods.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/layouts.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/leds.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/mods.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/layouts.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keymap/leds.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/context/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | mod context; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/keymap/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod keymap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/state/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod state; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/context/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | mod context; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/keymap/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod keymap; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/state/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod state; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/keysym.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn utf8(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/keysym.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn utf32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `context::include::Include<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/context/include.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / impl<'a> Include<'a> { [INFO] [stderr] 25 | | pub fn append>(&mut self, path: P) -> &mut Self { [INFO] [stderr] 26 | | unsafe { [INFO] [stderr] 27 | | xkb_context_include_path_append(self.0.as_ptr(), path.as_ref().as_os_str().as_bytes().as_ptr() as *const _); [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::mods::Mods<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/mods.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Mods<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_mods(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::layouts::Layouts<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/layouts.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Layouts<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_mods(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::leds::Leds<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/leds.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Leds<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_leds(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/keysym.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn utf8(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/keysym.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn utf32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `context::include::Include<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/context/include.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / impl<'a> Include<'a> { [INFO] [stderr] 25 | | pub fn append>(&mut self, path: P) -> &mut Self { [INFO] [stderr] 26 | | unsafe { [INFO] [stderr] 27 | | xkb_context_include_path_append(self.0.as_ptr(), path.as_ref().as_os_str().as_bytes().as_ptr() as *const _); [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::mods::Mods<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/mods.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Mods<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_mods(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::layouts::Layouts<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/layouts.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Layouts<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_mods(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `keymap::leds::Leds<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/keymap/leds.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / impl<'a> Leds<'a> { [INFO] [stderr] 24 | | pub fn len(&self) -> usize { [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | xkb_keymap_num_leds(self.0.as_ptr()) as usize [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `"docker" "inspect" "9f962522f070e11449c8428e72a1af66495316e0d39884de0ef74c37981e108a"` [INFO] running `"docker" "rm" "-f" "9f962522f070e11449c8428e72a1af66495316e0d39884de0ef74c37981e108a"` [INFO] [stdout] 9f962522f070e11449c8428e72a1af66495316e0d39884de0ef74c37981e108a