[INFO] crate xio_webclient 0.10.1 is already in cache
[INFO] extracting crate xio_webclient 0.10.1 into work/ex/clippy-test-run/sources/stable/reg/xio_webclient/0.10.1
[INFO] extracting crate xio_webclient 0.10.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_webclient/0.10.1
[INFO] validating manifest of xio_webclient-0.10.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xio_webclient-0.10.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xio_webclient-0.10.1
[INFO] finished frobbing xio_webclient-0.10.1
[INFO] frobbed toml for xio_webclient-0.10.1 written to work/ex/clippy-test-run/sources/stable/reg/xio_webclient/0.10.1/Cargo.toml
[INFO] started frobbing xio_webclient-0.10.1
[INFO] finished frobbing xio_webclient-0.10.1
[INFO] frobbed toml for xio_webclient-0.10.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_webclient/0.10.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xio_webclient-0.10.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xio_webclient/0.10.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 38abc38e7dc16cc35655e0a52db50b656826311e87e193193399dd381fec7048
[INFO] running `"docker" "start" "-a" "38abc38e7dc16cc35655e0a52db50b656826311e87e193193399dd381fec7048"`
[INFO] [stderr]    Compiling serde v1.0.85
[INFO] [stderr]     Checking encode_unicode v0.3.5
[INFO] [stderr]     Checking term v0.5.1
[INFO] [stderr]    Compiling native-tls v0.2.2
[INFO] [stderr]     Checking mio-extras v2.0.5
[INFO] [stderr]    Compiling serde_derive v1.0.85
[INFO] [stderr]    Compiling structopt-derive v0.2.14
[INFO] [stderr]     Checking tokio v0.1.15
[INFO] [stderr]     Checking ws v0.7.9
[INFO] [stderr]     Checking structopt v0.2.14
[INFO] [stderr]     Checking hyper v0.12.23
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking serde_json v1.0.37
[INFO] [stderr]     Checking xio_base_datatypes v0.4.3
[INFO] [stderr]     Checking ommui_string_patterns v0.1.2
[INFO] [stderr]     Checking uuid v0.7.2
[INFO] [stderr]     Checking serde_urlencoded v0.5.4
[INFO] [stderr]     Checking csv v1.0.5
[INFO] [stderr]     Checking prettytable-rs v0.8.0
[INFO] [stderr]     Checking xio_jobset v0.7.0
[INFO] [stderr]     Checking ommui_file_loading v0.3.3
[INFO] [stderr]     Checking reqwest v0.9.9
[INFO] [stderr]     Checking xio_hwdb v0.3.0
[INFO] [stderr]     Checking xio_webapi v0.12.0
[INFO] [stderr]     Checking xio_webclient v0.10.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/xioclient.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/bin/xioclient.rs:440:21
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     progress: _,
[INFO] [stderr]     |                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `FlashingProgressMessage { ref message, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/xioclient.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/bin/xioclient.rs:440:21
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     progress: _,
[INFO] [stderr]     |                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `FlashingProgressMessage { ref message, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/bin/xioclient.rs:350:17
[INFO] [stderr]     |
[INFO] [stderr] 350 |                 iter.filter(|s| !jobs.contains_key(s)).next().unwrap()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|s| !jobs.contains_key(s)).next()` with `find(|s| !jobs.contains_key(s))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/bin/xioclient.rs:412:13
[INFO] [stderr]     |
[INFO] [stderr] 412 |         for ref event in client.controller_events(uuid)? {
[INFO] [stderr]     |             ^^^^^^^^^    ------------------------------- help: try: `let event = &client.controller_events(uuid)?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/xioclient.rs:483:12
[INFO] [stderr]     |
[INFO] [stderr] 483 |         if list.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/bin/xioclient.rs:350:17
[INFO] [stderr]     |
[INFO] [stderr] 350 |                 iter.filter(|s| !jobs.contains_key(s)).next().unwrap()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|s| !jobs.contains_key(s)).next()` with `find(|s| !jobs.contains_key(s))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/bin/xioclient.rs:412:13
[INFO] [stderr]     |
[INFO] [stderr] 412 |         for ref event in client.controller_events(uuid)? {
[INFO] [stderr]     |             ^^^^^^^^^    ------------------------------- help: try: `let event = &client.controller_events(uuid)?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/xioclient.rs:483:12
[INFO] [stderr]     |
[INFO] [stderr] 483 |         if list.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 29s
[INFO] running `"docker" "inspect" "38abc38e7dc16cc35655e0a52db50b656826311e87e193193399dd381fec7048"`
[INFO] running `"docker" "rm" "-f" "38abc38e7dc16cc35655e0a52db50b656826311e87e193193399dd381fec7048"`
[INFO] [stdout] 38abc38e7dc16cc35655e0a52db50b656826311e87e193193399dd381fec7048