[INFO] crate xio_common 0.8.4 is already in cache [INFO] extracting crate xio_common 0.8.4 into work/ex/clippy-test-run/sources/stable/reg/xio_common/0.8.4 [INFO] extracting crate xio_common 0.8.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_common/0.8.4 [INFO] validating manifest of xio_common-0.8.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xio_common-0.8.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xio_common-0.8.4 [INFO] finished frobbing xio_common-0.8.4 [INFO] frobbed toml for xio_common-0.8.4 written to work/ex/clippy-test-run/sources/stable/reg/xio_common/0.8.4/Cargo.toml [INFO] started frobbing xio_common-0.8.4 [INFO] finished frobbing xio_common-0.8.4 [INFO] frobbed toml for xio_common-0.8.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_common/0.8.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xio_common-0.8.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xio_common/0.8.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9657064691af6b9612028718b0b63ee279f515c259da12a64a920263e75ee571 [INFO] running `"docker" "start" "-a" "9657064691af6b9612028718b0b63ee279f515c259da12a64a920263e75ee571"` [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking nix v0.12.0 [INFO] [stderr] Checking xio_base_datatypes v0.4.3 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking ommui_broadcast v0.2.3 [INFO] [stderr] Checking serialport v3.2.0 [INFO] [stderr] Checking xio_common v0.8.4 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/measurement_data.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | 0x9988776655443322u64.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x9988_7766_5544_3322u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/measurement_data.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | 0x9988776655443322u64.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x9988_7766_5544_3322u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data_value.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | for ref value in values { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let value = &values;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data_value.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | for ref value in values { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let value = &values;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:73:46 [INFO] [stderr] | [INFO] [stderr] 73 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | error_code: &ErrorCode, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ErrorCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/job_stopped_reason.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | r: &JobStoppedReason, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `JobStoppedReason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/job_stopped_reason.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | self.write_u8(r.clone() as u8)?; [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data_value.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | for ref value in values { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let value = &values;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data_value.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | for ref value in values { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let value = &values;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data_value.rs:73:46 [INFO] [stderr] | [INFO] [stderr] 73 | self.write_u64::(*v as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | error_code: &ErrorCode, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ErrorCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/job_stopped_reason.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | r: &JobStoppedReason, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `JobStoppedReason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/job_stopped_reason.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | self.write_u8(r.clone() as u8)?; [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.31s [INFO] running `"docker" "inspect" "9657064691af6b9612028718b0b63ee279f515c259da12a64a920263e75ee571"` [INFO] running `"docker" "rm" "-f" "9657064691af6b9612028718b0b63ee279f515c259da12a64a920263e75ee571"` [INFO] [stdout] 9657064691af6b9612028718b0b63ee279f515c259da12a64a920263e75ee571