[INFO] crate xio_base_datatypes 0.4.3 is already in cache [INFO] extracting crate xio_base_datatypes 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/xio_base_datatypes/0.4.3 [INFO] extracting crate xio_base_datatypes 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_base_datatypes/0.4.3 [INFO] validating manifest of xio_base_datatypes-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xio_base_datatypes-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xio_base_datatypes-0.4.3 [INFO] finished frobbing xio_base_datatypes-0.4.3 [INFO] frobbed toml for xio_base_datatypes-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/xio_base_datatypes/0.4.3/Cargo.toml [INFO] started frobbing xio_base_datatypes-0.4.3 [INFO] finished frobbing xio_base_datatypes-0.4.3 [INFO] frobbed toml for xio_base_datatypes-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xio_base_datatypes/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xio_base_datatypes-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xio_base_datatypes/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68faa0dcb789a0f8db63a035e420221f7a43f1a6ff9af0bc9ed00d5e05003b6a [INFO] running `"docker" "start" "-a" "68faa0dcb789a0f8db63a035e420221f7a43f1a6ff9af0bc9ed00d5e05003b6a"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking backtrace-sys v0.1.28 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking xio_base_datatypes v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_value.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn to_descriptive<'a, P>( [INFO] [stderr] 88 | | &'a self, [INFO] [stderr] 89 | | parameters: P, [INFO] [stderr] 90 | | ) -> Result [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn is_success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_value.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn to_descriptive<'a, P>( [INFO] [stderr] 88 | | &'a self, [INFO] [stderr] 89 | | parameters: P, [INFO] [stderr] 90 | | ) -> Result [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn is_success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error_code.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.28s [INFO] running `"docker" "inspect" "68faa0dcb789a0f8db63a035e420221f7a43f1a6ff9af0bc9ed00d5e05003b6a"` [INFO] running `"docker" "rm" "-f" "68faa0dcb789a0f8db63a035e420221f7a43f1a6ff9af0bc9ed00d5e05003b6a"` [INFO] [stdout] 68faa0dcb789a0f8db63a035e420221f7a43f1a6ff9af0bc9ed00d5e05003b6a