[INFO] crate xi-rope 0.2.0 is already in cache [INFO] extracting crate xi-rope 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/xi-rope/0.2.0 [INFO] extracting crate xi-rope 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xi-rope/0.2.0 [INFO] validating manifest of xi-rope-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xi-rope-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xi-rope-0.2.0 [INFO] finished frobbing xi-rope-0.2.0 [INFO] frobbed toml for xi-rope-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/xi-rope/0.2.0/Cargo.toml [INFO] started frobbing xi-rope-0.2.0 [INFO] finished frobbing xi-rope-0.2.0 [INFO] frobbed toml for xi-rope-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xi-rope/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xi-rope-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xi-rope/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c2904ef2871180102580d302162258ab22288a2012d5b3ae0544b3387e2572f [INFO] running `"docker" "start" "-a" "8c2904ef2871180102580d302162258ab22288a2012d5b3ae0544b3387e2572f"` [INFO] [stderr] Checking xi-rope v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/breaks.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | Delta { els: result, base_len: base_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | Delta { els: els, base_len: base_len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `els` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:150:27 [INFO] [stderr] | [INFO] [stderr] 150 | Delta { els: els, base_len: base_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/delta.rs:174:46 [INFO] [stderr] | [INFO] [stderr] 174 | DeltaElement::Insert(ref n) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/delta.rs:182:44 [INFO] [stderr] | [INFO] [stderr] 182 | DeltaElement::Copy(_b, e) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | Delta { els: els, base_len: l } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `els` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rope.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | iv: iv, [INFO] [stderr] | ^^^^^^ help: replace it with: `iv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | total_len: total_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subset.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | base_len: base_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | undo_group: undo_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `undo_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | groups: groups [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:286:29 [INFO] [stderr] | [INFO] [stderr] 286 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | undo_group: undo_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `undo_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:291:33 [INFO] [stderr] | [INFO] [stderr] 291 | inserts: inserts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inserts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:292:33 [INFO] [stderr] | [INFO] [stderr] 292 | deletes: deletes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `deletes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:312:29 [INFO] [stderr] | [INFO] [stderr] 312 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | len: len [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/breaks.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interval.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | Delta { els: result, base_len: base_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | Delta { els: els, base_len: base_len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `els` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:150:27 [INFO] [stderr] | [INFO] [stderr] 150 | Delta { els: els, base_len: base_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/delta.rs:174:46 [INFO] [stderr] | [INFO] [stderr] 174 | DeltaElement::Insert(ref n) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/delta.rs:182:44 [INFO] [stderr] | [INFO] [stderr] 182 | DeltaElement::Copy(_b, e) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | Delta { els: els, base_len: l } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `els` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rope.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | iv: iv, [INFO] [stderr] | ^^^^^^ help: replace it with: `iv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | total_len: total_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spans.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subset.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | base_len: base_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | undo_group: undo_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `undo_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | groups: groups [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:286:29 [INFO] [stderr] | [INFO] [stderr] 286 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | undo_group: undo_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `undo_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:291:33 [INFO] [stderr] | [INFO] [stderr] 291 | inserts: inserts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inserts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:292:33 [INFO] [stderr] | [INFO] [stderr] 292 | deletes: deletes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `deletes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:312:29 [INFO] [stderr] | [INFO] [stderr] 312 | from_union: from_union, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from_union` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | len: len [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/delta.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/delta.rs:325:32 [INFO] [stderr] | [INFO] [stderr] 325 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 326 | | if !iv.is_before(beg) { [INFO] [stderr] 327 | | return true; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | } else if !iv.is_before(beg) { [INFO] [stderr] 326 | return true; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/delta.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/delta.rs:325:32 [INFO] [stderr] | [INFO] [stderr] 325 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 326 | | if !iv.is_before(beg) { [INFO] [stderr] 327 | | return true; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | } else if !iv.is_before(beg) { [INFO] [stderr] 326 | return true; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/delta.rs:351:22 [INFO] [stderr] | [INFO] [stderr] 351 | const TEST_STR: &'static str = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/subset.rs:300:22 [INFO] [stderr] | [INFO] [stderr] 300 | const TEST_STR: &'static str = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tree.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | let mut node1 = Arc::make_mut(&mut rope1.0); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait `Leaf` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/tree.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / pub trait Leaf: Sized + Clone + Default { [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | // measurement of leaf in base units [INFO] [stderr] 62 | | fn len(&self) -> usize; [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `tree::Node` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/tree.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | / impl Node { [INFO] [stderr] 146 | | pub fn from_leaf(l: N::L) -> Node { [INFO] [stderr] 147 | | let len = l.len(); [INFO] [stderr] 148 | | let info = N::compute_info(&l); [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::TreeBuilder` [INFO] [stderr] --> src/tree.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> TreeBuilder { [INFO] [stderr] 427 | | TreeBuilder(None) [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 423 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:500:38 [INFO] [stderr] | [INFO] [stderr] 500 | pub fn is_boundary>(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | / pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stderr] 570 | | if self.position >= self.root.len() || self.leaf.is_none() { [INFO] [stderr] 571 | | self.leaf = None; [INFO] [stderr] 572 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 595 | | } [INFO] [stderr] 596 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/rope.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | s.as_bytes().iter().filter(|&&c| c == b'\n').count() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(s.as_bytes(), b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rope.rs:475:64 [INFO] [stderr] | [INFO] [stderr] 475 | result = cow_append(result, &self.fragment[.. i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: item `Rope` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / impl Rope { [INFO] [stderr] 134 | | /// Returns the length of `self`. [INFO] [stderr] 135 | | /// [INFO] [stderr] 136 | | /// The length is in bytes, the same as `str::len()`. [INFO] [stderr] ... | [INFO] [stderr] 347 | | } [INFO] [stderr] 348 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1023:64 [INFO] [stderr] | [INFO] [stderr] 1023 | result = cow_append(result, &self.fragment[.. i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tree.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | let mut node1 = Arc::make_mut(&mut rope1.0); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait `Leaf` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/tree.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / pub trait Leaf: Sized + Clone + Default { [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | // measurement of leaf in base units [INFO] [stderr] 62 | | fn len(&self) -> usize; [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `tree::Node` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/tree.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | / impl Node { [INFO] [stderr] 146 | | pub fn from_leaf(l: N::L) -> Node { [INFO] [stderr] 147 | | let len = l.len(); [INFO] [stderr] 148 | | let info = N::compute_info(&l); [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::TreeBuilder` [INFO] [stderr] --> src/tree.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> TreeBuilder { [INFO] [stderr] 427 | | TreeBuilder(None) [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 423 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:500:38 [INFO] [stderr] | [INFO] [stderr] 500 | pub fn is_boundary>(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | / pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stderr] 570 | | if self.position >= self.root.len() || self.leaf.is_none() { [INFO] [stderr] 571 | | self.leaf = None; [INFO] [stderr] 572 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 595 | | } [INFO] [stderr] 596 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/ropetoy.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | for i in 0..1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/rope.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | s.as_bytes().iter().filter(|&&c| c == b'\n').count() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(s.as_bytes(), b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rope.rs:475:64 [INFO] [stderr] | [INFO] [stderr] 475 | result = cow_append(result, &self.fragment[.. i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: item `Rope` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / impl Rope { [INFO] [stderr] 134 | | /// Returns the length of `self`. [INFO] [stderr] 135 | | /// [INFO] [stderr] 136 | | /// The length is in bytes, the same as `str::len()`. [INFO] [stderr] ... | [INFO] [stderr] 347 | | } [INFO] [stderr] 348 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1023:64 [INFO] [stderr] | [INFO] [stderr] 1023 | result = cow_append(result, &self.fragment[.. i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:1268:13 [INFO] [stderr] | [INFO] [stderr] 1268 | assert!(empty == empty); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xi-rope`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8c2904ef2871180102580d302162258ab22288a2012d5b3ae0544b3387e2572f"` [INFO] running `"docker" "rm" "-f" "8c2904ef2871180102580d302162258ab22288a2012d5b3ae0544b3387e2572f"` [INFO] [stdout] 8c2904ef2871180102580d302162258ab22288a2012d5b3ae0544b3387e2572f