[INFO] crate xhtmlchardet 2.0.0 is already in cache
[INFO] extracting crate xhtmlchardet 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/xhtmlchardet/2.0.0
[INFO] extracting crate xhtmlchardet 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xhtmlchardet/2.0.0
[INFO] validating manifest of xhtmlchardet-2.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xhtmlchardet-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xhtmlchardet-2.0.0
[INFO] finished frobbing xhtmlchardet-2.0.0
[INFO] frobbed toml for xhtmlchardet-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/xhtmlchardet/2.0.0/Cargo.toml
[INFO] started frobbing xhtmlchardet-2.0.0
[INFO] finished frobbing xhtmlchardet-2.0.0
[INFO] frobbed toml for xhtmlchardet-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xhtmlchardet/2.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xhtmlchardet-2.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xhtmlchardet/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 64817e7060e13f0e83071b0ba51232a6e9206dc17808a5c860602fa6e101dee4
[INFO] running `"docker" "start" "-a" "64817e7060e13f0e83071b0ba51232a6e9206dc17808a5c860602fa6e101dee4"`
[INFO] [stderr]     Checking xhtmlchardet v2.0.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking toml v0.2.1
[INFO] [stderr] warning: All variants have the same postfix: `Bit`
[INFO] [stderr]   --> src/lib.rs:25:1
[INFO] [stderr]    |
[INFO] [stderr] 25 | / enum Width {
[INFO] [stderr] 26 | |     EightBit     = 8,
[INFO] [stderr] 27 | |     SixteenBit   = 16,
[INFO] [stderr] 28 | |     ThirtyTwoBit = 32
[INFO] [stderr] 29 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:120:5
[INFO] [stderr]     |
[INFO] [stderr] 120 |     return Ok(candidates);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(candidates)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/lib.rs:76:5
[INFO] [stderr]    |
[INFO] [stderr] 76 |     try!(reader.read(&mut first_four_bytes));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/lib.rs:90:5
[INFO] [stderr]    |
[INFO] [stderr] 90 |     try!(reader.read(&mut buf));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/lib.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 | /     search("encoding=", &buf.to_vec(), possible_encoding.as_ref())
[INFO] [stderr] 96 | |         .or_else(|| search("charset=", &buf.to_vec(), possible_encoding.as_ref()))
[INFO] [stderr] 97 | |         .map(normalise)
[INFO] [stderr] 98 | |         .map(|encoding| push_if_not_contains(&mut candidates, endianify(&encoding, possible_encoding.as_ref())));
[INFO] [stderr]    | |________________________________________________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 95 |     if let Some(encoding) = search("encoding=", &buf.to_vec(), possible_encoding.as_ref())
[INFO] [stderr] 96 |         .or_else(|| search("charset=", &buf.to_vec(), possible_encoding.as_ref()))
[INFO] [stderr] 97 |         .map(normalise) { push_if_not_contains(&mut candidates, endianify(&encoding, possible_encoding.as_ref())) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/lib.rs:101:5
[INFO] [stderr]     |
[INFO] [stderr] 101 |        hint.map(normalise)
[INFO] [stderr]     |   _____^
[INFO] [stderr]     |  |_____|
[INFO] [stderr]     | ||
[INFO] [stderr] 102 | ||         .map(|encoding| push_if_not_contains(&mut candidates, endianify(&encoding, possible_encoding.as_ref())));
[INFO] [stderr]     | ||________________________________________________________________________________________________________________^- help: try this: `if let Some(encoding) = hint.map(normalise) { push_if_not_contains(&mut candidates, endianify(&encoding, possible_encoding.as_ref())) }`
[INFO] [stderr]     | |_________________________________________________________________________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/lib.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 | /     match possible_encoding {
[INFO] [stderr] 106 | |         Some(UCS_4_LE) => Some("ucs-4le"),
[INFO] [stderr] 107 | |         Some(UCS_4_BE) => Some("ucs-4be"),
[INFO] [stderr] 108 | |         Some(UTF_16_LE) => Some("utf-16le"),
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |         _ => None
[INFO] [stderr] 113 | |     }.map(|encoding| push_if_not_contains(&mut candidates, encoding.to_string()));
[INFO] [stderr]     | |_________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 105 |     if let Some(encoding) = match possible_encoding {
[INFO] [stderr] 106 |         Some(UCS_4_LE) => Some("ucs-4le"),
[INFO] [stderr] 107 |         Some(UCS_4_BE) => Some("ucs-4be"),
[INFO] [stderr] 108 |         Some(UTF_16_LE) => Some("utf-16le"),
[INFO] [stderr] 109 |         Some(UTF_16_BE) => Some("utf-16be"),
[INFO] [stderr] 110 |         Some(Descriptor(Flavour::UTF, Width::EightBit, _)) => Some("utf-8"),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:204:35
[INFO] [stderr]     |
[INFO] [stderr] 204 | fn search(needle: &str, haystack: &Vec<u8>, descriptor: Option<&Descriptor>) -> Option<String> {
[INFO] [stderr]     |                                   ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `xhtmlchardet`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "64817e7060e13f0e83071b0ba51232a6e9206dc17808a5c860602fa6e101dee4"`
[INFO] running `"docker" "rm" "-f" "64817e7060e13f0e83071b0ba51232a6e9206dc17808a5c860602fa6e101dee4"`
[INFO] [stdout] 64817e7060e13f0e83071b0ba51232a6e9206dc17808a5c860602fa6e101dee4