[INFO] crate xflow 0.1.1 is already in cache [INFO] extracting crate xflow 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/xflow/0.1.1 [INFO] extracting crate xflow 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xflow/0.1.1 [INFO] validating manifest of xflow-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xflow-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xflow-0.1.1 [INFO] finished frobbing xflow-0.1.1 [INFO] frobbed toml for xflow-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/xflow/0.1.1/Cargo.toml [INFO] started frobbing xflow-0.1.1 [INFO] finished frobbing xflow-0.1.1 [INFO] frobbed toml for xflow-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xflow/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xflow-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xflow/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f15d5bb460b2e81eb3f581069606505ce91b203aa68c35b1c690a06648e0484 [INFO] running `"docker" "start" "-a" "9f15d5bb460b2e81eb3f581069606505ce91b203aa68c35b1c690a06648e0484"` [INFO] [stderr] Checking xflow v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfstate.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | XFState { store: store } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | paths: paths, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | xflow: xflow, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xflow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | xflow: xflow, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xflow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | Dispatcher { dispatchers: dispatchers } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatchers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfstate.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | XFState { store: store } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | paths: paths, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | xflow: xflow, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xflow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | xflow: xflow, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xflow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfrunner.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | Dispatcher { dispatchers: dispatchers } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatchers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/actiondispatch/flow.rs:14:67 [INFO] [stderr] | [INFO] [stderr] 14 | fn process_node(&self, node: &XFlowNode, state: &mut XFState) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/actiondispatch/flox.rs:14:67 [INFO] [stderr] | [INFO] [stderr] 14 | fn process_node(&self, node: &XFlowNode, state: &mut XFState) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/xfrunner.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn run(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/xfrunner.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | fn next_node(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dispatcher.rs:19:92 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn register_dispatcher(&mut self, name: &str, dispatcher: T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/actiondispatch/flow.rs:14:67 [INFO] [stderr] | [INFO] [stderr] 14 | fn process_node(&self, node: &XFlowNode, state: &mut XFState) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/actiondispatch/flox.rs:14:67 [INFO] [stderr] | [INFO] [stderr] 14 | fn process_node(&self, node: &XFlowNode, state: &mut XFState) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/xfrunner.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn run(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/xfrunner.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | fn next_node(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dispatcher.rs:19:92 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn register_dispatcher(&mut self, name: &str, dispatcher: T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actiondispatch::flow::Flow` [INFO] [stderr] --> src/actiondispatch/flow.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Flow { [INFO] [stderr] 11 | | Flow { ready: false } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actiondispatch::flox::Flox` [INFO] [stderr] --> src/actiondispatch/flox.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Flox { [INFO] [stderr] 11 | | Flox { ready: false } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `xfstruct::XFlowStruct` [INFO] [stderr] --> src/xfstruct.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> XFlowStruct { [INFO] [stderr] 72 | | XFlowStruct { [INFO] [stderr] 73 | | id: "".to_owned(), [INFO] [stderr] 74 | | name: "".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | impl Default for xfstruct::XFlowStruct { [INFO] [stderr] 63 | fn default() -> Self { [INFO] [stderr] 64 | Self::new() [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/xfstruct.rs:186:42 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn get_branches_for(&self, edge: &XFlowEdge) -> Vec<&XFlowBranch> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `XFlowEdge` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `xfstate::XFState` [INFO] [stderr] --> src/xfstate.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> XFState { [INFO] [stderr] 29 | | let store: XFStore = HashMap::new(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | XFState { store: store } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validation::Validation` [INFO] [stderr] --> src/validation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Validation { [INFO] [stderr] 35 | | Validation { errors: Vec::::new() } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/validation.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | |node| node.id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | message: format!("XFlow has no entry nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has no entry nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | paths: vec![format!("/nodes")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:99:30 [INFO] [stderr] | [INFO] [stderr] 99 | message: format!("XFlow has multiple entry nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has multiple entry nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | message: format!("XFlow has no terminal nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has no terminal nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | paths: vec![format!("/nodes")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dispatcher::Dispatcher<'a>` [INFO] [stderr] --> src/dispatcher.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Dispatcher<'a> { [INFO] [stderr] 14 | | let dispatchers: Dispatchers = HashMap::new(); [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | Dispatcher { dispatchers: dispatchers } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/dispatcher.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | dispatch.dispatch(xfnode, xfstate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actiondispatch::flow::Flow` [INFO] [stderr] --> src/actiondispatch/flow.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Flow { [INFO] [stderr] 11 | | Flow { ready: false } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actiondispatch::flox::Flox` [INFO] [stderr] --> src/actiondispatch/flox.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Flox { [INFO] [stderr] 11 | | Flox { ready: false } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `xfstruct::XFlowStruct` [INFO] [stderr] --> src/xfstruct.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> XFlowStruct { [INFO] [stderr] 72 | | XFlowStruct { [INFO] [stderr] 73 | | id: "".to_owned(), [INFO] [stderr] 74 | | name: "".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | impl Default for xfstruct::XFlowStruct { [INFO] [stderr] 63 | fn default() -> Self { [INFO] [stderr] 64 | Self::new() [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/xfstruct.rs:186:42 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn get_branches_for(&self, edge: &XFlowEdge) -> Vec<&XFlowBranch> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `XFlowEdge` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `xfstate::XFState` [INFO] [stderr] --> src/xfstate.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> XFState { [INFO] [stderr] 29 | | let store: XFStore = HashMap::new(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | XFState { store: store } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validation::Validation` [INFO] [stderr] --> src/validation.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Validation { [INFO] [stderr] 35 | | Validation { errors: Vec::::new() } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/validation.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | |node| node.id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | message: format!("XFlow has no entry nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has no entry nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | paths: vec![format!("/nodes")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:99:30 [INFO] [stderr] | [INFO] [stderr] 99 | message: format!("XFlow has multiple entry nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has multiple entry nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | message: format!("XFlow has no terminal nodes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"XFlow has no terminal nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validation.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | paths: vec![format!("/nodes")], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/nodes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dispatcher::Dispatcher<'a>` [INFO] [stderr] --> src/dispatcher.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Dispatcher<'a> { [INFO] [stderr] 14 | | let dispatchers: Dispatchers = HashMap::new(); [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | Dispatcher { dispatchers: dispatchers } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/dispatcher.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | dispatch.dispatch(xfnode, xfstate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/xflow_load.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/xflow_load.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> tests/helper.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/helper.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_string(&mut s) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 23 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xflow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> tests/helper.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/helper.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_string(&mut s) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 23 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xflow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/xflow_load.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return nodes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/xflow_load.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return nodes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> tests/helper.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/helper.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_string(&mut s) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 23 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> tests/xflow_run_001.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/xflow_validation.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match file.read_to_string(&mut s) { [INFO] [stderr] 30 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 31 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: Could not compile `xflow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/xflow_load.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match file.read_to_string(&mut s) { [INFO] [stderr] 26 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 27 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> tests/helper.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/helper.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_string(&mut s) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 23 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/xflow_load.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / match file.read_to_string(&mut s) { [INFO] [stderr] 26 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 27 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/xflow_validation.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match file.read_to_string(&mut s) { [INFO] [stderr] 30 | | Err(why) => panic!("couldn't read {}: {}", display, Error::description(&why)), [INFO] [stderr] 31 | | Ok(_) => {} // print!("{} contains:\n{}", display, s), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, Error::description(&why)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xflow`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f15d5bb460b2e81eb3f581069606505ce91b203aa68c35b1c690a06648e0484"` [INFO] running `"docker" "rm" "-f" "9f15d5bb460b2e81eb3f581069606505ce91b203aa68c35b1c690a06648e0484"` [INFO] [stdout] 9f15d5bb460b2e81eb3f581069606505ce91b203aa68c35b1c690a06648e0484