[INFO] crate xero 0.1.0 is already in cache [INFO] extracting crate xero 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/xero/0.1.0 [INFO] extracting crate xero 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xero/0.1.0 [INFO] validating manifest of xero-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xero-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xero-0.1.0 [INFO] finished frobbing xero-0.1.0 [INFO] frobbed toml for xero-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/xero/0.1.0/Cargo.toml [INFO] started frobbing xero-0.1.0 [INFO] finished frobbing xero-0.1.0 [INFO] frobbed toml for xero-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xero/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xero-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xero/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd96784f14b3f87aa59bd2ee15b37cc7b317f48d716a703180d0524d3e475c59 [INFO] running `"docker" "start" "-a" "fd96784f14b3f87aa59bd2ee15b37cc7b317f48d716a703180d0524d3e475c59"` [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking serde_qs v0.0.2 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking hyper-openssl v0.2.7 [INFO] [stderr] Checking xero v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Client {client: client, application: Box::new(app)} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Client {client: client, application: Box::new(app)} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/oauth.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | pub const SIGNATURE_HMAC: &'static str = "HMAC-SHA1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/oauth.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | pub const SIGNATURE_RSA: &'static str = "RSA-SHA1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/oauth.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | pub const SIGNATURE_HMAC: &'static str = "HMAC-SHA1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/oauth.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | pub const SIGNATURE_RSA: &'static str = "RSA-SHA1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/oauth.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | let signature_bytes = signer.finish()?; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/oauth.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | let signature_bytes = signer.finish()?; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | json::from_str(&body).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encoding.rs:47:84 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn array(&mut self, array: &str, element: &str, items: &Vec) -> Result<(), XmlError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/encoding.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | xml.write(match *self {true => "true", false => "false"}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an if/else expression: `if *self { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | json::from_str(&body).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encoding.rs:47:84 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn array(&mut self, array: &str, element: &str, items: &Vec) -> Result<(), XmlError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/encoding.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | xml.write(match *self {true => "true", false => "false"}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an if/else expression: `if *self { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/encoding.rs:49:46 [INFO] [stderr] | [INFO] [stderr] 49 | date: Some(NaiveDate::from_ymd(2009, 08, 30)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 49 | date: Some(NaiveDate::from_ymd(2009, 8, 30)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 49 | date: Some(NaiveDate::from_ymd(2009, 0o8, 30)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/encoding.rs:50:50 [INFO] [stderr] | [INFO] [stderr] 50 | date_due: Some(NaiveDate::from_ymd(2009, 09, 20)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 50 | date_due: Some(NaiveDate::from_ymd(2009, 9, 20)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 50 | date_due: Some(NaiveDate::from_ymd(2009, 0o9, 20)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.96s [INFO] running `"docker" "inspect" "fd96784f14b3f87aa59bd2ee15b37cc7b317f48d716a703180d0524d3e475c59"` [INFO] running `"docker" "rm" "-f" "fd96784f14b3f87aa59bd2ee15b37cc7b317f48d716a703180d0524d3e475c59"` [INFO] [stdout] fd96784f14b3f87aa59bd2ee15b37cc7b317f48d716a703180d0524d3e475c59