[INFO] crate xdlol 0.0.0 is already in cache [INFO] extracting crate xdlol 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/xdlol/0.0.0 [INFO] extracting crate xdlol 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdlol/0.0.0 [INFO] validating manifest of xdlol-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xdlol-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xdlol-0.0.0 [INFO] finished frobbing xdlol-0.0.0 [INFO] frobbed toml for xdlol-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/xdlol/0.0.0/Cargo.toml [INFO] started frobbing xdlol-0.0.0 [INFO] finished frobbing xdlol-0.0.0 [INFO] frobbed toml for xdlol-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdlol/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xdlol-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xdlol/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f4e46f9f9d897aafce0ca44c80a587f3351820f8c62ca1e1037fe7c11154906 [INFO] running `"docker" "start" "-a" "1f4e46f9f9d897aafce0ca44c80a587f3351820f8c62ca1e1037fe7c11154906"` [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking statrs v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking xdlol v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/statistics/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/statistics/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p_value` [INFO] [stderr] --> src/statistics/chi_square.rs:112:1 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn p_value(dof: u64, critical_value: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `statistics::frequency::FrequencyMap` [INFO] [stderr] --> src/statistics/frequency.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | FrequencyMap { [INFO] [stderr] 43 | | default: Zero::zero(), [INFO] [stderr] 44 | | freq_map: HashMap::new(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for statistics::frequency::FrequencyMap { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/statistics/frequency.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | *self.freq_map.entry(k).or_insert(Zero::zero()) += One::one(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/statistics/frequency.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | self.get(&k).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.get(&k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable `K` should have a snake case name such as `k` [INFO] [stderr] --> src/statistics/chi_square.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let K: f64 = dof as f64 * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `X` should have a snake case name such as `x` [INFO] [stderr] --> src/statistics/chi_square.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let X: f64 = critical_value * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/statistics/mod.rs:41:43 [INFO] [stderr] | [INFO] [stderr] 41 | let bar_width: u64 = (item_norm * width as f64) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/statistics/chi_square.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | let expected = 0.0636423441307552; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.063_642_344_130_755_2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/statistics/chi_square.rs:181:36 [INFO] [stderr] | [INFO] [stderr] 181 | let p_value = p_value(255, 290.285192); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `290.285_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/statistics/chi_square.rs:206:31 [INFO] [stderr] | [INFO] [stderr] 206 | let expected_pvalue = 0.57240670447087982; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.572_406_704_470_879_82` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `statistics::frequency::FrequencyMap` [INFO] [stderr] --> src/statistics/frequency.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | FrequencyMap { [INFO] [stderr] 43 | | default: Zero::zero(), [INFO] [stderr] 44 | | freq_map: HashMap::new(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for statistics::frequency::FrequencyMap { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/statistics/frequency.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | *self.freq_map.entry(k).or_insert(Zero::zero()) += One::one(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/statistics/frequency.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | self.get(&k).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.get(&k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable `K` should have a snake case name such as `k` [INFO] [stderr] --> src/statistics/chi_square.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let K: f64 = dof as f64 * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `X` should have a snake case name such as `x` [INFO] [stderr] --> src/statistics/chi_square.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let X: f64 = critical_value * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/statistics/chi_square.rs:206:31 [INFO] [stderr] | [INFO] [stderr] 206 | let expected_pvalue = 0.57240670447087982; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.572_406_704_470_879_8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/statistics/mod.rs:41:43 [INFO] [stderr] | [INFO] [stderr] 41 | let bar_width: u64 = (item_norm * width as f64) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/frequency_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `xdlol`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1f4e46f9f9d897aafce0ca44c80a587f3351820f8c62ca1e1037fe7c11154906"` [INFO] running `"docker" "rm" "-f" "1f4e46f9f9d897aafce0ca44c80a587f3351820f8c62ca1e1037fe7c11154906"` [INFO] [stdout] 1f4e46f9f9d897aafce0ca44c80a587f3351820f8c62ca1e1037fe7c11154906