[INFO] crate xdg-user-macros 0.1.1 is already in cache [INFO] extracting crate xdg-user-macros 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/xdg-user-macros/0.1.1 [INFO] extracting crate xdg-user-macros 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdg-user-macros/0.1.1 [INFO] validating manifest of xdg-user-macros-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xdg-user-macros-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xdg-user-macros-0.1.1 [INFO] finished frobbing xdg-user-macros-0.1.1 [INFO] frobbed toml for xdg-user-macros-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/xdg-user-macros/0.1.1/Cargo.toml [INFO] started frobbing xdg-user-macros-0.1.1 [INFO] finished frobbing xdg-user-macros-0.1.1 [INFO] frobbed toml for xdg-user-macros-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdg-user-macros/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xdg-user-macros-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xdg-user-macros/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f385767a0e521fe0eeabf7a74554cea20696c03cb880d05eaacbccafb13ae793 [INFO] running `"docker" "start" "-a" "f385767a0e521fe0eeabf7a74554cea20696c03cb880d05eaacbccafb13ae793"` [INFO] [stderr] Checking xdg-user-macros v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | use std::env::{self, home_dir}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | path [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | let runtime_dir: PathBuf = xdg_runtime_dir!(); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | let mut path = match env::var_os("XDG_RUNTIME_DIR") { [INFO] [stderr] | ________________________^ [INFO] [stderr] 115 | | Some(val) => PathBuf::from(val), [INFO] [stderr] 116 | | None => { [INFO] [stderr] 117 | | let run_dir = "/run/user"; [INFO] [stderr] ... | [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 151 | let runtime_dir: PathBuf = xdg_runtime_dir!(); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | path [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | let runtime_dir: PathBuf = xdg_runtime_dir!(); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let path = PathBuf::from(format!("{}/{}", run_dir, uid)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | let runtime_dir: PathBuf = xdg_runtime_dir!(); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | use std::env::{self, home_dir}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | use std::env::{self, home_dir}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | let mut path = home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 140 | let data_home: PathBuf = xdg_data_home!("test"); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | home_dir().unwrap().to_str().unwrap(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:54:32 [INFO] [stderr] | [INFO] [stderr] 54 | let mut path = home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 159 | let config_home: PathBuf = xdg_config_home!("test"); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | home_dir().unwrap().to_str().unwrap(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:74:32 [INFO] [stderr] | [INFO] [stderr] 74 | let mut path = home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 170 | let config_home: PathBuf = xdg_cache_home!("test"); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | home_dir().unwrap().to_str().unwrap(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "f385767a0e521fe0eeabf7a74554cea20696c03cb880d05eaacbccafb13ae793"` [INFO] running `"docker" "rm" "-f" "f385767a0e521fe0eeabf7a74554cea20696c03cb880d05eaacbccafb13ae793"` [INFO] [stdout] f385767a0e521fe0eeabf7a74554cea20696c03cb880d05eaacbccafb13ae793