[INFO] crate xdg-basedir 1.0.0 is already in cache [INFO] extracting crate xdg-basedir 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/xdg-basedir/1.0.0 [INFO] extracting crate xdg-basedir 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdg-basedir/1.0.0 [INFO] validating manifest of xdg-basedir-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xdg-basedir-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xdg-basedir-1.0.0 [INFO] finished frobbing xdg-basedir-1.0.0 [INFO] frobbed toml for xdg-basedir-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/xdg-basedir/1.0.0/Cargo.toml [INFO] started frobbing xdg-basedir-1.0.0 [INFO] finished frobbing xdg-basedir-1.0.0 [INFO] frobbed toml for xdg-basedir-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xdg-basedir/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xdg-basedir-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xdg-basedir/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 893a764464c6b6468010357fa5dd0899b1257e669316e4169b375a530cbbfca0 [INFO] running `"docker" "start" "-a" "893a764464c6b6468010357fa5dd0899b1257e669316e4169b375a530cbbfca0"` [INFO] [stderr] Checking xdg-basedir v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Error { error_kind: error_kind } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Error { error_kind: error_kind } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env_path.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::{home_dir, split_paths}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env_path.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | .or(home_dir().map(|p| p.join(default))) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/env_path.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(Error::from(XdgError::NoHomeDir)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(XdgError::NoHomeDir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/env_path.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .or(home_dir().map(|p| p.join(default))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| home_dir().map(|p| p.join(default)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/env_path.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / get_env_var(env_var) [INFO] [stderr] 22 | | .map(PathBuf::from) [INFO] [stderr] 23 | | .into_iter() [INFO] [stderr] 24 | | .filter(|x| x.is_absolute()) [INFO] [stderr] 25 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.is_absolute()).next()` with `find(|x| x.is_absolute())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/env_path.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .unwrap_or(OsString::from(default)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from(default))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/env_path.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | let path_string = (*get_env_var)(env_var) [INFO] [stderr] | _______________________^ [INFO] [stderr] 32 | | .into_iter() [INFO] [stderr] 33 | | .filter(|x| x != "") [INFO] [stderr] 34 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|x| x != "").next()` with `find(|x| x != "")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env_path.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::{home_dir, split_paths}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env_path.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | .or(home_dir().map(|p| p.join(default))) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | use std::env::{self, home_dir, join_paths, split_paths}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:55:57 [INFO] [stderr] | [INFO] [stderr] 55 | assert!(get_data_home_from_env(f).unwrap() == home_dir().unwrap().join(".local/share")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:57:57 [INFO] [stderr] | [INFO] [stderr] 57 | assert!(get_config_home_from_env(f).unwrap() == home_dir().unwrap().join(".config")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:59:57 [INFO] [stderr] | [INFO] [stderr] 59 | assert!(get_cache_home_from_env(f).unwrap() == home_dir().unwrap().join(".cache")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:74:57 [INFO] [stderr] | [INFO] [stderr] 74 | assert!(get_data_home_from_env(f).unwrap() == home_dir().unwrap().join(".local/share")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:76:57 [INFO] [stderr] | [INFO] [stderr] 76 | assert!(get_config_home_from_env(f).unwrap() == home_dir().unwrap().join(".config")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:78:57 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(get_cache_home_from_env(f).unwrap() == home_dir().unwrap().join(".cache")); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/env_path.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(Error::from(XdgError::NoHomeDir)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(XdgError::NoHomeDir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/env_path.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | .or(home_dir().map(|p| p.join(default))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| home_dir().map(|p| p.join(default)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/env_path.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / get_env_var(env_var) [INFO] [stderr] 22 | | .map(PathBuf::from) [INFO] [stderr] 23 | | .into_iter() [INFO] [stderr] 24 | | .filter(|x| x.is_absolute()) [INFO] [stderr] 25 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.is_absolute()).next()` with `find(|x| x.is_absolute())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/env_path.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .unwrap_or(OsString::from(default)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from(default))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/env_path.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | let path_string = (*get_env_var)(env_var) [INFO] [stderr] | _______________________^ [INFO] [stderr] 32 | | .into_iter() [INFO] [stderr] 33 | | .filter(|x| x != "") [INFO] [stderr] 34 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|x| x != "").next()` with `find(|x| x != "")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "893a764464c6b6468010357fa5dd0899b1257e669316e4169b375a530cbbfca0"` [INFO] running `"docker" "rm" "-f" "893a764464c6b6468010357fa5dd0899b1257e669316e4169b375a530cbbfca0"` [INFO] [stdout] 893a764464c6b6468010357fa5dd0899b1257e669316e4169b375a530cbbfca0