[INFO] crate xcur 0.1.3 is already in cache [INFO] extracting crate xcur 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/xcur/0.1.3 [INFO] extracting crate xcur 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcur/0.1.3 [INFO] validating manifest of xcur-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xcur-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xcur-0.1.3 [INFO] finished frobbing xcur-0.1.3 [INFO] frobbed toml for xcur-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/xcur/0.1.3/Cargo.toml [INFO] started frobbing xcur-0.1.3 [INFO] finished frobbing xcur-0.1.3 [INFO] frobbed toml for xcur-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcur/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xcur-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xcur/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 768619f97fccd877f5c178f81acdc00cdba66cb2a7210f629e10721abdaac0f2 [INFO] running `"docker" "start" "-a" "768619f97fccd877f5c178f81acdc00cdba66cb2a7210f629e10721abdaac0f2"` [INFO] [stderr] Checking xcur v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:197:27 [INFO] [stderr] | [INFO] [stderr] 197 | chunkheader: chunkheader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunkheader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:198:27 [INFO] [stderr] | [INFO] [stderr] 198 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:255:27 [INFO] [stderr] | [INFO] [stderr] 255 | chunkheader: chunkheader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunkheader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:257:27 [INFO] [stderr] | [INFO] [stderr] 257 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | xhot: xhot, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `xhot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:259:27 [INFO] [stderr] | [INFO] [stderr] 259 | yhot: yhot, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `yhot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:260:27 [INFO] [stderr] | [INFO] [stderr] 260 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:261:27 [INFO] [stderr] | [INFO] [stderr] 261 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:349:27 [INFO] [stderr] | [INFO] [stderr] 349 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:350:27 [INFO] [stderr] | [INFO] [stderr] 350 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:197:27 [INFO] [stderr] | [INFO] [stderr] 197 | chunkheader: chunkheader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunkheader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:198:27 [INFO] [stderr] | [INFO] [stderr] 198 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:255:27 [INFO] [stderr] | [INFO] [stderr] 255 | chunkheader: chunkheader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunkheader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:257:27 [INFO] [stderr] | [INFO] [stderr] 257 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | xhot: xhot, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `xhot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:259:27 [INFO] [stderr] | [INFO] [stderr] 259 | yhot: yhot, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `yhot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:260:27 [INFO] [stderr] | [INFO] [stderr] 260 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:261:27 [INFO] [stderr] | [INFO] [stderr] 261 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:349:27 [INFO] [stderr] | [INFO] [stderr] 349 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:350:27 [INFO] [stderr] | [INFO] [stderr] 350 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | if self.magic != 0x72756358 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7275_6358` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | const COMMENT_TYPE: u32 = 0xFFFE0001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFE_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | const IMAGE_TYPE: u32 = 0xFFFD0002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFD_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | if self.magic != 0x72756358 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7275_6358` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | const COMMENT_TYPE: u32 = 0xFFFE0001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFE_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | const IMAGE_TYPE: u32 = 0xFFFD0002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFD_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | / match self { [INFO] [stderr] 395 | | &ParseError::NomError(ref e) => write!(f, "Nom Error: {}", e), [INFO] [stderr] 396 | | &ParseError::InvalidHeader(e) => write!(f, "Invalid header: {}", e), [INFO] [stderr] 397 | | &ParseError::InvalidCommentVersion => write!(f, "Invalid comment version"), [INFO] [stderr] ... | [INFO] [stderr] 403 | | &ParseError::InvalidTOC => write!(f, "Invalid table of contents"), [INFO] [stderr] 404 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 394 | match *self { [INFO] [stderr] 395 | ParseError::NomError(ref e) => write!(f, "Nom Error: {}", e), [INFO] [stderr] 396 | ParseError::InvalidHeader(e) => write!(f, "Invalid header: {}", e), [INFO] [stderr] 397 | ParseError::InvalidCommentVersion => write!(f, "Invalid comment version"), [INFO] [stderr] 398 | ParseError::InvalidImageVersion => write!(f, "Invalid image version"), [INFO] [stderr] 399 | ParseError::InvalidImageWidth => write!(f, "Invalid image width"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | / match self { [INFO] [stderr] 411 | | &ParseError::NomError(_) => "Nom Error", [INFO] [stderr] 412 | | &ParseError::InvalidHeader(_) => "Invalid header", [INFO] [stderr] 413 | | &ParseError::InvalidCommentVersion => "Invalid comment version", [INFO] [stderr] ... | [INFO] [stderr] 419 | | &ParseError::InvalidTOC => "Invalid table of contents", [INFO] [stderr] 420 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 410 | match *self { [INFO] [stderr] 411 | ParseError::NomError(_) => "Nom Error", [INFO] [stderr] 412 | ParseError::InvalidHeader(_) => "Invalid header", [INFO] [stderr] 413 | ParseError::InvalidCommentVersion => "Invalid comment version", [INFO] [stderr] 414 | ParseError::InvalidImageVersion => "Invalid image version", [INFO] [stderr] 415 | ParseError::InvalidImageWidth => "Invalid image width", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let file = parser::File::parse(data).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | / match self { [INFO] [stderr] 395 | | &ParseError::NomError(ref e) => write!(f, "Nom Error: {}", e), [INFO] [stderr] 396 | | &ParseError::InvalidHeader(e) => write!(f, "Invalid header: {}", e), [INFO] [stderr] 397 | | &ParseError::InvalidCommentVersion => write!(f, "Invalid comment version"), [INFO] [stderr] ... | [INFO] [stderr] 403 | | &ParseError::InvalidTOC => write!(f, "Invalid table of contents"), [INFO] [stderr] 404 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 394 | match *self { [INFO] [stderr] 395 | ParseError::NomError(ref e) => write!(f, "Nom Error: {}", e), [INFO] [stderr] 396 | ParseError::InvalidHeader(e) => write!(f, "Invalid header: {}", e), [INFO] [stderr] 397 | ParseError::InvalidCommentVersion => write!(f, "Invalid comment version"), [INFO] [stderr] 398 | ParseError::InvalidImageVersion => write!(f, "Invalid image version"), [INFO] [stderr] 399 | ParseError::InvalidImageWidth => write!(f, "Invalid image width"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | / match self { [INFO] [stderr] 411 | | &ParseError::NomError(_) => "Nom Error", [INFO] [stderr] 412 | | &ParseError::InvalidHeader(_) => "Invalid header", [INFO] [stderr] 413 | | &ParseError::InvalidCommentVersion => "Invalid comment version", [INFO] [stderr] ... | [INFO] [stderr] 419 | | &ParseError::InvalidTOC => "Invalid table of contents", [INFO] [stderr] 420 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 410 | match *self { [INFO] [stderr] 411 | ParseError::NomError(_) => "Nom Error", [INFO] [stderr] 412 | ParseError::InvalidHeader(_) => "Invalid header", [INFO] [stderr] 413 | ParseError::InvalidCommentVersion => "Invalid comment version", [INFO] [stderr] 414 | ParseError::InvalidImageVersion => "Invalid image version", [INFO] [stderr] 415 | ParseError::InvalidImageWidth => "Invalid image width", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "768619f97fccd877f5c178f81acdc00cdba66cb2a7210f629e10721abdaac0f2"` [INFO] running `"docker" "rm" "-f" "768619f97fccd877f5c178f81acdc00cdba66cb2a7210f629e10721abdaac0f2"` [INFO] [stdout] 768619f97fccd877f5c178f81acdc00cdba66cb2a7210f629e10721abdaac0f2