[INFO] crate xcore 0.1.3 is already in cache [INFO] extracting crate xcore 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/xcore/0.1.3 [INFO] extracting crate xcore 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcore/0.1.3 [INFO] validating manifest of xcore-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xcore-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xcore-0.1.3 [INFO] finished frobbing xcore-0.1.3 [INFO] frobbed toml for xcore-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/xcore/0.1.3/Cargo.toml [INFO] started frobbing xcore-0.1.3 [INFO] finished frobbing xcore-0.1.3 [INFO] frobbed toml for xcore-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcore/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xcore-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xcore/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db650e34949cc3af1bfb79ea0ecfc6e3e012004b6c7d8f8120c711d80369b43b [INFO] running `"docker" "start" "-a" "db650e34949cc3af1bfb79ea0ecfc6e3e012004b6c7d8f8120c711d80369b43b"` [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking xcore v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/epoll_wrapper.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | fd_list: fd_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fd_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/epoll_wrapper.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | fd_list: fd_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fd_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core_poll.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if self.list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/executor.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / match rx.try_recv() { [INFO] [stderr] 43 | | Ok(ctrl) => { [INFO] [stderr] 44 | | match ctrl { [INFO] [stderr] 45 | | Ctrl::ADD(fd) => { [INFO] [stderr] ... | [INFO] [stderr] 58 | | Err(_) => {} [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Ok(ctrl) = rx.try_recv() { [INFO] [stderr] 43 | match ctrl { [INFO] [stderr] 44 | Ctrl::ADD(fd) => { [INFO] [stderr] 45 | epoll.add(fd); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | Ctrl::RM(fd) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core_poll.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if self.list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/executor.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / match rx.try_recv() { [INFO] [stderr] 43 | | Ok(ctrl) => { [INFO] [stderr] 44 | | match ctrl { [INFO] [stderr] 45 | | Ctrl::ADD(fd) => { [INFO] [stderr] ... | [INFO] [stderr] 58 | | Err(_) => {} [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Ok(ctrl) = rx.try_recv() { [INFO] [stderr] 43 | match ctrl { [INFO] [stderr] 44 | Ctrl::ADD(fd) => { [INFO] [stderr] 45 | epoll.add(fd); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | Ctrl::RM(fd) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.74s [INFO] running `"docker" "inspect" "db650e34949cc3af1bfb79ea0ecfc6e3e012004b6c7d8f8120c711d80369b43b"` [INFO] running `"docker" "rm" "-f" "db650e34949cc3af1bfb79ea0ecfc6e3e012004b6c7d8f8120c711d80369b43b"` [INFO] [stdout] db650e34949cc3af1bfb79ea0ecfc6e3e012004b6c7d8f8120c711d80369b43b