[INFO] crate xcompress 0.10.3 is already in cache [INFO] extracting crate xcompress 0.10.3 into work/ex/clippy-test-run/sources/stable/reg/xcompress/0.10.3 [INFO] extracting crate xcompress 0.10.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcompress/0.10.3 [INFO] validating manifest of xcompress-0.10.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xcompress-0.10.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xcompress-0.10.3 [INFO] finished frobbing xcompress-0.10.3 [INFO] frobbed toml for xcompress-0.10.3 written to work/ex/clippy-test-run/sources/stable/reg/xcompress/0.10.3/Cargo.toml [INFO] started frobbing xcompress-0.10.3 [INFO] finished frobbing xcompress-0.10.3 [INFO] frobbed toml for xcompress-0.10.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xcompress/0.10.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xcompress-0.10.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xcompress/0.10.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0626aa6be1be5eaed03e919e4efaffdf1b65e9ab8998dc8f1602647d4cc0770 [INFO] running `"docker" "start" "-a" "d0626aa6be1be5eaed03e919e4efaffdf1b65e9ab8998dc8f1602647d4cc0770"` [INFO] [stderr] Checking path-dedot v1.1.9 [INFO] [stderr] Checking subprocess v0.1.18 [INFO] [stderr] Checking byte-unit v1.1.0 [INFO] [stderr] Checking path-absolutize v1.1.3 [INFO] [stderr] Checking xcompress v0.10.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:793:13 [INFO] [stderr] | [INFO] [stderr] 793 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:996:29 [INFO] [stderr] | [INFO] [stderr] 996 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:999:29 [INFO] [stderr] | [INFO] [stderr] 999 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1062:29 [INFO] [stderr] | [INFO] [stderr] 1062 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1065:29 [INFO] [stderr] | [INFO] [stderr] 1065 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1125:29 [INFO] [stderr] | [INFO] [stderr] 1125 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1128:29 [INFO] [stderr] | [INFO] [stderr] 1128 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1168:29 [INFO] [stderr] | [INFO] [stderr] 1168 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1171:29 [INFO] [stderr] | [INFO] [stderr] 1171 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1213:29 [INFO] [stderr] | [INFO] [stderr] 1213 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1216:29 [INFO] [stderr] | [INFO] [stderr] 1216 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1258:29 [INFO] [stderr] | [INFO] [stderr] 1258 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1261:29 [INFO] [stderr] | [INFO] [stderr] 1261 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1329:21 [INFO] [stderr] | [INFO] [stderr] 1329 | return execute_two(&cmd1, &cmd2, output_folder); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute_two(&cmd1, &cmd2, output_folder)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1388:21 [INFO] [stderr] | [INFO] [stderr] 1388 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1391:21 [INFO] [stderr] | [INFO] [stderr] 1391 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1464:21 [INFO] [stderr] | [INFO] [stderr] 1464 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1467:21 [INFO] [stderr] | [INFO] [stderr] 1467 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1539:21 [INFO] [stderr] | [INFO] [stderr] 1539 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1542:21 [INFO] [stderr] | [INFO] [stderr] 1542 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1594:21 [INFO] [stderr] | [INFO] [stderr] 1594 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1597:21 [INFO] [stderr] | [INFO] [stderr] 1597 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1651:21 [INFO] [stderr] | [INFO] [stderr] 1651 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1654:21 [INFO] [stderr] | [INFO] [stderr] 1654 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1708:21 [INFO] [stderr] | [INFO] [stderr] 1708 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1711:21 [INFO] [stderr] | [INFO] [stderr] 1711 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:957:12 [INFO] [stderr] | [INFO] [stderr] 957 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 958 | | if let Err(error) = fs::create_dir_all(output_folder) { [INFO] [stderr] 959 | | return Err(error.to_string()); [INFO] [stderr] 960 | | } [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 957 | } else if let Err(error) = fs::create_dir_all(output_folder) { [INFO] [stderr] 958 | return Err(error.to_string()); [INFO] [stderr] 959 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2188:13 [INFO] [stderr] | [INFO] [stderr] 2188 | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute_two(&cmd1, &cmd2, output_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2283:21 [INFO] [stderr] | [INFO] [stderr] 2283 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2286:21 [INFO] [stderr] | [INFO] [stderr] 2286 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2343:21 [INFO] [stderr] | [INFO] [stderr] 2343 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2346:21 [INFO] [stderr] | [INFO] [stderr] 2346 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2389:21 [INFO] [stderr] | [INFO] [stderr] 2389 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2392:21 [INFO] [stderr] | [INFO] [stderr] 2392 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2435:21 [INFO] [stderr] | [INFO] [stderr] 2435 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2438:21 [INFO] [stderr] | [INFO] [stderr] 2438 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2481:21 [INFO] [stderr] | [INFO] [stderr] 2481 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2484:21 [INFO] [stderr] | [INFO] [stderr] 2484 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2605:21 [INFO] [stderr] | [INFO] [stderr] 2605 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2608:21 [INFO] [stderr] | [INFO] [stderr] 2608 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1974:12 [INFO] [stderr] | [INFO] [stderr] 1974 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1975 | | if let Err(error) = fs::create_dir_all(&output_path_obj) { [INFO] [stderr] 1976 | | return Err(error.to_string()); [INFO] [stderr] 1977 | | } [INFO] [stderr] 1978 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1974 | } else if let Err(error) = fs::create_dir_all(&output_path_obj) { [INFO] [stderr] 1975 | return Err(error.to_string()); [INFO] [stderr] 1976 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:793:13 [INFO] [stderr] | [INFO] [stderr] 793 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:996:29 [INFO] [stderr] | [INFO] [stderr] 996 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:999:29 [INFO] [stderr] | [INFO] [stderr] 999 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1062:29 [INFO] [stderr] | [INFO] [stderr] 1062 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1065:29 [INFO] [stderr] | [INFO] [stderr] 1065 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1125:29 [INFO] [stderr] | [INFO] [stderr] 1125 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1128:29 [INFO] [stderr] | [INFO] [stderr] 1128 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1168:29 [INFO] [stderr] | [INFO] [stderr] 1168 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1171:29 [INFO] [stderr] | [INFO] [stderr] 1171 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1213:29 [INFO] [stderr] | [INFO] [stderr] 1213 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1216:29 [INFO] [stderr] | [INFO] [stderr] 1216 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1258:29 [INFO] [stderr] | [INFO] [stderr] 1258 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1261:29 [INFO] [stderr] | [INFO] [stderr] 1261 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1329:21 [INFO] [stderr] | [INFO] [stderr] 1329 | return execute_two(&cmd1, &cmd2, output_folder); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute_two(&cmd1, &cmd2, output_folder)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1388:21 [INFO] [stderr] | [INFO] [stderr] 1388 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1391:21 [INFO] [stderr] | [INFO] [stderr] 1391 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1464:21 [INFO] [stderr] | [INFO] [stderr] 1464 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1467:21 [INFO] [stderr] | [INFO] [stderr] 1467 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1539:21 [INFO] [stderr] | [INFO] [stderr] 1539 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1542:21 [INFO] [stderr] | [INFO] [stderr] 1542 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1594:21 [INFO] [stderr] | [INFO] [stderr] 1594 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1597:21 [INFO] [stderr] | [INFO] [stderr] 1597 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1651:21 [INFO] [stderr] | [INFO] [stderr] 1651 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1654:21 [INFO] [stderr] | [INFO] [stderr] 1654 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1708:21 [INFO] [stderr] | [INFO] [stderr] 1708 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1711:21 [INFO] [stderr] | [INFO] [stderr] 1711 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:957:12 [INFO] [stderr] | [INFO] [stderr] 957 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 958 | | if let Err(error) = fs::create_dir_all(output_folder) { [INFO] [stderr] 959 | | return Err(error.to_string()); [INFO] [stderr] 960 | | } [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 957 | } else if let Err(error) = fs::create_dir_all(output_folder) { [INFO] [stderr] 958 | return Err(error.to_string()); [INFO] [stderr] 959 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2188:13 [INFO] [stderr] | [INFO] [stderr] 2188 | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute_two(&cmd1, &cmd2, output_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2283:21 [INFO] [stderr] | [INFO] [stderr] 2283 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2286:21 [INFO] [stderr] | [INFO] [stderr] 2286 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2343:21 [INFO] [stderr] | [INFO] [stderr] 2343 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2346:21 [INFO] [stderr] | [INFO] [stderr] 2346 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2389:21 [INFO] [stderr] | [INFO] [stderr] 2389 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2392:21 [INFO] [stderr] | [INFO] [stderr] 2392 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2435:21 [INFO] [stderr] | [INFO] [stderr] 2435 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2438:21 [INFO] [stderr] | [INFO] [stderr] 2438 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2481:21 [INFO] [stderr] | [INFO] [stderr] 2481 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2484:21 [INFO] [stderr] | [INFO] [stderr] 2484 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2605:21 [INFO] [stderr] | [INFO] [stderr] 2605 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2608:21 [INFO] [stderr] | [INFO] [stderr] 2608 | return Err(error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1974:12 [INFO] [stderr] | [INFO] [stderr] 1974 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1975 | | if let Err(error) = fs::create_dir_all(&output_path_obj) { [INFO] [stderr] 1976 | | return Err(error.to_string()); [INFO] [stderr] 1977 | | } [INFO] [stderr] 1978 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1974 | } else if let Err(error) = fs::create_dir_all(&output_path_obj) { [INFO] [stderr] 1975 | return Err(error.to_string()); [INFO] [stderr] 1976 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:857:47 [INFO] [stderr] | [INFO] [stderr] 857 | ExitStatus::Signaled(c) => Ok(c as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:874:47 [INFO] [stderr] | [INFO] [stderr] 874 | ExitStatus::Signaled(c) => Ok(c as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:933:152 [INFO] [stderr] | [INFO] [stderr] 933 | pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 101 [INFO] [stderr] --> src/lib.rs:933:1 [INFO] [stderr] | [INFO] [stderr] 933 | / pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] 934 | | let format = match ArchiveFormat::get_archive_format_from_file_path(output_path, exlude_tar) { [INFO] [stderr] 935 | | Ok(f) => f, [INFO] [stderr] 936 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 1950 | | } [INFO] [stderr] 1951 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:933:1 [INFO] [stderr] | [INFO] [stderr] 933 | / pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] 934 | | let format = match ArchiveFormat::get_archive_format_from_file_path(output_path, exlude_tar) { [INFO] [stderr] 935 | | Ok(f) => f, [INFO] [stderr] 936 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 1950 | | } [INFO] [stderr] 1951 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1005:32 [INFO] [stderr] | [INFO] [stderr] 1005 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1006 | | let mut cmd2 = vec![paths.pigz_path.as_str(), "-c", "-p", threads, "-"]; [INFO] [stderr] 1007 | | [INFO] [stderr] 1008 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1023 | | } [INFO] [stderr] 1024 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1005:57 [INFO] [stderr] | [INFO] [stderr] 1005 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1028:32 [INFO] [stderr] | [INFO] [stderr] 1028 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1029 | | let mut cmd2 = vec![paths.pigz_path.as_str(), "-c", "-p", "1", "-"]; [INFO] [stderr] 1030 | | [INFO] [stderr] 1031 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1046 | | } [INFO] [stderr] 1047 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1028:57 [INFO] [stderr] | [INFO] [stderr] 1028 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1071:32 [INFO] [stderr] | [INFO] [stderr] 1071 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1072 | | let mut cmd2 = vec![paths.lbzip2_path.as_str(), "-z", "-c", "-n", threads, "-"]; [INFO] [stderr] 1073 | | [INFO] [stderr] 1074 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1109 | | } [INFO] [stderr] 1110 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1071:57 [INFO] [stderr] | [INFO] [stderr] 1071 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1090:39 [INFO] [stderr] | [INFO] [stderr] 1090 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________________- ^^^^^ [INFO] [stderr] 1091 | | let cmd2 = format!("-p{}", threads); [INFO] [stderr] 1092 | | let mut cmd2 = vec![paths.pbzip2_path.as_str(), "-z", "-c", cmd2.as_str(), "-"]; [INFO] [stderr] 1093 | | [INFO] [stderr] ... | [INFO] [stderr] 1109 | | } [INFO] [stderr] 1110 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1090:64 [INFO] [stderr] | [INFO] [stderr] 1090 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1134:32 [INFO] [stderr] | [INFO] [stderr] 1134 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1135 | | let mut cmd2 = vec![paths.plzip_path.as_str(), "-F", "-c", "-n", threads, "-"]; [INFO] [stderr] 1136 | | [INFO] [stderr] 1137 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1152 | | } [INFO] [stderr] 1153 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1134:57 [INFO] [stderr] | [INFO] [stderr] 1134 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1177:32 [INFO] [stderr] | [INFO] [stderr] 1177 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1178 | | let mut cmd2 = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-"]; [INFO] [stderr] 1179 | | [INFO] [stderr] 1180 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1196 | | } [INFO] [stderr] 1197 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1177:57 [INFO] [stderr] | [INFO] [stderr] 1177 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1222:32 [INFO] [stderr] | [INFO] [stderr] 1222 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1223 | | let mut cmd2 = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-F", "lzma", "-"]; [INFO] [stderr] 1224 | | [INFO] [stderr] 1225 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1241 | | } [INFO] [stderr] 1242 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1222:57 [INFO] [stderr] | [INFO] [stderr] 1222 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1302:32 [INFO] [stderr] | [INFO] [stderr] 1302 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1303 | | let mut cmd2 = vec![paths.pzstd_path.as_str(), "-p", threads, "-", "-o", output_path]; [INFO] [stderr] 1304 | | [INFO] [stderr] 1305 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1314 | | return execute_two(&cmd1, &cmd2, output_folder); [INFO] [stderr] 1315 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1302:57 [INFO] [stderr] | [INFO] [stderr] 1302 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1409:24 [INFO] [stderr] | [INFO] [stderr] 1409 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1410 | | let mut cmd = vec![paths.pigz_path.as_str(), "-c", "-p", threads, input_path]; [INFO] [stderr] 1411 | | [INFO] [stderr] 1412 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1427 | | } [INFO] [stderr] 1428 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1409:49 [INFO] [stderr] | [INFO] [stderr] 1409 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1432:24 [INFO] [stderr] | [INFO] [stderr] 1432 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1433 | | let mut cmd = vec![paths.pigz_path.as_str(), "-c", "-p", "1", input_path]; [INFO] [stderr] 1434 | | [INFO] [stderr] 1435 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1448 | | } [INFO] [stderr] 1449 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1432:49 [INFO] [stderr] | [INFO] [stderr] 1432 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1485:24 [INFO] [stderr] | [INFO] [stderr] 1485 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1486 | | let mut cmd = vec![paths.lbzip2_path.as_str(), "-z", "-c", "-n", threads, input_path]; [INFO] [stderr] 1487 | | [INFO] [stderr] 1488 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1523 | | } [INFO] [stderr] 1524 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1485:49 [INFO] [stderr] | [INFO] [stderr] 1485 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1504:31 [INFO] [stderr] | [INFO] [stderr] 1504 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 1505 | | let cmd = format!("-p{}", threads); [INFO] [stderr] 1506 | | let mut cmd = vec![paths.pbzip2_path.as_str(), "-z", "-c", cmd.as_str(), input_path]; [INFO] [stderr] 1507 | | [INFO] [stderr] ... | [INFO] [stderr] 1523 | | } [INFO] [stderr] 1524 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1504:56 [INFO] [stderr] | [INFO] [stderr] 1504 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1560:24 [INFO] [stderr] | [INFO] [stderr] 1560 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1561 | | let mut cmd = vec![paths.plzip_path.as_str(), "-F", "-c", "-n", threads, input_path]; [INFO] [stderr] 1562 | | [INFO] [stderr] 1563 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1578 | | } [INFO] [stderr] 1579 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1560:49 [INFO] [stderr] | [INFO] [stderr] 1560 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1615:24 [INFO] [stderr] | [INFO] [stderr] 1615 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1616 | | let mut cmd = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, input_path]; [INFO] [stderr] 1617 | | [INFO] [stderr] 1618 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1634 | | } [INFO] [stderr] 1635 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1615:49 [INFO] [stderr] | [INFO] [stderr] 1615 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1672:24 [INFO] [stderr] | [INFO] [stderr] 1672 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1673 | | let mut cmd = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 1674 | | [INFO] [stderr] 1675 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1691 | | } [INFO] [stderr] 1692 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1672:49 [INFO] [stderr] | [INFO] [stderr] 1672 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:1764:46 [INFO] [stderr] | [INFO] [stderr] 1764 | let output_tmp_path_obj = if let Some(_) = &split { [INFO] [stderr] | _______________________________________- ^^^^^^^ [INFO] [stderr] 1765 | | let new_filename = format!("{}.tmp.zip", output_path_obj.file_stem().unwrap().to_str().unwrap()); [INFO] [stderr] 1766 | | [INFO] [stderr] 1767 | | if output_path_obj.exists() { [INFO] [stderr] ... | [INFO] [stderr] 1775 | | output_path_obj.clone() [INFO] [stderr] 1776 | | }; [INFO] [stderr] | |_____________- help: try this: `if &split.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1920:24 [INFO] [stderr] | [INFO] [stderr] 1920 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1921 | | let mut cmd = vec![paths.pzstd_path.as_str(), "-p", threads, input_path, "-o", output_path]; [INFO] [stderr] 1922 | | [INFO] [stderr] 1923 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1932 | | return execute_one(&cmd, output_folder); [INFO] [stderr] 1933 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1920:49 [INFO] [stderr] | [INFO] [stderr] 1920 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/lib.rs:1957:1 [INFO] [stderr] | [INFO] [stderr] 1957 | / pub fn extract(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, input_path: &str, output_path: &str) -> Result { [INFO] [stderr] 1958 | | let format = match ArchiveFormat::get_archive_format_from_file_path(input_path, exlude_tar) { [INFO] [stderr] 1959 | | Ok(f) => f, [INFO] [stderr] 1960 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 2613 | | } [INFO] [stderr] 2614 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1986:24 [INFO] [stderr] | [INFO] [stderr] 1986 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1987 | | let cmd1 = vec![paths.pigz_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 1988 | | [INFO] [stderr] 1989 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 1998 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 1999 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1986:49 [INFO] [stderr] | [INFO] [stderr] 1986 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2015:24 [INFO] [stderr] | [INFO] [stderr] 2015 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2016 | | let cmd1 = vec![paths.lbzip2_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2017 | | [INFO] [stderr] 2018 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2041 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2042 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2015:49 [INFO] [stderr] | [INFO] [stderr] 2015 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2028:31 [INFO] [stderr] | [INFO] [stderr] 2028 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 2029 | | let cmd1 = format!("-p{}", threads); [INFO] [stderr] 2030 | | let cmd1 = vec![paths.pbzip2_path.as_str(), "-d", "-c", cmd1.as_str(), input_path]; [INFO] [stderr] 2031 | | [INFO] [stderr] ... | [INFO] [stderr] 2041 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2042 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2028:56 [INFO] [stderr] | [INFO] [stderr] 2028 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2058:24 [INFO] [stderr] | [INFO] [stderr] 2058 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2059 | | let cmd1 = vec![paths.plzip_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2060 | | [INFO] [stderr] 2061 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2070 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2071 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2058:49 [INFO] [stderr] | [INFO] [stderr] 2058 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2074:20 [INFO] [stderr] | [INFO] [stderr] 2074 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2075 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.lunzip_path.as_str(), "-x"]; [INFO] [stderr] 2076 | | [INFO] [stderr] 2077 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2084 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2085 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.lunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2074:45 [INFO] [stderr] | [INFO] [stderr] 2074 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2100:24 [INFO] [stderr] | [INFO] [stderr] 2100 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2101 | | let cmd1 = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, input_path]; [INFO] [stderr] 2102 | | [INFO] [stderr] 2103 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2112 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2113 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2100:49 [INFO] [stderr] | [INFO] [stderr] 2100 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2129:24 [INFO] [stderr] | [INFO] [stderr] 2129 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2130 | | let cmd1 = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 2131 | | [INFO] [stderr] 2132 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2141 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2142 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2129:49 [INFO] [stderr] | [INFO] [stderr] 2129 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2145:20 [INFO] [stderr] | [INFO] [stderr] 2145 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2146 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.unlzma_path.as_str(), "-x"]; [INFO] [stderr] 2147 | | [INFO] [stderr] 2148 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2155 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2156 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unlzma_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2145:45 [INFO] [stderr] | [INFO] [stderr] 2145 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unlzma_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2192:24 [INFO] [stderr] | [INFO] [stderr] 2192 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2193 | | let cmd1 = vec![paths.pzstd_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2194 | | [INFO] [stderr] 2195 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2204 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2205 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2192:49 [INFO] [stderr] | [INFO] [stderr] 2192 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2208:20 [INFO] [stderr] | [INFO] [stderr] 2208 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2209 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.unzstd_path.as_str(), "-x"]; [INFO] [stderr] 2210 | | [INFO] [stderr] 2211 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2218 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2219 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2208:45 [INFO] [stderr] | [INFO] [stderr] 2208 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2246:24 [INFO] [stderr] | [INFO] [stderr] 2246 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2247 | | let cmd = vec![paths.pigz_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2248 | | [INFO] [stderr] 2249 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2258 | | } [INFO] [stderr] 2259 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2246:49 [INFO] [stderr] | [INFO] [stderr] 2246 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2262:20 [INFO] [stderr] | [INFO] [stderr] 2262 | if let Ok(_) = check_executable(&vec![paths.gunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2263 | | let cmd = vec![paths.gzip_path.as_str(), "-c", input_path]; [INFO] [stderr] 2264 | | [INFO] [stderr] 2265 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2274 | | } [INFO] [stderr] 2275 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.gunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2262:45 [INFO] [stderr] | [INFO] [stderr] 2262 | if let Ok(_) = check_executable(&vec![paths.gunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.gunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2292:24 [INFO] [stderr] | [INFO] [stderr] 2292 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2293 | | let cmd = vec![paths.lbzip2_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2294 | | [INFO] [stderr] 2295 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2318 | | } [INFO] [stderr] 2319 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2292:49 [INFO] [stderr] | [INFO] [stderr] 2292 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2305:31 [INFO] [stderr] | [INFO] [stderr] 2305 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 2306 | | let cmd = format!("-p{}", threads); [INFO] [stderr] 2307 | | let cmd = vec![paths.pbzip2_path.as_str(), "-d", "-c", cmd.as_str(), input_path]; [INFO] [stderr] 2308 | | [INFO] [stderr] ... | [INFO] [stderr] 2318 | | } [INFO] [stderr] 2319 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2305:56 [INFO] [stderr] | [INFO] [stderr] 2305 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2322:20 [INFO] [stderr] | [INFO] [stderr] 2322 | if let Ok(_) = check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2323 | | let cmd = vec![paths.bzip2_path.as_str(), "-c", input_path]; [INFO] [stderr] 2324 | | [INFO] [stderr] 2325 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2334 | | } [INFO] [stderr] 2335 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2322:45 [INFO] [stderr] | [INFO] [stderr] 2322 | if let Ok(_) = check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.bunzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2352:24 [INFO] [stderr] | [INFO] [stderr] 2352 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2353 | | let cmd = vec![paths.plzip_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2354 | | [INFO] [stderr] 2355 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2364 | | } [INFO] [stderr] 2365 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2352:49 [INFO] [stderr] | [INFO] [stderr] 2352 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2368:20 [INFO] [stderr] | [INFO] [stderr] 2368 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2369 | | let cmd = vec![paths.lunzip_path.as_str(), "-c", input_path]; [INFO] [stderr] 2370 | | [INFO] [stderr] 2371 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2380 | | } [INFO] [stderr] 2381 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.lunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2368:45 [INFO] [stderr] | [INFO] [stderr] 2368 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2398:24 [INFO] [stderr] | [INFO] [stderr] 2398 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2399 | | let cmd = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, input_path]; [INFO] [stderr] 2400 | | [INFO] [stderr] 2401 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2410 | | } [INFO] [stderr] 2411 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2398:49 [INFO] [stderr] | [INFO] [stderr] 2398 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2414:20 [INFO] [stderr] | [INFO] [stderr] 2414 | if let Ok(_) = check_executable(&vec![paths.unxz_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2415 | | let cmd = vec![paths.xz_path.as_str(), "-c", input_path]; [INFO] [stderr] 2416 | | [INFO] [stderr] 2417 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2426 | | } [INFO] [stderr] 2427 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2414:45 [INFO] [stderr] | [INFO] [stderr] 2414 | if let Ok(_) = check_executable(&vec![paths.unxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2444:24 [INFO] [stderr] | [INFO] [stderr] 2444 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2445 | | let cmd = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 2446 | | [INFO] [stderr] 2447 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2456 | | } [INFO] [stderr] 2457 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2444:49 [INFO] [stderr] | [INFO] [stderr] 2444 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2460:20 [INFO] [stderr] | [INFO] [stderr] 2460 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2461 | | let cmd = vec![paths.unlzma_path.as_str(), "-c", input_path]; [INFO] [stderr] 2462 | | [INFO] [stderr] 2463 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2472 | | } [INFO] [stderr] 2473 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unlzma_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2460:45 [INFO] [stderr] | [INFO] [stderr] 2460 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unlzma_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2527:20 [INFO] [stderr] | [INFO] [stderr] 2527 | if let Ok(_) = check_executable(&vec![paths.unrar_path.as_str(), "-?"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2528 | | let mut cmd = vec![paths.unrar_path.as_str(), "x", "-o+"]; [INFO] [stderr] 2529 | | [INFO] [stderr] 2530 | | cmd.push(thread_arg.as_str()); [INFO] [stderr] ... | [INFO] [stderr] 2544 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2545 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unrar_path.as_str(), "-?"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2527:45 [INFO] [stderr] | [INFO] [stderr] 2527 | if let Ok(_) = check_executable(&vec![paths.unrar_path.as_str(), "-?"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unrar_path.as_str(), "-?"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2568:24 [INFO] [stderr] | [INFO] [stderr] 2568 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2569 | | let cmd = vec![paths.pzstd_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2570 | | [INFO] [stderr] 2571 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2580 | | } [INFO] [stderr] 2581 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2568:49 [INFO] [stderr] | [INFO] [stderr] 2568 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2584:20 [INFO] [stderr] | [INFO] [stderr] 2584 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2585 | | let cmd = vec![paths.unzstd_path.as_str(), "-c", input_path]; [INFO] [stderr] 2586 | | [INFO] [stderr] 2587 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2596 | | } [INFO] [stderr] 2597 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2584:45 [INFO] [stderr] | [INFO] [stderr] 2584 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:857:47 [INFO] [stderr] | [INFO] [stderr] 857 | ExitStatus::Signaled(c) => Ok(c as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:874:47 [INFO] [stderr] | [INFO] [stderr] 874 | ExitStatus::Signaled(c) => Ok(c as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:933:152 [INFO] [stderr] | [INFO] [stderr] 933 | pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 101 [INFO] [stderr] --> src/lib.rs:933:1 [INFO] [stderr] | [INFO] [stderr] 933 | / pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] 934 | | let format = match ArchiveFormat::get_archive_format_from_file_path(output_path, exlude_tar) { [INFO] [stderr] 935 | | Ok(f) => f, [INFO] [stderr] 936 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 1950 | | } [INFO] [stderr] 1951 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:933:1 [INFO] [stderr] | [INFO] [stderr] 933 | / pub fn archive(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, best_compression: bool, split: Option, input_paths: &Vec, output_path: &str) -> Result { [INFO] [stderr] 934 | | let format = match ArchiveFormat::get_archive_format_from_file_path(output_path, exlude_tar) { [INFO] [stderr] 935 | | Ok(f) => f, [INFO] [stderr] 936 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 1950 | | } [INFO] [stderr] 1951 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1005:32 [INFO] [stderr] | [INFO] [stderr] 1005 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1006 | | let mut cmd2 = vec![paths.pigz_path.as_str(), "-c", "-p", threads, "-"]; [INFO] [stderr] 1007 | | [INFO] [stderr] 1008 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1023 | | } [INFO] [stderr] 1024 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1005:57 [INFO] [stderr] | [INFO] [stderr] 1005 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1028:32 [INFO] [stderr] | [INFO] [stderr] 1028 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1029 | | let mut cmd2 = vec![paths.pigz_path.as_str(), "-c", "-p", "1", "-"]; [INFO] [stderr] 1030 | | [INFO] [stderr] 1031 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1046 | | } [INFO] [stderr] 1047 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1028:57 [INFO] [stderr] | [INFO] [stderr] 1028 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1071:32 [INFO] [stderr] | [INFO] [stderr] 1071 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1072 | | let mut cmd2 = vec![paths.lbzip2_path.as_str(), "-z", "-c", "-n", threads, "-"]; [INFO] [stderr] 1073 | | [INFO] [stderr] 1074 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1109 | | } [INFO] [stderr] 1110 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1071:57 [INFO] [stderr] | [INFO] [stderr] 1071 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1090:39 [INFO] [stderr] | [INFO] [stderr] 1090 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________________- ^^^^^ [INFO] [stderr] 1091 | | let cmd2 = format!("-p{}", threads); [INFO] [stderr] 1092 | | let mut cmd2 = vec![paths.pbzip2_path.as_str(), "-z", "-c", cmd2.as_str(), "-"]; [INFO] [stderr] 1093 | | [INFO] [stderr] ... | [INFO] [stderr] 1109 | | } [INFO] [stderr] 1110 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1090:64 [INFO] [stderr] | [INFO] [stderr] 1090 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1134:32 [INFO] [stderr] | [INFO] [stderr] 1134 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1135 | | let mut cmd2 = vec![paths.plzip_path.as_str(), "-F", "-c", "-n", threads, "-"]; [INFO] [stderr] 1136 | | [INFO] [stderr] 1137 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1152 | | } [INFO] [stderr] 1153 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1134:57 [INFO] [stderr] | [INFO] [stderr] 1134 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1177:32 [INFO] [stderr] | [INFO] [stderr] 1177 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1178 | | let mut cmd2 = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-"]; [INFO] [stderr] 1179 | | [INFO] [stderr] 1180 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1196 | | } [INFO] [stderr] 1197 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1177:57 [INFO] [stderr] | [INFO] [stderr] 1177 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1222:32 [INFO] [stderr] | [INFO] [stderr] 1222 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1223 | | let mut cmd2 = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-F", "lzma", "-"]; [INFO] [stderr] 1224 | | [INFO] [stderr] 1225 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1241 | | } [INFO] [stderr] 1242 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1222:57 [INFO] [stderr] | [INFO] [stderr] 1222 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1302:32 [INFO] [stderr] | [INFO] [stderr] 1302 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 1303 | | let mut cmd2 = vec![paths.pzstd_path.as_str(), "-p", threads, "-", "-o", output_path]; [INFO] [stderr] 1304 | | [INFO] [stderr] 1305 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1314 | | return execute_two(&cmd1, &cmd2, output_folder); [INFO] [stderr] 1315 | | } [INFO] [stderr] | |_________________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1302:57 [INFO] [stderr] | [INFO] [stderr] 1302 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1409:24 [INFO] [stderr] | [INFO] [stderr] 1409 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1410 | | let mut cmd = vec![paths.pigz_path.as_str(), "-c", "-p", threads, input_path]; [INFO] [stderr] 1411 | | [INFO] [stderr] 1412 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1427 | | } [INFO] [stderr] 1428 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1409:49 [INFO] [stderr] | [INFO] [stderr] 1409 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1432:24 [INFO] [stderr] | [INFO] [stderr] 1432 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1433 | | let mut cmd = vec![paths.pigz_path.as_str(), "-c", "-p", "1", input_path]; [INFO] [stderr] 1434 | | [INFO] [stderr] 1435 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1448 | | } [INFO] [stderr] 1449 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1432:49 [INFO] [stderr] | [INFO] [stderr] 1432 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1485:24 [INFO] [stderr] | [INFO] [stderr] 1485 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1486 | | let mut cmd = vec![paths.lbzip2_path.as_str(), "-z", "-c", "-n", threads, input_path]; [INFO] [stderr] 1487 | | [INFO] [stderr] 1488 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1523 | | } [INFO] [stderr] 1524 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1485:49 [INFO] [stderr] | [INFO] [stderr] 1485 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1504:31 [INFO] [stderr] | [INFO] [stderr] 1504 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 1505 | | let cmd = format!("-p{}", threads); [INFO] [stderr] 1506 | | let mut cmd = vec![paths.pbzip2_path.as_str(), "-z", "-c", cmd.as_str(), input_path]; [INFO] [stderr] 1507 | | [INFO] [stderr] ... | [INFO] [stderr] 1523 | | } [INFO] [stderr] 1524 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1504:56 [INFO] [stderr] | [INFO] [stderr] 1504 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1560:24 [INFO] [stderr] | [INFO] [stderr] 1560 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1561 | | let mut cmd = vec![paths.plzip_path.as_str(), "-F", "-c", "-n", threads, input_path]; [INFO] [stderr] 1562 | | [INFO] [stderr] 1563 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1578 | | } [INFO] [stderr] 1579 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1560:49 [INFO] [stderr] | [INFO] [stderr] 1560 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1615:24 [INFO] [stderr] | [INFO] [stderr] 1615 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1616 | | let mut cmd = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, input_path]; [INFO] [stderr] 1617 | | [INFO] [stderr] 1618 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1634 | | } [INFO] [stderr] 1635 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1615:49 [INFO] [stderr] | [INFO] [stderr] 1615 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1672:24 [INFO] [stderr] | [INFO] [stderr] 1672 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1673 | | let mut cmd = vec![paths.pxz_path.as_str(), "-z", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 1674 | | [INFO] [stderr] 1675 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1691 | | } [INFO] [stderr] 1692 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1672:49 [INFO] [stderr] | [INFO] [stderr] 1672 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:1764:46 [INFO] [stderr] | [INFO] [stderr] 1764 | let output_tmp_path_obj = if let Some(_) = &split { [INFO] [stderr] | _______________________________________- ^^^^^^^ [INFO] [stderr] 1765 | | let new_filename = format!("{}.tmp.zip", output_path_obj.file_stem().unwrap().to_str().unwrap()); [INFO] [stderr] 1766 | | [INFO] [stderr] 1767 | | if output_path_obj.exists() { [INFO] [stderr] ... | [INFO] [stderr] 1775 | | output_path_obj.clone() [INFO] [stderr] 1776 | | }; [INFO] [stderr] | |_____________- help: try this: `if &split.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1920:24 [INFO] [stderr] | [INFO] [stderr] 1920 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1921 | | let mut cmd = vec![paths.pzstd_path.as_str(), "-p", threads, input_path, "-o", output_path]; [INFO] [stderr] 1922 | | [INFO] [stderr] 1923 | | if quiet { [INFO] [stderr] ... | [INFO] [stderr] 1932 | | return execute_one(&cmd, output_folder); [INFO] [stderr] 1933 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1920:49 [INFO] [stderr] | [INFO] [stderr] 1920 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/lib.rs:1957:1 [INFO] [stderr] | [INFO] [stderr] 1957 | / pub fn extract(paths: &ExePaths, quiet: bool, cpus: usize, password: &str, exlude_tar: bool, input_path: &str, output_path: &str) -> Result { [INFO] [stderr] 1958 | | let format = match ArchiveFormat::get_archive_format_from_file_path(input_path, exlude_tar) { [INFO] [stderr] 1959 | | Ok(f) => f, [INFO] [stderr] 1960 | | Err(err) => return Err(String::from(err)) [INFO] [stderr] ... | [INFO] [stderr] 2613 | | } [INFO] [stderr] 2614 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:1986:24 [INFO] [stderr] | [INFO] [stderr] 1986 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 1987 | | let cmd1 = vec![paths.pigz_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 1988 | | [INFO] [stderr] 1989 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 1998 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 1999 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1986:49 [INFO] [stderr] | [INFO] [stderr] 1986 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2015:24 [INFO] [stderr] | [INFO] [stderr] 2015 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2016 | | let cmd1 = vec![paths.lbzip2_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2017 | | [INFO] [stderr] 2018 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2041 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2042 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2015:49 [INFO] [stderr] | [INFO] [stderr] 2015 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2028:31 [INFO] [stderr] | [INFO] [stderr] 2028 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 2029 | | let cmd1 = format!("-p{}", threads); [INFO] [stderr] 2030 | | let cmd1 = vec![paths.pbzip2_path.as_str(), "-d", "-c", cmd1.as_str(), input_path]; [INFO] [stderr] 2031 | | [INFO] [stderr] ... | [INFO] [stderr] 2041 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2042 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2028:56 [INFO] [stderr] | [INFO] [stderr] 2028 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2058:24 [INFO] [stderr] | [INFO] [stderr] 2058 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2059 | | let cmd1 = vec![paths.plzip_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2060 | | [INFO] [stderr] 2061 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2070 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2071 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2058:49 [INFO] [stderr] | [INFO] [stderr] 2058 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2074:20 [INFO] [stderr] | [INFO] [stderr] 2074 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2075 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.lunzip_path.as_str(), "-x"]; [INFO] [stderr] 2076 | | [INFO] [stderr] 2077 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2084 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2085 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.lunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2074:45 [INFO] [stderr] | [INFO] [stderr] 2074 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2100:24 [INFO] [stderr] | [INFO] [stderr] 2100 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2101 | | let cmd1 = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, input_path]; [INFO] [stderr] 2102 | | [INFO] [stderr] 2103 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2112 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2113 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2100:49 [INFO] [stderr] | [INFO] [stderr] 2100 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2129:24 [INFO] [stderr] | [INFO] [stderr] 2129 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2130 | | let cmd1 = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 2131 | | [INFO] [stderr] 2132 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2141 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2142 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2129:49 [INFO] [stderr] | [INFO] [stderr] 2129 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2145:20 [INFO] [stderr] | [INFO] [stderr] 2145 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2146 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.unlzma_path.as_str(), "-x"]; [INFO] [stderr] 2147 | | [INFO] [stderr] 2148 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2155 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2156 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unlzma_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2145:45 [INFO] [stderr] | [INFO] [stderr] 2145 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unlzma_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2192:24 [INFO] [stderr] | [INFO] [stderr] 2192 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2193 | | let cmd1 = vec![paths.pzstd_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2194 | | [INFO] [stderr] 2195 | | let mut cmd2 = vec![paths.tar_path.as_str(), "-x"]; [INFO] [stderr] ... | [INFO] [stderr] 2204 | | return execute_two(&cmd1, &cmd2, output_path); [INFO] [stderr] 2205 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2192:49 [INFO] [stderr] | [INFO] [stderr] 2192 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2208:20 [INFO] [stderr] | [INFO] [stderr] 2208 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2209 | | let mut cmd = vec![paths.tar_path.as_str(), "-I", paths.unzstd_path.as_str(), "-x"]; [INFO] [stderr] 2210 | | [INFO] [stderr] 2211 | | if !quiet { [INFO] [stderr] ... | [INFO] [stderr] 2218 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2219 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2208:45 [INFO] [stderr] | [INFO] [stderr] 2208 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2246:24 [INFO] [stderr] | [INFO] [stderr] 2246 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2247 | | let cmd = vec![paths.pigz_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2248 | | [INFO] [stderr] 2249 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2258 | | } [INFO] [stderr] 2259 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pigz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2246:49 [INFO] [stderr] | [INFO] [stderr] 2246 | if let Ok(_) = check_executable(&vec![paths.pigz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pigz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2262:20 [INFO] [stderr] | [INFO] [stderr] 2262 | if let Ok(_) = check_executable(&vec![paths.gunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2263 | | let cmd = vec![paths.gzip_path.as_str(), "-c", input_path]; [INFO] [stderr] 2264 | | [INFO] [stderr] 2265 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2274 | | } [INFO] [stderr] 2275 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.gunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2262:45 [INFO] [stderr] | [INFO] [stderr] 2262 | if let Ok(_) = check_executable(&vec![paths.gunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.gunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2292:24 [INFO] [stderr] | [INFO] [stderr] 2292 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2293 | | let cmd = vec![paths.lbzip2_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2294 | | [INFO] [stderr] 2295 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2318 | | } [INFO] [stderr] 2319 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2292:49 [INFO] [stderr] | [INFO] [stderr] 2292 | if let Ok(_) = check_executable(&vec![paths.lbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2305:31 [INFO] [stderr] | [INFO] [stderr] 2305 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ________________________- ^^^^^ [INFO] [stderr] 2306 | | let cmd = format!("-p{}", threads); [INFO] [stderr] 2307 | | let cmd = vec![paths.pbzip2_path.as_str(), "-d", "-c", cmd.as_str(), input_path]; [INFO] [stderr] 2308 | | [INFO] [stderr] ... | [INFO] [stderr] 2318 | | } [INFO] [stderr] 2319 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2305:56 [INFO] [stderr] | [INFO] [stderr] 2305 | } else if let Ok(_) = check_executable(&vec![paths.pbzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pbzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2322:20 [INFO] [stderr] | [INFO] [stderr] 2322 | if let Ok(_) = check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2323 | | let cmd = vec![paths.bzip2_path.as_str(), "-c", input_path]; [INFO] [stderr] 2324 | | [INFO] [stderr] 2325 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2334 | | } [INFO] [stderr] 2335 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2322:45 [INFO] [stderr] | [INFO] [stderr] 2322 | if let Ok(_) = check_executable(&vec![paths.bunzip2_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.bunzip2_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2352:24 [INFO] [stderr] | [INFO] [stderr] 2352 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2353 | | let cmd = vec![paths.plzip_path.as_str(), "-d", "-c", "-n", threads, input_path]; [INFO] [stderr] 2354 | | [INFO] [stderr] 2355 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2364 | | } [INFO] [stderr] 2365 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.plzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2352:49 [INFO] [stderr] | [INFO] [stderr] 2352 | if let Ok(_) = check_executable(&vec![paths.plzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.plzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2368:20 [INFO] [stderr] | [INFO] [stderr] 2368 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2369 | | let cmd = vec![paths.lunzip_path.as_str(), "-c", input_path]; [INFO] [stderr] 2370 | | [INFO] [stderr] 2371 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2380 | | } [INFO] [stderr] 2381 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.lunzip_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2368:45 [INFO] [stderr] | [INFO] [stderr] 2368 | if let Ok(_) = check_executable(&vec![paths.lunzip_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.lunzip_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2398:24 [INFO] [stderr] | [INFO] [stderr] 2398 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2399 | | let cmd = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, input_path]; [INFO] [stderr] 2400 | | [INFO] [stderr] 2401 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2410 | | } [INFO] [stderr] 2411 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2398:49 [INFO] [stderr] | [INFO] [stderr] 2398 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2414:20 [INFO] [stderr] | [INFO] [stderr] 2414 | if let Ok(_) = check_executable(&vec![paths.unxz_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2415 | | let cmd = vec![paths.xz_path.as_str(), "-c", input_path]; [INFO] [stderr] 2416 | | [INFO] [stderr] 2417 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2426 | | } [INFO] [stderr] 2427 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2414:45 [INFO] [stderr] | [INFO] [stderr] 2414 | if let Ok(_) = check_executable(&vec![paths.unxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2444:24 [INFO] [stderr] | [INFO] [stderr] 2444 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2445 | | let cmd = vec![paths.pxz_path.as_str(), "-d", "-c", "-T", threads, "-F", "lzma", input_path]; [INFO] [stderr] 2446 | | [INFO] [stderr] 2447 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2456 | | } [INFO] [stderr] 2457 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pxz_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2444:49 [INFO] [stderr] | [INFO] [stderr] 2444 | if let Ok(_) = check_executable(&vec![paths.pxz_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pxz_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2460:20 [INFO] [stderr] | [INFO] [stderr] 2460 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2461 | | let cmd = vec![paths.unlzma_path.as_str(), "-c", input_path]; [INFO] [stderr] 2462 | | [INFO] [stderr] 2463 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2472 | | } [INFO] [stderr] 2473 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unlzma_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2460:45 [INFO] [stderr] | [INFO] [stderr] 2460 | if let Ok(_) = check_executable(&vec![paths.unlzma_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unlzma_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2527:20 [INFO] [stderr] | [INFO] [stderr] 2527 | if let Ok(_) = check_executable(&vec![paths.unrar_path.as_str(), "-?"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2528 | | let mut cmd = vec![paths.unrar_path.as_str(), "x", "-o+"]; [INFO] [stderr] 2529 | | [INFO] [stderr] 2530 | | cmd.push(thread_arg.as_str()); [INFO] [stderr] ... | [INFO] [stderr] 2544 | | return execute_one(&cmd, output_path); [INFO] [stderr] 2545 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unrar_path.as_str(), "-?"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2527:45 [INFO] [stderr] | [INFO] [stderr] 2527 | if let Ok(_) = check_executable(&vec![paths.unrar_path.as_str(), "-?"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unrar_path.as_str(), "-?"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2568:24 [INFO] [stderr] | [INFO] [stderr] 2568 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 2569 | | let cmd = vec![paths.pzstd_path.as_str(), "-d", "-c", "-p", threads, input_path]; [INFO] [stderr] 2570 | | [INFO] [stderr] 2571 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2580 | | } [INFO] [stderr] 2581 | | } [INFO] [stderr] | |_________________- help: try this: `if check_executable(&vec![paths.pzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2568:49 [INFO] [stderr] | [INFO] [stderr] 2568 | if let Ok(_) = check_executable(&vec![paths.pzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.pzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:2584:20 [INFO] [stderr] | [INFO] [stderr] 2584 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 2585 | | let cmd = vec![paths.unzstd_path.as_str(), "-c", input_path]; [INFO] [stderr] 2586 | | [INFO] [stderr] 2587 | | let file_path = Path::new(input_path); [INFO] [stderr] ... | [INFO] [stderr] 2596 | | } [INFO] [stderr] 2597 | | } [INFO] [stderr] | |_____________- help: try this: `if check_executable(&vec![paths.unzstd_path.as_str(), "-V"]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2584:45 [INFO] [stderr] | [INFO] [stderr] 2584 | if let Ok(_) = check_executable(&vec![paths.unzstd_path.as_str(), "-V"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[paths.unzstd_path.as_str(), "-V"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.49s [INFO] running `"docker" "inspect" "d0626aa6be1be5eaed03e919e4efaffdf1b65e9ab8998dc8f1602647d4cc0770"` [INFO] running `"docker" "rm" "-f" "d0626aa6be1be5eaed03e919e4efaffdf1b65e9ab8998dc8f1602647d4cc0770"` [INFO] [stdout] d0626aa6be1be5eaed03e919e4efaffdf1b65e9ab8998dc8f1602647d4cc0770