[INFO] crate xc2bit 0.0.3 is already in cache [INFO] extracting crate xc2bit 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/xc2bit/0.0.3 [INFO] extracting crate xc2bit 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xc2bit/0.0.3 [INFO] validating manifest of xc2bit-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xc2bit-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xc2bit-0.0.3 [INFO] finished frobbing xc2bit-0.0.3 [INFO] frobbed toml for xc2bit-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/xc2bit/0.0.3/Cargo.toml [INFO] started frobbing xc2bit-0.0.3 [INFO] finished frobbing xc2bit-0.0.3 [INFO] frobbed toml for xc2bit-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xc2bit/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xc2bit-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xc2bit/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91013077f7a976284f1f92b509eec8ae7915b4b97d6a2116923caf576d506d72 [INFO] running `"docker" "start" "-a" "91013077f7a976284f1f92b509eec8ae7915b4b97d6a2116923caf576d506d72"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Compiling xc2bit v0.0.3 (/opt/crater/workdir) [INFO] [stderr] Checking jedec v0.0.2 [INFO] [stderr] Compiling bittwiddler v0.0.1 [INFO] [stderr] Checking yosys-netlist-json v0.0.2 [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | write!(writer, "xc2bit dump\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | write!(writer, "device speed grade: {}\n", self.speed_grade)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | write!(writer, "device package: {}\n", self.package)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | write!(writer, ".JED fuse map written by xc2bit\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | write!(writer, "device type: {}\n", self.device_type())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:806:17 [INFO] [stderr] | [INFO] [stderr] 806 | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | write!(writer, "input voltage range: {}\n", if *ivoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:811:17 [INFO] [stderr] | [INFO] [stderr] 811 | write!(writer, "legacy output voltage range: {}\n", if *legacy_ovoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:812:17 [INFO] [stderr] | [INFO] [stderr] 812 | write!(writer, "legacy input voltage range: {}\n", if *legacy_ivoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:813:17 [INFO] [stderr] | [INFO] [stderr] 813 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:814:17 [INFO] [stderr] | [INFO] [stderr] 814 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:815:17 [INFO] [stderr] | [INFO] [stderr] 815 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:816:17 [INFO] [stderr] | [INFO] [stderr] 816 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:820:17 [INFO] [stderr] | [INFO] [stderr] 820 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:821:17 [INFO] [stderr] | [INFO] [stderr] 821 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:822:17 [INFO] [stderr] | [INFO] [stderr] 822 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:823:17 [INFO] [stderr] | [INFO] [stderr] 823 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:824:17 [INFO] [stderr] | [INFO] [stderr] 824 | write!(writer, "DataGate used: {}\n", if *data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:825:17 [INFO] [stderr] | [INFO] [stderr] 825 | write!(writer, "VREF used: {}\n", if *use_vref {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:829:17 [INFO] [stderr] | [INFO] [stderr] 829 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:830:17 [INFO] [stderr] | [INFO] [stderr] 830 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:831:17 [INFO] [stderr] | [INFO] [stderr] 831 | write!(writer, "bank 2 output voltage range: {}\n", if ovoltage[2] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:832:17 [INFO] [stderr] | [INFO] [stderr] 832 | write!(writer, "bank 3 output voltage range: {}\n", if ovoltage[3] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:833:17 [INFO] [stderr] | [INFO] [stderr] 833 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:834:17 [INFO] [stderr] | [INFO] [stderr] 834 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:835:17 [INFO] [stderr] | [INFO] [stderr] 835 | write!(writer, "bank 2 input voltage range: {}\n", if ivoltage[2] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:836:17 [INFO] [stderr] | [INFO] [stderr] 836 | write!(writer, "bank 3 input voltage range: {}\n", if ivoltage[3] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | write!(writer, "DataGate used: {}\n", if *data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:838:17 [INFO] [stderr] | [INFO] [stderr] 838 | write!(writer, "VREF used: {}\n", if *use_vref {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | write!(writer, "// crbit native bitstream file written by xc2bit\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | write!(writer, "ZIA inputs for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | XC2ZIAInput::Zero => write!(writer, "0\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:154:37 [INFO] [stderr] | [INFO] [stderr] 154 | XC2ZIAInput::One => write!(writer, "1\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | write!(writer, "FB{}_{} FF\n", fb + 1, mc + 1)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | write!(writer, "FB{}_{} pad\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:161:48 [INFO] [stderr] | [INFO] [stderr] 161 | XC2ZIAInput::DedicatedInput => write!(writer, "dedicated input\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(writer, "AND terms for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / write!(writer, " | 0| ~0| 1| ~1| 2| ~2| 3| ~3| 4| ~4| 5| ~5| 6| ~6| 7| ~7| 8| ~8| 9| ~9| 10|~10| \ [INFO] [stderr] 168 | | 11|~11| 12|~12| 13|~13| 14|~14| 15|~15| 16|~16| 17|~17| 18|~18| 19|~19| 20|~20| \ [INFO] [stderr] 169 | | 21|~21| 22|~22| 23|~23| 24|~24| 25|~25| 26|~26| 27|~27| 28|~28| 29|~29| 30|~30| \ [INFO] [stderr] 170 | | 31|~31| 32|~32| 33|~33| 34|~34| 35|~35| 36|~36| 37|~37| 38|~38| 39|~39\ [INFO] [stderr] 171 | | \n")?; [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | write!(writer, "OR terms for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / write!(writer, " | 0| 1| 2| 3| 4| 5| 6| 7| 8| 9|10|11|12|13|14|15|16|17|18|19|20|\ [INFO] [stderr] 193 | | 21|22|23|24|25|26|27|28|29|30|31|32|33|34|35|36|37|38|39|40|\ [INFO] [stderr] 194 | | 41|42|43|44|45|46|47|48|49|50|51|52|53|54|55\n")?; [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | write!(writer, "GCK0 {}\n", if self.gck_enable[0] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | write!(writer, "GCK1 {}\n", if self.gck_enable[1] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | write!(writer, "GCK2 {}\n", if self.gck_enable[2] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / write!(writer, "GSR {}, active {}\n", [INFO] [stderr] 83 | | if self.gsr_enable {"enabled"} else {"disabled"}, [INFO] [stderr] 84 | | if self.gsr_invert {"high"} else {"low"})?; [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / write!(writer, "GTS0 {}, acts as {}\n", [INFO] [stderr] 87 | | if self.gts_enable[0] {"enabled"} else {"disabled"}, [INFO] [stderr] 88 | | if self.gts_invert[0] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / write!(writer, "GTS1 {}, acts as {}\n", [INFO] [stderr] 90 | | if self.gts_enable[1] {"enabled"} else {"disabled"}, [INFO] [stderr] 91 | | if self.gts_invert[1] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / write!(writer, "GTS2 {}, acts as {}\n", [INFO] [stderr] 93 | | if self.gts_enable[2] {"enabled"} else {"disabled"}, [INFO] [stderr] 94 | | if self.gts_invert[2] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / write!(writer, "GTS3 {}, acts as {}\n", [INFO] [stderr] 96 | | if self.gts_enable[3] {"enabled"} else {"disabled"}, [INFO] [stderr] 97 | | if self.gts_invert[3] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | write!(writer, "global termination is {}\n", if self.global_pu {"pull-up"} else {"bus hold"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | write!(writer, "GCK2 clock divider {}\n", if self.enabled {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | write!(writer, "clock divider delay {}\n", if self.delay {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / write!(writer, "clock division ratio: {}\n", match self.div_ratio { [INFO] [stderr] 236 | | XC2ClockDivRatio::Div2 => "2", [INFO] [stderr] 237 | | XC2ClockDivRatio::Div4 => "4", [INFO] [stderr] 238 | | XC2ClockDivRatio::Div6 => "6", [INFO] [stderr] ... | [INFO] [stderr] 243 | | XC2ClockDivRatio::Div16 => "16", [INFO] [stderr] 244 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | write!(writer, "I/O configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / write!(writer, "output mode: {}\n", match self.obuf_mode { [INFO] [stderr] 148 | | XC2IOBOBufMode::Disabled => "disabled", [INFO] [stderr] 149 | | XC2IOBOBufMode::PushPull => "push-pull", [INFO] [stderr] 150 | | XC2IOBOBufMode::OpenDrain => "open-drain", [INFO] [stderr] ... | [INFO] [stderr] 157 | | XC2IOBOBufMode::CGND => "CGND", [INFO] [stderr] 158 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | write!(writer, "output comes from {}\n", if self.obuf_uses_ff {"FF"} else {"XOR gate"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | write!(writer, "slew rate: {}\n", if self.slew_is_fast {"fast"} else {"slow"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / write!(writer, "ZIA driven from: {}\n", match self.zia_mode { [INFO] [stderr] 162 | | XC2IOBZIAMode::Disabled => "disabled", [INFO] [stderr] 163 | | XC2IOBZIAMode::PAD => "input pad", [INFO] [stderr] 164 | | XC2IOBZIAMode::REG => "register", [INFO] [stderr] 165 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(writer, "Schmitt trigger input: {}\n", if self.schmitt_trigger {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | write!(writer, "I/O configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:323:9 [INFO] [stderr] | [INFO] [stderr] 323 | / write!(writer, "output mode: {}\n", match self.obuf_mode { [INFO] [stderr] 324 | | XC2IOBOBufMode::Disabled => "disabled", [INFO] [stderr] 325 | | XC2IOBOBufMode::PushPull => "push-pull", [INFO] [stderr] 326 | | XC2IOBOBufMode::OpenDrain => "open-drain", [INFO] [stderr] ... | [INFO] [stderr] 333 | | XC2IOBOBufMode::CGND => "CGND", [INFO] [stderr] 334 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | / write!(writer, "input mode: {}\n", match self.ibuf_mode { [INFO] [stderr] 336 | | XC2IOBIbufMode::NoVrefNoSt => "no VREF, no Schmitt trigger", [INFO] [stderr] 337 | | XC2IOBIbufMode::NoVrefSt => "no VREF, Schmitt trigger", [INFO] [stderr] 338 | | XC2IOBIbufMode::UsesVref => "uses VREF (HSTL/SSTL)", [INFO] [stderr] 339 | | XC2IOBIbufMode::IsVref => "is a VREF pin", [INFO] [stderr] 340 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | write!(writer, "output comes from {}\n", if self.obuf_uses_ff {"FF"} else {"XOR gate"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | write!(writer, "slew rate: {}\n", if self.slew_is_fast {"fast"} else {"slow"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / write!(writer, "ZIA driven from: {}\n", match self.zia_mode { [INFO] [stderr] 344 | | XC2IOBZIAMode::Disabled => "disabled", [INFO] [stderr] 345 | | XC2IOBZIAMode::PAD => "input pad", [INFO] [stderr] 346 | | XC2IOBZIAMode::REG => "register", [INFO] [stderr] 347 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | write!(writer, "DataGate used: {}\n", if self.uses_data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | write!(writer, "I/O configuration for input-only pin\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | write!(writer, "Schmitt trigger input: {}\n", if self.schmitt_trigger {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:443:9 [INFO] [stderr] | [INFO] [stderr] 443 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | write!(writer, "FF configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | write!(writer, "xc2bit dump\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | write!(writer, "device speed grade: {}\n", self.speed_grade)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | write!(writer, "device package: {}\n", self.package)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | write!(writer, ".JED fuse map written by xc2bit\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / write!(writer, "FF mode: {}\n", match self.reg_mode { [INFO] [stderr] 275 | | XC2MCRegMode::DFF => "D flip-flop", [INFO] [stderr] 276 | | XC2MCRegMode::LATCH => "transparent latch", [INFO] [stderr] 277 | | XC2MCRegMode::TFF => "T flip-flop", [INFO] [stderr] 278 | | XC2MCRegMode::DFFCE => "D flip-flop with clock-enable", [INFO] [stderr] 279 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | write!(writer, "initial state: {}\n", if self.init_state {1} else {0})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | write!(writer, "{}-edge triggered\n", if self.clk_invert_pol {"falling"} else {"rising"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | write!(writer, "DDR: {}\n", if self.is_ddr {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / write!(writer, "clock source: {}\n", match self.clk_src { [INFO] [stderr] 284 | | XC2MCRegClkSrc::GCK0 => "GCK0", [INFO] [stderr] 285 | | XC2MCRegClkSrc::GCK1 => "GCK1", [INFO] [stderr] 286 | | XC2MCRegClkSrc::GCK2 => "GCK2", [INFO] [stderr] 287 | | XC2MCRegClkSrc::PTC => "PTC", [INFO] [stderr] 288 | | XC2MCRegClkSrc::CTC => "CTC", [INFO] [stderr] 289 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | / write!(writer, "set source: {}\n", match self.s_src { [INFO] [stderr] 291 | | XC2MCRegSetSrc::Disabled => "disabled", [INFO] [stderr] 292 | | XC2MCRegSetSrc::PTA => "PTA", [INFO] [stderr] 293 | | XC2MCRegSetSrc::GSR => "GSR", [INFO] [stderr] 294 | | XC2MCRegSetSrc::CTS => "CTS", [INFO] [stderr] 295 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | / write!(writer, "reset source: {}\n", match self.r_src { [INFO] [stderr] 297 | | XC2MCRegResetSrc::Disabled => "disabled", [INFO] [stderr] 298 | | XC2MCRegResetSrc::PTA => "PTA", [INFO] [stderr] 299 | | XC2MCRegResetSrc::GSR => "GSR", [INFO] [stderr] 300 | | XC2MCRegResetSrc::CTR => "CTR", [INFO] [stderr] 301 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | write!(writer, "device type: {}\n", self.device_type())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | write!(writer, "using ibuf direct path: {}\n", if self.ff_in_ibuf {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:806:17 [INFO] [stderr] | [INFO] [stderr] 806 | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | / write!(writer, "XOR gate input: {}\n", match self.xor_mode { [INFO] [stderr] 304 | | XC2MCXorMode::ZERO => "0", [INFO] [stderr] 305 | | XC2MCXorMode::ONE => "1", [INFO] [stderr] 306 | | XC2MCXorMode::PTC => "PTC", [INFO] [stderr] 307 | | XC2MCXorMode::PTCB => "~PTC", [INFO] [stderr] 308 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / write!(writer, "ZIA feedback: {}\n", match self.fb_mode { [INFO] [stderr] 310 | | XC2MCFeedbackMode::Disabled => "disabled", [INFO] [stderr] 311 | | XC2MCFeedbackMode::COMB => "combinatorial", [INFO] [stderr] 312 | | XC2MCFeedbackMode::REG => "registered", [INFO] [stderr] 313 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | write!(writer, "input voltage range: {}\n", if *ivoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:811:17 [INFO] [stderr] | [INFO] [stderr] 811 | write!(writer, "legacy output voltage range: {}\n", if *legacy_ovoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:812:17 [INFO] [stderr] | [INFO] [stderr] 812 | write!(writer, "legacy input voltage range: {}\n", if *legacy_ivoltage {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:813:17 [INFO] [stderr] | [INFO] [stderr] 813 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:814:17 [INFO] [stderr] | [INFO] [stderr] 814 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:815:17 [INFO] [stderr] | [INFO] [stderr] 815 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:816:17 [INFO] [stderr] | [INFO] [stderr] 816 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:820:17 [INFO] [stderr] | [INFO] [stderr] 820 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:821:17 [INFO] [stderr] | [INFO] [stderr] 821 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:822:17 [INFO] [stderr] | [INFO] [stderr] 822 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:823:17 [INFO] [stderr] | [INFO] [stderr] 823 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:824:17 [INFO] [stderr] | [INFO] [stderr] 824 | write!(writer, "DataGate used: {}\n", if *data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:825:17 [INFO] [stderr] | [INFO] [stderr] 825 | write!(writer, "VREF used: {}\n", if *use_vref {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:829:17 [INFO] [stderr] | [INFO] [stderr] 829 | write!(writer, "bank 0 output voltage range: {}\n", if ovoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:830:17 [INFO] [stderr] | [INFO] [stderr] 830 | write!(writer, "bank 1 output voltage range: {}\n", if ovoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:831:17 [INFO] [stderr] | [INFO] [stderr] 831 | write!(writer, "bank 2 output voltage range: {}\n", if ovoltage[2] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:832:17 [INFO] [stderr] | [INFO] [stderr] 832 | write!(writer, "bank 3 output voltage range: {}\n", if ovoltage[3] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:833:17 [INFO] [stderr] | [INFO] [stderr] 833 | write!(writer, "bank 0 input voltage range: {}\n", if ivoltage[0] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:834:17 [INFO] [stderr] | [INFO] [stderr] 834 | write!(writer, "bank 1 input voltage range: {}\n", if ivoltage[1] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:835:17 [INFO] [stderr] | [INFO] [stderr] 835 | write!(writer, "bank 2 input voltage range: {}\n", if ivoltage[2] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:836:17 [INFO] [stderr] | [INFO] [stderr] 836 | write!(writer, "bank 3 input voltage range: {}\n", if ivoltage[3] {"high"} else {"low"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | write!(writer, "DataGate used: {}\n", if *data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bitstream.rs:838:17 [INFO] [stderr] | [INFO] [stderr] 838 | write!(writer, "VREF used: {}\n", if *use_vref {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | write!(writer, "// crbit native bitstream file written by xc2bit\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/crbit.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | write!(writer, "ZIA inputs for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | XC2ZIAInput::Zero => write!(writer, "0\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:154:37 [INFO] [stderr] | [INFO] [stderr] 154 | XC2ZIAInput::One => write!(writer, "1\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | write!(writer, "FB{}_{} FF\n", fb + 1, mc + 1)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | write!(writer, "FB{}_{} pad\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:161:48 [INFO] [stderr] | [INFO] [stderr] 161 | XC2ZIAInput::DedicatedInput => write!(writer, "dedicated input\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(writer, "AND terms for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / write!(writer, " | 0| ~0| 1| ~1| 2| ~2| 3| ~3| 4| ~4| 5| ~5| 6| ~6| 7| ~7| 8| ~8| 9| ~9| 10|~10| \ [INFO] [stderr] 168 | | 11|~11| 12|~12| 13|~13| 14|~14| 15|~15| 16|~16| 17|~17| 18|~18| 19|~19| 20|~20| \ [INFO] [stderr] 169 | | 21|~21| 22|~22| 23|~23| 24|~24| 25|~25| 26|~26| 27|~27| 28|~28| 29|~29| 30|~30| \ [INFO] [stderr] 170 | | 31|~31| 32|~32| 33|~33| 34|~34| 35|~35| 36|~36| 37|~37| 38|~38| 39|~39\ [INFO] [stderr] 171 | | \n")?; [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | write!(writer, "OR terms for FB{}\n", fb + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / write!(writer, " | 0| 1| 2| 3| 4| 5| 6| 7| 8| 9|10|11|12|13|14|15|16|17|18|19|20|\ [INFO] [stderr] 193 | | 21|22|23|24|25|26|27|28|29|30|31|32|33|34|35|36|37|38|39|40|\ [INFO] [stderr] 194 | | 41|42|43|44|45|46|47|48|49|50|51|52|53|54|55\n")?; [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fb.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | write!(writer, "GCK0 {}\n", if self.gck_enable[0] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | write!(writer, "GCK1 {}\n", if self.gck_enable[1] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | write!(writer, "GCK2 {}\n", if self.gck_enable[2] {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / write!(writer, "GSR {}, active {}\n", [INFO] [stderr] 83 | | if self.gsr_enable {"enabled"} else {"disabled"}, [INFO] [stderr] 84 | | if self.gsr_invert {"high"} else {"low"})?; [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / write!(writer, "GTS0 {}, acts as {}\n", [INFO] [stderr] 87 | | if self.gts_enable[0] {"enabled"} else {"disabled"}, [INFO] [stderr] 88 | | if self.gts_invert[0] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / write!(writer, "GTS1 {}, acts as {}\n", [INFO] [stderr] 90 | | if self.gts_enable[1] {"enabled"} else {"disabled"}, [INFO] [stderr] 91 | | if self.gts_invert[1] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / write!(writer, "GTS2 {}, acts as {}\n", [INFO] [stderr] 93 | | if self.gts_enable[2] {"enabled"} else {"disabled"}, [INFO] [stderr] 94 | | if self.gts_invert[2] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / write!(writer, "GTS3 {}, acts as {}\n", [INFO] [stderr] 96 | | if self.gts_enable[3] {"enabled"} else {"disabled"}, [INFO] [stderr] 97 | | if self.gts_invert[3] {"!T"} else {"T"})?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | write!(writer, "global termination is {}\n", if self.global_pu {"pull-up"} else {"bus hold"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | write!(writer, "GCK2 clock divider {}\n", if self.enabled {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | write!(writer, "clock divider delay {}\n", if self.delay {"enabled"} else {"disabled"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/globalbits.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / write!(writer, "clock division ratio: {}\n", match self.div_ratio { [INFO] [stderr] 236 | | XC2ClockDivRatio::Div2 => "2", [INFO] [stderr] 237 | | XC2ClockDivRatio::Div4 => "4", [INFO] [stderr] 238 | | XC2ClockDivRatio::Div6 => "6", [INFO] [stderr] ... | [INFO] [stderr] 243 | | XC2ClockDivRatio::Div16 => "16", [INFO] [stderr] 244 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | write!(writer, "I/O configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / write!(writer, "output mode: {}\n", match self.obuf_mode { [INFO] [stderr] 148 | | XC2IOBOBufMode::Disabled => "disabled", [INFO] [stderr] 149 | | XC2IOBOBufMode::PushPull => "push-pull", [INFO] [stderr] 150 | | XC2IOBOBufMode::OpenDrain => "open-drain", [INFO] [stderr] ... | [INFO] [stderr] 157 | | XC2IOBOBufMode::CGND => "CGND", [INFO] [stderr] 158 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | write!(writer, "output comes from {}\n", if self.obuf_uses_ff {"FF"} else {"XOR gate"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | write!(writer, "slew rate: {}\n", if self.slew_is_fast {"fast"} else {"slow"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / write!(writer, "ZIA driven from: {}\n", match self.zia_mode { [INFO] [stderr] 162 | | XC2IOBZIAMode::Disabled => "disabled", [INFO] [stderr] 163 | | XC2IOBZIAMode::PAD => "input pad", [INFO] [stderr] 164 | | XC2IOBZIAMode::REG => "register", [INFO] [stderr] 165 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(writer, "Schmitt trigger input: {}\n", if self.schmitt_trigger {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | write!(writer, "I/O configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:323:9 [INFO] [stderr] | [INFO] [stderr] 323 | / write!(writer, "output mode: {}\n", match self.obuf_mode { [INFO] [stderr] 324 | | XC2IOBOBufMode::Disabled => "disabled", [INFO] [stderr] 325 | | XC2IOBOBufMode::PushPull => "push-pull", [INFO] [stderr] 326 | | XC2IOBOBufMode::OpenDrain => "open-drain", [INFO] [stderr] ... | [INFO] [stderr] 333 | | XC2IOBOBufMode::CGND => "CGND", [INFO] [stderr] 334 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | / write!(writer, "input mode: {}\n", match self.ibuf_mode { [INFO] [stderr] 336 | | XC2IOBIbufMode::NoVrefNoSt => "no VREF, no Schmitt trigger", [INFO] [stderr] 337 | | XC2IOBIbufMode::NoVrefSt => "no VREF, Schmitt trigger", [INFO] [stderr] 338 | | XC2IOBIbufMode::UsesVref => "uses VREF (HSTL/SSTL)", [INFO] [stderr] 339 | | XC2IOBIbufMode::IsVref => "is a VREF pin", [INFO] [stderr] 340 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | write!(writer, "output comes from {}\n", if self.obuf_uses_ff {"FF"} else {"XOR gate"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | write!(writer, "slew rate: {}\n", if self.slew_is_fast {"fast"} else {"slow"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / write!(writer, "ZIA driven from: {}\n", match self.zia_mode { [INFO] [stderr] 344 | | XC2IOBZIAMode::Disabled => "disabled", [INFO] [stderr] 345 | | XC2IOBZIAMode::PAD => "input pad", [INFO] [stderr] 346 | | XC2IOBZIAMode::REG => "register", [INFO] [stderr] 347 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | write!(writer, "DataGate used: {}\n", if self.uses_data_gate {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | write!(writer, "I/O configuration for input-only pin\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | write!(writer, "Schmitt trigger input: {}\n", if self.schmitt_trigger {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/iob.rs:443:9 [INFO] [stderr] | [INFO] [stderr] 443 | write!(writer, "termination: {}\n", if self.termination_enabled {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | write!(writer, "FF configuration for FB{}_{}\n", fb + 1, mc + 1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / write!(writer, "FF mode: {}\n", match self.reg_mode { [INFO] [stderr] 275 | | XC2MCRegMode::DFF => "D flip-flop", [INFO] [stderr] 276 | | XC2MCRegMode::LATCH => "transparent latch", [INFO] [stderr] 277 | | XC2MCRegMode::TFF => "T flip-flop", [INFO] [stderr] 278 | | XC2MCRegMode::DFFCE => "D flip-flop with clock-enable", [INFO] [stderr] 279 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | write!(writer, "initial state: {}\n", if self.init_state {1} else {0})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | write!(writer, "{}-edge triggered\n", if self.clk_invert_pol {"falling"} else {"rising"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | write!(writer, "DDR: {}\n", if self.is_ddr {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / write!(writer, "clock source: {}\n", match self.clk_src { [INFO] [stderr] 284 | | XC2MCRegClkSrc::GCK0 => "GCK0", [INFO] [stderr] 285 | | XC2MCRegClkSrc::GCK1 => "GCK1", [INFO] [stderr] 286 | | XC2MCRegClkSrc::GCK2 => "GCK2", [INFO] [stderr] 287 | | XC2MCRegClkSrc::PTC => "PTC", [INFO] [stderr] 288 | | XC2MCRegClkSrc::CTC => "CTC", [INFO] [stderr] 289 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | / write!(writer, "set source: {}\n", match self.s_src { [INFO] [stderr] 291 | | XC2MCRegSetSrc::Disabled => "disabled", [INFO] [stderr] 292 | | XC2MCRegSetSrc::PTA => "PTA", [INFO] [stderr] 293 | | XC2MCRegSetSrc::GSR => "GSR", [INFO] [stderr] 294 | | XC2MCRegSetSrc::CTS => "CTS", [INFO] [stderr] 295 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | / write!(writer, "reset source: {}\n", match self.r_src { [INFO] [stderr] 297 | | XC2MCRegResetSrc::Disabled => "disabled", [INFO] [stderr] 298 | | XC2MCRegResetSrc::PTA => "PTA", [INFO] [stderr] 299 | | XC2MCRegResetSrc::GSR => "GSR", [INFO] [stderr] 300 | | XC2MCRegResetSrc::CTR => "CTR", [INFO] [stderr] 301 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | write!(writer, "using ibuf direct path: {}\n", if self.ff_in_ibuf {"yes"} else {"no"})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | / write!(writer, "XOR gate input: {}\n", match self.xor_mode { [INFO] [stderr] 304 | | XC2MCXorMode::ZERO => "0", [INFO] [stderr] 305 | | XC2MCXorMode::ONE => "1", [INFO] [stderr] 306 | | XC2MCXorMode::PTC => "PTC", [INFO] [stderr] 307 | | XC2MCXorMode::PTCB => "~PTC", [INFO] [stderr] 308 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mc.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / write!(writer, "ZIA feedback: {}\n", match self.fb_mode { [INFO] [stderr] 310 | | XC2MCFeedbackMode::Disabled => "disabled", [INFO] [stderr] 311 | | XC2MCFeedbackMode::COMB => "combinatorial", [INFO] [stderr] 312 | | XC2MCFeedbackMode::REG => "registered", [INFO] [stderr] 313 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:995:32 [INFO] [stderr] | [INFO] [stderr] 995 | linebreaks.add(123243); [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:996:23 [INFO] [stderr] | [INFO] [stderr] 996 | jed.f[123243] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:998:32 [INFO] [stderr] | [INFO] [stderr] 998 | linebreaks.add(123244); [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:999:23 [INFO] [stderr] | [INFO] [stderr] 999 | jed.f[123244] = !ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1000:23 [INFO] [stderr] | [INFO] [stderr] 1000 | jed.f[123245] = !ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `123_245` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1001:32 [INFO] [stderr] | [INFO] [stderr] 1001 | linebreaks.add(123246); [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1002:23 [INFO] [stderr] | [INFO] [stderr] 1002 | jed.f[123246] = !ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1003:23 [INFO] [stderr] | [INFO] [stderr] 1003 | jed.f[123247] = !ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `123_247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1005:32 [INFO] [stderr] | [INFO] [stderr] 1005 | linebreaks.add(123248); [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1006:23 [INFO] [stderr] | [INFO] [stderr] 1006 | jed.f[123248] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1009:32 [INFO] [stderr] | [INFO] [stderr] 1009 | linebreaks.add(209347); [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1010:23 [INFO] [stderr] | [INFO] [stderr] 1010 | jed.f[209347] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1012:32 [INFO] [stderr] | [INFO] [stderr] 1012 | linebreaks.add(209348); [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1013:23 [INFO] [stderr] | [INFO] [stderr] 1013 | jed.f[209348] = !ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1014:23 [INFO] [stderr] | [INFO] [stderr] 1014 | jed.f[209349] = !ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `209_349` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1015:23 [INFO] [stderr] | [INFO] [stderr] 1015 | jed.f[209350] = !ivoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `209_350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1016:23 [INFO] [stderr] | [INFO] [stderr] 1016 | jed.f[209351] = !ivoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `209_351` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1018:32 [INFO] [stderr] | [INFO] [stderr] 1018 | linebreaks.add(209352); [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1019:23 [INFO] [stderr] | [INFO] [stderr] 1019 | jed.f[209352] = !ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1020:23 [INFO] [stderr] | [INFO] [stderr] 1020 | jed.f[209353] = !ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `209_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1021:23 [INFO] [stderr] | [INFO] [stderr] 1021 | jed.f[209354] = !ovoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `209_354` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1022:23 [INFO] [stderr] | [INFO] [stderr] 1022 | jed.f[209355] = !ovoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `209_355` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1024:32 [INFO] [stderr] | [INFO] [stderr] 1024 | linebreaks.add(209356); [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1025:23 [INFO] [stderr] | [INFO] [stderr] 1025 | jed.f[209356] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1028:32 [INFO] [stderr] | [INFO] [stderr] 1028 | linebreaks.add(296393); [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1029:23 [INFO] [stderr] | [INFO] [stderr] 1029 | jed.f[296393] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1031:32 [INFO] [stderr] | [INFO] [stderr] 1031 | linebreaks.add(296394); [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1032:23 [INFO] [stderr] | [INFO] [stderr] 1032 | jed.f[296394] = ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1033:23 [INFO] [stderr] | [INFO] [stderr] 1033 | jed.f[296395] = ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `296_395` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1034:23 [INFO] [stderr] | [INFO] [stderr] 1034 | jed.f[296396] = ivoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `296_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1035:23 [INFO] [stderr] | [INFO] [stderr] 1035 | jed.f[296397] = ivoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `296_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1037:32 [INFO] [stderr] | [INFO] [stderr] 1037 | linebreaks.add(296398); [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1038:23 [INFO] [stderr] | [INFO] [stderr] 1038 | jed.f[296398] = ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1039:23 [INFO] [stderr] | [INFO] [stderr] 1039 | jed.f[296399] = ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `296_399` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1040:23 [INFO] [stderr] | [INFO] [stderr] 1040 | jed.f[296400] = ovoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `296_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1041:23 [INFO] [stderr] | [INFO] [stderr] 1041 | jed.f[296401] = ovoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `296_401` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1043:32 [INFO] [stderr] | [INFO] [stderr] 1043 | linebreaks.add(296402); [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1044:23 [INFO] [stderr] | [INFO] [stderr] 1044 | jed.f[296402] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1285:27 [INFO] [stderr] | [INFO] [stderr] 1285 | data_gate: !fuses[123243], [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1286:26 [INFO] [stderr] | [INFO] [stderr] 1286 | use_vref: !fuses[123248], [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1288:20 [INFO] [stderr] | [INFO] [stderr] 1288 | !fuses[123244], [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1289:20 [INFO] [stderr] | [INFO] [stderr] 1289 | !fuses[123245], [INFO] [stderr] | ^^^^^^ help: consider: `123_245` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1292:20 [INFO] [stderr] | [INFO] [stderr] 1292 | !fuses[123246], [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1293:20 [INFO] [stderr] | [INFO] [stderr] 1293 | !fuses[123247], [INFO] [stderr] | ^^^^^^ help: consider: `123_247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1317:27 [INFO] [stderr] | [INFO] [stderr] 1317 | data_gate: !fuses[209347], [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1318:26 [INFO] [stderr] | [INFO] [stderr] 1318 | use_vref: !fuses[209356], [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1320:20 [INFO] [stderr] | [INFO] [stderr] 1320 | !fuses[209348], [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1321:20 [INFO] [stderr] | [INFO] [stderr] 1321 | !fuses[209349], [INFO] [stderr] | ^^^^^^ help: consider: `209_349` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1322:20 [INFO] [stderr] | [INFO] [stderr] 1322 | !fuses[209350], [INFO] [stderr] | ^^^^^^ help: consider: `209_350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1323:20 [INFO] [stderr] | [INFO] [stderr] 1323 | !fuses[209351], [INFO] [stderr] | ^^^^^^ help: consider: `209_351` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1326:20 [INFO] [stderr] | [INFO] [stderr] 1326 | !fuses[209352], [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1327:20 [INFO] [stderr] | [INFO] [stderr] 1327 | !fuses[209353], [INFO] [stderr] | ^^^^^^ help: consider: `209_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1328:20 [INFO] [stderr] | [INFO] [stderr] 1328 | !fuses[209354], [INFO] [stderr] | ^^^^^^ help: consider: `209_354` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1329:20 [INFO] [stderr] | [INFO] [stderr] 1329 | !fuses[209355], [INFO] [stderr] | ^^^^^^ help: consider: `209_355` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1353:27 [INFO] [stderr] | [INFO] [stderr] 1353 | data_gate: !fuses[296393], [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1354:26 [INFO] [stderr] | [INFO] [stderr] 1354 | use_vref: !fuses[296402], [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1356:19 [INFO] [stderr] | [INFO] [stderr] 1356 | fuses[296394], [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1357:19 [INFO] [stderr] | [INFO] [stderr] 1357 | fuses[296395], [INFO] [stderr] | ^^^^^^ help: consider: `296_395` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1358:19 [INFO] [stderr] | [INFO] [stderr] 1358 | fuses[296396], [INFO] [stderr] | ^^^^^^ help: consider: `296_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1359:19 [INFO] [stderr] | [INFO] [stderr] 1359 | fuses[296397], [INFO] [stderr] | ^^^^^^ help: consider: `296_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1362:19 [INFO] [stderr] | [INFO] [stderr] 1362 | fuses[296398], [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1363:19 [INFO] [stderr] | [INFO] [stderr] 1363 | fuses[296399], [INFO] [stderr] | ^^^^^^ help: consider: `296_399` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1364:19 [INFO] [stderr] | [INFO] [stderr] 1364 | fuses[296400], [INFO] [stderr] | ^^^^^^ help: consider: `296_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1365:19 [INFO] [stderr] | [INFO] [stderr] 1365 | fuses[296401], [INFO] [stderr] | ^^^^^^ help: consider: `296_401` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fb.rs:351:32 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 352 | | if and_term_idx % 2 == 1 { [INFO] [stderr] 353 | | out_x += 1; [INFO] [stderr] 354 | | } [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if and_term_idx % 2 == 1 { [INFO] [stderr] 352 | out_x += 1; [INFO] [stderr] 353 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fb.rs:500:32 [INFO] [stderr] | [INFO] [stderr] 500 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 501 | | if and_term_idx % 2 == 1 { [INFO] [stderr] 502 | | out_x += 1; [INFO] [stderr] 503 | | } [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 500 | } else if and_term_idx % 2 == 1 { [INFO] [stderr] 501 | out_x += 1; [INFO] [stderr] 502 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | 13 => 100113, [INFO] [stderr] | ^^^^^^ help: consider: `100_113` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | 14 => 107808, [INFO] [stderr] | ^^^^^^ help: consider: `107_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | 15 => 115516, [INFO] [stderr] | ^^^^^^ help: consider: `115_516` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | 12 => 104664, [INFO] [stderr] | ^^^^^^ help: consider: `104_664` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | 13 => 113386, [INFO] [stderr] | ^^^^^^ help: consider: `113_386` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | 14 => 122108, [INFO] [stderr] | ^^^^^^ help: consider: `122_108` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | 15 => 130830, [INFO] [stderr] | ^^^^^^ help: consider: `130_830` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:100:23 [INFO] [stderr] | [INFO] [stderr] 100 | 16 => 139552, [INFO] [stderr] | ^^^^^^ help: consider: `139_552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | 17 => 148274, [INFO] [stderr] | ^^^^^^ help: consider: `148_274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | 18 => 156996, [INFO] [stderr] | ^^^^^^ help: consider: `156_996` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | 19 => 165718, [INFO] [stderr] | ^^^^^^ help: consider: `165_718` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | 20 => 174440, [INFO] [stderr] | ^^^^^^ help: consider: `174_440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | 21 => 183162, [INFO] [stderr] | ^^^^^^ help: consider: `183_162` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | 22 => 191884, [INFO] [stderr] | ^^^^^^ help: consider: `191_884` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | 23 => 200606, [INFO] [stderr] | ^^^^^^ help: consider: `200_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | 11 => 101855, [INFO] [stderr] | ^^^^^^ help: consider: `101_855` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | 12 => 111124, [INFO] [stderr] | ^^^^^^ help: consider: `111_124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | 13 => 120380, [INFO] [stderr] | ^^^^^^ help: consider: `120_380` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | 14 => 129649, [INFO] [stderr] | ^^^^^^ help: consider: `129_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | 15 => 138905, [INFO] [stderr] | ^^^^^^ help: consider: `138_905` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | 16 => 148174, [INFO] [stderr] | ^^^^^^ help: consider: `148_174` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | 17 => 157443, [INFO] [stderr] | ^^^^^^ help: consider: `157_443` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | 18 => 166699, [INFO] [stderr] | ^^^^^^ help: consider: `166_699` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | 19 => 175968, [INFO] [stderr] | ^^^^^^ help: consider: `175_968` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | 20 => 185224, [INFO] [stderr] | ^^^^^^ help: consider: `185_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | 21 => 194493, [INFO] [stderr] | ^^^^^^ help: consider: `194_493` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | 22 => 203749, [INFO] [stderr] | ^^^^^^ help: consider: `203_749` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | 23 => 213018, [INFO] [stderr] | ^^^^^^ help: consider: `213_018` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | 24 => 222274, [INFO] [stderr] | ^^^^^^ help: consider: `222_274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | 25 => 231530, [INFO] [stderr] | ^^^^^^ help: consider: `231_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:139:23 [INFO] [stderr] | [INFO] [stderr] 139 | 26 => 240799, [INFO] [stderr] | ^^^^^^ help: consider: `240_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | 27 => 250055, [INFO] [stderr] | ^^^^^^ help: consider: `250_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | 28 => 259324, [INFO] [stderr] | ^^^^^^ help: consider: `259_324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | 29 => 268580, [INFO] [stderr] | ^^^^^^ help: consider: `268_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | 30 => 277849, [INFO] [stderr] | ^^^^^^ help: consider: `277_849` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | 31 => 287105, [INFO] [stderr] | ^^^^^^ help: consider: `287_105` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | XC2Device::XC2C256 => 123224, [INFO] [stderr] | ^^^^^^ help: consider: `123_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | XC2Device::XC2C384 => 209328, [INFO] [stderr] | ^^^^^^ help: consider: `209_328` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:158:31 [INFO] [stderr] | [INFO] [stderr] 158 | XC2Device::XC2C512 => 296374, [INFO] [stderr] | ^^^^^^ help: consider: `296_374` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | XC2Device::XC2C256 => 123232, [INFO] [stderr] | ^^^^^^ help: consider: `123_232` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:168:31 [INFO] [stderr] | [INFO] [stderr] 168 | XC2Device::XC2C384 => 209336, [INFO] [stderr] | ^^^^^^ help: consider: `209_336` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | XC2Device::XC2C512 => 296382, [INFO] [stderr] | ^^^^^^ help: consider: `296_382` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | XC2Device::XC2C256 => 123234, [INFO] [stderr] | ^^^^^^ help: consider: `123_234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:179:31 [INFO] [stderr] | [INFO] [stderr] 179 | XC2Device::XC2C384 => 209338, [INFO] [stderr] | ^^^^^^ help: consider: `209_338` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | XC2Device::XC2C512 => 296384, [INFO] [stderr] | ^^^^^^ help: consider: `296_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | XC2Device::XC2C256 => 123242, [INFO] [stderr] | ^^^^^^ help: consider: `123_242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:190:31 [INFO] [stderr] | [INFO] [stderr] 190 | XC2Device::XC2C384 => 209346, [INFO] [stderr] | ^^^^^^ help: consider: `209_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | XC2Device::XC2C512 => 296392, [INFO] [stderr] | ^^^^^^ help: consider: `296_392` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | XC2Device::XC2C256 => 123249, [INFO] [stderr] | ^^^^^^ help: consider: `123_249` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | XC2Device::XC2C384 => 209357, [INFO] [stderr] | ^^^^^^ help: consider: `209_357` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | XC2Device::XC2C512 => 296403, [INFO] [stderr] | ^^^^^^ help: consider: `296_403` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:212:31 [INFO] [stderr] | [INFO] [stderr] 212 | XC2Device::XC2C256 => 123227, [INFO] [stderr] | ^^^^^^ help: consider: `123_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:213:31 [INFO] [stderr] | [INFO] [stderr] 213 | XC2Device::XC2C384 => 209331, [INFO] [stderr] | ^^^^^^ help: consider: `209_331` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | XC2Device::XC2C512 => 296377, [INFO] [stderr] | ^^^^^^ help: consider: `296_377` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:995:32 [INFO] [stderr] | [INFO] [stderr] 995 | linebreaks.add(123243); [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:996:23 [INFO] [stderr] | [INFO] [stderr] 996 | jed.f[123243] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:998:32 [INFO] [stderr] | [INFO] [stderr] 998 | linebreaks.add(123244); [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:999:23 [INFO] [stderr] | [INFO] [stderr] 999 | jed.f[123244] = !ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1000:23 [INFO] [stderr] | [INFO] [stderr] 1000 | jed.f[123245] = !ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `123_245` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1001:32 [INFO] [stderr] | [INFO] [stderr] 1001 | linebreaks.add(123246); [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1002:23 [INFO] [stderr] | [INFO] [stderr] 1002 | jed.f[123246] = !ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1003:23 [INFO] [stderr] | [INFO] [stderr] 1003 | jed.f[123247] = !ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `123_247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1005:32 [INFO] [stderr] | [INFO] [stderr] 1005 | linebreaks.add(123248); [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1006:23 [INFO] [stderr] | [INFO] [stderr] 1006 | jed.f[123248] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1009:32 [INFO] [stderr] | [INFO] [stderr] 1009 | linebreaks.add(209347); [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1010:23 [INFO] [stderr] | [INFO] [stderr] 1010 | jed.f[209347] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1012:32 [INFO] [stderr] | [INFO] [stderr] 1012 | linebreaks.add(209348); [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1013:23 [INFO] [stderr] | [INFO] [stderr] 1013 | jed.f[209348] = !ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1014:23 [INFO] [stderr] | [INFO] [stderr] 1014 | jed.f[209349] = !ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `209_349` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1015:23 [INFO] [stderr] | [INFO] [stderr] 1015 | jed.f[209350] = !ivoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `209_350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1016:23 [INFO] [stderr] | [INFO] [stderr] 1016 | jed.f[209351] = !ivoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `209_351` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1018:32 [INFO] [stderr] | [INFO] [stderr] 1018 | linebreaks.add(209352); [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1019:23 [INFO] [stderr] | [INFO] [stderr] 1019 | jed.f[209352] = !ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1020:23 [INFO] [stderr] | [INFO] [stderr] 1020 | jed.f[209353] = !ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `209_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1021:23 [INFO] [stderr] | [INFO] [stderr] 1021 | jed.f[209354] = !ovoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `209_354` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1022:23 [INFO] [stderr] | [INFO] [stderr] 1022 | jed.f[209355] = !ovoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `209_355` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1024:32 [INFO] [stderr] | [INFO] [stderr] 1024 | linebreaks.add(209356); [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1025:23 [INFO] [stderr] | [INFO] [stderr] 1025 | jed.f[209356] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1028:32 [INFO] [stderr] | [INFO] [stderr] 1028 | linebreaks.add(296393); [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1029:23 [INFO] [stderr] | [INFO] [stderr] 1029 | jed.f[296393] = !data_gate; [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1031:32 [INFO] [stderr] | [INFO] [stderr] 1031 | linebreaks.add(296394); [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1032:23 [INFO] [stderr] | [INFO] [stderr] 1032 | jed.f[296394] = ivoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1033:23 [INFO] [stderr] | [INFO] [stderr] 1033 | jed.f[296395] = ivoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `296_395` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1034:23 [INFO] [stderr] | [INFO] [stderr] 1034 | jed.f[296396] = ivoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `296_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1035:23 [INFO] [stderr] | [INFO] [stderr] 1035 | jed.f[296397] = ivoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `296_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1037:32 [INFO] [stderr] | [INFO] [stderr] 1037 | linebreaks.add(296398); [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1038:23 [INFO] [stderr] | [INFO] [stderr] 1038 | jed.f[296398] = ovoltage[0]; [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1039:23 [INFO] [stderr] | [INFO] [stderr] 1039 | jed.f[296399] = ovoltage[1]; [INFO] [stderr] | ^^^^^^ help: consider: `296_399` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1040:23 [INFO] [stderr] | [INFO] [stderr] 1040 | jed.f[296400] = ovoltage[2]; [INFO] [stderr] | ^^^^^^ help: consider: `296_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1041:23 [INFO] [stderr] | [INFO] [stderr] 1041 | jed.f[296401] = ovoltage[3]; [INFO] [stderr] | ^^^^^^ help: consider: `296_401` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1043:32 [INFO] [stderr] | [INFO] [stderr] 1043 | linebreaks.add(296402); [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1044:23 [INFO] [stderr] | [INFO] [stderr] 1044 | jed.f[296402] = !use_vref; [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1285:27 [INFO] [stderr] | [INFO] [stderr] 1285 | data_gate: !fuses[123243], [INFO] [stderr] | ^^^^^^ help: consider: `123_243` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1286:26 [INFO] [stderr] | [INFO] [stderr] 1286 | use_vref: !fuses[123248], [INFO] [stderr] | ^^^^^^ help: consider: `123_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1288:20 [INFO] [stderr] | [INFO] [stderr] 1288 | !fuses[123244], [INFO] [stderr] | ^^^^^^ help: consider: `123_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1289:20 [INFO] [stderr] | [INFO] [stderr] 1289 | !fuses[123245], [INFO] [stderr] | ^^^^^^ help: consider: `123_245` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1292:20 [INFO] [stderr] | [INFO] [stderr] 1292 | !fuses[123246], [INFO] [stderr] | ^^^^^^ help: consider: `123_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1293:20 [INFO] [stderr] | [INFO] [stderr] 1293 | !fuses[123247], [INFO] [stderr] | ^^^^^^ help: consider: `123_247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1317:27 [INFO] [stderr] | [INFO] [stderr] 1317 | data_gate: !fuses[209347], [INFO] [stderr] | ^^^^^^ help: consider: `209_347` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1318:26 [INFO] [stderr] | [INFO] [stderr] 1318 | use_vref: !fuses[209356], [INFO] [stderr] | ^^^^^^ help: consider: `209_356` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1320:20 [INFO] [stderr] | [INFO] [stderr] 1320 | !fuses[209348], [INFO] [stderr] | ^^^^^^ help: consider: `209_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1321:20 [INFO] [stderr] | [INFO] [stderr] 1321 | !fuses[209349], [INFO] [stderr] | ^^^^^^ help: consider: `209_349` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1322:20 [INFO] [stderr] | [INFO] [stderr] 1322 | !fuses[209350], [INFO] [stderr] | ^^^^^^ help: consider: `209_350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1323:20 [INFO] [stderr] | [INFO] [stderr] 1323 | !fuses[209351], [INFO] [stderr] | ^^^^^^ help: consider: `209_351` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1326:20 [INFO] [stderr] | [INFO] [stderr] 1326 | !fuses[209352], [INFO] [stderr] | ^^^^^^ help: consider: `209_352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1327:20 [INFO] [stderr] | [INFO] [stderr] 1327 | !fuses[209353], [INFO] [stderr] | ^^^^^^ help: consider: `209_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1328:20 [INFO] [stderr] | [INFO] [stderr] 1328 | !fuses[209354], [INFO] [stderr] | ^^^^^^ help: consider: `209_354` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1329:20 [INFO] [stderr] | [INFO] [stderr] 1329 | !fuses[209355], [INFO] [stderr] | ^^^^^^ help: consider: `209_355` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1353:27 [INFO] [stderr] | [INFO] [stderr] 1353 | data_gate: !fuses[296393], [INFO] [stderr] | ^^^^^^ help: consider: `296_393` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1354:26 [INFO] [stderr] | [INFO] [stderr] 1354 | use_vref: !fuses[296402], [INFO] [stderr] | ^^^^^^ help: consider: `296_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1356:19 [INFO] [stderr] | [INFO] [stderr] 1356 | fuses[296394], [INFO] [stderr] | ^^^^^^ help: consider: `296_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1357:19 [INFO] [stderr] | [INFO] [stderr] 1357 | fuses[296395], [INFO] [stderr] | ^^^^^^ help: consider: `296_395` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1358:19 [INFO] [stderr] | [INFO] [stderr] 1358 | fuses[296396], [INFO] [stderr] | ^^^^^^ help: consider: `296_396` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1359:19 [INFO] [stderr] | [INFO] [stderr] 1359 | fuses[296397], [INFO] [stderr] | ^^^^^^ help: consider: `296_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1362:19 [INFO] [stderr] | [INFO] [stderr] 1362 | fuses[296398], [INFO] [stderr] | ^^^^^^ help: consider: `296_398` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1363:19 [INFO] [stderr] | [INFO] [stderr] 1363 | fuses[296399], [INFO] [stderr] | ^^^^^^ help: consider: `296_399` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1364:19 [INFO] [stderr] | [INFO] [stderr] 1364 | fuses[296400], [INFO] [stderr] | ^^^^^^ help: consider: `296_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitstream.rs:1365:19 [INFO] [stderr] | [INFO] [stderr] 1365 | fuses[296401], [INFO] [stderr] | ^^^^^^ help: consider: `296_401` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fb.rs:351:32 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 352 | | if and_term_idx % 2 == 1 { [INFO] [stderr] 353 | | out_x += 1; [INFO] [stderr] 354 | | } [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if and_term_idx % 2 == 1 { [INFO] [stderr] 352 | out_x += 1; [INFO] [stderr] 353 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fb.rs:500:32 [INFO] [stderr] | [INFO] [stderr] 500 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 501 | | if and_term_idx % 2 == 1 { [INFO] [stderr] 502 | | out_x += 1; [INFO] [stderr] 503 | | } [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 500 | } else if and_term_idx % 2 == 1 { [INFO] [stderr] 501 | out_x += 1; [INFO] [stderr] 502 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | 13 => 100113, [INFO] [stderr] | ^^^^^^ help: consider: `100_113` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | 14 => 107808, [INFO] [stderr] | ^^^^^^ help: consider: `107_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | 15 => 115516, [INFO] [stderr] | ^^^^^^ help: consider: `115_516` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | 12 => 104664, [INFO] [stderr] | ^^^^^^ help: consider: `104_664` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | 13 => 113386, [INFO] [stderr] | ^^^^^^ help: consider: `113_386` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | 14 => 122108, [INFO] [stderr] | ^^^^^^ help: consider: `122_108` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | 15 => 130830, [INFO] [stderr] | ^^^^^^ help: consider: `130_830` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:100:23 [INFO] [stderr] | [INFO] [stderr] 100 | 16 => 139552, [INFO] [stderr] | ^^^^^^ help: consider: `139_552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | 17 => 148274, [INFO] [stderr] | ^^^^^^ help: consider: `148_274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | 18 => 156996, [INFO] [stderr] | ^^^^^^ help: consider: `156_996` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | 19 => 165718, [INFO] [stderr] | ^^^^^^ help: consider: `165_718` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | 20 => 174440, [INFO] [stderr] | ^^^^^^ help: consider: `174_440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | 21 => 183162, [INFO] [stderr] | ^^^^^^ help: consider: `183_162` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | 22 => 191884, [INFO] [stderr] | ^^^^^^ help: consider: `191_884` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | 23 => 200606, [INFO] [stderr] | ^^^^^^ help: consider: `200_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | 11 => 101855, [INFO] [stderr] | ^^^^^^ help: consider: `101_855` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | 12 => 111124, [INFO] [stderr] | ^^^^^^ help: consider: `111_124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | 13 => 120380, [INFO] [stderr] | ^^^^^^ help: consider: `120_380` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | 14 => 129649, [INFO] [stderr] | ^^^^^^ help: consider: `129_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | 15 => 138905, [INFO] [stderr] | ^^^^^^ help: consider: `138_905` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | 16 => 148174, [INFO] [stderr] | ^^^^^^ help: consider: `148_174` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | 17 => 157443, [INFO] [stderr] | ^^^^^^ help: consider: `157_443` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | 18 => 166699, [INFO] [stderr] | ^^^^^^ help: consider: `166_699` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | 19 => 175968, [INFO] [stderr] | ^^^^^^ help: consider: `175_968` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | 20 => 185224, [INFO] [stderr] | ^^^^^^ help: consider: `185_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | 21 => 194493, [INFO] [stderr] | ^^^^^^ help: consider: `194_493` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | 22 => 203749, [INFO] [stderr] | ^^^^^^ help: consider: `203_749` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | 23 => 213018, [INFO] [stderr] | ^^^^^^ help: consider: `213_018` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | 24 => 222274, [INFO] [stderr] | ^^^^^^ help: consider: `222_274` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | 25 => 231530, [INFO] [stderr] | ^^^^^^ help: consider: `231_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:139:23 [INFO] [stderr] | [INFO] [stderr] 139 | 26 => 240799, [INFO] [stderr] | ^^^^^^ help: consider: `240_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | 27 => 250055, [INFO] [stderr] | ^^^^^^ help: consider: `250_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | 28 => 259324, [INFO] [stderr] | ^^^^^^ help: consider: `259_324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | 29 => 268580, [INFO] [stderr] | ^^^^^^ help: consider: `268_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | 30 => 277849, [INFO] [stderr] | ^^^^^^ help: consider: `277_849` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | 31 => 287105, [INFO] [stderr] | ^^^^^^ help: consider: `287_105` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | XC2Device::XC2C256 => 123224, [INFO] [stderr] | ^^^^^^ help: consider: `123_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | XC2Device::XC2C384 => 209328, [INFO] [stderr] | ^^^^^^ help: consider: `209_328` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:158:31 [INFO] [stderr] | [INFO] [stderr] 158 | XC2Device::XC2C512 => 296374, [INFO] [stderr] | ^^^^^^ help: consider: `296_374` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | XC2Device::XC2C256 => 123232, [INFO] [stderr] | ^^^^^^ help: consider: `123_232` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:168:31 [INFO] [stderr] | [INFO] [stderr] 168 | XC2Device::XC2C384 => 209336, [INFO] [stderr] | ^^^^^^ help: consider: `209_336` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | XC2Device::XC2C512 => 296382, [INFO] [stderr] | ^^^^^^ help: consider: `296_382` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | XC2Device::XC2C256 => 123234, [INFO] [stderr] | ^^^^^^ help: consider: `123_234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:179:31 [INFO] [stderr] | [INFO] [stderr] 179 | XC2Device::XC2C384 => 209338, [INFO] [stderr] | ^^^^^^ help: consider: `209_338` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | XC2Device::XC2C512 => 296384, [INFO] [stderr] | ^^^^^^ help: consider: `296_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | XC2Device::XC2C256 => 123242, [INFO] [stderr] | ^^^^^^ help: consider: `123_242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:190:31 [INFO] [stderr] | [INFO] [stderr] 190 | XC2Device::XC2C384 => 209346, [INFO] [stderr] | ^^^^^^ help: consider: `209_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | XC2Device::XC2C512 => 296392, [INFO] [stderr] | ^^^^^^ help: consider: `296_392` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | XC2Device::XC2C256 => 123249, [INFO] [stderr] | ^^^^^^ help: consider: `123_249` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | XC2Device::XC2C384 => 209357, [INFO] [stderr] | ^^^^^^ help: consider: `209_357` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | XC2Device::XC2C512 => 296403, [INFO] [stderr] | ^^^^^^ help: consider: `296_403` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:212:31 [INFO] [stderr] | [INFO] [stderr] 212 | XC2Device::XC2C256 => 123227, [INFO] [stderr] | ^^^^^^ help: consider: `123_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:213:31 [INFO] [stderr] | [INFO] [stderr] 213 | XC2Device::XC2C384 => 209331, [INFO] [stderr] | ^^^^^^ help: consider: `209_331` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fusemap_logical.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | XC2Device::XC2C512 => 296377, [INFO] [stderr] | ^^^^^^ help: consider: `296_377` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/bitstream.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | / XC2C512 { [INFO] [stderr] 527 | | fb: [XC2BitstreamFB; 32], [INFO] [stderr] 528 | | iobs: [[XC2MCLargeIOB; 27]; 10], [INFO] [stderr] 529 | | global_nets: XC2GlobalNets, [INFO] [stderr] ... | [INFO] [stderr] 542 | | ovoltage: [bool; 4], [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/bitstream.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | / XC2C512 { [INFO] [stderr] 527 | | fb: [XC2BitstreamFB; 32], [INFO] [stderr] 528 | | iobs: [[XC2MCLargeIOB; 27]; 10], [INFO] [stderr] 529 | | global_nets: XC2GlobalNets, [INFO] [stderr] ... | [INFO] [stderr] 542 | | ovoltage: [bool; 4], [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | / match self { [INFO] [stderr] 550 | | &XC2BitstreamBits::XC2C32{..} => XC2Device::XC2C32, [INFO] [stderr] 551 | | &XC2BitstreamBits::XC2C32A{..} => XC2Device::XC2C32A, [INFO] [stderr] 552 | | &XC2BitstreamBits::XC2C64{..} => XC2Device::XC2C64, [INFO] [stderr] ... | [INFO] [stderr] 557 | | &XC2BitstreamBits::XC2C512{..} => XC2Device::XC2C512, [INFO] [stderr] 558 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 549 | match *self { [INFO] [stderr] 550 | XC2BitstreamBits::XC2C32{..} => XC2Device::XC2C32, [INFO] [stderr] 551 | XC2BitstreamBits::XC2C32A{..} => XC2Device::XC2C32A, [INFO] [stderr] 552 | XC2BitstreamBits::XC2C64{..} => XC2Device::XC2C64, [INFO] [stderr] 553 | XC2BitstreamBits::XC2C64A{..} => XC2Device::XC2C64A, [INFO] [stderr] 554 | XC2BitstreamBits::XC2C128{..} => XC2Device::XC2C128, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:563:9 [INFO] [stderr] | [INFO] [stderr] 563 | / match self { [INFO] [stderr] 564 | | &XC2BitstreamBits::XC2C32{ref fb, ..} => fb, [INFO] [stderr] 565 | | &XC2BitstreamBits::XC2C32A{ref fb, ..} => fb, [INFO] [stderr] 566 | | &XC2BitstreamBits::XC2C64{ref fb, ..} => fb, [INFO] [stderr] ... | [INFO] [stderr] 571 | | &XC2BitstreamBits::XC2C512{ref fb, ..} => fb, [INFO] [stderr] 572 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 563 | match *self { [INFO] [stderr] 564 | XC2BitstreamBits::XC2C32{ref fb, ..} => fb, [INFO] [stderr] 565 | XC2BitstreamBits::XC2C32A{ref fb, ..} => fb, [INFO] [stderr] 566 | XC2BitstreamBits::XC2C64{ref fb, ..} => fb, [INFO] [stderr] 567 | XC2BitstreamBits::XC2C64A{ref fb, ..} => fb, [INFO] [stderr] 568 | XC2BitstreamBits::XC2C128{ref fb, ..} => fb, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:577:9 [INFO] [stderr] | [INFO] [stderr] 577 | / match self { [INFO] [stderr] 578 | | &mut XC2BitstreamBits::XC2C32{ref mut fb, ..} => fb, [INFO] [stderr] 579 | | &mut XC2BitstreamBits::XC2C32A{ref mut fb, ..} => fb, [INFO] [stderr] 580 | | &mut XC2BitstreamBits::XC2C64{ref mut fb, ..} => fb, [INFO] [stderr] ... | [INFO] [stderr] 585 | | &mut XC2BitstreamBits::XC2C512{ref mut fb, ..} => fb, [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 577 | match *self { [INFO] [stderr] 578 | XC2BitstreamBits::XC2C32{ref mut fb, ..} => fb, [INFO] [stderr] 579 | XC2BitstreamBits::XC2C32A{ref mut fb, ..} => fb, [INFO] [stderr] 580 | XC2BitstreamBits::XC2C64{ref mut fb, ..} => fb, [INFO] [stderr] 581 | XC2BitstreamBits::XC2C64A{ref mut fb, ..} => fb, [INFO] [stderr] 582 | XC2BitstreamBits::XC2C128{ref mut fb, ..} => fb, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | / match self { [INFO] [stderr] 592 | | &XC2BitstreamBits::XC2C32{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 593 | | &XC2BitstreamBits::XC2C32A{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 594 | | &XC2BitstreamBits::XC2C64{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 595 | | &XC2BitstreamBits::XC2C64A{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 596 | | _ => None, [INFO] [stderr] 597 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 591 | match *self { [INFO] [stderr] 592 | XC2BitstreamBits::XC2C32{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 593 | XC2BitstreamBits::XC2C32A{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 594 | XC2BitstreamBits::XC2C64{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 595 | XC2BitstreamBits::XC2C64A{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | / match self { [INFO] [stderr] 603 | | &mut XC2BitstreamBits::XC2C32{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 604 | | &mut XC2BitstreamBits::XC2C32A{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 605 | | &mut XC2BitstreamBits::XC2C64{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 606 | | &mut XC2BitstreamBits::XC2C64A{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 607 | | _ => None, [INFO] [stderr] 608 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 602 | match *self { [INFO] [stderr] 603 | XC2BitstreamBits::XC2C32{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 604 | XC2BitstreamBits::XC2C32A{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 605 | XC2BitstreamBits::XC2C64{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 606 | XC2BitstreamBits::XC2C64A{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | / match self { [INFO] [stderr] 614 | | &XC2BitstreamBits::XC2C128{ref iobs, ..} => Some(&iobs[i / 25][i % 25]), [INFO] [stderr] 615 | | &XC2BitstreamBits::XC2C256{ref iobs, ..} => Some(&iobs[i / 23][i % 23]), [INFO] [stderr] 616 | | &XC2BitstreamBits::XC2C384{ref iobs, ..} => Some(&iobs[i / 24][i % 24]), [INFO] [stderr] 617 | | &XC2BitstreamBits::XC2C512{ref iobs, ..} => Some(&iobs[i / 27][i % 27]), [INFO] [stderr] 618 | | _ => None, [INFO] [stderr] 619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 613 | match *self { [INFO] [stderr] 614 | XC2BitstreamBits::XC2C128{ref iobs, ..} => Some(&iobs[i / 25][i % 25]), [INFO] [stderr] 615 | XC2BitstreamBits::XC2C256{ref iobs, ..} => Some(&iobs[i / 23][i % 23]), [INFO] [stderr] 616 | XC2BitstreamBits::XC2C384{ref iobs, ..} => Some(&iobs[i / 24][i % 24]), [INFO] [stderr] 617 | XC2BitstreamBits::XC2C512{ref iobs, ..} => Some(&iobs[i / 27][i % 27]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:624:9 [INFO] [stderr] | [INFO] [stderr] 624 | / match self { [INFO] [stderr] 625 | | &mut XC2BitstreamBits::XC2C128{ref mut iobs, ..} => Some(&mut iobs[i / 25][i % 25]), [INFO] [stderr] 626 | | &mut XC2BitstreamBits::XC2C256{ref mut iobs, ..} => Some(&mut iobs[i / 23][i % 23]), [INFO] [stderr] 627 | | &mut XC2BitstreamBits::XC2C384{ref mut iobs, ..} => Some(&mut iobs[i / 24][i % 24]), [INFO] [stderr] 628 | | &mut XC2BitstreamBits::XC2C512{ref mut iobs, ..} => Some(&mut iobs[i / 27][i % 27]), [INFO] [stderr] 629 | | _ => None, [INFO] [stderr] 630 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 624 | match *self { [INFO] [stderr] 625 | XC2BitstreamBits::XC2C128{ref mut iobs, ..} => Some(&mut iobs[i / 25][i % 25]), [INFO] [stderr] 626 | XC2BitstreamBits::XC2C256{ref mut iobs, ..} => Some(&mut iobs[i / 23][i % 23]), [INFO] [stderr] 627 | XC2BitstreamBits::XC2C384{ref mut iobs, ..} => Some(&mut iobs[i / 24][i % 24]), [INFO] [stderr] 628 | XC2BitstreamBits::XC2C512{ref mut iobs, ..} => Some(&mut iobs[i / 27][i % 27]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:635:9 [INFO] [stderr] | [INFO] [stderr] 635 | / match self { [INFO] [stderr] 636 | | &XC2BitstreamBits::XC2C32{ref global_nets, ..} => global_nets, [INFO] [stderr] 637 | | &XC2BitstreamBits::XC2C32A{ref global_nets, ..} => global_nets, [INFO] [stderr] 638 | | &XC2BitstreamBits::XC2C64{ref global_nets, ..} => global_nets, [INFO] [stderr] ... | [INFO] [stderr] 643 | | &XC2BitstreamBits::XC2C512{ref global_nets, ..} => global_nets, [INFO] [stderr] 644 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 635 | match *self { [INFO] [stderr] 636 | XC2BitstreamBits::XC2C32{ref global_nets, ..} => global_nets, [INFO] [stderr] 637 | XC2BitstreamBits::XC2C32A{ref global_nets, ..} => global_nets, [INFO] [stderr] 638 | XC2BitstreamBits::XC2C64{ref global_nets, ..} => global_nets, [INFO] [stderr] 639 | XC2BitstreamBits::XC2C64A{ref global_nets, ..} => global_nets, [INFO] [stderr] 640 | XC2BitstreamBits::XC2C128{ref global_nets, ..} => global_nets, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | / match self { [INFO] [stderr] 650 | | &mut XC2BitstreamBits::XC2C32{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 651 | | &mut XC2BitstreamBits::XC2C32A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 652 | | &mut XC2BitstreamBits::XC2C64{ref mut global_nets, ..} => global_nets, [INFO] [stderr] ... | [INFO] [stderr] 657 | | &mut XC2BitstreamBits::XC2C512{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 658 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 649 | match *self { [INFO] [stderr] 650 | XC2BitstreamBits::XC2C32{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 651 | XC2BitstreamBits::XC2C32A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 652 | XC2BitstreamBits::XC2C64{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 653 | XC2BitstreamBits::XC2C64A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 654 | XC2BitstreamBits::XC2C128{ref mut global_nets, ..} => global_nets, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:662:9 [INFO] [stderr] | [INFO] [stderr] 662 | / match self { [INFO] [stderr] 663 | | &XC2BitstreamBits::XC2C32{..} => None, [INFO] [stderr] 664 | | &XC2BitstreamBits::XC2C32A{..} => None, [INFO] [stderr] 665 | | &XC2BitstreamBits::XC2C64{..} => None, [INFO] [stderr] ... | [INFO] [stderr] 670 | | &XC2BitstreamBits::XC2C512{ref clock_div, ..} => Some(clock_div), [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 662 | match *self { [INFO] [stderr] 663 | XC2BitstreamBits::XC2C32{..} => None, [INFO] [stderr] 664 | XC2BitstreamBits::XC2C32A{..} => None, [INFO] [stderr] 665 | XC2BitstreamBits::XC2C64{..} => None, [INFO] [stderr] 666 | XC2BitstreamBits::XC2C64A{..} => None, [INFO] [stderr] 667 | XC2BitstreamBits::XC2C128{ref clock_div, ..} => Some(clock_div), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:692:9 [INFO] [stderr] | [INFO] [stderr] 692 | / match self { [INFO] [stderr] 693 | | &XC2BitstreamBits::XC2C32 {ref inpin, ..} | [INFO] [stderr] 694 | | &XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] 695 | | inpin.encode_crbit(fuse_array); [INFO] [stderr] 696 | | }, [INFO] [stderr] 697 | | _ => {} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 692 | match *self { [INFO] [stderr] 693 | XC2BitstreamBits::XC2C32 {ref inpin, ..} | [INFO] [stderr] 694 | XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | / match self { [INFO] [stderr] 720 | | &XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 721 | | &XC2BitstreamBits::XC2C32A {legacy_ivoltage: ref ivoltage, legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 722 | | fuse_array.set(130, 24, !*ovoltage); [INFO] [stderr] ... | [INFO] [stderr] 777 | | } [INFO] [stderr] 778 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 719 | match *self { [INFO] [stderr] 720 | XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 721 | XC2BitstreamBits::XC2C32A {legacy_ivoltage: ref ivoltage, legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 722 | fuse_array.set(130, 24, !*ovoltage); [INFO] [stderr] 723 | fuse_array.set(130, 25, !*ivoltage); [INFO] [stderr] 724 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:781:9 [INFO] [stderr] | [INFO] [stderr] 781 | / match self { [INFO] [stderr] 782 | | &XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 783 | | fuse_array.set(131, 25, !ivoltage[0]); [INFO] [stderr] 784 | | fuse_array.set(132, 25, !ovoltage[0]); [INFO] [stderr] ... | [INFO] [stderr] 794 | | _ => {} [INFO] [stderr] 795 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 781 | match *self { [INFO] [stderr] 782 | XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 783 | fuse_array.set(131, 25, !ivoltage[0]); [INFO] [stderr] 784 | fuse_array.set(132, 25, !ovoltage[0]); [INFO] [stderr] 785 | fuse_array.set(133, 25, !ivoltage[1]); [INFO] [stderr] 786 | fuse_array.set(134, 25, !ovoltage[1]); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/bitstream.rs:799:5 [INFO] [stderr] | [INFO] [stderr] 799 | / pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] 800 | | write!(writer, "device type: {}\n", self.device_type())?; [INFO] [stderr] 801 | | [INFO] [stderr] 802 | | // Bank voltages [INFO] [stderr] ... | [INFO] [stderr] 873 | | Ok(()) [INFO] [stderr] 874 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:803:9 [INFO] [stderr] | [INFO] [stderr] 803 | / match self { [INFO] [stderr] 804 | | &XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 805 | | &XC2BitstreamBits::XC2C64 {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 806 | | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] ... | [INFO] [stderr] 839 | | } [INFO] [stderr] 840 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 803 | match *self { [INFO] [stderr] 804 | XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 805 | XC2BitstreamBits::XC2C64 {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 806 | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] 807 | write!(writer, "input voltage range: {}\n", if *ivoltage {"high"} else {"low"})?; [INFO] [stderr] 808 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:861:9 [INFO] [stderr] | [INFO] [stderr] 861 | / match self { [INFO] [stderr] 862 | | &XC2BitstreamBits::XC2C32 {ref inpin, ..} | &XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] 863 | | inpin.dump_human_readable(&mut writer)?; [INFO] [stderr] 864 | | }, [INFO] [stderr] 865 | | _ => {} [INFO] [stderr] 866 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 861 | match *self { [INFO] [stderr] 862 | XC2BitstreamBits::XC2C32 {ref inpin, ..} | XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gck_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:921:15 [INFO] [stderr] | [INFO] [stderr] 921 | jed.f[gck_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gck_enable[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gsr_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:941:15 [INFO] [stderr] | [INFO] [stderr] 941 | jed.f[gsr_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gsr_invert; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gts_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:946:15 [INFO] [stderr] | [INFO] [stderr] 946 | jed.f[gts_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gts_invert[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:960:9 [INFO] [stderr] | [INFO] [stderr] 960 | / match self { [INFO] [stderr] 961 | | &XC2BitstreamBits::XC2C32 {ref inpin, ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 962 | | &XC2BitstreamBits::XC2C32A {ref inpin, legacy_ivoltage: ref ivoltage, [INFO] [stderr] 963 | | legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 1045 | | } [INFO] [stderr] 1046 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 960 | match *self { [INFO] [stderr] 961 | XC2BitstreamBits::XC2C32 {ref inpin, ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 962 | XC2BitstreamBits::XC2C32A {ref inpin, legacy_ivoltage: ref ivoltage, [INFO] [stderr] 963 | legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 964 | [INFO] [stderr] 965 | linebreaks.add(12270); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:1049:9 [INFO] [stderr] | [INFO] [stderr] 1049 | / match self { [INFO] [stderr] 1050 | | &XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 1051 | | linebreaks.add(12274); [INFO] [stderr] 1052 | | jed.f[12274] = !ivoltage[0]; [INFO] [stderr] ... | [INFO] [stderr] 1070 | | _ => {} [INFO] [stderr] 1071 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1049 | match *self { [INFO] [stderr] 1050 | XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 1051 | linebreaks.add(12274); [INFO] [stderr] 1052 | jed.f[12274] = !ivoltage[0]; [INFO] [stderr] 1053 | linebreaks.add(12275); [INFO] [stderr] 1054 | jed.f[12275] = !ovoltage[0]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1079:14 [INFO] [stderr] | [INFO] [stderr] 1079 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1079 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1104:14 [INFO] [stderr] | [INFO] [stderr] 1104 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1104 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1374:14 [INFO] [stderr] | [INFO] [stderr] 1374 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1374 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iobs` [INFO] [stderr] --> src/bitstream.rs:1378:14 [INFO] [stderr] | [INFO] [stderr] 1378 | for i in 0..iobs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1378 | for (i, ) in iobs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1389:14 [INFO] [stderr] | [INFO] [stderr] 1389 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1389 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iobs` [INFO] [stderr] --> src/bitstream.rs:1393:14 [INFO] [stderr] | [INFO] [stderr] 1393 | for i in 0..iobs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1393 | for (i, ) in iobs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/crbit.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fb.rs:158:65 [INFO] [stderr] | [INFO] [stderr] 158 | let (fb, mc) = iob_num_to_fb_mc_num(device, ibuf as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(ibuf)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:285:44 [INFO] [stderr] | [INFO] [stderr] 285 | fuse_array.set(x + term_idx * 2 + 0, out_y, !self.get_andterm(term_idx).get_b(input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:290:44 [INFO] [stderr] | [INFO] [stderr] 290 | fuse_array.set(x - term_idx * 2 - 0, out_y, !self.get_andterm(term_idx).get_b(input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `term_idx` is used to index `AND_BLOCK_TYPE2_P2L_MAP` [INFO] [stderr] --> src/fb.rs:297:33 [INFO] [stderr] | [INFO] [stderr] 297 | for term_idx in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 297 | for (term_idx, ) in AND_BLOCK_TYPE2_P2L_MAP.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:305:44 [INFO] [stderr] | [INFO] [stderr] 305 | fuse_array.set(x + term_idx * 2 + 0, y + input_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:312:44 [INFO] [stderr] | [INFO] [stderr] 312 | fuse_array.set(x - term_idx * 2 - 0, y + input_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:432:67 [INFO] [stderr] | [INFO] [stderr] 432 | .set_b(input_idx, !fuse_array.get(x + term_idx * 2 + 0, out_y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:439:67 [INFO] [stderr] | [INFO] [stderr] 439 | .set_b(input_idx, !fuse_array.get(x - term_idx * 2 - 0, out_y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `term_idx` is used to index `AND_BLOCK_TYPE2_P2L_MAP` [INFO] [stderr] --> src/fb.rs:446:33 [INFO] [stderr] | [INFO] [stderr] 446 | for term_idx in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 446 | for (term_idx, ) in AND_BLOCK_TYPE2_P2L_MAP.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:455:49 [INFO] [stderr] | [INFO] [stderr] 455 | !fuse_array.get(x + term_idx * 2 + 0, y + input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:462:49 [INFO] [stderr] | [INFO] [stderr] 462 | !fuse_array.get(x - term_idx * 2 - 0, y + input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:546:30 [INFO] [stderr] | [INFO] [stderr] 546 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 546 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:555:30 [INFO] [stderr] | [INFO] [stderr] 555 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 555 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:564:30 [INFO] [stderr] | [INFO] [stderr] 564 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 564 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:573:30 [INFO] [stderr] | [INFO] [stderr] 573 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 573 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:582:30 [INFO] [stderr] | [INFO] [stderr] 582 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 582 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:591:30 [INFO] [stderr] | [INFO] [stderr] 591 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 591 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `and_fuse_base + j * 2` [INFO] [stderr] --> src/fb.rs:605:23 [INFO] [stderr] | [INFO] [stderr] 605 | jed.f[and_fuse_base + j * 2 + 0] = !self.get_andterm(i).get(j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fusemap_physical.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / (((usize, usize), (usize, usize)), ((usize, usize), (usize, usize)), [INFO] [stderr] 231 | | ((usize, usize), (usize, usize)), ((usize, usize), (usize, usize))) { [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fusemap_physical.rs:262:8 [INFO] [stderr] | [INFO] [stderr] 262 | -> ((usize, usize), (usize, usize), (usize, usize), (usize, usize), (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gck_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | fuses[gck_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gsr_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | gsr_invert: fuses[gsr_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gts_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | fuses[gts_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/globalbits.rs:230:42 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_one_reftest` [INFO] [stderr] --> src/lib.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | fn run_one_reftest(jed_filename: &'static str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/bitstream.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | / XC2C512 { [INFO] [stderr] 527 | | fb: [XC2BitstreamFB; 32], [INFO] [stderr] 528 | | iobs: [[XC2MCLargeIOB; 27]; 10], [INFO] [stderr] 529 | | global_nets: XC2GlobalNets, [INFO] [stderr] ... | [INFO] [stderr] 542 | | ovoltage: [bool; 4], [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/bitstream.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | / XC2C512 { [INFO] [stderr] 527 | | fb: [XC2BitstreamFB; 32], [INFO] [stderr] 528 | | iobs: [[XC2MCLargeIOB; 27]; 10], [INFO] [stderr] 529 | | global_nets: XC2GlobalNets, [INFO] [stderr] ... | [INFO] [stderr] 542 | | ovoltage: [bool; 4], [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:143:42 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn dump_human_readable(&self, device: XC2Device, my_idx: u32, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn to_crbit(&self, device: XC2Device, iob: u32, fuse_array: &mut FuseArray) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:224:19 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn to_jed(&self, jed: &mut JEDECFile, device: XC2Device, fuse_base: usize, i: usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:319:42 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn dump_human_readable(&self, device: XC2Device, my_idx: u32, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | pub fn to_crbit(&self, device: XC2Device, iob: u32, fuse_array: &mut FuseArray) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn to_jed(&self, jed: &mut JEDECFile, fuse_base: usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:439:42 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | / match self { [INFO] [stderr] 550 | | &XC2BitstreamBits::XC2C32{..} => XC2Device::XC2C32, [INFO] [stderr] 551 | | &XC2BitstreamBits::XC2C32A{..} => XC2Device::XC2C32A, [INFO] [stderr] 552 | | &XC2BitstreamBits::XC2C64{..} => XC2Device::XC2C64, [INFO] [stderr] ... | [INFO] [stderr] 557 | | &XC2BitstreamBits::XC2C512{..} => XC2Device::XC2C512, [INFO] [stderr] 558 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 549 | match *self { [INFO] [stderr] 550 | XC2BitstreamBits::XC2C32{..} => XC2Device::XC2C32, [INFO] [stderr] 551 | XC2BitstreamBits::XC2C32A{..} => XC2Device::XC2C32A, [INFO] [stderr] 552 | XC2BitstreamBits::XC2C64{..} => XC2Device::XC2C64, [INFO] [stderr] 553 | XC2BitstreamBits::XC2C64A{..} => XC2Device::XC2C64A, [INFO] [stderr] 554 | XC2BitstreamBits::XC2C128{..} => XC2Device::XC2C128, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:563:9 [INFO] [stderr] | [INFO] [stderr] 563 | / match self { [INFO] [stderr] 564 | | &XC2BitstreamBits::XC2C32{ref fb, ..} => fb, [INFO] [stderr] 565 | | &XC2BitstreamBits::XC2C32A{ref fb, ..} => fb, [INFO] [stderr] 566 | | &XC2BitstreamBits::XC2C64{ref fb, ..} => fb, [INFO] [stderr] ... | [INFO] [stderr] 571 | | &XC2BitstreamBits::XC2C512{ref fb, ..} => fb, [INFO] [stderr] 572 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 563 | match *self { [INFO] [stderr] 564 | XC2BitstreamBits::XC2C32{ref fb, ..} => fb, [INFO] [stderr] 565 | XC2BitstreamBits::XC2C32A{ref fb, ..} => fb, [INFO] [stderr] 566 | XC2BitstreamBits::XC2C64{ref fb, ..} => fb, [INFO] [stderr] 567 | XC2BitstreamBits::XC2C64A{ref fb, ..} => fb, [INFO] [stderr] 568 | XC2BitstreamBits::XC2C128{ref fb, ..} => fb, [INFO] [stderr] | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:577:9 [INFO] [stderr] | [INFO] [stderr] 577 | / match self { [INFO] [stderr] 578 | | &mut XC2BitstreamBits::XC2C32{ref mut fb, ..} => fb, [INFO] [stderr] 579 | | &mut XC2BitstreamBits::XC2C32A{ref mut fb, ..} => fb, [INFO] [stderr] 580 | | &mut XC2BitstreamBits::XC2C64{ref mut fb, ..} => fb, [INFO] [stderr] ... | [INFO] [stderr] 585 | | &mut XC2BitstreamBits::XC2C512{ref mut fb, ..} => fb, [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 577 | match *self { [INFO] [stderr] 578 | XC2BitstreamBits::XC2C32{ref mut fb, ..} => fb, [INFO] [stderr] 579 | XC2BitstreamBits::XC2C32A{ref mut fb, ..} => fb, [INFO] [stderr] 580 | XC2BitstreamBits::XC2C64{ref mut fb, ..} => fb, [INFO] [stderr] 581 | XC2BitstreamBits::XC2C64A{ref mut fb, ..} => fb, [INFO] [stderr] 582 | XC2BitstreamBits::XC2C128{ref mut fb, ..} => fb, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | / match self { [INFO] [stderr] 592 | | &XC2BitstreamBits::XC2C32{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 593 | | &XC2BitstreamBits::XC2C32A{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 594 | | &XC2BitstreamBits::XC2C64{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 595 | | &XC2BitstreamBits::XC2C64A{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 596 | | _ => None, [INFO] [stderr] 597 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 591 | match *self { [INFO] [stderr] 592 | XC2BitstreamBits::XC2C32{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 593 | XC2BitstreamBits::XC2C32A{ref iobs, ..} => Some(&iobs[i]), [INFO] [stderr] 594 | XC2BitstreamBits::XC2C64{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] 595 | XC2BitstreamBits::XC2C64A{ref iobs, ..} => Some(&iobs[i / 32][i % 32]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | / match self { [INFO] [stderr] 603 | | &mut XC2BitstreamBits::XC2C32{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 604 | | &mut XC2BitstreamBits::XC2C32A{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 605 | | &mut XC2BitstreamBits::XC2C64{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 606 | | &mut XC2BitstreamBits::XC2C64A{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 607 | | _ => None, [INFO] [stderr] 608 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 602 | match *self { [INFO] [stderr] 603 | XC2BitstreamBits::XC2C32{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 604 | XC2BitstreamBits::XC2C32A{ref mut iobs, ..} => Some(&mut iobs[i]), [INFO] [stderr] 605 | XC2BitstreamBits::XC2C64{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] 606 | XC2BitstreamBits::XC2C64A{ref mut iobs, ..} => Some(&mut iobs[i / 32][i % 32]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | / match self { [INFO] [stderr] 614 | | &XC2BitstreamBits::XC2C128{ref iobs, ..} => Some(&iobs[i / 25][i % 25]), [INFO] [stderr] 615 | | &XC2BitstreamBits::XC2C256{ref iobs, ..} => Some(&iobs[i / 23][i % 23]), [INFO] [stderr] 616 | | &XC2BitstreamBits::XC2C384{ref iobs, ..} => Some(&iobs[i / 24][i % 24]), [INFO] [stderr] 617 | | &XC2BitstreamBits::XC2C512{ref iobs, ..} => Some(&iobs[i / 27][i % 27]), [INFO] [stderr] 618 | | _ => None, [INFO] [stderr] 619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 613 | match *self { [INFO] [stderr] 614 | XC2BitstreamBits::XC2C128{ref iobs, ..} => Some(&iobs[i / 25][i % 25]), [INFO] [stderr] 615 | XC2BitstreamBits::XC2C256{ref iobs, ..} => Some(&iobs[i / 23][i % 23]), [INFO] [stderr] 616 | XC2BitstreamBits::XC2C384{ref iobs, ..} => Some(&iobs[i / 24][i % 24]), [INFO] [stderr] 617 | XC2BitstreamBits::XC2C512{ref iobs, ..} => Some(&iobs[i / 27][i % 27]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:624:9 [INFO] [stderr] | [INFO] [stderr] 624 | / match self { [INFO] [stderr] 625 | | &mut XC2BitstreamBits::XC2C128{ref mut iobs, ..} => Some(&mut iobs[i / 25][i % 25]), [INFO] [stderr] 626 | | &mut XC2BitstreamBits::XC2C256{ref mut iobs, ..} => Some(&mut iobs[i / 23][i % 23]), [INFO] [stderr] 627 | | &mut XC2BitstreamBits::XC2C384{ref mut iobs, ..} => Some(&mut iobs[i / 24][i % 24]), [INFO] [stderr] 628 | | &mut XC2BitstreamBits::XC2C512{ref mut iobs, ..} => Some(&mut iobs[i / 27][i % 27]), [INFO] [stderr] 629 | | _ => None, [INFO] [stderr] 630 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 624 | match *self { [INFO] [stderr] 625 | XC2BitstreamBits::XC2C128{ref mut iobs, ..} => Some(&mut iobs[i / 25][i % 25]), [INFO] [stderr] 626 | XC2BitstreamBits::XC2C256{ref mut iobs, ..} => Some(&mut iobs[i / 23][i % 23]), [INFO] [stderr] 627 | XC2BitstreamBits::XC2C384{ref mut iobs, ..} => Some(&mut iobs[i / 24][i % 24]), [INFO] [stderr] 628 | XC2BitstreamBits::XC2C512{ref mut iobs, ..} => Some(&mut iobs[i / 27][i % 27]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:635:9 [INFO] [stderr] | [INFO] [stderr] 635 | / match self { [INFO] [stderr] 636 | | &XC2BitstreamBits::XC2C32{ref global_nets, ..} => global_nets, [INFO] [stderr] 637 | | &XC2BitstreamBits::XC2C32A{ref global_nets, ..} => global_nets, [INFO] [stderr] 638 | | &XC2BitstreamBits::XC2C64{ref global_nets, ..} => global_nets, [INFO] [stderr] ... | [INFO] [stderr] 643 | | &XC2BitstreamBits::XC2C512{ref global_nets, ..} => global_nets, [INFO] [stderr] 644 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 635 | match *self { [INFO] [stderr] 636 | XC2BitstreamBits::XC2C32{ref global_nets, ..} => global_nets, [INFO] [stderr] 637 | XC2BitstreamBits::XC2C32A{ref global_nets, ..} => global_nets, [INFO] [stderr] 638 | XC2BitstreamBits::XC2C64{ref global_nets, ..} => global_nets, [INFO] [stderr] 639 | XC2BitstreamBits::XC2C64A{ref global_nets, ..} => global_nets, [INFO] [stderr] 640 | XC2BitstreamBits::XC2C128{ref global_nets, ..} => global_nets, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | / match self { [INFO] [stderr] 650 | | &mut XC2BitstreamBits::XC2C32{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 651 | | &mut XC2BitstreamBits::XC2C32A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 652 | | &mut XC2BitstreamBits::XC2C64{ref mut global_nets, ..} => global_nets, [INFO] [stderr] ... | [INFO] [stderr] 657 | | &mut XC2BitstreamBits::XC2C512{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 658 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 649 | match *self { [INFO] [stderr] 650 | XC2BitstreamBits::XC2C32{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 651 | XC2BitstreamBits::XC2C32A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 652 | XC2BitstreamBits::XC2C64{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 653 | XC2BitstreamBits::XC2C64A{ref mut global_nets, ..} => global_nets, [INFO] [stderr] 654 | XC2BitstreamBits::XC2C128{ref mut global_nets, ..} => global_nets, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:662:9 [INFO] [stderr] | [INFO] [stderr] 662 | / match self { [INFO] [stderr] 663 | | &XC2BitstreamBits::XC2C32{..} => None, [INFO] [stderr] 664 | | &XC2BitstreamBits::XC2C32A{..} => None, [INFO] [stderr] 665 | | &XC2BitstreamBits::XC2C64{..} => None, [INFO] [stderr] ... | [INFO] [stderr] 670 | | &XC2BitstreamBits::XC2C512{ref clock_div, ..} => Some(clock_div), [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 662 | match *self { [INFO] [stderr] 663 | XC2BitstreamBits::XC2C32{..} => None, [INFO] [stderr] 664 | XC2BitstreamBits::XC2C32A{..} => None, [INFO] [stderr] 665 | XC2BitstreamBits::XC2C64{..} => None, [INFO] [stderr] 666 | XC2BitstreamBits::XC2C64A{..} => None, [INFO] [stderr] 667 | XC2BitstreamBits::XC2C128{ref clock_div, ..} => Some(clock_div), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:469:37 [INFO] [stderr] | [INFO] [stderr] 469 | 0... 5 => Some((0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:469:37 [INFO] [stderr] | [INFO] [stderr] 469 | 0... 5 => Some((0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 12` [INFO] [stderr] --> src/iob.rs:471:37 [INFO] [stderr] | [INFO] [stderr] 471 | 12...17 => Some((1, iob - 12 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 24` [INFO] [stderr] --> src/iob.rs:474:37 [INFO] [stderr] | [INFO] [stderr] 474 | 24...30 => Some((2, iob - 24 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 37` [INFO] [stderr] --> src/iob.rs:476:37 [INFO] [stderr] | [INFO] [stderr] 476 | 37...43 => Some((3, iob - 37 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:692:9 [INFO] [stderr] | [INFO] [stderr] 692 | / match self { [INFO] [stderr] 693 | | &XC2BitstreamBits::XC2C32 {ref inpin, ..} | [INFO] [stderr] 694 | | &XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] 695 | | inpin.encode_crbit(fuse_array); [INFO] [stderr] 696 | | }, [INFO] [stderr] 697 | | _ => {} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 50` [INFO] [stderr] --> src/iob.rs:478:37 [INFO] [stderr] | [INFO] [stderr] 478 | 50...56 => Some((4, iob - 50 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 692 | match *self { [INFO] [stderr] 693 | XC2BitstreamBits::XC2C32 {ref inpin, ..} | [INFO] [stderr] 694 | XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 63` [INFO] [stderr] --> src/iob.rs:481:37 [INFO] [stderr] | [INFO] [stderr] 481 | 63...68 => Some((5, iob - 63 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 75` [INFO] [stderr] --> src/iob.rs:484:37 [INFO] [stderr] | [INFO] [stderr] 484 | 75...81 => Some((6, iob - 75 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | / match self { [INFO] [stderr] 720 | | &XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 721 | | &XC2BitstreamBits::XC2C32A {legacy_ivoltage: ref ivoltage, legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 722 | | fuse_array.set(130, 24, !*ovoltage); [INFO] [stderr] ... | [INFO] [stderr] 777 | | } [INFO] [stderr] 778 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 719 | match *self { [INFO] [stderr] 720 | XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 721 | XC2BitstreamBits::XC2C32A {legacy_ivoltage: ref ivoltage, legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 722 | fuse_array.set(130, 24, !*ovoltage); [INFO] [stderr] 723 | fuse_array.set(130, 25, !*ivoltage); [INFO] [stderr] 724 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 88` [INFO] [stderr] --> src/iob.rs:487:37 [INFO] [stderr] | [INFO] [stderr] 487 | 88...93 => Some((7, iob - 88 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:495:40 [INFO] [stderr] | [INFO] [stderr] 495 | 0... 5 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:495:40 [INFO] [stderr] | [INFO] [stderr] 495 | 0... 5 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 11` [INFO] [stderr] --> src/iob.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | 11... 16 => Some(( 1, iob - 11 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 22` [INFO] [stderr] --> src/iob.rs:499:40 [INFO] [stderr] | [INFO] [stderr] 499 | 22... 27 => Some(( 2, iob - 22 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:781:9 [INFO] [stderr] | [INFO] [stderr] 781 | / match self { [INFO] [stderr] 782 | | &XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 783 | | fuse_array.set(131, 25, !ivoltage[0]); [INFO] [stderr] 784 | | fuse_array.set(132, 25, !ovoltage[0]); [INFO] [stderr] ... | [INFO] [stderr] 794 | | _ => {} [INFO] [stderr] 795 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 781 | match *self { [INFO] [stderr] 782 | XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 783 | fuse_array.set(131, 25, !ivoltage[0]); [INFO] [stderr] 784 | fuse_array.set(132, 25, !ovoltage[0]); [INFO] [stderr] 785 | fuse_array.set(133, 25, !ivoltage[1]); [INFO] [stderr] 786 | fuse_array.set(134, 25, !ovoltage[1]); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/bitstream.rs:799:5 [INFO] [stderr] | [INFO] [stderr] 799 | / pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] 800 | | write!(writer, "device type: {}\n", self.device_type())?; [INFO] [stderr] 801 | | [INFO] [stderr] 802 | | // Bank voltages [INFO] [stderr] ... | [INFO] [stderr] 873 | | Ok(()) [INFO] [stderr] 874 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 33` [INFO] [stderr] --> src/iob.rs:501:40 [INFO] [stderr] | [INFO] [stderr] 501 | 33... 38 => Some(( 3, iob - 33 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 44` [INFO] [stderr] --> src/iob.rs:503:40 [INFO] [stderr] | [INFO] [stderr] 503 | 44... 49 => Some(( 4, iob - 44 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 55` [INFO] [stderr] --> src/iob.rs:505:40 [INFO] [stderr] | [INFO] [stderr] 505 | 55... 60 => Some(( 5, iob - 55 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 66` [INFO] [stderr] --> src/iob.rs:508:40 [INFO] [stderr] | [INFO] [stderr] 508 | 66... 71 => Some(( 6, iob - 66 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 78` [INFO] [stderr] --> src/iob.rs:510:40 [INFO] [stderr] | [INFO] [stderr] 510 | 78... 83 => Some(( 7, iob - 78 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 90` [INFO] [stderr] --> src/iob.rs:512:40 [INFO] [stderr] | [INFO] [stderr] 512 | 90... 95 => Some(( 8, iob - 90 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 102` [INFO] [stderr] --> src/iob.rs:514:40 [INFO] [stderr] | [INFO] [stderr] 514 | 102...107 => Some(( 9, iob - 102 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 114` [INFO] [stderr] --> src/iob.rs:516:40 [INFO] [stderr] | [INFO] [stderr] 516 | 114...119 => Some((10, iob - 114 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 126` [INFO] [stderr] --> src/iob.rs:518:40 [INFO] [stderr] | [INFO] [stderr] 518 | 126...131 => Some((11, iob - 126 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 138` [INFO] [stderr] --> src/iob.rs:521:40 [INFO] [stderr] | [INFO] [stderr] 521 | 138...143 => Some((12, iob - 138 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 149` [INFO] [stderr] --> src/iob.rs:523:40 [INFO] [stderr] | [INFO] [stderr] 523 | 149...154 => Some((13, iob - 149 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 160` [INFO] [stderr] --> src/iob.rs:525:40 [INFO] [stderr] | [INFO] [stderr] 525 | 160...165 => Some((14, iob - 160 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 172` [INFO] [stderr] --> src/iob.rs:527:40 [INFO] [stderr] | [INFO] [stderr] 527 | 172...177 => Some((15, iob - 172 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/iob.rs:541:21 [INFO] [stderr] | [INFO] [stderr] 541 | mc = mc + 6; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `mc += 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:550:40 [INFO] [stderr] | [INFO] [stderr] 550 | 0... 3 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:550:40 [INFO] [stderr] | [INFO] [stderr] 550 | 0... 3 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 8` [INFO] [stderr] --> src/iob.rs:552:40 [INFO] [stderr] | [INFO] [stderr] 552 | 8... 11 => Some(( 1, iob - 8 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 16` [INFO] [stderr] --> src/iob.rs:555:40 [INFO] [stderr] | [INFO] [stderr] 555 | 16... 20 => Some(( 2, iob - 16 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 25` [INFO] [stderr] --> src/iob.rs:558:40 [INFO] [stderr] | [INFO] [stderr] 558 | 25... 28 => Some(( 3, iob - 25 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 33` [INFO] [stderr] --> src/iob.rs:561:40 [INFO] [stderr] | [INFO] [stderr] 561 | 33... 37 => Some(( 4, iob - 33 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 42` [INFO] [stderr] --> src/iob.rs:564:40 [INFO] [stderr] | [INFO] [stderr] 564 | 42... 45 => Some(( 5, iob - 42 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 50` [INFO] [stderr] --> src/iob.rs:567:40 [INFO] [stderr] | [INFO] [stderr] 567 | 50... 54 => Some(( 6, iob - 50 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 59` [INFO] [stderr] --> src/iob.rs:570:40 [INFO] [stderr] | [INFO] [stderr] 570 | 59... 62 => Some(( 7, iob - 59 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 67` [INFO] [stderr] --> src/iob.rs:572:40 [INFO] [stderr] | [INFO] [stderr] 572 | 67... 70 => Some(( 8, iob - 67 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 75` [INFO] [stderr] --> src/iob.rs:574:40 [INFO] [stderr] | [INFO] [stderr] 574 | 75... 78 => Some(( 9, iob - 75 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 83` [INFO] [stderr] --> src/iob.rs:576:40 [INFO] [stderr] | [INFO] [stderr] 576 | 83... 86 => Some((10, iob - 83 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:803:9 [INFO] [stderr] | [INFO] [stderr] 803 | / match self { [INFO] [stderr] 804 | | &XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 805 | | &XC2BitstreamBits::XC2C64 {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 806 | | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] ... | [INFO] [stderr] 839 | | } [INFO] [stderr] 840 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 803 | match *self { [INFO] [stderr] 804 | XC2BitstreamBits::XC2C32 {ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 805 | XC2BitstreamBits::XC2C64 {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 806 | write!(writer, "output voltage range: {}\n", if *ovoltage {"high"} else {"low"})?; [INFO] [stderr] 807 | write!(writer, "input voltage range: {}\n", if *ivoltage {"high"} else {"low"})?; [INFO] [stderr] 808 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 91` [INFO] [stderr] --> src/iob.rs:579:40 [INFO] [stderr] | [INFO] [stderr] 579 | 91... 95 => Some((11, iob - 91 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 100` [INFO] [stderr] --> src/iob.rs:582:40 [INFO] [stderr] | [INFO] [stderr] 582 | 100...103 => Some((12, iob - 100 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 108` [INFO] [stderr] --> src/iob.rs:585:40 [INFO] [stderr] | [INFO] [stderr] 585 | 108...112 => Some((13, iob - 108 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 117` [INFO] [stderr] --> src/iob.rs:588:40 [INFO] [stderr] | [INFO] [stderr] 588 | 117...120 => Some((14, iob - 117 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 125` [INFO] [stderr] --> src/iob.rs:591:40 [INFO] [stderr] | [INFO] [stderr] 591 | 125...129 => Some((15, iob - 125 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 134` [INFO] [stderr] --> src/iob.rs:593:40 [INFO] [stderr] | [INFO] [stderr] 593 | 134...138 => Some((16, iob - 134 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 143` [INFO] [stderr] --> src/iob.rs:596:40 [INFO] [stderr] | [INFO] [stderr] 596 | 143...146 => Some((17, iob - 143 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 151` [INFO] [stderr] --> src/iob.rs:599:40 [INFO] [stderr] | [INFO] [stderr] 599 | 151...155 => Some((18, iob - 151 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 160` [INFO] [stderr] --> src/iob.rs:602:40 [INFO] [stderr] | [INFO] [stderr] 602 | 160...163 => Some((19, iob - 160 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 168` [INFO] [stderr] --> src/iob.rs:605:40 [INFO] [stderr] | [INFO] [stderr] 605 | 168...172 => Some((20, iob - 168 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 177` [INFO] [stderr] --> src/iob.rs:608:40 [INFO] [stderr] | [INFO] [stderr] 608 | 177...180 => Some((21, iob - 177 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 185` [INFO] [stderr] --> src/iob.rs:611:40 [INFO] [stderr] | [INFO] [stderr] 611 | 185...189 => Some((22, iob - 185 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 194` [INFO] [stderr] --> src/iob.rs:614:40 [INFO] [stderr] | [INFO] [stderr] 614 | 194...197 => Some((23, iob - 194 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 202` [INFO] [stderr] --> src/iob.rs:616:40 [INFO] [stderr] | [INFO] [stderr] 616 | 202...205 => Some((24, iob - 202 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 210` [INFO] [stderr] --> src/iob.rs:619:40 [INFO] [stderr] | [INFO] [stderr] 619 | 210...214 => Some((25, iob - 210 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 219` [INFO] [stderr] --> src/iob.rs:622:40 [INFO] [stderr] | [INFO] [stderr] 622 | 219...222 => Some((26, iob - 219 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 227` [INFO] [stderr] --> src/iob.rs:625:40 [INFO] [stderr] | [INFO] [stderr] 625 | 227...231 => Some((27, iob - 227 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 236` [INFO] [stderr] --> src/iob.rs:628:40 [INFO] [stderr] | [INFO] [stderr] 628 | 236...239 => Some((28, iob - 236 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 244` [INFO] [stderr] --> src/iob.rs:631:40 [INFO] [stderr] | [INFO] [stderr] 631 | 244...248 => Some((29, iob - 244 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 253` [INFO] [stderr] --> src/iob.rs:634:40 [INFO] [stderr] | [INFO] [stderr] 634 | 253...256 => Some((30, iob - 253 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 261` [INFO] [stderr] --> src/iob.rs:637:40 [INFO] [stderr] | [INFO] [stderr] 637 | 261...265 => Some((31, iob - 261 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/iob.rs:646:1 [INFO] [stderr] | [INFO] [stderr] 646 | / pub fn fb_mc_num_to_iob_num(device: XC2Device, fb: u32, mc: u32) -> Option { [INFO] [stderr] 647 | | match device { [INFO] [stderr] 648 | | XC2Device::XC2C32 | XC2Device::XC2C32A => { [INFO] [stderr] 649 | | if fb >= 2 || mc >= MCS_PER_FB as u32 { [INFO] [stderr] ... | [INFO] [stderr] 1000 | | } [INFO] [stderr] 1001 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:861:9 [INFO] [stderr] | [INFO] [stderr] 861 | / match self { [INFO] [stderr] 862 | | &XC2BitstreamBits::XC2C32 {ref inpin, ..} | &XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] 863 | | inpin.dump_human_readable(&mut writer)?; [INFO] [stderr] 864 | | }, [INFO] [stderr] 865 | | _ => {} [INFO] [stderr] 866 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 861 | match *self { [INFO] [stderr] 862 | XC2BitstreamBits::XC2C32 {ref inpin, ..} | XC2BitstreamBits::XC2C32A {ref inpin, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gck_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:921:15 [INFO] [stderr] | [INFO] [stderr] 921 | jed.f[gck_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gck_enable[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gsr_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:941:15 [INFO] [stderr] | [INFO] [stderr] 941 | jed.f[gsr_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gsr_invert; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gts_fuse_idx(self.device_type())` [INFO] [stderr] --> src/bitstream.rs:946:15 [INFO] [stderr] | [INFO] [stderr] 946 | jed.f[gts_fuse_idx(self.device_type()) + 0] = self.get_global_nets().gts_invert[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:960:9 [INFO] [stderr] | [INFO] [stderr] 960 | / match self { [INFO] [stderr] 961 | | &XC2BitstreamBits::XC2C32 {ref inpin, ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 962 | | &XC2BitstreamBits::XC2C32A {ref inpin, legacy_ivoltage: ref ivoltage, [INFO] [stderr] 963 | | legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 1045 | | } [INFO] [stderr] 1046 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 960 | match *self { [INFO] [stderr] 961 | XC2BitstreamBits::XC2C32 {ref inpin, ref ivoltage, ref ovoltage, ..} | [INFO] [stderr] 962 | XC2BitstreamBits::XC2C32A {ref inpin, legacy_ivoltage: ref ivoltage, [INFO] [stderr] 963 | legacy_ovoltage: ref ovoltage, ..} => { [INFO] [stderr] 964 | [INFO] [stderr] 965 | linebreaks.add(12270); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:666:37 [INFO] [stderr] | [INFO] [stderr] 666 | 0...5 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:716:37 [INFO] [stderr] | [INFO] [stderr] 716 | 0...5 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bitstream.rs:1049:9 [INFO] [stderr] | [INFO] [stderr] 1049 | / match self { [INFO] [stderr] 1050 | | &XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 1051 | | linebreaks.add(12274); [INFO] [stderr] 1052 | | jed.f[12274] = !ivoltage[0]; [INFO] [stderr] ... | [INFO] [stderr] 1070 | | _ => {} [INFO] [stderr] 1071 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1049 | match *self { [INFO] [stderr] 1050 | XC2BitstreamBits::XC2C32A {ref ivoltage, ref ovoltage, ..} => { [INFO] [stderr] 1051 | linebreaks.add(12274); [INFO] [stderr] 1052 | jed.f[12274] = !ivoltage[0]; [INFO] [stderr] 1053 | linebreaks.add(12275); [INFO] [stderr] 1054 | jed.f[12275] = !ovoltage[0]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1079:14 [INFO] [stderr] | [INFO] [stderr] 1079 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1079 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:813:37 [INFO] [stderr] | [INFO] [stderr] 813 | 0...3 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1104:14 [INFO] [stderr] | [INFO] [stderr] 1104 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1104 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1374:14 [INFO] [stderr] | [INFO] [stderr] 1374 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1374 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iobs` [INFO] [stderr] --> src/bitstream.rs:1378:14 [INFO] [stderr] | [INFO] [stderr] 1378 | for i in 0..iobs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1378 | for (i, ) in iobs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fb` [INFO] [stderr] --> src/bitstream.rs:1389:14 [INFO] [stderr] | [INFO] [stderr] 1389 | for i in 0..fb.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1389 | for (i, ) in fb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iobs` [INFO] [stderr] --> src/bitstream.rs:1393:14 [INFO] [stderr] | [INFO] [stderr] 1393 | for i in 0..iobs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1393 | for (i, ) in iobs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/crbit.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mc.rs:396:25 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn to_jed_small(jed: &mut JEDECFile, linebreaks: &mut LinebreakSet, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mc.rs:415:25 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn to_jed_large(jed: &mut JEDECFile, linebreaks: &mut LinebreakSet, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fb.rs:158:65 [INFO] [stderr] | [INFO] [stderr] 158 | let (fb, mc) = iob_num_to_fb_mc_num(device, ibuf as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(ibuf)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn num_fbs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn num_iobs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn is_small_iob(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn is_large_iob(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 { [INFO] [stderr] 141 | | true [INFO] [stderr] 142 | | } else { [INFO] [stderr] 143 | | false [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 152 | | package == XC2Package::QFG32 { [INFO] [stderr] 153 | | true [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | false [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 151 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 152 | package == XC2Package::QFG32 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 164 | | package == XC2Package::VQ100 { [INFO] [stderr] 165 | | true [INFO] [stderr] 166 | | } else { [INFO] [stderr] 167 | | false [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 163 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 164 | package == XC2Package::VQ100 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 176 | | package == XC2Package::VQ100 || package == XC2Package::QFG48 { [INFO] [stderr] 177 | | true [INFO] [stderr] 178 | | } else { [INFO] [stderr] 179 | | false [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 175 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 176 | package == XC2Package::VQ100 || package == XC2Package::QFG48 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:285:44 [INFO] [stderr] | [INFO] [stderr] 285 | fuse_array.set(x + term_idx * 2 + 0, out_y, !self.get_andterm(term_idx).get_b(input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / if package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 { [INFO] [stderr] 188 | | true [INFO] [stderr] 189 | | } else { [INFO] [stderr] 190 | | false [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | / if package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 || [INFO] [stderr] 199 | | package == XC2Package::PQ208 || package == XC2Package::FT256 { [INFO] [stderr] 200 | | true [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | false [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 198 | package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 || [INFO] [stderr] 199 | package == XC2Package::PQ208 || package == XC2Package::FT256 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | / if package == XC2Package::TQ144 || package == XC2Package::PQ208 || package == XC2Package::FT256 || [INFO] [stderr] 211 | | package == XC2Package::FG324 { [INFO] [stderr] 212 | | true [INFO] [stderr] 213 | | } else { [INFO] [stderr] 214 | | false [INFO] [stderr] 215 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 210 | package == XC2Package::TQ144 || package == XC2Package::PQ208 || package == XC2Package::FT256 || [INFO] [stderr] 211 | package == XC2Package::FG324 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | / if package == XC2Package::PQ208 || package == XC2Package::FT256 || package == XC2Package::FG324 { [INFO] [stderr] 223 | | true [INFO] [stderr] 224 | | } else { [INFO] [stderr] 225 | | false [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::PQ208 || package == XC2Package::FT256 || package == XC2Package::FG324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:290:44 [INFO] [stderr] | [INFO] [stderr] 290 | fuse_array.set(x - term_idx * 2 - 0, out_y, !self.get_andterm(term_idx).get_b(input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `term_idx` is used to index `AND_BLOCK_TYPE2_P2L_MAP` [INFO] [stderr] --> src/fb.rs:297:33 [INFO] [stderr] | [INFO] [stderr] 297 | for term_idx in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 297 | for (term_idx, ) in AND_BLOCK_TYPE2_P2L_MAP.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:305:44 [INFO] [stderr] | [INFO] [stderr] 305 | fuse_array.set(x + term_idx * 2 + 0, y + input_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:312:44 [INFO] [stderr] | [INFO] [stderr] 312 | fuse_array.set(x - term_idx * 2 - 0, y + input_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/partdb.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn from_str(part_name: &str) -> Option { [INFO] [stderr] 246 | | let dev; [INFO] [stderr] 247 | | let spd; [INFO] [stderr] 248 | | let pkg; [INFO] [stderr] ... | [INFO] [stderr] 321 | | }) [INFO] [stderr] 322 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `block_idx + term_idx * INPUTS_PER_ANDTERM * 2 + i * 2` [INFO] [stderr] --> src/pla.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | if !fuses[block_idx + term_idx * INPUTS_PER_ANDTERM * 2 + i * 2 + 0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pla.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn get(&self, i: usize) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:432:67 [INFO] [stderr] | [INFO] [stderr] 432 | .set_b(input_idx, !fuse_array.get(x + term_idx * 2 + 0, out_y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:439:67 [INFO] [stderr] | [INFO] [stderr] 439 | .set_b(input_idx, !fuse_array.get(x - term_idx * 2 - 0, out_y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `term_idx` is used to index `AND_BLOCK_TYPE2_P2L_MAP` [INFO] [stderr] --> src/fb.rs:446:33 [INFO] [stderr] | [INFO] [stderr] 446 | for term_idx in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 446 | for (term_idx, ) in AND_BLOCK_TYPE2_P2L_MAP.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `orterm_wires` [INFO] [stderr] --> src/structure.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | for i in 0..MCS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 195 | for (i, ) in orterm_wires.iter().enumerate().take(MCS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x + term_idx * 2` [INFO] [stderr] --> src/fb.rs:455:49 [INFO] [stderr] | [INFO] [stderr] 455 | !fuse_array.get(x + term_idx * 2 + 0, y + input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x - term_idx * 2` [INFO] [stderr] --> src/fb.rs:462:49 [INFO] [stderr] | [INFO] [stderr] 462 | !fuse_array.get(x - term_idx * 2 - 0, y + input_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `pterm_wires` [INFO] [stderr] --> src/structure.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | for j in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for (j, ) in pterm_wires.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `gck` [INFO] [stderr] --> src/structure.rs:232:22 [INFO] [stderr] | [INFO] [stderr] 232 | for j in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 232 | for (j, ) in gck.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `iob_idx` is used to index `to_from_iob_wires` [INFO] [stderr] --> src/structure.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | for iob_idx in 0..device.num_iobs() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (iob_idx, ) in to_from_iob_wires.iter().enumerate().take(device.num_iobs()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gts` [INFO] [stderr] --> src/structure.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 296 | for (i, ) in gts.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gck` [INFO] [stderr] --> src/structure.rs:328:14 [INFO] [stderr] | [INFO] [stderr] 328 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 328 | for (i, ) in gck.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gts` [INFO] [stderr] --> src/structure.rs:334:14 [INFO] [stderr] | [INFO] [stderr] 334 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 334 | for (i, ) in gts.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structure.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | / match zia_choice { [INFO] [stderr] 352 | | &XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 353 | | // From the XOR gate [INFO] [stderr] 354 | | connection_callback(fb_things[and_fb as usize].3[and_i as usize], [INFO] [stderr] ... | [INFO] [stderr] 379 | | _ => unreachable!(), [INFO] [stderr] 380 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 351 | match *zia_choice { [INFO] [stderr] 352 | XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 353 | // From the XOR gate [INFO] [stderr] 354 | connection_callback(fb_things[and_fb as usize].3[and_i as usize], [INFO] [stderr] 355 | fb_things[zia_fb as usize].5[zia_mc as usize], "IN", zia_row_i, [INFO] [stderr] 356 | (zia_choice_i as u32, 0)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/structure.rs:363:81 [INFO] [stderr] | [INFO] [stderr] 363 | let (iob_fb, iob_mc) = iob_num_to_fb_mc_num(device, zia_iob as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(zia_iob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:546:30 [INFO] [stderr] | [INFO] [stderr] 546 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 546 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:555:30 [INFO] [stderr] | [INFO] [stderr] 555 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 555 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:564:30 [INFO] [stderr] | [INFO] [stderr] 564 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 564 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:573:30 [INFO] [stderr] | [INFO] [stderr] 573 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 573 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:582:30 [INFO] [stderr] | [INFO] [stderr] 582 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 582 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `zia_choice_bits`. [INFO] [stderr] --> src/fb.rs:591:30 [INFO] [stderr] | [INFO] [stderr] 591 | for j in 0..zia_choice_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 591 | for in &zia_choice_bits { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `and_fuse_base + j * 2` [INFO] [stderr] --> src/fb.rs:605:23 [INFO] [stderr] | [INFO] [stderr] 605 | jed.f[and_fuse_base + j * 2 + 0] = !self.get_andterm(i).get(j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fusemap_physical.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / (((usize, usize), (usize, usize)), ((usize, usize), (usize, usize)), [INFO] [stderr] 231 | | ((usize, usize), (usize, usize)), ((usize, usize), (usize, usize))) { [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fusemap_physical.rs:262:8 [INFO] [stderr] | [INFO] [stderr] 262 | -> ((usize, usize), (usize, usize), (usize, usize), (usize, usize), (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gck_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | fuses[gck_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gsr_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | gsr_invert: fuses[gsr_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `gts_fuse_idx(device)` [INFO] [stderr] --> src/globalbits.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | fuses[gts_fuse_idx(device) + 0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/globalbits.rs:230:42 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:143:42 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn dump_human_readable(&self, device: XC2Device, my_idx: u32, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn to_crbit(&self, device: XC2Device, iob: u32, fuse_array: &mut FuseArray) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:224:19 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn to_jed(&self, jed: &mut JEDECFile, device: XC2Device, fuse_base: usize, i: usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:319:42 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn dump_human_readable(&self, device: XC2Device, my_idx: u32, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | pub fn to_crbit(&self, device: XC2Device, iob: u32, fuse_array: &mut FuseArray) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn to_jed(&self, jed: &mut JEDECFile, fuse_base: usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iob.rs:439:42 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn dump_human_readable(&self, mut writer: W) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:469:37 [INFO] [stderr] | [INFO] [stderr] 469 | 0... 5 => Some((0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:469:37 [INFO] [stderr] | [INFO] [stderr] 469 | 0... 5 => Some((0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 12` [INFO] [stderr] --> src/iob.rs:471:37 [INFO] [stderr] | [INFO] [stderr] 471 | 12...17 => Some((1, iob - 12 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 24` [INFO] [stderr] --> src/iob.rs:474:37 [INFO] [stderr] | [INFO] [stderr] 474 | 24...30 => Some((2, iob - 24 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 37` [INFO] [stderr] --> src/iob.rs:476:37 [INFO] [stderr] | [INFO] [stderr] 476 | 37...43 => Some((3, iob - 37 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 50` [INFO] [stderr] --> src/iob.rs:478:37 [INFO] [stderr] | [INFO] [stderr] 478 | 50...56 => Some((4, iob - 50 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 63` [INFO] [stderr] --> src/iob.rs:481:37 [INFO] [stderr] | [INFO] [stderr] 481 | 63...68 => Some((5, iob - 63 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 75` [INFO] [stderr] --> src/iob.rs:484:37 [INFO] [stderr] | [INFO] [stderr] 484 | 75...81 => Some((6, iob - 75 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 88` [INFO] [stderr] --> src/iob.rs:487:37 [INFO] [stderr] | [INFO] [stderr] 487 | 88...93 => Some((7, iob - 88 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:495:40 [INFO] [stderr] | [INFO] [stderr] 495 | 0... 5 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:495:40 [INFO] [stderr] | [INFO] [stderr] 495 | 0... 5 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 11` [INFO] [stderr] --> src/iob.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | 11... 16 => Some(( 1, iob - 11 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 22` [INFO] [stderr] --> src/iob.rs:499:40 [INFO] [stderr] | [INFO] [stderr] 499 | 22... 27 => Some(( 2, iob - 22 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 33` [INFO] [stderr] --> src/iob.rs:501:40 [INFO] [stderr] | [INFO] [stderr] 501 | 33... 38 => Some(( 3, iob - 33 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 44` [INFO] [stderr] --> src/iob.rs:503:40 [INFO] [stderr] | [INFO] [stderr] 503 | 44... 49 => Some(( 4, iob - 44 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 55` [INFO] [stderr] --> src/iob.rs:505:40 [INFO] [stderr] | [INFO] [stderr] 505 | 55... 60 => Some(( 5, iob - 55 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 66` [INFO] [stderr] --> src/iob.rs:508:40 [INFO] [stderr] | [INFO] [stderr] 508 | 66... 71 => Some(( 6, iob - 66 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 78` [INFO] [stderr] --> src/iob.rs:510:40 [INFO] [stderr] | [INFO] [stderr] 510 | 78... 83 => Some(( 7, iob - 78 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 90` [INFO] [stderr] --> src/iob.rs:512:40 [INFO] [stderr] | [INFO] [stderr] 512 | 90... 95 => Some(( 8, iob - 90 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 102` [INFO] [stderr] --> src/iob.rs:514:40 [INFO] [stderr] | [INFO] [stderr] 514 | 102...107 => Some(( 9, iob - 102 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 114` [INFO] [stderr] --> src/iob.rs:516:40 [INFO] [stderr] | [INFO] [stderr] 516 | 114...119 => Some((10, iob - 114 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 126` [INFO] [stderr] --> src/iob.rs:518:40 [INFO] [stderr] | [INFO] [stderr] 518 | 126...131 => Some((11, iob - 126 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 138` [INFO] [stderr] --> src/iob.rs:521:40 [INFO] [stderr] | [INFO] [stderr] 521 | 138...143 => Some((12, iob - 138 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 149` [INFO] [stderr] --> src/iob.rs:523:40 [INFO] [stderr] | [INFO] [stderr] 523 | 149...154 => Some((13, iob - 149 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 160` [INFO] [stderr] --> src/iob.rs:525:40 [INFO] [stderr] | [INFO] [stderr] 525 | 160...165 => Some((14, iob - 160 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 172` [INFO] [stderr] --> src/iob.rs:527:40 [INFO] [stderr] | [INFO] [stderr] 527 | 172...177 => Some((15, iob - 172 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/iob.rs:541:21 [INFO] [stderr] | [INFO] [stderr] 541 | mc = mc + 6; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `mc += 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 0` [INFO] [stderr] --> src/iob.rs:550:40 [INFO] [stderr] | [INFO] [stderr] 550 | 0... 3 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob` [INFO] [stderr] --> src/iob.rs:550:40 [INFO] [stderr] | [INFO] [stderr] 550 | 0... 3 => Some(( 0, iob - 0 + 0)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 8` [INFO] [stderr] --> src/iob.rs:552:40 [INFO] [stderr] | [INFO] [stderr] 552 | 8... 11 => Some(( 1, iob - 8 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 16` [INFO] [stderr] --> src/iob.rs:555:40 [INFO] [stderr] | [INFO] [stderr] 555 | 16... 20 => Some(( 2, iob - 16 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 25` [INFO] [stderr] --> src/iob.rs:558:40 [INFO] [stderr] | [INFO] [stderr] 558 | 25... 28 => Some(( 3, iob - 25 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 33` [INFO] [stderr] --> src/iob.rs:561:40 [INFO] [stderr] | [INFO] [stderr] 561 | 33... 37 => Some(( 4, iob - 33 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 42` [INFO] [stderr] --> src/iob.rs:564:40 [INFO] [stderr] | [INFO] [stderr] 564 | 42... 45 => Some(( 5, iob - 42 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 50` [INFO] [stderr] --> src/iob.rs:567:40 [INFO] [stderr] | [INFO] [stderr] 567 | 50... 54 => Some(( 6, iob - 50 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 59` [INFO] [stderr] --> src/iob.rs:570:40 [INFO] [stderr] | [INFO] [stderr] 570 | 59... 62 => Some(( 7, iob - 59 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 67` [INFO] [stderr] --> src/iob.rs:572:40 [INFO] [stderr] | [INFO] [stderr] 572 | 67... 70 => Some(( 8, iob - 67 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 75` [INFO] [stderr] --> src/iob.rs:574:40 [INFO] [stderr] | [INFO] [stderr] 574 | 75... 78 => Some(( 9, iob - 75 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 83` [INFO] [stderr] --> src/iob.rs:576:40 [INFO] [stderr] | [INFO] [stderr] 576 | 83... 86 => Some((10, iob - 83 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 91` [INFO] [stderr] --> src/iob.rs:579:40 [INFO] [stderr] | [INFO] [stderr] 579 | 91... 95 => Some((11, iob - 91 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 100` [INFO] [stderr] --> src/iob.rs:582:40 [INFO] [stderr] | [INFO] [stderr] 582 | 100...103 => Some((12, iob - 100 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 108` [INFO] [stderr] --> src/iob.rs:585:40 [INFO] [stderr] | [INFO] [stderr] 585 | 108...112 => Some((13, iob - 108 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 117` [INFO] [stderr] --> src/iob.rs:588:40 [INFO] [stderr] | [INFO] [stderr] 588 | 117...120 => Some((14, iob - 117 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 125` [INFO] [stderr] --> src/iob.rs:591:40 [INFO] [stderr] | [INFO] [stderr] 591 | 125...129 => Some((15, iob - 125 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 134` [INFO] [stderr] --> src/iob.rs:593:40 [INFO] [stderr] | [INFO] [stderr] 593 | 134...138 => Some((16, iob - 134 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 143` [INFO] [stderr] --> src/iob.rs:596:40 [INFO] [stderr] | [INFO] [stderr] 596 | 143...146 => Some((17, iob - 143 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 151` [INFO] [stderr] --> src/iob.rs:599:40 [INFO] [stderr] | [INFO] [stderr] 599 | 151...155 => Some((18, iob - 151 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 160` [INFO] [stderr] --> src/iob.rs:602:40 [INFO] [stderr] | [INFO] [stderr] 602 | 160...163 => Some((19, iob - 160 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 168` [INFO] [stderr] --> src/iob.rs:605:40 [INFO] [stderr] | [INFO] [stderr] 605 | 168...172 => Some((20, iob - 168 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 177` [INFO] [stderr] --> src/iob.rs:608:40 [INFO] [stderr] | [INFO] [stderr] 608 | 177...180 => Some((21, iob - 177 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 185` [INFO] [stderr] --> src/iob.rs:611:40 [INFO] [stderr] | [INFO] [stderr] 611 | 185...189 => Some((22, iob - 185 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 194` [INFO] [stderr] --> src/iob.rs:614:40 [INFO] [stderr] | [INFO] [stderr] 614 | 194...197 => Some((23, iob - 194 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 202` [INFO] [stderr] --> src/iob.rs:616:40 [INFO] [stderr] | [INFO] [stderr] 616 | 202...205 => Some((24, iob - 202 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 210` [INFO] [stderr] --> src/iob.rs:619:40 [INFO] [stderr] | [INFO] [stderr] 619 | 210...214 => Some((25, iob - 210 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 219` [INFO] [stderr] --> src/iob.rs:622:40 [INFO] [stderr] | [INFO] [stderr] 622 | 219...222 => Some((26, iob - 219 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 227` [INFO] [stderr] --> src/iob.rs:625:40 [INFO] [stderr] | [INFO] [stderr] 625 | 227...231 => Some((27, iob - 227 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 236` [INFO] [stderr] --> src/iob.rs:628:40 [INFO] [stderr] | [INFO] [stderr] 628 | 236...239 => Some((28, iob - 236 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 244` [INFO] [stderr] --> src/iob.rs:631:40 [INFO] [stderr] | [INFO] [stderr] 631 | 244...248 => Some((29, iob - 244 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 253` [INFO] [stderr] --> src/iob.rs:634:40 [INFO] [stderr] | [INFO] [stderr] 634 | 253...256 => Some((30, iob - 253 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iob - 261` [INFO] [stderr] --> src/iob.rs:637:40 [INFO] [stderr] | [INFO] [stderr] 637 | 261...265 => Some((31, iob - 261 + 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/iob.rs:646:1 [INFO] [stderr] | [INFO] [stderr] 646 | / pub fn fb_mc_num_to_iob_num(device: XC2Device, fb: u32, mc: u32) -> Option { [INFO] [stderr] 647 | | match device { [INFO] [stderr] 648 | | XC2Device::XC2C32 | XC2Device::XC2C32A => { [INFO] [stderr] 649 | | if fb >= 2 || mc >= MCS_PER_FB as u32 { [INFO] [stderr] ... | [INFO] [stderr] 1000 | | } [INFO] [stderr] 1001 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:666:37 [INFO] [stderr] | [INFO] [stderr] 666 | 0...5 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:716:37 [INFO] [stderr] | [INFO] [stderr] 716 | 0...5 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `mc` [INFO] [stderr] --> src/iob.rs:813:37 [INFO] [stderr] | [INFO] [stderr] 813 | 0...3 => Some(0 + mc), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mc.rs:396:25 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn to_jed_small(jed: &mut JEDECFile, linebreaks: &mut LinebreakSet, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mc.rs:415:25 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn to_jed_large(jed: &mut JEDECFile, linebreaks: &mut LinebreakSet, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn num_fbs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn num_iobs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn is_small_iob(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/partdb.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn is_large_iob(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 { [INFO] [stderr] 141 | | true [INFO] [stderr] 142 | | } else { [INFO] [stderr] 143 | | false [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 152 | | package == XC2Package::QFG32 { [INFO] [stderr] 153 | | true [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | false [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 151 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 152 | package == XC2Package::QFG32 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 164 | | package == XC2Package::VQ100 { [INFO] [stderr] 165 | | true [INFO] [stderr] 166 | | } else { [INFO] [stderr] 167 | | false [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 163 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 164 | package == XC2Package::VQ100 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | / if package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 176 | | package == XC2Package::VQ100 || package == XC2Package::QFG48 { [INFO] [stderr] 177 | | true [INFO] [stderr] 178 | | } else { [INFO] [stderr] 179 | | false [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 175 | package == XC2Package::PC44 || package == XC2Package::VQ44 || package == XC2Package::CP56 || [INFO] [stderr] 176 | package == XC2Package::VQ100 || package == XC2Package::QFG48 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / if package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 { [INFO] [stderr] 188 | | true [INFO] [stderr] 189 | | } else { [INFO] [stderr] 190 | | false [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | / if package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 || [INFO] [stderr] 199 | | package == XC2Package::PQ208 || package == XC2Package::FT256 { [INFO] [stderr] 200 | | true [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | false [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 198 | package == XC2Package::VQ100 || package == XC2Package::CP132 || package == XC2Package::TQ144 || [INFO] [stderr] 199 | package == XC2Package::PQ208 || package == XC2Package::FT256 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | / if package == XC2Package::TQ144 || package == XC2Package::PQ208 || package == XC2Package::FT256 || [INFO] [stderr] 211 | | package == XC2Package::FG324 { [INFO] [stderr] 212 | | true [INFO] [stderr] 213 | | } else { [INFO] [stderr] 214 | | false [INFO] [stderr] 215 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 210 | package == XC2Package::TQ144 || package == XC2Package::PQ208 || package == XC2Package::FT256 || [INFO] [stderr] 211 | package == XC2Package::FG324 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/partdb.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | / if package == XC2Package::PQ208 || package == XC2Package::FT256 || package == XC2Package::FG324 { [INFO] [stderr] 223 | | true [INFO] [stderr] 224 | | } else { [INFO] [stderr] 225 | | false [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `package == XC2Package::PQ208 || package == XC2Package::FT256 || package == XC2Package::FG324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/partdb.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn from_str(part_name: &str) -> Option { [INFO] [stderr] 246 | | let dev; [INFO] [stderr] 247 | | let spd; [INFO] [stderr] 248 | | let pkg; [INFO] [stderr] ... | [INFO] [stderr] 321 | | }) [INFO] [stderr] 322 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `block_idx + term_idx * INPUTS_PER_ANDTERM * 2 + i * 2` [INFO] [stderr] --> src/pla.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | if !fuses[block_idx + term_idx * INPUTS_PER_ANDTERM * 2 + i * 2 + 0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pla.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn get(&self, i: usize) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `orterm_wires` [INFO] [stderr] --> src/structure.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | for i in 0..MCS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 195 | for (i, ) in orterm_wires.iter().enumerate().take(MCS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `pterm_wires` [INFO] [stderr] --> src/structure.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | for j in 0..ANDTERMS_PER_FB { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for (j, ) in pterm_wires.iter().enumerate().take(ANDTERMS_PER_FB) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `gck` [INFO] [stderr] --> src/structure.rs:232:22 [INFO] [stderr] | [INFO] [stderr] 232 | for j in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 232 | for (j, ) in gck.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `iob_idx` is used to index `to_from_iob_wires` [INFO] [stderr] --> src/structure.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | for iob_idx in 0..device.num_iobs() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (iob_idx, ) in to_from_iob_wires.iter().enumerate().take(device.num_iobs()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gts` [INFO] [stderr] --> src/structure.rs:296:18 [INFO] [stderr] | [INFO] [stderr] 296 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 296 | for (i, ) in gts.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gck` [INFO] [stderr] --> src/structure.rs:328:14 [INFO] [stderr] | [INFO] [stderr] 328 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 328 | for (i, ) in gck.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `gts` [INFO] [stderr] --> src/structure.rs:334:14 [INFO] [stderr] | [INFO] [stderr] 334 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 334 | for (i, ) in gts.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structure.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | / match zia_choice { [INFO] [stderr] 352 | | &XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 353 | | // From the XOR gate [INFO] [stderr] 354 | | connection_callback(fb_things[and_fb as usize].3[and_i as usize], [INFO] [stderr] ... | [INFO] [stderr] 379 | | _ => unreachable!(), [INFO] [stderr] 380 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 351 | match *zia_choice { [INFO] [stderr] 352 | XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 353 | // From the XOR gate [INFO] [stderr] 354 | connection_callback(fb_things[and_fb as usize].3[and_i as usize], [INFO] [stderr] 355 | fb_things[zia_fb as usize].5[zia_mc as usize], "IN", zia_row_i, [INFO] [stderr] 356 | (zia_choice_i as u32, 0)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/structure.rs:363:81 [INFO] [stderr] | [INFO] [stderr] 363 | let (iob_fb, iob_mc) = iob_num_to_fb_mc_num(device, zia_iob as u32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(zia_iob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::LinebreakSet` [INFO] [stderr] --> src/util.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Self { [INFO] [stderr] 38 | | Self { [INFO] [stderr] 39 | | map: BTreeMap::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/util.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / if next_item.is_none() { [INFO] [stderr] 71 | | None [INFO] [stderr] 72 | | } else { [INFO] [stderr] 73 | | let (&k, &v) = next_item.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 76 | | Some(k) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `next_item?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::LinebreakSet` [INFO] [stderr] --> src/util.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Self { [INFO] [stderr] 38 | | Self { [INFO] [stderr] 39 | | map: BTreeMap::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/util.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / if next_item.is_none() { [INFO] [stderr] 71 | | None [INFO] [stderr] 72 | | } else { [INFO] [stderr] 73 | | let (&k, &v) = next_item.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 76 | | Some(k) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `next_item?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/xc2structuretest.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | dev: device, spd: _, pkg: _ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/xc2structuretest.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | dev: device, spd: _, pkg: _ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `XC2DeviceSpeedPackage { dev: device, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | i + 1000000 [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | if node_ref >= 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | if wire_ref < 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | let wire_ref = wire_ref - 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:330:36 [INFO] [stderr] | [INFO] [stderr] 330 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 331 | | if !mc.clk_invert_pol { [INFO] [stderr] 332 | | cell_type = String::from("FDCP"); [INFO] [stderr] 333 | | } else { [INFO] [stderr] 334 | | cell_type = String::from("FDCP_N"); [INFO] [stderr] 335 | | } [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 330 | } else if !mc.clk_invert_pol { [INFO] [stderr] 331 | cell_type = String::from("FDCP"); [INFO] [stderr] 332 | } else { [INFO] [stderr] 333 | cell_type = String::from("FDCP_N"); [INFO] [stderr] 334 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:354:36 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 355 | | if !mc.clk_invert_pol { [INFO] [stderr] 356 | | cell_type = String::from("FTCP"); [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | cell_type = String::from("FTCP_N"); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 354 | } else if !mc.clk_invert_pol { [INFO] [stderr] 355 | cell_type = String::from("FTCP"); [INFO] [stderr] 356 | } else { [INFO] [stderr] 357 | cell_type = String::from("FTCP_N"); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:369:36 [INFO] [stderr] | [INFO] [stderr] 369 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 370 | | if !mc.clk_invert_pol { [INFO] [stderr] 371 | | cell_type = String::from("FDCPE"); [INFO] [stderr] 372 | | } else { [INFO] [stderr] 373 | | cell_type = String::from("FDCPE_N"); [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 369 | } else if !mc.clk_invert_pol { [INFO] [stderr] 370 | cell_type = String::from("FDCPE"); [INFO] [stderr] 371 | } else { [INFO] [stderr] 372 | cell_type = String::from("FDCPE_N"); [INFO] [stderr] 373 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:631:32 [INFO] [stderr] | [INFO] [stderr] 631 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 632 | | if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 633 | | let mut obuf_uses_ff = false; [INFO] [stderr] 634 | | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] ... | [INFO] [stderr] 644 | | } [INFO] [stderr] 645 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 631 | } else if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 632 | let mut obuf_uses_ff = false; [INFO] [stderr] 633 | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] 634 | obuf_uses_ff = iob.obuf_uses_ff; [INFO] [stderr] 635 | } [INFO] [stderr] 636 | if let Some(iob) = bitstream.bits.get_large_iob(iob_idx as usize) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:655:32 [INFO] [stderr] | [INFO] [stderr] 655 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 656 | | if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 657 | | let mut obuf_uses_ff = false; [INFO] [stderr] 658 | | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] ... | [INFO] [stderr] 668 | | } [INFO] [stderr] 669 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 655 | } else if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 656 | let mut obuf_uses_ff = false; [INFO] [stderr] 657 | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] 658 | obuf_uses_ff = iob.obuf_uses_ff; [INFO] [stderr] 659 | } [INFO] [stderr] 660 | if let Some(iob) = bitstream.bits.get_large_iob(iob_idx as usize) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:728:32 [INFO] [stderr] | [INFO] [stderr] 728 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 729 | | if port_idx == 0 { [INFO] [stderr] 730 | | should_add_wire = true; [INFO] [stderr] 731 | | } [INFO] [stderr] 732 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 728 | } else if port_idx == 0 { [INFO] [stderr] 729 | should_add_wire = true; [INFO] [stderr] 730 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bin/xc2jed2json.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / |node_name: &str, node_type: &str, fb: u32, idx: u32| { [INFO] [stderr] 92 | | // Start constructing the cell object [INFO] [stderr] 93 | | let mut cell_type = node_type.to_owned(); [INFO] [stderr] 94 | | let mut parameters = HashMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 397 | | node_vec.len() - 1 [INFO] [stderr] 398 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bin/xc2jed2json.rs:493:28 [INFO] [stderr] | [INFO] [stderr] 493 | if (obuf_mode.unwrap() == XC2IOBOBufMode::PushPull && port_idx == 0) || [INFO] [stderr] | ____________________________^ [INFO] [stderr] 494 | | (obuf_mode.unwrap() == XC2IOBOBufMode::CGND && port_idx == 0) { [INFO] [stderr] | |________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 493 | if !(!obuf_mode.unwrap() == XC2IOBOBufMode::PushPull && !obuf_mode.unwrap() == XC2IOBOBufMode::CGND || port_idx != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 493 | if (obuf_mode.unwrap() == XC2IOBOBufMode::PushPull || obuf_mode.unwrap() == XC2IOBOBufMode::CGND) && port_idx == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/bin/xc2jed2json.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / |node_ref: usize, wire_ref: usize, port_name: &str, port_idx: u32, extra_data: (u32, u32)| { [INFO] [stderr] 415 | | let (ref node_name, ref node_type, fb, idx) = node_vec.borrow()[node_ref]; [INFO] [stderr] 416 | | [INFO] [stderr] 417 | | let mut should_add_wire = false; [INFO] [stderr] ... | [INFO] [stderr] 749 | | } [INFO] [stderr] 750 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/xc2jed2json.rs:547:29 [INFO] [stderr] | [INFO] [stderr] 547 | / match &zia_choice { [INFO] [stderr] 548 | | &XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 549 | | // FIXME Hack [INFO] [stderr] 550 | | if bitstream.bits.get_fb()[zia_fb as usize].mcs[zia_mc as usize].fb_mode == [INFO] [stderr] ... | [INFO] [stderr] 586 | | _ => unreachable!(), [INFO] [stderr] 587 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 547 | match zia_choice { [INFO] [stderr] 548 | XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 549 | // FIXME Hack [INFO] [stderr] 550 | if bitstream.bits.get_fb()[zia_fb as usize].mcs[zia_mc as usize].fb_mode == [INFO] [stderr] 551 | XC2MCFeedbackMode::Disabled && extra_data.1 == 0 { [INFO] [stderr] 552 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/xc2jed2json.rs:598:49 [INFO] [stderr] | [INFO] [stderr] 598 | wire_bitval_2 = wire_bitval.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wire_bitval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:760:37 [INFO] [stderr] | [INFO] [stderr] 760 | AttributeVal::N(cell.connections.get("IN").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:762:37 [INFO] [stderr] | [INFO] [stderr] 762 | AttributeVal::N(cell.connections.get("IN_B").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN_B"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:767:37 [INFO] [stderr] | [INFO] [stderr] 767 | AttributeVal::N(cell.connections.get("IN").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/xc2jed2json.rs:792:64 [INFO] [stderr] | [INFO] [stderr] 792 | connections.insert(String::from("A"), vec![out[0].clone()]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/xc2structuretest.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | dev: device, spd: _, pkg: _ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/xc2structuretest.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | dev: device, spd: _, pkg: _ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `XC2DeviceSpeedPackage { dev: device, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | i + 1000000 [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | if node_ref >= 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | if wire_ref < 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/xc2structuretest.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | let wire_ref = wire_ref - 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:330:36 [INFO] [stderr] | [INFO] [stderr] 330 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 331 | | if !mc.clk_invert_pol { [INFO] [stderr] 332 | | cell_type = String::from("FDCP"); [INFO] [stderr] 333 | | } else { [INFO] [stderr] 334 | | cell_type = String::from("FDCP_N"); [INFO] [stderr] 335 | | } [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 330 | } else if !mc.clk_invert_pol { [INFO] [stderr] 331 | cell_type = String::from("FDCP"); [INFO] [stderr] 332 | } else { [INFO] [stderr] 333 | cell_type = String::from("FDCP_N"); [INFO] [stderr] 334 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:354:36 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 355 | | if !mc.clk_invert_pol { [INFO] [stderr] 356 | | cell_type = String::from("FTCP"); [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | cell_type = String::from("FTCP_N"); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 354 | } else if !mc.clk_invert_pol { [INFO] [stderr] 355 | cell_type = String::from("FTCP"); [INFO] [stderr] 356 | } else { [INFO] [stderr] 357 | cell_type = String::from("FTCP_N"); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:369:36 [INFO] [stderr] | [INFO] [stderr] 369 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 370 | | if !mc.clk_invert_pol { [INFO] [stderr] 371 | | cell_type = String::from("FDCPE"); [INFO] [stderr] 372 | | } else { [INFO] [stderr] 373 | | cell_type = String::from("FDCPE_N"); [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 369 | } else if !mc.clk_invert_pol { [INFO] [stderr] 370 | cell_type = String::from("FDCPE"); [INFO] [stderr] 371 | } else { [INFO] [stderr] 372 | cell_type = String::from("FDCPE_N"); [INFO] [stderr] 373 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:631:32 [INFO] [stderr] | [INFO] [stderr] 631 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 632 | | if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 633 | | let mut obuf_uses_ff = false; [INFO] [stderr] 634 | | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] ... | [INFO] [stderr] 644 | | } [INFO] [stderr] 645 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 631 | } else if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 632 | let mut obuf_uses_ff = false; [INFO] [stderr] 633 | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] 634 | obuf_uses_ff = iob.obuf_uses_ff; [INFO] [stderr] 635 | } [INFO] [stderr] 636 | if let Some(iob) = bitstream.bits.get_large_iob(iob_idx as usize) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:655:32 [INFO] [stderr] | [INFO] [stderr] 655 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 656 | | if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 657 | | let mut obuf_uses_ff = false; [INFO] [stderr] 658 | | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] ... | [INFO] [stderr] 668 | | } [INFO] [stderr] 669 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 655 | } else if let Some(iob_idx) = fb_mc_num_to_iob_num(bitstream.bits.device_type(), fb, idx) { [INFO] [stderr] 656 | let mut obuf_uses_ff = false; [INFO] [stderr] 657 | if let Some(iob) = bitstream.bits.get_small_iob(iob_idx as usize) { [INFO] [stderr] 658 | obuf_uses_ff = iob.obuf_uses_ff; [INFO] [stderr] 659 | } [INFO] [stderr] 660 | if let Some(iob) = bitstream.bits.get_large_iob(iob_idx as usize) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/xc2jed2json.rs:728:32 [INFO] [stderr] | [INFO] [stderr] 728 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 729 | | if port_idx == 0 { [INFO] [stderr] 730 | | should_add_wire = true; [INFO] [stderr] 731 | | } [INFO] [stderr] 732 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 728 | } else if port_idx == 0 { [INFO] [stderr] 729 | should_add_wire = true; [INFO] [stderr] 730 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bin/xc2jed2json.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / |node_name: &str, node_type: &str, fb: u32, idx: u32| { [INFO] [stderr] 92 | | // Start constructing the cell object [INFO] [stderr] 93 | | let mut cell_type = node_type.to_owned(); [INFO] [stderr] 94 | | let mut parameters = HashMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 397 | | node_vec.len() - 1 [INFO] [stderr] 398 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bin/xc2jed2json.rs:493:28 [INFO] [stderr] | [INFO] [stderr] 493 | if (obuf_mode.unwrap() == XC2IOBOBufMode::PushPull && port_idx == 0) || [INFO] [stderr] | ____________________________^ [INFO] [stderr] 494 | | (obuf_mode.unwrap() == XC2IOBOBufMode::CGND && port_idx == 0) { [INFO] [stderr] | |________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 493 | if !(!obuf_mode.unwrap() == XC2IOBOBufMode::PushPull && !obuf_mode.unwrap() == XC2IOBOBufMode::CGND || port_idx != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 493 | if (obuf_mode.unwrap() == XC2IOBOBufMode::PushPull || obuf_mode.unwrap() == XC2IOBOBufMode::CGND) && port_idx == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/bin/xc2jed2json.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / |node_ref: usize, wire_ref: usize, port_name: &str, port_idx: u32, extra_data: (u32, u32)| { [INFO] [stderr] 415 | | let (ref node_name, ref node_type, fb, idx) = node_vec.borrow()[node_ref]; [INFO] [stderr] 416 | | [INFO] [stderr] 417 | | let mut should_add_wire = false; [INFO] [stderr] ... | [INFO] [stderr] 749 | | } [INFO] [stderr] 750 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/xc2jed2json.rs:547:29 [INFO] [stderr] | [INFO] [stderr] 547 | / match &zia_choice { [INFO] [stderr] 548 | | &XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 549 | | // FIXME Hack [INFO] [stderr] 550 | | if bitstream.bits.get_fb()[zia_fb as usize].mcs[zia_mc as usize].fb_mode == [INFO] [stderr] ... | [INFO] [stderr] 586 | | _ => unreachable!(), [INFO] [stderr] 587 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 547 | match zia_choice { [INFO] [stderr] 548 | XC2ZIAInput::Macrocell{fb: zia_fb, mc: zia_mc} => { [INFO] [stderr] 549 | // FIXME Hack [INFO] [stderr] 550 | if bitstream.bits.get_fb()[zia_fb as usize].mcs[zia_mc as usize].fb_mode == [INFO] [stderr] 551 | XC2MCFeedbackMode::Disabled && extra_data.1 == 0 { [INFO] [stderr] 552 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/xc2jed2json.rs:598:49 [INFO] [stderr] | [INFO] [stderr] 598 | wire_bitval_2 = wire_bitval.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wire_bitval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:760:37 [INFO] [stderr] | [INFO] [stderr] 760 | AttributeVal::N(cell.connections.get("IN").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:762:37 [INFO] [stderr] | [INFO] [stderr] 762 | AttributeVal::N(cell.connections.get("IN_B").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN_B"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/xc2jed2json.rs:767:37 [INFO] [stderr] | [INFO] [stderr] 767 | AttributeVal::N(cell.connections.get("IN").unwrap().len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cell.connections["IN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/xc2jed2json.rs:792:64 [INFO] [stderr] | [INFO] [stderr] 792 | connections.insert(String::from("A"), vec![out[0].clone()]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.01s [INFO] running `"docker" "inspect" "91013077f7a976284f1f92b509eec8ae7915b4b97d6a2116923caf576d506d72"` [INFO] running `"docker" "rm" "-f" "91013077f7a976284f1f92b509eec8ae7915b4b97d6a2116923caf576d506d72"` [INFO] [stdout] 91013077f7a976284f1f92b509eec8ae7915b4b97d6a2116923caf576d506d72