[INFO] crate xapirpc 0.9.0 is already in cache [INFO] extracting crate xapirpc 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/xapirpc/0.9.0 [INFO] extracting crate xapirpc 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xapirpc/0.9.0 [INFO] validating manifest of xapirpc-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xapirpc-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xapirpc-0.9.0 [INFO] finished frobbing xapirpc-0.9.0 [INFO] frobbed toml for xapirpc-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/xapirpc/0.9.0/Cargo.toml [INFO] started frobbing xapirpc-0.9.0 [INFO] finished frobbing xapirpc-0.9.0 [INFO] frobbed toml for xapirpc-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xapirpc/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xapirpc-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/xapirpc/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 621a5441b63abcd3693e2f8ebbb574168da057ca67c2aacbc33121efcc7de960 [INFO] running `"docker" "start" "-a" "621a5441b63abcd3693e2f8ebbb574168da057ca67c2aacbc33121efcc7de960"` [INFO] [stderr] Checking simple-error v0.1.13 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking iso8601 v0.2.0 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking quicli v0.2.0 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking xmlrpc v0.11.1 [INFO] [stderr] Checking xapirpc v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:165:48 [INFO] [stderr] | [INFO] [stderr] 165 | let i = json::Number::from_f64(i as f64).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:165:48 [INFO] [stderr] | [INFO] [stderr] 165 | let i = json::Number::from_f64(i as f64).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const HOST: &'static str = "http://127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | const USER: &'static str = "guest"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | const PASS: &'static str = "guest"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const HOST: &'static str = "http://127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | const USER: &'static str = "guest"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | const PASS: &'static str = "guest"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let preferences = PreferencesMap::::load(&APP_INFO, "config") [INFO] [stderr] | _______________________^ [INFO] [stderr] 58 | | .unwrap_or(PreferencesMap::::new()); [INFO] [stderr] | |___________________________________________________^ help: try this: `PreferencesMap::::load(&APP_INFO, "config").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | }.map_err(|err| From::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | .or(preferences.get("host")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("host"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | .or(env.host.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.host.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | .or(preferences.get("user")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("user"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | .or(env.user.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.user.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:119:10 [INFO] [stderr] | [INFO] [stderr] 119 | .or(preferences.get("pass")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("pass"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:118:10 [INFO] [stderr] | [INFO] [stderr] 118 | .or(env.pass.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.pass.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let preferences = PreferencesMap::::load(&APP_INFO, "config") [INFO] [stderr] | _______________________^ [INFO] [stderr] 58 | | .unwrap_or(PreferencesMap::::new()); [INFO] [stderr] | |___________________________________________________^ help: try this: `PreferencesMap::::load(&APP_INFO, "config").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | }.map_err(|err| From::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | .or(preferences.get("host")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("host"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | .or(env.host.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.host.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | .or(preferences.get("user")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("user"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | .or(env.user.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.user.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:119:10 [INFO] [stderr] | [INFO] [stderr] 119 | .or(preferences.get("pass")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| preferences.get("pass"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:118:10 [INFO] [stderr] | [INFO] [stderr] 118 | .or(env.pass.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.pass.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.24s [INFO] running `"docker" "inspect" "621a5441b63abcd3693e2f8ebbb574168da057ca67c2aacbc33121efcc7de960"` [INFO] running `"docker" "rm" "-f" "621a5441b63abcd3693e2f8ebbb574168da057ca67c2aacbc33121efcc7de960"` [INFO] [stdout] 621a5441b63abcd3693e2f8ebbb574168da057ca67c2aacbc33121efcc7de960