[INFO] crate x11-screenshot 0.1.0 is already in cache [INFO] extracting crate x11-screenshot 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/x11-screenshot/0.1.0 [INFO] extracting crate x11-screenshot 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/x11-screenshot/0.1.0 [INFO] validating manifest of x11-screenshot-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of x11-screenshot-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing x11-screenshot-0.1.0 [INFO] finished frobbing x11-screenshot-0.1.0 [INFO] frobbed toml for x11-screenshot-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/x11-screenshot/0.1.0/Cargo.toml [INFO] started frobbing x11-screenshot-0.1.0 [INFO] finished frobbing x11-screenshot-0.1.0 [INFO] frobbed toml for x11-screenshot-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/x11-screenshot/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting x11-screenshot-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/x11-screenshot/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 112e3932d1e644c013ca64722fa505a32f6e831a39c2b358290fb920e861881f [INFO] running `"docker" "start" "-a" "112e3932d1e644c013ca64722fa505a32f6e831a39c2b358290fb920e861881f"` [INFO] [stderr] Compiling x11 v2.18.1 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking png v0.10.0 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking x11-screenshot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let (xc,yc,p) = pixs.next().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let (xc,yc,p) = pixs.next().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/lib.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | if(!img.is_null()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/lib.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | if(!img.is_null()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/lib.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let (xc,yc,p) = pixs.next().unwrap(); [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut img = unsafe { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `bgr` should have a camel case name such as `Bgr` [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub struct bgr { [INFO] [stderr] 17 | | b: u8, [INFO] [stderr] 18 | | g: u8, [INFO] [stderr] 19 | | r: u8, [INFO] [stderr] 20 | | _pad: u8, [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Screen` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Screen{ [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | let display = xlib::XOpenDisplay(ptr::null()); [INFO] [stderr] 27 | | let screen = xlib::XDefaultScreen(display); [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | impl Default for Screen { [INFO] [stderr] 24 | fn default() -> Self { [INFO] [stderr] 25 | Self::new() [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/lib.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let (xc,yc,p) = pixs.next().unwrap(); [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut img = unsafe { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `bgr` should have a camel case name such as `Bgr` [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub struct bgr { [INFO] [stderr] 17 | | b: u8, [INFO] [stderr] 18 | | g: u8, [INFO] [stderr] 19 | | r: u8, [INFO] [stderr] 20 | | _pad: u8, [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Screen` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Screen{ [INFO] [stderr] 25 | | unsafe { [INFO] [stderr] 26 | | let display = xlib::XOpenDisplay(ptr::null()); [INFO] [stderr] 27 | | let screen = xlib::XDefaultScreen(display); [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | impl Default for Screen { [INFO] [stderr] 24 | fn default() -> Self { [INFO] [stderr] 25 | Self::new() [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.93s [INFO] running `"docker" "inspect" "112e3932d1e644c013ca64722fa505a32f6e831a39c2b358290fb920e861881f"` [INFO] running `"docker" "rm" "-f" "112e3932d1e644c013ca64722fa505a32f6e831a39c2b358290fb920e861881f"` [INFO] [stdout] 112e3932d1e644c013ca64722fa505a32f6e831a39c2b358290fb920e861881f