[INFO] crate wurl 0.1.0 is already in cache [INFO] extracting crate wurl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wurl/0.1.0 [INFO] extracting crate wurl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wurl/0.1.0 [INFO] validating manifest of wurl-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wurl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wurl-0.1.0 [INFO] finished frobbing wurl-0.1.0 [INFO] frobbed toml for wurl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wurl/0.1.0/Cargo.toml [INFO] started frobbing wurl-0.1.0 [INFO] finished frobbing wurl-0.1.0 [INFO] frobbed toml for wurl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wurl/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wurl-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wurl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df931c9c6d13611f7eb8a0800afa163af6b7a0d22d734b1587f54219c40428d0 [INFO] running `"docker" "start" "-a" "df931c9c6d13611f7eb8a0800afa163af6b7a0d22d734b1587f54219c40428d0"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/app.rs [INFO] [stderr] * /opt/crater/workdir/src/bin/messages.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling slab v0.4.2 [INFO] [stderr] Compiling lazycell v1.2.1 [INFO] [stderr] Compiling termcolor v0.3.6 [INFO] [stderr] Compiling rprompt v1.0.3 [INFO] [stderr] Compiling smallvec v0.6.8 [INFO] [stderr] Compiling net2 v0.2.33 [INFO] [stderr] Compiling iovec v0.1.2 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling atty v0.2.11 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling bytes v0.4.11 [INFO] [stderr] Compiling clap v2.32.0 [INFO] [stderr] Compiling unicode-normalization v0.1.8 [INFO] [stderr] Compiling mio v0.6.16 [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking stderrlog v0.3.0 [INFO] [stderr] Compiling chrono v0.4.6 [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Compiling idna v0.1.5 [INFO] [stderr] Compiling url v1.7.2 [INFO] [stderr] Compiling wurl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network/ws.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network/ws.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/network/handler.rs:219:77 [INFO] [stderr] | [INFO] [stderr] 219 | fn add_headers(request_headers: &mut Vec<(String, Vec)>, input_headers: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/network/handler.rs:224:31 [INFO] [stderr] | [INFO] [stderr] 224 | request_headers.push((key.to_owned().into(), value.to_owned().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/network/handler.rs:219:77 [INFO] [stderr] | [INFO] [stderr] 219 | fn add_headers(request_headers: &mut Vec<(String, Vec)>, input_headers: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/network/handler.rs:224:31 [INFO] [stderr] | [INFO] [stderr] 224 | request_headers.push((key.to_owned().into(), value.to_owned().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/messages.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | String::from(result) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/messages.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | String::from(result) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `"docker" "inspect" "df931c9c6d13611f7eb8a0800afa163af6b7a0d22d734b1587f54219c40428d0"` [INFO] running `"docker" "rm" "-f" "df931c9c6d13611f7eb8a0800afa163af6b7a0d22d734b1587f54219c40428d0"` [INFO] [stdout] df931c9c6d13611f7eb8a0800afa163af6b7a0d22d734b1587f54219c40428d0