[INFO] crate wstcp 0.1.4 is already in cache [INFO] extracting crate wstcp 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/wstcp/0.1.4 [INFO] extracting crate wstcp 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wstcp/0.1.4 [INFO] validating manifest of wstcp-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wstcp-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wstcp-0.1.4 [INFO] finished frobbing wstcp-0.1.4 [INFO] frobbed toml for wstcp-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/wstcp/0.1.4/Cargo.toml [INFO] started frobbing wstcp-0.1.4 [INFO] finished frobbing wstcp-0.1.4 [INFO] frobbed toml for wstcp-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wstcp/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wstcp-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wstcp/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60769932a0486792ea570659bfe91fd4778bdad6bc77beecd0959a82323a9ba1 [INFO] running `"docker" "start" "-a" "60769932a0486792ea570659bfe91fd4778bdad6bc77beecd0959a82323a9ba1"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking nbchan v0.1.3 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking fibers v0.1.12 [INFO] [stderr] Checking slog-scope v4.1.1 [INFO] [stderr] Checking slog-kvfilter v0.6.1 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking trackable v0.2.21 [INFO] [stderr] Checking bytecodec v0.4.11 [INFO] [stderr] Checking slog-stdlog v3.0.2 [INFO] [stderr] Checking sloggers v0.2.9 [INFO] [stderr] Checking httpcodec v0.2.2 [INFO] [stderr] Checking wstcp v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/channel.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(RequestDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcode.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn is_control(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/channel.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(RequestDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcode.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn is_control(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.69s [INFO] running `"docker" "inspect" "60769932a0486792ea570659bfe91fd4778bdad6bc77beecd0959a82323a9ba1"` [INFO] running `"docker" "rm" "-f" "60769932a0486792ea570659bfe91fd4778bdad6bc77beecd0959a82323a9ba1"` [INFO] [stdout] 60769932a0486792ea570659bfe91fd4778bdad6bc77beecd0959a82323a9ba1