[INFO] crate world_id 0.1.0 is already in cache [INFO] extracting crate world_id 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/world_id/0.1.0 [INFO] extracting crate world_id 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/world_id/0.1.0 [INFO] validating manifest of world_id-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of world_id-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing world_id-0.1.0 [INFO] finished frobbing world_id-0.1.0 [INFO] frobbed toml for world_id-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/world_id/0.1.0/Cargo.toml [INFO] started frobbing world_id-0.1.0 [INFO] finished frobbing world_id-0.1.0 [INFO] frobbed toml for world_id-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/world_id/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting world_id-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/world_id/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bef2b3d847cf9edfd2c393c4ad450358c61f3a81b6b405fc3aadfdea37647eda [INFO] running `"docker" "start" "-a" "bef2b3d847cf9edfd2c393c4ad450358c61f3a81b6b405fc3aadfdea37647eda"` [INFO] [stderr] Compiling ring v0.13.5 [INFO] [stderr] Checking serde_cbor v0.8.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking pem v0.5.1 [INFO] [stderr] Checking hyper-multipart-rfc7578 v0.1.0-alpha3 [INFO] [stderr] Checking ipfs-api v0.4.0-alpha.3 [INFO] [stderr] Checking world_id v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:384:23 [INFO] [stderr] | [INFO] [stderr] 384 | let message = "Hello world!".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello world!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:398:32 [INFO] [stderr] | [INFO] [stderr] 398 | assert!(!new_id.verify("some random signature".as_bytes(), message)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"some random signature"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.85s [INFO] running `"docker" "inspect" "bef2b3d847cf9edfd2c393c4ad450358c61f3a81b6b405fc3aadfdea37647eda"` [INFO] running `"docker" "rm" "-f" "bef2b3d847cf9edfd2c393c4ad450358c61f3a81b6b405fc3aadfdea37647eda"` [INFO] [stdout] bef2b3d847cf9edfd2c393c4ad450358c61f3a81b6b405fc3aadfdea37647eda