[INFO] crate workctl 0.1.1 is already in cache [INFO] extracting crate workctl 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/workctl/0.1.1 [INFO] extracting crate workctl 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/workctl/0.1.1 [INFO] validating manifest of workctl-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of workctl-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing workctl-0.1.1 [INFO] finished frobbing workctl-0.1.1 [INFO] frobbed toml for workctl-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/workctl/0.1.1/Cargo.toml [INFO] started frobbing workctl-0.1.1 [INFO] finished frobbing workctl-0.1.1 [INFO] frobbed toml for workctl-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/workctl/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting workctl-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/workctl/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9086bd49e0ea7c4f34c702e932f48d3872adb73d8a22e6334c6d7df6446664e0 [INFO] running `"docker" "start" "-a" "9086bd49e0ea7c4f34c702e932f48d3872adb73d8a22e6334c6d7df6446664e0"` [INFO] [stderr] Checking workctl v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/work_queue.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sync_flag.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return (tx, rx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tx, rx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/work_queue.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sync_flag.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return (tx, rx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tx, rx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `work_queue::WorkQueue` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/work_queue.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl WorkQueue { [INFO] [stderr] 57 | | /// Creates a new, empty WorkQueue with the default capacity. [INFO] [stderr] 58 | | pub fn new() -> Self { [INFO] [stderr] 59 | | Self { inner: Arc::new(Mutex::new(VecDeque::new())) } [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `work_queue::WorkQueue` [INFO] [stderr] --> src/work_queue.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> Self { [INFO] [stderr] 59 | | Self { inner: Arc::new(Mutex::new(VecDeque::new())) } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync_flag.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let state = Arc::new(Mutex::new(initial_state)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: item `work_queue::WorkQueue` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/work_queue.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl WorkQueue { [INFO] [stderr] 57 | | /// Creates a new, empty WorkQueue with the default capacity. [INFO] [stderr] 58 | | pub fn new() -> Self { [INFO] [stderr] 59 | | Self { inner: Arc::new(Mutex::new(VecDeque::new())) } [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `work_queue::WorkQueue` [INFO] [stderr] --> src/work_queue.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> Self { [INFO] [stderr] 59 | | Self { inner: Arc::new(Mutex::new(VecDeque::new())) } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync_flag.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let state = Arc::new(Mutex::new(initial_state)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "9086bd49e0ea7c4f34c702e932f48d3872adb73d8a22e6334c6d7df6446664e0"` [INFO] running `"docker" "rm" "-f" "9086bd49e0ea7c4f34c702e932f48d3872adb73d8a22e6334c6d7df6446664e0"` [INFO] [stdout] 9086bd49e0ea7c4f34c702e932f48d3872adb73d8a22e6334c6d7df6446664e0