[INFO] crate wordnet 0.1.2 is already in cache [INFO] extracting crate wordnet 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/wordnet/0.1.2 [INFO] extracting crate wordnet 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wordnet/0.1.2 [INFO] validating manifest of wordnet-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wordnet-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wordnet-0.1.2 [INFO] finished frobbing wordnet-0.1.2 [INFO] frobbed toml for wordnet-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/wordnet/0.1.2/Cargo.toml [INFO] started frobbing wordnet-0.1.2 [INFO] finished frobbing wordnet-0.1.2 [INFO] frobbed toml for wordnet-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wordnet/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wordnet-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wordnet/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a256096ed0369e5fd9e34363f461f284f5a705ecbfa22445efc635f187ee3eb [INFO] running `"docker" "start" "-a" "6a256096ed0369e5fd9e34363f461f284f5a705ecbfa22445efc635f187ee3eb"` [INFO] [stderr] Checking wordnet v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:280:4 [INFO] [stderr] | [INFO] [stderr] 280 | index_size: index_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:282:4 [INFO] [stderr] | [INFO] [stderr] 282 | part_of_speech : part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:6 [INFO] [stderr] | [INFO] [stderr] 447 | part_of_speech: part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:6 [INFO] [stderr] | [INFO] [stderr] 448 | offset : offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:471:4 [INFO] [stderr] | [INFO] [stderr] 471 | part_of_speech: part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:473:4 [INFO] [stderr] | [INFO] [stderr] 473 | synonyms: synonyms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `synonyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:474:4 [INFO] [stderr] | [INFO] [stderr] 474 | pointers: pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:280:4 [INFO] [stderr] | [INFO] [stderr] 280 | index_size: index_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:282:4 [INFO] [stderr] | [INFO] [stderr] 282 | part_of_speech : part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:6 [INFO] [stderr] | [INFO] [stderr] 447 | part_of_speech: part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:6 [INFO] [stderr] | [INFO] [stderr] 448 | offset : offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:471:4 [INFO] [stderr] | [INFO] [stderr] 471 | part_of_speech: part_of_speech, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_of_speech` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:473:4 [INFO] [stderr] | [INFO] [stderr] 473 | synonyms: synonyms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `synonyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:474:4 [INFO] [stderr] | [INFO] [stderr] 474 | pointers: pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:3 [INFO] [stderr] | [INFO] [stderr] 310 | return self.is_found_here( [INFO] [stderr] | _________^ [INFO] [stderr] 311 | | pos + data.len() as u64, [INFO] [stderr] 312 | | &block[0..bytes], [INFO] [stderr] 313 | | &remaining_word[data.len()..] [INFO] [stderr] 314 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 310 | self.is_found_here( [INFO] [stderr] 311 | pos + data.len() as u64, [INFO] [stderr] 312 | &block[0..bytes], [INFO] [stderr] 313 | &remaining_word[data.len()..] [INFO] [stderr] 314 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:466:4 [INFO] [stderr] | [INFO] [stderr] 466 | gloss [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:465:16 [INFO] [stderr] | [INFO] [stderr] 465 | let gloss = &line_utf[line_utf.find('|').unwrap()+2..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:483:3 [INFO] [stderr] | [INFO] [stderr] 483 | if offset.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `offset?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:3 [INFO] [stderr] | [INFO] [stderr] 310 | return self.is_found_here( [INFO] [stderr] | _________^ [INFO] [stderr] 311 | | pos + data.len() as u64, [INFO] [stderr] 312 | | &block[0..bytes], [INFO] [stderr] 313 | | &remaining_word[data.len()..] [INFO] [stderr] 314 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 310 | self.is_found_here( [INFO] [stderr] 311 | pos + data.len() as u64, [INFO] [stderr] 312 | &block[0..bytes], [INFO] [stderr] 313 | &remaining_word[data.len()..] [INFO] [stderr] 314 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:466:4 [INFO] [stderr] | [INFO] [stderr] 466 | gloss [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:465:16 [INFO] [stderr] | [INFO] [stderr] 465 | let gloss = &line_utf[line_utf.find('|').unwrap()+2..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:544:28 [INFO] [stderr] | [INFO] [stderr] 544 | if path_buf.file_stem().unwrap_or(std::ffi::OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::ffi::OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:547:35 [INFO] [stderr] | [INFO] [stderr] 547 | let ex = path_buf.extension().ok_or(std::io::Error::new( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 548 | | std::io::ErrorKind::InvalidData, [INFO] [stderr] 549 | | "file with invalid part of speech".to_string() [INFO] [stderr] 550 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 547 | let ex = path_buf.extension().ok_or_else(|| std::io::Error::new( [INFO] [stderr] 548 | std::io::ErrorKind::InvalidData, [INFO] [stderr] 549 | "file with invalid part of speech".to_string() [INFO] [stderr] 550 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:578:6 [INFO] [stderr] | [INFO] [stderr] 578 | if db.db_files.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `db.db_files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:594:7 [INFO] [stderr] | [INFO] [stderr] 594 | for ref db in &self.db_files [INFO] [stderr] | ^^^^^^ -------------- help: try: `let db = &&self.db_files;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:483:3 [INFO] [stderr] | [INFO] [stderr] 483 | if offset.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `offset?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:544:28 [INFO] [stderr] | [INFO] [stderr] 544 | if path_buf.file_stem().unwrap_or(std::ffi::OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::ffi::OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:547:35 [INFO] [stderr] | [INFO] [stderr] 547 | let ex = path_buf.extension().ok_or(std::io::Error::new( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 548 | | std::io::ErrorKind::InvalidData, [INFO] [stderr] 549 | | "file with invalid part of speech".to_string() [INFO] [stderr] 550 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 547 | let ex = path_buf.extension().ok_or_else(|| std::io::Error::new( [INFO] [stderr] 548 | std::io::ErrorKind::InvalidData, [INFO] [stderr] 549 | "file with invalid part of speech".to_string() [INFO] [stderr] 550 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:578:6 [INFO] [stderr] | [INFO] [stderr] 578 | if db.db_files.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `db.db_files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:594:7 [INFO] [stderr] | [INFO] [stderr] 594 | for ref db in &self.db_files [INFO] [stderr] | ^^^^^^ -------------- help: try: `let db = &&self.db_files;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/senses.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let s = if acc.len()==0 { "" } else { ", " }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/senses.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | let s = if acc.len()==0 { "" } else { ", " }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "6a256096ed0369e5fd9e34363f461f284f5a705ecbfa22445efc635f187ee3eb"` [INFO] running `"docker" "rm" "-f" "6a256096ed0369e5fd9e34363f461f284f5a705ecbfa22445efc635f187ee3eb"` [INFO] [stdout] 6a256096ed0369e5fd9e34363f461f284f5a705ecbfa22445efc635f187ee3eb