[INFO] crate word_replace 0.0.3 is already in cache [INFO] extracting crate word_replace 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/word_replace/0.0.3 [INFO] extracting crate word_replace 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/word_replace/0.0.3 [INFO] validating manifest of word_replace-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of word_replace-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing word_replace-0.0.3 [INFO] finished frobbing word_replace-0.0.3 [INFO] frobbed toml for word_replace-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/word_replace/0.0.3/Cargo.toml [INFO] started frobbing word_replace-0.0.3 [INFO] finished frobbing word_replace-0.0.3 [INFO] frobbed toml for word_replace-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/word_replace/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting word_replace-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/word_replace/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7dbd683d7e26b020d96a47b5cf84ea2604fbb41b5cb6b962d9a1443d1a6258d [INFO] running `"docker" "start" "-a" "b7dbd683d7e26b020d96a47b5cf84ea2604fbb41b5cb6b962d9a1443d1a6258d"` [INFO] [stderr] Checking word_replace v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/word_replace_tools.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | else { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 154 | | if postpos_is_korean && show_warning { [INFO] [stderr] 155 | | println!("warning: undefined korean postposition at {}: {}{} => {}{}", [INFO] [stderr] 156 | | src_filepath.to_str().unwrap(), m.as_str(), postpos, [INFO] [stderr] 157 | | word, postpos); [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | else if postpos_is_korean && show_warning { [INFO] [stderr] 154 | println!("warning: undefined korean postposition at {}: {}{} => {}{}", [INFO] [stderr] 155 | src_filepath.to_str().unwrap(), m.as_str(), postpos, [INFO] [stderr] 156 | word, postpos); [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/word_replace_tools.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | else { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 154 | | if postpos_is_korean && show_warning { [INFO] [stderr] 155 | | println!("warning: undefined korean postposition at {}: {}{} => {}{}", [INFO] [stderr] 156 | | src_filepath.to_str().unwrap(), m.as_str(), postpos, [INFO] [stderr] 157 | | word, postpos); [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | else if postpos_is_korean && show_warning { [INFO] [stderr] 154 | println!("warning: undefined korean postposition at {}: {}{} => {}{}", [INFO] [stderr] 155 | src_filepath.to_str().unwrap(), m.as_str(), postpos, [INFO] [stderr] 156 | word, postpos); [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / if let &Value::Table(ref dic_table) = toml_value { [INFO] [stderr] 24 | | match dic_table.get(language) { [INFO] [stderr] 25 | | Some(dic_contents) => { [INFO] [stderr] 26 | | if let Value::Table(ref dic) = *dic_contents { [INFO] [stderr] ... | [INFO] [stderr] 44 | | Err("cannot find toml tables") [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | if let Value::Table(ref dic_table) = *toml_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | / match *translate { [INFO] [stderr] 29 | | Value::String(ref x) => { [INFO] [stderr] 30 | | dictionary_map.insert(keyword.clone(), x.clone()); [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | _ => (), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Value::String(ref x) = *translate { [INFO] [stderr] 29 | dictionary_map.insert(keyword.clone(), x.clone()); [INFO] [stderr] 30 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / if let &Value::Table(ref all_tables) = toml_value { [INFO] [stderr] 83 | | match all_tables.get(&(String::from(language) + "-postpos")) { [INFO] [stderr] 84 | | Some(postpos_contents) => { [INFO] [stderr] 85 | | let postpos_table = match postpos_contents { &Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 101 | | None [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | if let Value::Table(ref all_tables) = *toml_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | let postpos_table = match postpos_contents { &Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let postpos_table = match *postpos_contents { Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | let postpos_pairs_toml = match postpos_table.get("postpos").unwrap() { &Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | let postpos_pairs_toml = match *postpos_table.get("postpos").unwrap() { Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | let p = match pair { &Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | let p = match *pair { Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | let left = match p.get(0).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | let left = match *p.get(0).unwrap() { Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/word_replace_tools.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | let left = match p.get(0).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&p[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let right = match p.get(1).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | let right = match *p.get(1).unwrap() { Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/word_replace_tools.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | let right = match p.get(1).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&p[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match src_read_result { [INFO] [stderr] 116 | | Err(_) => { [INFO] [stderr] 117 | | if show_warning { [INFO] [stderr] 118 | | println!("{} is not a text file, so just copied.", src_filepath.to_str().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 123 | | _ => {}, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Err(_) = src_read_result { [INFO] [stderr] 116 | if show_warning { [INFO] [stderr] 117 | println!("{} is not a text file, so just copied.", src_filepath.to_str().unwrap()); [INFO] [stderr] 118 | file_copy(src_filepath, dst_filepath).expect("failed to copy file"); [INFO] [stderr] 119 | return; [INFO] [stderr] 120 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | / match next { [INFO] [stderr] 141 | | Some(postpos) => { [INFO] [stderr] 142 | | let found_postpos_pair = postpos_pairs.find(postpos); [INFO] [stderr] 143 | | let (word_is_korean, word_has_final_jamo) = [INFO] [stderr] ... | [INFO] [stderr] 162 | | None => {}, [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(postpos) = next { [INFO] [stderr] 141 | let found_postpos_pair = postpos_pairs.find(postpos); [INFO] [stderr] 142 | let (word_is_korean, word_has_final_jamo) = [INFO] [stderr] 143 | is_korean_character_and_has_final_jamo(word.chars().last().unwrap()); [INFO] [stderr] 144 | let (postpos_is_korean, _) = [INFO] [stderr] 145 | is_korean_character_and_has_final_jamo(postpos.chars().next().unwrap()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let postpos_pairs_option = match postpos_pairs { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 48 | | Some(ref s) => Some(s), [INFO] [stderr] 49 | | None => None, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ help: try this: `postpos_pairs.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / if let &Value::Table(ref dic_table) = toml_value { [INFO] [stderr] 24 | | match dic_table.get(language) { [INFO] [stderr] 25 | | Some(dic_contents) => { [INFO] [stderr] 26 | | if let Value::Table(ref dic) = *dic_contents { [INFO] [stderr] ... | [INFO] [stderr] 44 | | Err("cannot find toml tables") [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | if let Value::Table(ref dic_table) = *toml_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | / match *translate { [INFO] [stderr] 29 | | Value::String(ref x) => { [INFO] [stderr] 30 | | dictionary_map.insert(keyword.clone(), x.clone()); [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | _ => (), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Value::String(ref x) = *translate { [INFO] [stderr] 29 | dictionary_map.insert(keyword.clone(), x.clone()); [INFO] [stderr] 30 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / if let &Value::Table(ref all_tables) = toml_value { [INFO] [stderr] 83 | | match all_tables.get(&(String::from(language) + "-postpos")) { [INFO] [stderr] 84 | | Some(postpos_contents) => { [INFO] [stderr] 85 | | let postpos_table = match postpos_contents { &Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 101 | | None [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | if let Value::Table(ref all_tables) = *toml_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | let postpos_table = match postpos_contents { &Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let postpos_table = match *postpos_contents { Value::Table(ref t) => Some(t), _ => None }.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | let postpos_pairs_toml = match postpos_table.get("postpos").unwrap() { &Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | let postpos_pairs_toml = match *postpos_table.get("postpos").unwrap() { Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | let p = match pair { &Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | let p = match *pair { Value::Array(ref t) => Some(t), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | let left = match p.get(0).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | let left = match *p.get(0).unwrap() { Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/word_replace_tools.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | let left = match p.get(0).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&p[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/word_replace_tools.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let right = match p.get(1).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | let right = match *p.get(1).unwrap() { Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/word_replace_tools.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | let right = match p.get(1).unwrap() { &Value::String(ref s) => Some(s), _ => None}.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&p[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match src_read_result { [INFO] [stderr] 116 | | Err(_) => { [INFO] [stderr] 117 | | if show_warning { [INFO] [stderr] 118 | | println!("{} is not a text file, so just copied.", src_filepath.to_str().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 123 | | _ => {}, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Err(_) = src_read_result { [INFO] [stderr] 116 | if show_warning { [INFO] [stderr] 117 | println!("{} is not a text file, so just copied.", src_filepath.to_str().unwrap()); [INFO] [stderr] 118 | file_copy(src_filepath, dst_filepath).expect("failed to copy file"); [INFO] [stderr] 119 | return; [INFO] [stderr] 120 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/word_replace_tools.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | / match next { [INFO] [stderr] 141 | | Some(postpos) => { [INFO] [stderr] 142 | | let found_postpos_pair = postpos_pairs.find(postpos); [INFO] [stderr] 143 | | let (word_is_korean, word_has_final_jamo) = [INFO] [stderr] ... | [INFO] [stderr] 162 | | None => {}, [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(postpos) = next { [INFO] [stderr] 141 | let found_postpos_pair = postpos_pairs.find(postpos); [INFO] [stderr] 142 | let (word_is_korean, word_has_final_jamo) = [INFO] [stderr] 143 | is_korean_character_and_has_final_jamo(word.chars().last().unwrap()); [INFO] [stderr] 144 | let (postpos_is_korean, _) = [INFO] [stderr] 145 | is_korean_character_and_has_final_jamo(postpos.chars().next().unwrap()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let postpos_pairs_option = match postpos_pairs { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 48 | | Some(ref s) => Some(s), [INFO] [stderr] 49 | | None => None, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ help: try this: `postpos_pairs.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `"docker" "inspect" "b7dbd683d7e26b020d96a47b5cf84ea2604fbb41b5cb6b962d9a1443d1a6258d"` [INFO] running `"docker" "rm" "-f" "b7dbd683d7e26b020d96a47b5cf84ea2604fbb41b5cb6b962d9a1443d1a6258d"` [INFO] [stdout] b7dbd683d7e26b020d96a47b5cf84ea2604fbb41b5cb6b962d9a1443d1a6258d