[INFO] crate word2vec 0.3.0 is already in cache [INFO] extracting crate word2vec 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/word2vec/0.3.0 [INFO] extracting crate word2vec 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/word2vec/0.3.0 [INFO] validating manifest of word2vec-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of word2vec-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing word2vec-0.3.0 [INFO] removed 1 missing tests [INFO] finished frobbing word2vec-0.3.0 [INFO] frobbed toml for word2vec-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/word2vec/0.3.0/Cargo.toml [INFO] started frobbing word2vec-0.3.0 [INFO] removed 1 missing tests [INFO] finished frobbing word2vec-0.3.0 [INFO] frobbed toml for word2vec-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/word2vec/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting word2vec-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/word2vec/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b05729b7964105552e58baee2e4618999f3d9df6d4f82bcc36846006b87ba68 [INFO] running `"docker" "start" "-a" "6b05729b7964105552e58baee2e4618999f3d9df6d4f82bcc36846006b87ba68"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/tests.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking word2vec v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordvectors.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | vocabulary: vocabulary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vocabulary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordvectors.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | vector_size: vector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordclusters.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(WordClusters { clusters: clusters }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `clusters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordvectors.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | vocabulary: vocabulary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vocabulary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordvectors.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | vector_size: vector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wordclusters.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(WordClusters { clusters: clusters }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `clusters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/wordvectors.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | Some(metrics[1..n+1].iter().map(|&(idx, dist)| [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wordvectors.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.get_vector(word) { [INFO] [stderr] 98 | | Some(val) => vectors.push(val.clone()), [INFO] [stderr] 99 | | None => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = self.get_vector(word) { vectors.push(val.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wordvectors.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.get_vector(word) { [INFO] [stderr] 105 | | Some(val) => vectors.push(val.iter().map(|x| -x).collect::>()), [INFO] [stderr] 106 | | None => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = self.get_vector(word) { vectors.push(val.iter().map(|x| -x).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/wordvectors.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn get_words<'a>(&'a self) -> Words<'a> { [INFO] [stderr] 137 | | Words::new(&self.vocabulary) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/wordvectors.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | fn new(x: &'a Vec<(String, Vec)>) -> Words<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Vec)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/wordclusters.rs:24:62 [INFO] [stderr] | [INFO] [stderr] 24 | let cluster = clusters.entry(cluster_number).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn dot_product(arr1: &Vec, arr2: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn dot_product(arr1: &Vec, arr2: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/wordvectors.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | Some(metrics[1..n+1].iter().map(|&(idx, dist)| [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wordvectors.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.get_vector(word) { [INFO] [stderr] 98 | | Some(val) => vectors.push(val.clone()), [INFO] [stderr] 99 | | None => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = self.get_vector(word) { vectors.push(val.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wordvectors.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.get_vector(word) { [INFO] [stderr] 105 | | Some(val) => vectors.push(val.iter().map(|x| -x).collect::>()), [INFO] [stderr] 106 | | None => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(val) = self.get_vector(word) { vectors.push(val.iter().map(|x| -x).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/wordvectors.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn get_words<'a>(&'a self) -> Words<'a> { [INFO] [stderr] 137 | | Words::new(&self.vocabulary) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/wordvectors.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | fn new(x: &'a Vec<(String, Vec)>) -> Words<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Vec)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/wordclusters.rs:24:62 [INFO] [stderr] | [INFO] [stderr] 24 | let cluster = clusters.entry(cluster_number).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn dot_product(arr1: &Vec, arr2: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn dot_product(arr1: &Vec, arr2: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "6b05729b7964105552e58baee2e4618999f3d9df6d4f82bcc36846006b87ba68"` [INFO] running `"docker" "rm" "-f" "6b05729b7964105552e58baee2e4618999f3d9df6d4f82bcc36846006b87ba68"` [INFO] [stdout] 6b05729b7964105552e58baee2e4618999f3d9df6d4f82bcc36846006b87ba68