[INFO] crate wonder 0.1.0 is already in cache [INFO] extracting crate wonder 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wonder/0.1.0 [INFO] extracting crate wonder 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wonder/0.1.0 [INFO] validating manifest of wonder-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wonder-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wonder-0.1.0 [INFO] finished frobbing wonder-0.1.0 [INFO] frobbed toml for wonder-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wonder/0.1.0/Cargo.toml [INFO] started frobbing wonder-0.1.0 [INFO] finished frobbing wonder-0.1.0 [INFO] frobbed toml for wonder-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wonder/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wonder-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wonder/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4bda5991909fe61ace6c97ad7432b355b2ffaf2d221b1ea194b156773cf96ca [INFO] running `"docker" "start" "-a" "b4bda5991909fe61ace6c97ad7432b355b2ffaf2d221b1ea194b156773cf96ca"` [INFO] [stderr] Checking wonder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actor.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/actor.rs:101:40 [INFO] [stderr] | [INFO] [stderr] 101 | let thread_name = name.clone().unwrap_or("GenServer".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "GenServer".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actor.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self { [INFO] [stderr] 239 | | &Message::Call(ref msg) => write!(f, "CALL: {:?}", msg), [INFO] [stderr] 240 | | &Message::Cast(ref msg) => write!(f, "CAST: {:?}", msg), [INFO] [stderr] 241 | | &Message::Reply(ref msg) => write!(f, "REPLY: {:?}", msg), [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *self { [INFO] [stderr] 239 | Message::Call(ref msg) => write!(f, "CALL: {:?}", msg), [INFO] [stderr] 240 | Message::Cast(ref msg) => write!(f, "CAST: {:?}", msg), [INFO] [stderr] 241 | Message::Reply(ref msg) => write!(f, "REPLY: {:?}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/actor.rs:101:40 [INFO] [stderr] | [INFO] [stderr] 101 | let thread_name = name.clone().unwrap_or("GenServer".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "GenServer".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actor.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self { [INFO] [stderr] 239 | | &Message::Call(ref msg) => write!(f, "CALL: {:?}", msg), [INFO] [stderr] 240 | | &Message::Cast(ref msg) => write!(f, "CAST: {:?}", msg), [INFO] [stderr] 241 | | &Message::Reply(ref msg) => write!(f, "REPLY: {:?}", msg), [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *self { [INFO] [stderr] 239 | Message::Call(ref msg) => write!(f, "CALL: {:?}", msg), [INFO] [stderr] 240 | Message::Cast(ref msg) => write!(f, "CAST: {:?}", msg), [INFO] [stderr] 241 | Message::Reply(ref msg) => write!(f, "REPLY: {:?}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "b4bda5991909fe61ace6c97ad7432b355b2ffaf2d221b1ea194b156773cf96ca"` [INFO] running `"docker" "rm" "-f" "b4bda5991909fe61ace6c97ad7432b355b2ffaf2d221b1ea194b156773cf96ca"` [INFO] [stdout] b4bda5991909fe61ace6c97ad7432b355b2ffaf2d221b1ea194b156773cf96ca