[INFO] crate wombo 0.1.2 is already in cache [INFO] extracting crate wombo 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/wombo/0.1.2 [INFO] extracting crate wombo 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wombo/0.1.2 [INFO] validating manifest of wombo-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wombo-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wombo-0.1.2 [INFO] finished frobbing wombo-0.1.2 [INFO] frobbed toml for wombo-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/wombo/0.1.2/Cargo.toml [INFO] started frobbing wombo-0.1.2 [INFO] finished frobbing wombo-0.1.2 [INFO] frobbed toml for wombo-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wombo/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wombo-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wombo/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cddfd652191fded436c2f97604f280be882bda9b8337948a9546ea243c49262f [INFO] running `"docker" "start" "-a" "cddfd652191fded436c2f97604f280be882bda9b8337948a9546ea243c49262f"` [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking pretty_env_logger v0.1.1 [INFO] [stderr] Checking wombo v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/utils.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | pub type ExitSender = OneshotSender>; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | id_guard.deref().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*id_guard.deref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/lib.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | pub type CancelHookFt = Box>; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Wombo` [INFO] [stderr] --> src/lib.rs:251:3 [INFO] [stderr] | [INFO] [stderr] 251 | / pub fn new() -> Wombo { [INFO] [stderr] 252 | | Wombo { [INFO] [stderr] 253 | | id: Arc::new(utils::uuid_v4()), [INFO] [stderr] 254 | | core_thread_id: Arc::new(RwLock::new(None)), [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | let _ = utils::check_not_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | let _ = utils::check_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | let _ = utils::check_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/utils.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | pub type ExitSender = OneshotSender>; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | id_guard.deref().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*id_guard.deref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/lib.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | pub type CancelHookFt = Box>; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Wombo` [INFO] [stderr] --> src/lib.rs:251:3 [INFO] [stderr] | [INFO] [stderr] 251 | / pub fn new() -> Wombo { [INFO] [stderr] 252 | | Wombo { [INFO] [stderr] 253 | | id: Arc::new(utils::uuid_v4()), [INFO] [stderr] 254 | | core_thread_id: Arc::new(RwLock::new(None)), [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | let _ = utils::check_not_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | let _ = utils::check_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | let _ = utils::check_initialized(&self.core_thread_id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/timer.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | let foo = 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> examples/timer.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | let bar = 2; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.28s [INFO] running `"docker" "inspect" "cddfd652191fded436c2f97604f280be882bda9b8337948a9546ea243c49262f"` [INFO] running `"docker" "rm" "-f" "cddfd652191fded436c2f97604f280be882bda9b8337948a9546ea243c49262f"` [INFO] [stdout] cddfd652191fded436c2f97604f280be882bda9b8337948a9546ea243c49262f