[INFO] crate wkdr 0.2.0 is already in cache [INFO] extracting crate wkdr 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/wkdr/0.2.0 [INFO] extracting crate wkdr 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wkdr/0.2.0 [INFO] validating manifest of wkdr-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wkdr-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wkdr-0.2.0 [INFO] finished frobbing wkdr-0.2.0 [INFO] frobbed toml for wkdr-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/wkdr/0.2.0/Cargo.toml [INFO] started frobbing wkdr-0.2.0 [INFO] finished frobbing wkdr-0.2.0 [INFO] frobbed toml for wkdr-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wkdr/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wkdr-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wkdr/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97c5baa65a20b6b21d95d58520c12f7e109a868dd9c3a58cfb8586893869681e [INFO] running `"docker" "start" "-a" "97c5baa65a20b6b21d95d58520c12f7e109a868dd9c3a58cfb8586893869681e"` [INFO] [stderr] Checking wikibase v0.2.0 [INFO] [stderr] Checking wkdr v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | print!("Unknown / Some value\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | print!("No value\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | print!("Unknown / Some value\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | print!("No value\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | print!("==================================================\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/input.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | comma_separated_ids.split(",").map(|entity| entity.to_string()).collect() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/input.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn all_ids_valid(entities: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/input.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match all_ids_valid(&entities) { [INFO] [stderr] 45 | | true => Ok(entities), [INFO] [stderr] 46 | | false => Err(CliError::Input("Not all entities are valid Wikibase Ids".to_string())) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if all_ids_valid(&entities) { Ok(entities) } else { Err(CliError::Input("Not all entities are valid Wikibase Ids".to_string())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if *entity.missing() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entity.missing()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match entity.description_in_locale(&query.lang()) { [INFO] [stderr] 53 | | Some(value) => print!(" - {}", value), [INFO] [stderr] 54 | | None => {} [INFO] [stderr] 55 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(value) = entity.description_in_locale(&query.lang()) { print!(" - {}", value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | if *entity.missing() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entity.missing()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | alias_string.push_str(&format!("{}", value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if alias_string.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!alias_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if entity.claims().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entity.claims().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / match snak.snak_type() { [INFO] [stderr] 89 | | &SnakType::UnknownValue => { [INFO] [stderr] 90 | | print!("Unknown / Some value\n"); [INFO] [stderr] 91 | | continue [INFO] [stderr] ... | [INFO] [stderr] 97 | | &SnakType::Value => {} [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *snak.snak_type() { [INFO] [stderr] 89 | SnakType::UnknownValue => { [INFO] [stderr] 90 | print!("Unknown / Some value\n"); [INFO] [stderr] 91 | continue [INFO] [stderr] 92 | } [INFO] [stderr] 93 | SnakType::NoValue => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | let data_value = match snak.data_value() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 101 | | &Some(ref value) => value, [INFO] [stderr] 102 | | &None => return [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | let data_value = match *snak.data_value() { [INFO] [stderr] 101 | Some(ref value) => value, [INFO] [stderr] 102 | None => return [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / match data_value.value() { [INFO] [stderr] 106 | | &Value::Coordinate(ref value) => { [INFO] [stderr] 107 | | print!("{} °N ", RGB(200, 0, 0).paint(value.latitude().to_string())); [INFO] [stderr] 108 | | print!("{} °E", RGB(200, 0, 0).paint(value.longitude().to_string())); [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *data_value.value() { [INFO] [stderr] 106 | Value::Coordinate(ref value) => { [INFO] [stderr] 107 | print!("{} °N ", RGB(200, 0, 0).paint(value.latitude().to_string())); [INFO] [stderr] 108 | print!("{} °E", RGB(200, 0, 0).paint(value.longitude().to_string())); [INFO] [stderr] 109 | } [INFO] [stderr] 110 | Value::Entity(ref value) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match result.description() { [INFO] [stderr] 171 | | &Some(ref description) => print!("{} ", description.value()), [INFO] [stderr] 172 | | &None => print!("{} ", RGB(100, 100, 100).paint("(No description)")) [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 170 | match *result.description() { [INFO] [stderr] 171 | Some(ref description) => print!("{} ", description.value()), [INFO] [stderr] 172 | None => print!("{} ", RGB(100, 100, 100).paint("(No description)")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match result.aliases() { [INFO] [stderr] 176 | | &Some(ref aliases) => { [INFO] [stderr] 177 | | for alias in aliases.values() { [INFO] [stderr] 178 | | print!("{}, ", RGB(190, 40, 30).paint(alias.to_string())); [INFO] [stderr] ... | [INFO] [stderr] 181 | | &None => print!("{} ", RGB(100, 100, 100).paint("(No aliases)")) [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *result.aliases() { [INFO] [stderr] 176 | Some(ref aliases) => { [INFO] [stderr] 177 | for alias in aliases.values() { [INFO] [stderr] 178 | print!("{}, ", RGB(190, 40, 30).paint(alias.to_string())); [INFO] [stderr] 179 | } [INFO] [stderr] 180 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / match matches.value_of(input) { [INFO] [stderr] 296 | | Some(value) => { [INFO] [stderr] 297 | | process_input(&value, &matches, &configuration); [INFO] [stderr] 298 | | return [INFO] [stderr] 299 | | }, [INFO] [stderr] 300 | | None => {} [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | if let Some(value) = matches.value_of(input) { [INFO] [stderr] 296 | process_input(&value, &matches, &configuration); [INFO] [stderr] 297 | return [INFO] [stderr] 298 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/input.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | comma_separated_ids.split(",").map(|entity| entity.to_string()).collect() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/input.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn all_ids_valid(entities: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/input.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match all_ids_valid(&entities) { [INFO] [stderr] 45 | | true => Ok(entities), [INFO] [stderr] 46 | | false => Err(CliError::Input("Not all entities are valid Wikibase Ids".to_string())) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if all_ids_valid(&entities) { Ok(entities) } else { Err(CliError::Input("Not all entities are valid Wikibase Ids".to_string())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if *entity.missing() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entity.missing()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match entity.description_in_locale(&query.lang()) { [INFO] [stderr] 53 | | Some(value) => print!(" - {}", value), [INFO] [stderr] 54 | | None => {} [INFO] [stderr] 55 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(value) = entity.description_in_locale(&query.lang()) { print!(" - {}", value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | if *entity.missing() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entity.missing()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | alias_string.push_str(&format!("{}", value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if alias_string.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!alias_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if entity.claims().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entity.claims().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / match snak.snak_type() { [INFO] [stderr] 89 | | &SnakType::UnknownValue => { [INFO] [stderr] 90 | | print!("Unknown / Some value\n"); [INFO] [stderr] 91 | | continue [INFO] [stderr] ... | [INFO] [stderr] 97 | | &SnakType::Value => {} [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *snak.snak_type() { [INFO] [stderr] 89 | SnakType::UnknownValue => { [INFO] [stderr] 90 | print!("Unknown / Some value\n"); [INFO] [stderr] 91 | continue [INFO] [stderr] 92 | } [INFO] [stderr] 93 | SnakType::NoValue => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | let data_value = match snak.data_value() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 101 | | &Some(ref value) => value, [INFO] [stderr] 102 | | &None => return [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | let data_value = match *snak.data_value() { [INFO] [stderr] 101 | Some(ref value) => value, [INFO] [stderr] 102 | None => return [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / match data_value.value() { [INFO] [stderr] 106 | | &Value::Coordinate(ref value) => { [INFO] [stderr] 107 | | print!("{} °N ", RGB(200, 0, 0).paint(value.latitude().to_string())); [INFO] [stderr] 108 | | print!("{} °E", RGB(200, 0, 0).paint(value.longitude().to_string())); [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *data_value.value() { [INFO] [stderr] 106 | Value::Coordinate(ref value) => { [INFO] [stderr] 107 | print!("{} °N ", RGB(200, 0, 0).paint(value.latitude().to_string())); [INFO] [stderr] 108 | print!("{} °E", RGB(200, 0, 0).paint(value.longitude().to_string())); [INFO] [stderr] 109 | } [INFO] [stderr] 110 | Value::Entity(ref value) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match result.description() { [INFO] [stderr] 171 | | &Some(ref description) => print!("{} ", description.value()), [INFO] [stderr] 172 | | &None => print!("{} ", RGB(100, 100, 100).paint("(No description)")) [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 170 | match *result.description() { [INFO] [stderr] 171 | Some(ref description) => print!("{} ", description.value()), [INFO] [stderr] 172 | None => print!("{} ", RGB(100, 100, 100).paint("(No description)")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match result.aliases() { [INFO] [stderr] 176 | | &Some(ref aliases) => { [INFO] [stderr] 177 | | for alias in aliases.values() { [INFO] [stderr] 178 | | print!("{}, ", RGB(190, 40, 30).paint(alias.to_string())); [INFO] [stderr] ... | [INFO] [stderr] 181 | | &None => print!("{} ", RGB(100, 100, 100).paint("(No aliases)")) [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *result.aliases() { [INFO] [stderr] 176 | Some(ref aliases) => { [INFO] [stderr] 177 | for alias in aliases.values() { [INFO] [stderr] 178 | print!("{}, ", RGB(190, 40, 30).paint(alias.to_string())); [INFO] [stderr] 179 | } [INFO] [stderr] 180 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / match matches.value_of(input) { [INFO] [stderr] 296 | | Some(value) => { [INFO] [stderr] 297 | | process_input(&value, &matches, &configuration); [INFO] [stderr] 298 | | return [INFO] [stderr] 299 | | }, [INFO] [stderr] 300 | | None => {} [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | if let Some(value) = matches.value_of(input) { [INFO] [stderr] 296 | process_input(&value, &matches, &configuration); [INFO] [stderr] 297 | return [INFO] [stderr] 298 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.34s [INFO] running `"docker" "inspect" "97c5baa65a20b6b21d95d58520c12f7e109a868dd9c3a58cfb8586893869681e"` [INFO] running `"docker" "rm" "-f" "97c5baa65a20b6b21d95d58520c12f7e109a868dd9c3a58cfb8586893869681e"` [INFO] [stdout] 97c5baa65a20b6b21d95d58520c12f7e109a868dd9c3a58cfb8586893869681e