[INFO] crate wkb 0.3.0 is already in cache [INFO] extracting crate wkb 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/wkb/0.3.0 [INFO] extracting crate wkb 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wkb/0.3.0 [INFO] validating manifest of wkb-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wkb-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wkb-0.3.0 [INFO] finished frobbing wkb-0.3.0 [INFO] frobbed toml for wkb-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/wkb/0.3.0/Cargo.toml [INFO] started frobbing wkb-0.3.0 [INFO] finished frobbing wkb-0.3.0 [INFO] frobbed toml for wkb-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wkb/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wkb-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wkb/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08bee12447b6433a4efca7f0c28dd5c2fa94026abf91c5647b96dd6ce0e5dd2f [INFO] running `"docker" "start" "-a" "08bee12447b6433a4efca7f0c28dd5c2fa94026abf91c5647b96dd6ce0e5dd2f"` [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Checking pdqselect v0.1.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking spade v1.6.0 [INFO] [stderr] Checking geo-types v0.2.2 [INFO] [stderr] Checking geo v0.10.3 [INFO] [stderr] Checking wkb v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / match geom { [INFO] [stderr] 106 | | &Geometry::Point(p) => { [INFO] [stderr] 107 | | result.write_u32::(1); [INFO] [stderr] 108 | | write_point(&p.0, &mut result); [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *geom { [INFO] [stderr] 106 | Geometry::Point(p) => { [INFO] [stderr] 107 | result.write_u32::(1); [INFO] [stderr] 108 | write_point(&p.0, &mut result); [INFO] [stderr] 109 | }, [INFO] [stderr] 110 | Geometry::LineString(ref ls) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(reader.read_f64::().unwrap(), a.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(reader.read_f64::().unwrap(), a.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(reader.read_f64::().unwrap(), b.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(reader.read_f64::().unwrap(), b.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(p.x(), 100.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(p.x(), 100.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(p.y(), -2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(p.y(), -2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | assert_eq!(ls.0[0].x, 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | assert_eq!(ls.0[0].x, 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | assert_eq!(ls.0[0].y, 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | assert_eq!(ls.0[0].y, 0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | assert_eq!(ls.0[1].x, 1000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | assert_eq!(ls.0[1].x, 1000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | assert_eq!(ls.0[1].y, 1000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | assert_eq!(ls.0[1].y, 1000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | assert_eq!(mp.0[0].x(), 100.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | assert_eq!(mp.0[0].x(), 100.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | assert_eq!(mp.0[0].y(), -2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | assert_eq!(mp.0[0].y(), -2.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wkb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / match geom { [INFO] [stderr] 106 | | &Geometry::Point(p) => { [INFO] [stderr] 107 | | result.write_u32::(1); [INFO] [stderr] 108 | | write_point(&p.0, &mut result); [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *geom { [INFO] [stderr] 106 | Geometry::Point(p) => { [INFO] [stderr] 107 | result.write_u32::(1); [INFO] [stderr] 108 | write_point(&p.0, &mut result); [INFO] [stderr] 109 | }, [INFO] [stderr] 110 | Geometry::LineString(ref ls) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "08bee12447b6433a4efca7f0c28dd5c2fa94026abf91c5647b96dd6ce0e5dd2f"` [INFO] running `"docker" "rm" "-f" "08bee12447b6433a4efca7f0c28dd5c2fa94026abf91c5647b96dd6ce0e5dd2f"` [INFO] [stdout] 08bee12447b6433a4efca7f0c28dd5c2fa94026abf91c5647b96dd6ce0e5dd2f