[INFO] crate wither_derive 0.8.0-beta.0 is already in cache [INFO] extracting crate wither_derive 0.8.0-beta.0 into work/ex/clippy-test-run/sources/stable/reg/wither_derive/0.8.0-beta.0 [INFO] extracting crate wither_derive 0.8.0-beta.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wither_derive/0.8.0-beta.0 [INFO] validating manifest of wither_derive-0.8.0-beta.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wither_derive-0.8.0-beta.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wither_derive-0.8.0-beta.0 [INFO] finished frobbing wither_derive-0.8.0-beta.0 [INFO] frobbed toml for wither_derive-0.8.0-beta.0 written to work/ex/clippy-test-run/sources/stable/reg/wither_derive/0.8.0-beta.0/Cargo.toml [INFO] started frobbing wither_derive-0.8.0-beta.0 [INFO] finished frobbing wither_derive-0.8.0-beta.0 [INFO] frobbed toml for wither_derive-0.8.0-beta.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wither_derive/0.8.0-beta.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wither_derive-0.8.0-beta.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wither_derive/0.8.0-beta.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4474d977d88ddded2f16992f648fdecba0e0b6e4248381fc1ca969fbd68d4801 [INFO] running `"docker" "start" "-a" "4474d977d88ddded2f16992f648fdecba0e0b6e4248381fc1ca969fbd68d4801"` [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking crypto-mac v0.6.2 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking md-5 v0.7.0 [INFO] [stderr] Checking textnonce v0.6.4 [INFO] [stderr] Checking scan_fmt v0.1.3 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking hmac v0.6.3 [INFO] [stderr] Checking pbkdf2 v0.2.3 [INFO] [stderr] Checking bson v0.13.0 [INFO] [stderr] Checking mongodb v0.3.12 [INFO] [stderr] Checking wither_derive v0.8.0-beta.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/model_field.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / struct_fields.named.iter() [INFO] [stderr] 23 | | // Filter out fields with no attrs. [INFO] [stderr] 24 | | .filter_map(|field| { [INFO] [stderr] 25 | | if field.attrs.len() == 0 { None } else { Some(field) } [INFO] [stderr] 26 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model_field.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | if field.attrs.len() == 0 { None } else { Some(field) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/model_field.rs:171:55 [INFO] [stderr] | [INFO] [stderr] 171 | let opt_weights = opts.weights.get_or_insert_with(|| Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Document::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model_struct.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if data.collection_name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.collection_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/model_struct.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | if struct_data.collection_name.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `struct_data.collection_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if self.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/model_field.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / struct_fields.named.iter() [INFO] [stderr] 23 | | // Filter out fields with no attrs. [INFO] [stderr] 24 | | .filter_map(|field| { [INFO] [stderr] 25 | | if field.attrs.len() == 0 { None } else { Some(field) } [INFO] [stderr] 26 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model_field.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | if field.attrs.len() == 0 { None } else { Some(field) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/model_field.rs:171:55 [INFO] [stderr] | [INFO] [stderr] 171 | let opt_weights = opts.weights.get_or_insert_with(|| Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Document::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model_struct.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if data.collection_name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.collection_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/model_struct.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | if struct_data.collection_name.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `struct_data.collection_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if self.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.35s [INFO] running `"docker" "inspect" "4474d977d88ddded2f16992f648fdecba0e0b6e4248381fc1ca969fbd68d4801"` [INFO] running `"docker" "rm" "-f" "4474d977d88ddded2f16992f648fdecba0e0b6e4248381fc1ca969fbd68d4801"` [INFO] [stdout] 4474d977d88ddded2f16992f648fdecba0e0b6e4248381fc1ca969fbd68d4801