[INFO] crate wipe_buddy 0.1.0 is already in cache
[INFO] extracting crate wipe_buddy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wipe_buddy/0.1.0
[INFO] extracting crate wipe_buddy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wipe_buddy/0.1.0
[INFO] validating manifest of wipe_buddy-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wipe_buddy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wipe_buddy-0.1.0
[INFO] finished frobbing wipe_buddy-0.1.0
[INFO] frobbed toml for wipe_buddy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wipe_buddy/0.1.0/Cargo.toml
[INFO] started frobbing wipe_buddy-0.1.0
[INFO] finished frobbing wipe_buddy-0.1.0
[INFO] frobbed toml for wipe_buddy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wipe_buddy/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wipe_buddy-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wipe_buddy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a208952aca837cceb74f8dc9775479da435e73309144a6f430b358b1d2502796
[INFO] running `"docker" "start" "-a" "a208952aca837cceb74f8dc9775479da435e73309144a6f430b358b1d2502796"`
[INFO] [stderr]     Checking threadpool v1.7.1
[INFO] [stderr]     Checking wipe_buddy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]    --> src/main.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 /// Contains the major and minor numbers of  each  partition  as  well  as  the  number  of 1024-byte blocks and the partition name.
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:196:36
[INFO] [stderr]     |
[INFO] [stderr] 196 |             Detected | Protected | Wiped{ took:_ } | WipeFailed => true,
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Wiped { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:197:28
[INFO] [stderr]     |
[INFO] [stderr] 197 |             QueueForWipe | Wiping{ progress: _, per_second: _ } => false,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Wiping { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:364:17
[INFO] [stderr]     |
[INFO] [stderr] 364 |                 return KiloByte(size / 1024).fmt(f);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `KiloByte(size / 1024).fmt(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]    --> src/main.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 /// Contains the major and minor numbers of  each  partition  as  well  as  the  number  of 1024-byte blocks and the partition name.
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:196:36
[INFO] [stderr]     |
[INFO] [stderr] 196 |             Detected | Protected | Wiped{ took:_ } | WipeFailed => true,
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Wiped { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:197:28
[INFO] [stderr]     |
[INFO] [stderr] 197 |             QueueForWipe | Wiping{ progress: _, per_second: _ } => false,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `Wiping { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:364:17
[INFO] [stderr]     |
[INFO] [stderr] 364 |                 return KiloByte(size / 1024).fmt(f);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `KiloByte(size / 1024).fmt(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:661:28
[INFO] [stderr]     |
[INFO] [stderr] 661 |             size: KiloByte(500107608),
[INFO] [stderr]     |                            ^^^^^^^^^ help: consider: `500_107_608`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:669:28
[INFO] [stderr]     |
[INFO] [stderr] 669 |             size: KiloByte(31166976),
[INFO] [stderr]     |                            ^^^^^^^^ help: consider: `31_166_976`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn show_disk_status(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:101:37
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn parse_partition_file(partitions: &String) -> Vec<Arc<DiskInformation>> {
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:102:34
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let lines = partitions.split("\n").skip(2);
[INFO] [stderr]     |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:133:30
[INFO] [stderr]     |
[INFO] [stderr] 133 | fn mark_mounted_disks(disks: &Vec<Arc<DiskInformation>>, mounts: String) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in reader.lines().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 |     for line in reader.lines() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:158:27
[INFO] [stderr]     |
[INFO] [stderr] 158 |         buffer += &* line.unwrap_or( format!("<read error on line {} - {}>\n", i, path) );
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("<read error on line {} - {}>\n", i, path))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:165:48
[INFO] [stderr]     |
[INFO] [stderr] 165 | fn replace_file_contents(path: &str, contents: &String) -> io::Result<()> {
[INFO] [stderr]     |                                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 | fn try_shutdown(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/main.rs:194:29
[INFO] [stderr]     |
[INFO] [stderr] 194 |       if disks.iter().all(|e| {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 195 | |         match *e.state.lock().unwrap() {
[INFO] [stderr] 196 | |             Detected | Protected | Wiped{ took:_ } | WipeFailed => true,
[INFO] [stderr] 197 | |             QueueForWipe | Wiping{ progress: _, per_second: _ } => false,
[INFO] [stderr] 198 | |         }
[INFO] [stderr] 199 | |     }) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match self {
[INFO] [stderr] 238 | |             &Detected => write!(f, "Detected"),
[INFO] [stderr] 239 | |             &Protected => write!(f, "Protected"),
[INFO] [stderr] 240 | |             &QueueForWipe => write!(f, "Queued for Wipe"),
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |             &WipeFailed=> write!(f, "Wipe failed"),
[INFO] [stderr] 244 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 237 |         match *self {
[INFO] [stderr] 238 |             Detected => write!(f, "Detected"),
[INFO] [stderr] 239 |             Protected => write!(f, "Protected"),
[INFO] [stderr] 240 |             QueueForWipe => write!(f, "Queued for Wipe"),
[INFO] [stderr] 241 |             Wiping { ref progress, ref per_second } => write!(f, "Wiping {} ({}/s)", progress, per_second),
[INFO] [stderr] 242 |             Wiped { ref took } => write!(f, "Wiped successfully in {} seconds", took.as_secs()),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 | /         match self {
[INFO] [stderr] 259 | |             &Byte(v) => Byte(v),
[INFO] [stderr] 260 | |             &KiloByte(v) => Byte(1024 * v),
[INFO] [stderr] 261 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 258 |         match *self {
[INFO] [stderr] 259 |             Byte(v) => Byte(v),
[INFO] [stderr] 260 |             KiloByte(v) => Byte(1024 * v),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:282:9
[INFO] [stderr]     |
[INFO] [stderr] 282 | /         match self {
[INFO] [stderr] 283 | |             &Byte(l) => match rhs {
[INFO] [stderr] 284 | |                 &Byte(r) => l == r,
[INFO] [stderr] 285 | |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] ...   |
[INFO] [stderr] 290 | |             }
[INFO] [stderr] 291 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 282 |         match *self {
[INFO] [stderr] 283 |             Byte(l) => match rhs {
[INFO] [stderr] 284 |                 &Byte(r) => l == r,
[INFO] [stderr] 285 |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] 286 |             },
[INFO] [stderr] 287 |             KiloByte(l) => match rhs {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:283:25
[INFO] [stderr]     |
[INFO] [stderr] 283 |               &Byte(l) => match rhs {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 284 | |                 &Byte(r) => l == r,
[INFO] [stderr] 285 | |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] 286 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |             &Byte(l) => match *rhs {
[INFO] [stderr] 284 |                 Byte(r) => l == r,
[INFO] [stderr] 285 |                 KiloByte(r) => l == 1024 * r,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:287:29
[INFO] [stderr]     |
[INFO] [stderr] 287 |               &KiloByte(l) => match rhs {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 288 | |                 &Byte(r) => 1024 * l == r,
[INFO] [stderr] 289 | |                 &KiloByte(r) => l == r,
[INFO] [stderr] 290 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 287 |             &KiloByte(l) => match *rhs {
[INFO] [stderr] 288 |                 Byte(r) => 1024 * l == r,
[INFO] [stderr] 289 |                 KiloByte(r) => l == r,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:326:9
[INFO] [stderr]     |
[INFO] [stderr] 326 | /         match self {
[INFO] [stderr] 327 | |             &mut Byte(ref mut me) => match other {
[INFO] [stderr] 328 | |                 Byte(r) => { *me += r; return },
[INFO] [stderr] 329 | |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr] ...   |
[INFO] [stderr] 334 | |             },
[INFO] [stderr] 335 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 326 |         match *self {
[INFO] [stderr] 327 |             Byte(ref mut me) => match other {
[INFO] [stderr] 328 |                 Byte(r) => { *me += r; return },
[INFO] [stderr] 329 |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr] 330 |             },
[INFO] [stderr] 331 |             KiloByte(ref mut me) => match other {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl
[INFO] [stderr]    --> src/main.rs:329:43
[INFO] [stderr]     |
[INFO] [stderr] 329 |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr]     |                                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_op_assign_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:358:9
[INFO] [stderr]     |
[INFO] [stderr] 358 | /         match self {
[INFO] [stderr] 359 | |             &Byte(size) => {
[INFO] [stderr] 360 | |                 if size < 1000 {
[INFO] [stderr] 361 | |                     return write!(f, "{:>6.2} B ", size);
[INFO] [stderr] ...   |
[INFO] [stderr] 384 | |             }
[INFO] [stderr] 385 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 358 |         match *self {
[INFO] [stderr] 359 |             Byte(size) => {
[INFO] [stderr] 360 |                 if size < 1000 {
[INFO] [stderr] 361 |                     return write!(f, "{:>6.2} B ", size);
[INFO] [stderr] 362 |                 }
[INFO] [stderr] 363 |                 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:406:31
[INFO] [stderr]     |
[INFO] [stderr] 406 | fn select_disk_to_wipe(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:434:23
[INFO] [stderr]     |
[INFO] [stderr] 434 | fn update_jobs(disks: &Vec<Arc<DiskInformation>>, pool: &threadpool::ThreadPool) {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `wipe_buddy`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn show_disk_status(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:101:37
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn parse_partition_file(partitions: &String) -> Vec<Arc<DiskInformation>> {
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:102:34
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let lines = partitions.split("\n").skip(2);
[INFO] [stderr]     |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:133:30
[INFO] [stderr]     |
[INFO] [stderr] 133 | fn mark_mounted_disks(disks: &Vec<Arc<DiskInformation>>, mounts: String) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in reader.lines().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 |     for line in reader.lines() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:158:27
[INFO] [stderr]     |
[INFO] [stderr] 158 |         buffer += &* line.unwrap_or( format!("<read error on line {} - {}>\n", i, path) );
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("<read error on line {} - {}>\n", i, path))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:165:48
[INFO] [stderr]     |
[INFO] [stderr] 165 | fn replace_file_contents(path: &str, contents: &String) -> io::Result<()> {
[INFO] [stderr]     |                                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 | fn try_shutdown(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/main.rs:194:29
[INFO] [stderr]     |
[INFO] [stderr] 194 |       if disks.iter().all(|e| {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 195 | |         match *e.state.lock().unwrap() {
[INFO] [stderr] 196 | |             Detected | Protected | Wiped{ took:_ } | WipeFailed => true,
[INFO] [stderr] 197 | |             QueueForWipe | Wiping{ progress: _, per_second: _ } => false,
[INFO] [stderr] 198 | |         }
[INFO] [stderr] 199 | |     }) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match self {
[INFO] [stderr] 238 | |             &Detected => write!(f, "Detected"),
[INFO] [stderr] 239 | |             &Protected => write!(f, "Protected"),
[INFO] [stderr] 240 | |             &QueueForWipe => write!(f, "Queued for Wipe"),
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |             &WipeFailed=> write!(f, "Wipe failed"),
[INFO] [stderr] 244 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 237 |         match *self {
[INFO] [stderr] 238 |             Detected => write!(f, "Detected"),
[INFO] [stderr] 239 |             Protected => write!(f, "Protected"),
[INFO] [stderr] 240 |             QueueForWipe => write!(f, "Queued for Wipe"),
[INFO] [stderr] 241 |             Wiping { ref progress, ref per_second } => write!(f, "Wiping {} ({}/s)", progress, per_second),
[INFO] [stderr] 242 |             Wiped { ref took } => write!(f, "Wiped successfully in {} seconds", took.as_secs()),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 | /         match self {
[INFO] [stderr] 259 | |             &Byte(v) => Byte(v),
[INFO] [stderr] 260 | |             &KiloByte(v) => Byte(1024 * v),
[INFO] [stderr] 261 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 258 |         match *self {
[INFO] [stderr] 259 |             Byte(v) => Byte(v),
[INFO] [stderr] 260 |             KiloByte(v) => Byte(1024 * v),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:282:9
[INFO] [stderr]     |
[INFO] [stderr] 282 | /         match self {
[INFO] [stderr] 283 | |             &Byte(l) => match rhs {
[INFO] [stderr] 284 | |                 &Byte(r) => l == r,
[INFO] [stderr] 285 | |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] ...   |
[INFO] [stderr] 290 | |             }
[INFO] [stderr] 291 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 282 |         match *self {
[INFO] [stderr] 283 |             Byte(l) => match rhs {
[INFO] [stderr] 284 |                 &Byte(r) => l == r,
[INFO] [stderr] 285 |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] 286 |             },
[INFO] [stderr] 287 |             KiloByte(l) => match rhs {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:283:25
[INFO] [stderr]     |
[INFO] [stderr] 283 |               &Byte(l) => match rhs {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 284 | |                 &Byte(r) => l == r,
[INFO] [stderr] 285 | |                 &KiloByte(r) => l == 1024 * r,
[INFO] [stderr] 286 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |             &Byte(l) => match *rhs {
[INFO] [stderr] 284 |                 Byte(r) => l == r,
[INFO] [stderr] 285 |                 KiloByte(r) => l == 1024 * r,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:287:29
[INFO] [stderr]     |
[INFO] [stderr] 287 |               &KiloByte(l) => match rhs {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 288 | |                 &Byte(r) => 1024 * l == r,
[INFO] [stderr] 289 | |                 &KiloByte(r) => l == r,
[INFO] [stderr] 290 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 287 |             &KiloByte(l) => match *rhs {
[INFO] [stderr] 288 |                 Byte(r) => 1024 * l == r,
[INFO] [stderr] 289 |                 KiloByte(r) => l == r,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:326:9
[INFO] [stderr]     |
[INFO] [stderr] 326 | /         match self {
[INFO] [stderr] 327 | |             &mut Byte(ref mut me) => match other {
[INFO] [stderr] 328 | |                 Byte(r) => { *me += r; return },
[INFO] [stderr] 329 | |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr] ...   |
[INFO] [stderr] 334 | |             },
[INFO] [stderr] 335 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 326 |         match *self {
[INFO] [stderr] 327 |             Byte(ref mut me) => match other {
[INFO] [stderr] 328 |                 Byte(r) => { *me += r; return },
[INFO] [stderr] 329 |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr] 330 |             },
[INFO] [stderr] 331 |             KiloByte(ref mut me) => match other {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl
[INFO] [stderr]    --> src/main.rs:329:43
[INFO] [stderr]     |
[INFO] [stderr] 329 |                 KiloByte(r) => { *me += r * 1024; return; },
[INFO] [stderr]     |                                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_op_assign_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:358:9
[INFO] [stderr]     |
[INFO] [stderr] 358 | /         match self {
[INFO] [stderr] 359 | |             &Byte(size) => {
[INFO] [stderr] 360 | |                 if size < 1000 {
[INFO] [stderr] 361 | |                     return write!(f, "{:>6.2} B ", size);
[INFO] [stderr] ...   |
[INFO] [stderr] 384 | |             }
[INFO] [stderr] 385 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 358 |         match *self {
[INFO] [stderr] 359 |             Byte(size) => {
[INFO] [stderr] 360 |                 if size < 1000 {
[INFO] [stderr] 361 |                     return write!(f, "{:>6.2} B ", size);
[INFO] [stderr] 362 |                 }
[INFO] [stderr] 363 |                 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:406:31
[INFO] [stderr]     |
[INFO] [stderr] 406 | fn select_disk_to_wipe(disks: &Vec<Arc<DiskInformation>>) {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:434:23
[INFO] [stderr]     |
[INFO] [stderr] 434 | fn update_jobs(disks: &Vec<Arc<DiskInformation>>, pool: &threadpool::ThreadPool) {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc<DiskInformation>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `wipe_buddy`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "a208952aca837cceb74f8dc9775479da435e73309144a6f430b358b1d2502796"`
[INFO] running `"docker" "rm" "-f" "a208952aca837cceb74f8dc9775479da435e73309144a6f430b358b1d2502796"`
[INFO] [stdout] a208952aca837cceb74f8dc9775479da435e73309144a6f430b358b1d2502796