[INFO] crate winres 0.1.8 is already in cache [INFO] extracting crate winres 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/winres/0.1.8 [INFO] extracting crate winres 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winres/0.1.8 [INFO] validating manifest of winres-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of winres-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing winres-0.1.8 [INFO] finished frobbing winres-0.1.8 [INFO] frobbed toml for winres-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/winres/0.1.8/Cargo.toml [INFO] started frobbing winres-0.1.8 [INFO] finished frobbing winres-0.1.8 [INFO] frobbed toml for winres-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winres/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting winres-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/winres/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cc380eedddda58b5c24a9991a2bf3513f5a100098c8cd8e14547835ff8d43ed [INFO] running `"docker" "start" "-a" "2cc380eedddda58b5c24a9991a2bf3513f5a100098c8cd8e14547835ff8d43ed"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking winres v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:445:52 [INFO] [stderr] | [INFO] [stderr] 445 | println!("cargo:rustc-link-lib=static={}", "resource"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:506:51 [INFO] [stderr] | [INFO] [stderr] 506 | println!("cargo:rustc-link-lib=dylib={}", "resource"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:161:41 [INFO] [stderr] | [INFO] [stderr] 161 | ver.insert(VersionInfo::FILEOS, 0x00040004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0004` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `WindowsResource` [INFO] [stderr] --> lib.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn new() -> Self { [INFO] [stderr] 140 | | let mut props: HashMap = HashMap::new(); [INFO] [stderr] 141 | | let mut ver: HashMap = HashMap::new(); [INFO] [stderr] 142 | | [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> lib.rs:185:51 [INFO] [stderr] | [INFO] [stderr] 185 | output_directory: env::var("OUT_DIR").unwrap_or(".".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:445:52 [INFO] [stderr] | [INFO] [stderr] 445 | println!("cargo:rustc-link-lib=static={}", "resource"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:506:51 [INFO] [stderr] | [INFO] [stderr] 506 | println!("cargo:rustc-link-lib=dylib={}", "resource"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:161:41 [INFO] [stderr] | [INFO] [stderr] 161 | ver.insert(VersionInfo::FILEOS, 0x00040004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0004` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `WindowsResource` [INFO] [stderr] --> lib.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn new() -> Self { [INFO] [stderr] 140 | | let mut props: HashMap = HashMap::new(); [INFO] [stderr] 141 | | let mut ver: HashMap = HashMap::new(); [INFO] [stderr] 142 | | [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> lib.rs:185:51 [INFO] [stderr] | [INFO] [stderr] 185 | output_directory: env::var("OUT_DIR").unwrap_or(".".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.10s [INFO] running `"docker" "inspect" "2cc380eedddda58b5c24a9991a2bf3513f5a100098c8cd8e14547835ff8d43ed"` [INFO] running `"docker" "rm" "-f" "2cc380eedddda58b5c24a9991a2bf3513f5a100098c8cd8e14547835ff8d43ed"` [INFO] [stdout] 2cc380eedddda58b5c24a9991a2bf3513f5a100098c8cd8e14547835ff8d43ed