[INFO] crate winit_input_helper 0.2.0 is already in cache [INFO] extracting crate winit_input_helper 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/winit_input_helper/0.2.0 [INFO] extracting crate winit_input_helper 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winit_input_helper/0.2.0 [INFO] validating manifest of winit_input_helper-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of winit_input_helper-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing winit_input_helper-0.2.0 [INFO] finished frobbing winit_input_helper-0.2.0 [INFO] frobbed toml for winit_input_helper-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/winit_input_helper/0.2.0/Cargo.toml [INFO] started frobbing winit_input_helper-0.2.0 [INFO] finished frobbing winit_input_helper-0.2.0 [INFO] frobbed toml for winit_input_helper-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winit_input_helper/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting winit_input_helper-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/winit_input_helper/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe710c4a4761599cefb60f37833f85427ab07dadb75171e933bda0be5c74d8d7 [INFO] running `"docker" "start" "-a" "fe710c4a4761599cefb60f37833f85427ab07dadb75171e933bda0be5c74d8d7"` [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking libloading v0.5.0 [INFO] [stderr] Checking nix v0.12.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking stb_truetype v0.2.5 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Compiling wayland-scanner v0.21.11 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Compiling wayland-protocols v0.21.11 [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking winit_input_helper v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return self.key_held(VirtualKeyCode::LShift) || self.key_held(VirtualKeyCode::RShift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LShift) || self.key_held(VirtualKeyCode::RShift)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return self.key_held(VirtualKeyCode::LControl) || self.key_held(VirtualKeyCode::RControl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LControl) || self.key_held(VirtualKeyCode::RControl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return self.key_held(VirtualKeyCode::LAlt) || self.key_held(VirtualKeyCode::RAlt); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LAlt) || self.key_held(VirtualKeyCode::RAlt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `WinitInputHelper` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> WinitInputHelper { [INFO] [stderr] 20 | | WinitInputHelper { [INFO] [stderr] 21 | | current: Some(CurrentInput::new()), [INFO] [stderr] 22 | | dropped_file: None, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:48:89 [INFO] [stderr] | [INFO] [stderr] 48 | WindowEvent::Resized (ref size) => { self.window_resized = Some(size.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / if let &KeyAction::Pressed(key_code) = action { [INFO] [stderr] 75 | | if key_code == check_key_code { [INFO] [stderr] 76 | | return true; [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | if let KeyAction::Pressed(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / if let &MouseAction::Pressed(key_code) = action { [INFO] [stderr] 96 | | if key_code == check_mouse_button { [INFO] [stderr] 97 | | return true; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | if let MouseAction::Pressed(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / if let &KeyAction::Released(key_code) = action { [INFO] [stderr] 111 | | if key_code == check_key_code { [INFO] [stderr] 112 | | return true; [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | if let KeyAction::Released(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &MouseAction::Released(key_code) = action { [INFO] [stderr] 132 | | if key_code == check_mouse_button { [INFO] [stderr] 133 | | return true; [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let MouseAction::Released(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | self.window_resized.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.window_resized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return self.key_held(VirtualKeyCode::LShift) || self.key_held(VirtualKeyCode::RShift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LShift) || self.key_held(VirtualKeyCode::RShift)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return self.key_held(VirtualKeyCode::LControl) || self.key_held(VirtualKeyCode::RControl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LControl) || self.key_held(VirtualKeyCode::RControl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return self.key_held(VirtualKeyCode::LAlt) || self.key_held(VirtualKeyCode::RAlt); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key_held(VirtualKeyCode::LAlt) || self.key_held(VirtualKeyCode::RAlt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `WinitInputHelper` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> WinitInputHelper { [INFO] [stderr] 20 | | WinitInputHelper { [INFO] [stderr] 21 | | current: Some(CurrentInput::new()), [INFO] [stderr] 22 | | dropped_file: None, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:48:89 [INFO] [stderr] | [INFO] [stderr] 48 | WindowEvent::Resized (ref size) => { self.window_resized = Some(size.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / if let &KeyAction::Pressed(key_code) = action { [INFO] [stderr] 75 | | if key_code == check_key_code { [INFO] [stderr] 76 | | return true; [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | if let KeyAction::Pressed(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / if let &MouseAction::Pressed(key_code) = action { [INFO] [stderr] 96 | | if key_code == check_mouse_button { [INFO] [stderr] 97 | | return true; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | if let MouseAction::Pressed(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / if let &KeyAction::Released(key_code) = action { [INFO] [stderr] 111 | | if key_code == check_key_code { [INFO] [stderr] 112 | | return true; [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | if let KeyAction::Released(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &MouseAction::Released(key_code) = action { [INFO] [stderr] 132 | | if key_code == check_mouse_button { [INFO] [stderr] 133 | | return true; [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let MouseAction::Released(key_code) = *action { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | self.window_resized.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.window_resized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.03s [INFO] running `"docker" "inspect" "fe710c4a4761599cefb60f37833f85427ab07dadb75171e933bda0be5c74d8d7"` [INFO] running `"docker" "rm" "-f" "fe710c4a4761599cefb60f37833f85427ab07dadb75171e933bda0be5c74d8d7"` [INFO] [stdout] fe710c4a4761599cefb60f37833f85427ab07dadb75171e933bda0be5c74d8d7