[INFO] crate winauth 0.0.3 is already in cache [INFO] extracting crate winauth 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/winauth/0.0.3 [INFO] extracting crate winauth 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winauth/0.0.3 [INFO] validating manifest of winauth-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of winauth-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing winauth-0.0.3 [INFO] finished frobbing winauth-0.0.3 [INFO] frobbed toml for winauth-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/winauth/0.0.3/Cargo.toml [INFO] started frobbing winauth-0.0.3 [INFO] finished frobbing winauth-0.0.3 [INFO] frobbed toml for winauth-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/winauth/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting winauth-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/winauth/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e919fe7e8d7ac0038dcd4157ff2fa0fe2fc740494bcc328302b6959740a68b6d [INFO] running `"docker" "start" "-a" "e919fe7e8d7ac0038dcd4157ff2fa0fe2fc740494bcc328302b6959740a68b6d"` [INFO] [stderr] Checking winauth v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/md4.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let mut d = self.state[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | negotiate_flags: negotiate_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `negotiate_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | server_challenge: server_challenge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_challenge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | target_name: target_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | av_pairs: av_pairs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `av_pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:633:13 [INFO] [stderr] | [INFO] [stderr] 633 | exported_session_key: exported_session_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exported_session_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:634:13 [INFO] [stderr] | [INFO] [stderr] 634 | encrypted_random_session_key: encrypted_random_session_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted_random_session_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:851:25 [INFO] [stderr] | [INFO] [stderr] 851 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/md4.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let mut d = self.state[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | negotiate_flags: negotiate_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `negotiate_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | server_challenge: server_challenge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_challenge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | target_name: target_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | av_pairs: av_pairs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `av_pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:633:13 [INFO] [stderr] | [INFO] [stderr] 633 | exported_session_key: exported_session_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exported_session_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:634:13 [INFO] [stderr] | [INFO] [stderr] 634 | encrypted_random_session_key: encrypted_random_session_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encrypted_random_session_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:851:25 [INFO] [stderr] | [INFO] [stderr] 851 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6745_2301` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xefcd_ab89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:45 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x98ba_dcfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:57 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1032_5476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 183 | GG!(a, b, c, d, x[ 0], S21); /* 17 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 184 | GG!(d, a, b, c, x[ 4], S22); /* 18 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 185 | GG!(c, d, a, b, x[ 8], S23); /* 19 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 186 | GG!(b, c, d, a, x[12], S24); /* 20 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 187 | GG!(a, b, c, d, x[ 1], S21); /* 21 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 188 | GG!(d, a, b, c, x[ 5], S22); /* 22 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 189 | GG!(c, d, a, b, x[ 9], S23); /* 23 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 190 | GG!(b, c, d, a, x[13], S24); /* 24 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 191 | GG!(a, b, c, d, x[ 2], S21); /* 25 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 192 | GG!(d, a, b, c, x[ 6], S22); /* 26 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 193 | GG!(c, d, a, b, x[10], S23); /* 27 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 194 | GG!(b, c, d, a, x[14], S24); /* 28 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 195 | GG!(a, b, c, d, x[ 3], S21); /* 29 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 196 | GG!(d, a, b, c, x[ 7], S22); /* 30 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 197 | GG!(c, d, a, b, x[11], S23); /* 31 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 198 | GG!(b, c, d, a, x[15], S24); /* 32 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 201 | HH!(a, b, c, d, x[ 0], S31); /* 33 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 202 | HH!(d, a, b, c, x[ 8], S32); /* 34 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 203 | HH!(c, d, a, b, x[ 4], S33); /* 35 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 204 | HH!(b, c, d, a, x[12], S34); /* 36 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 205 | HH!(a, b, c, d, x[ 2], S31); /* 37 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 206 | HH!(d, a, b, c, x[10], S32); /* 38 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 207 | HH!(c, d, a, b, x[ 6], S33); /* 39 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 208 | HH!(b, c, d, a, x[14], S34); /* 40 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 209 | HH!(a, b, c, d, x[ 1], S31); /* 41 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 210 | HH!(d, a, b, c, x[ 9], S32); /* 42 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 211 | HH!(c, d, a, b, x[ 5], S33); /* 43 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 212 | HH!(b, c, d, a, x[13], S34); /* 44 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 213 | HH!(a, b, c, d, x[ 3], S31); /* 45 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 214 | HH!(d, a, b, c, x[11], S32); /* 46 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 215 | HH!(c, d, a, b, x[ 7], S33); /* 47 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 216 | HH!(b, c, d, a, x[15], S34); /* 48 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Msv` [INFO] [stderr] --> src/lib.rs:196:1 [INFO] [stderr] | [INFO] [stderr] 196 | / enum AvId { [INFO] [stderr] 197 | | MsvAvEOL = 0, [INFO] [stderr] 198 | | MsvAvNbComputerName = 0x01, [INFO] [stderr] 199 | | MsvAvNbDomainName = 0x02, [INFO] [stderr] ... | [INFO] [stderr] 207 | | MsvChannelBindings = 0x0A, [INFO] [stderr] 208 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:593:30 [INFO] [stderr] | [INFO] [stderr] 593 | let delta_time = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6745_2301` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xefcd_ab89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:45 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x98ba_dcfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:112:57 [INFO] [stderr] | [INFO] [stderr] 112 | state: [0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1032_5476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 183 | GG!(a, b, c, d, x[ 0], S21); /* 17 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 184 | GG!(d, a, b, c, x[ 4], S22); /* 18 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 185 | GG!(c, d, a, b, x[ 8], S23); /* 19 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 186 | GG!(b, c, d, a, x[12], S24); /* 20 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 187 | GG!(a, b, c, d, x[ 1], S21); /* 21 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 188 | GG!(d, a, b, c, x[ 5], S22); /* 22 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 189 | GG!(c, d, a, b, x[ 9], S23); /* 23 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 190 | GG!(b, c, d, a, x[13], S24); /* 24 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 191 | GG!(a, b, c, d, x[ 2], S21); /* 25 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 192 | GG!(d, a, b, c, x[ 6], S22); /* 26 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 193 | GG!(c, d, a, b, x[10], S23); /* 27 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 194 | GG!(b, c, d, a, x[14], S24); /* 28 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 195 | GG!(a, b, c, d, x[ 3], S21); /* 29 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 196 | GG!(d, a, b, c, x[ 7], S22); /* 30 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 197 | GG!(c, d, a, b, x[11], S23); /* 31 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | $a = $a.wrapping_add(G($b, $c, $d).wrapping_add($x).wrapping_add(0x5a827999u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x5a82_7999u32` [INFO] [stderr] ... [INFO] [stderr] 198 | GG!(b, c, d, a, x[15], S24); /* 32 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 201 | HH!(a, b, c, d, x[ 0], S31); /* 33 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 202 | HH!(d, a, b, c, x[ 8], S32); /* 34 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 203 | HH!(c, d, a, b, x[ 4], S33); /* 35 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 204 | HH!(b, c, d, a, x[12], S34); /* 36 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 205 | HH!(a, b, c, d, x[ 2], S31); /* 37 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 206 | HH!(d, a, b, c, x[10], S32); /* 38 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 207 | HH!(c, d, a, b, x[ 6], S33); /* 39 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 208 | HH!(b, c, d, a, x[14], S34); /* 40 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 209 | HH!(a, b, c, d, x[ 1], S31); /* 41 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 210 | HH!(d, a, b, c, x[ 9], S32); /* 42 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 211 | HH!(c, d, a, b, x[ 5], S33); /* 43 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 212 | HH!(b, c, d, a, x[13], S34); /* 44 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 213 | HH!(a, b, c, d, x[ 3], S31); /* 45 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 214 | HH!(d, a, b, c, x[11], S32); /* 46 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 215 | HH!(c, d, a, b, x[ 7], S33); /* 47 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md4.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | $a = $a.wrapping_add(H($b, $c, $d).wrapping_add($x).wrapping_add(0x6ed9eba1u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6ed9_eba1u32` [INFO] [stderr] ... [INFO] [stderr] 216 | HH!(b, c, d, a, x[15], S34); /* 48 */ [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Msv` [INFO] [stderr] --> src/lib.rs:196:1 [INFO] [stderr] | [INFO] [stderr] 196 | / enum AvId { [INFO] [stderr] 197 | | MsvAvEOL = 0, [INFO] [stderr] 198 | | MsvAvNbComputerName = 0x01, [INFO] [stderr] 199 | | MsvAvNbDomainName = 0x02, [INFO] [stderr] ... | [INFO] [stderr] 207 | | MsvChannelBindings = 0x0A, [INFO] [stderr] 208 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:593:30 [INFO] [stderr] | [INFO] [stderr] 593 | let delta_time = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> src/md4.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/md4.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..(bytes.len()/4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (i, ) in output.iter_mut().enumerate().take((bytes.len()/4)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:73 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:105 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s` [INFO] [stderr] --> src/rc4.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 6 | for (i, ) in s.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:161:43 [INFO] [stderr] | [INFO] [stderr] 161 | const NTLMSSP_NEGOTIATE_UNICODE = 1<<0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:310:81 [INFO] [stderr] | [INFO] [stderr] 310 | let id = try!(AvId::from_u16(try!(self.read_u16::())).ok_or( [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 311 | | io::Error::new(io::ErrorKind::InvalidData, "invalid av_id"))); [INFO] [stderr] | |____________________________________________________________________________^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid av_id"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:324:98 [INFO] [stderr] | [INFO] [stderr] 324 | AvItem::Flags(try!(AvFlags::from_bits(try!(self.read_u32::())).ok_or( [INFO] [stderr] | __________________________________________________________________________________________________^ [INFO] [stderr] 325 | | io::Error::new(io::ErrorKind::InvalidData, "invalid AV flags")))) [INFO] [stderr] | |_______________________________________________________________________________________^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid AV flags"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:379:14 [INFO] [stderr] | [INFO] [stderr] 379 | .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid negotiate flags"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid negotiate flags"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:424:35 [INFO] [stderr] | [INFO] [stderr] 424 | payload_offset += target_name_len as u32 + skip_bytes as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(target_name_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:429:35 [INFO] [stderr] | [INFO] [stderr] 429 | payload_offset += target_info_len as u32 + skip_bytes as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(target_info_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:598:85 [INFO] [stderr] | [INFO] [stderr] 598 | delta_time + (unix_time_delta.as_secs() as u64 * (1e9 as u64 / 100)) + (unix_time_delta.subsec_nanos() as u64 / 100) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time_delta.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NtlmV2ClientBuilder<'a>` [INFO] [stderr] --> src/lib.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | / pub fn new() -> NtlmV2ClientBuilder<'a> { [INFO] [stderr] 649 | | NtlmV2ClientBuilder { [INFO] [stderr] 650 | | target_spn: None, [INFO] [stderr] 651 | | channel_bindings: None, [INFO] [stderr] 652 | | } [INFO] [stderr] 653 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 642 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:794:50 [INFO] [stderr] | [INFO] [stderr] 794 | self.all_bytes.extend_from_slice(bytes.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:795:71 [INFO] [stderr] | [INFO] [stderr] 795 | let mut challenge_msg = try!(ChallengeMessage::decode(bytes.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> src/md4.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/md4.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..(bytes.len()/4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (i, ) in output.iter_mut().enumerate().take((bytes.len()/4)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:73 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md4.rs:63:105 [INFO] [stderr] | [INFO] [stderr] 63 | output[i] = bytes[idx] as u32 | ((bytes[idx+1] as u32) << 8) | ((bytes[idx+2] as u32) << 16) | ((bytes[idx+3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[idx+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s` [INFO] [stderr] --> src/rc4.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 6 | for (i, ) in s.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:161:43 [INFO] [stderr] | [INFO] [stderr] 161 | const NTLMSSP_NEGOTIATE_UNICODE = 1<<0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:310:81 [INFO] [stderr] | [INFO] [stderr] 310 | let id = try!(AvId::from_u16(try!(self.read_u16::())).ok_or( [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 311 | | io::Error::new(io::ErrorKind::InvalidData, "invalid av_id"))); [INFO] [stderr] | |____________________________________________________________________________^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid av_id"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:324:98 [INFO] [stderr] | [INFO] [stderr] 324 | AvItem::Flags(try!(AvFlags::from_bits(try!(self.read_u32::())).ok_or( [INFO] [stderr] | __________________________________________________________________________________________________^ [INFO] [stderr] 325 | | io::Error::new(io::ErrorKind::InvalidData, "invalid AV flags")))) [INFO] [stderr] | |_______________________________________________________________________________________^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid AV flags"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:379:14 [INFO] [stderr] | [INFO] [stderr] 379 | .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid negotiate flags"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid negotiate flags"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:424:35 [INFO] [stderr] | [INFO] [stderr] 424 | payload_offset += target_name_len as u32 + skip_bytes as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(target_name_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:429:35 [INFO] [stderr] | [INFO] [stderr] 429 | payload_offset += target_info_len as u32 + skip_bytes as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(target_info_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:598:85 [INFO] [stderr] | [INFO] [stderr] 598 | delta_time + (unix_time_delta.as_secs() as u64 * (1e9 as u64 / 100)) + (unix_time_delta.subsec_nanos() as u64 / 100) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time_delta.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NtlmV2ClientBuilder<'a>` [INFO] [stderr] --> src/lib.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | / pub fn new() -> NtlmV2ClientBuilder<'a> { [INFO] [stderr] 649 | | NtlmV2ClientBuilder { [INFO] [stderr] 650 | | target_spn: None, [INFO] [stderr] 651 | | channel_bindings: None, [INFO] [stderr] 652 | | } [INFO] [stderr] 653 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 642 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:794:50 [INFO] [stderr] | [INFO] [stderr] 794 | self.all_bytes.extend_from_slice(bytes.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:795:71 [INFO] [stderr] | [INFO] [stderr] 795 | let mut challenge_msg = try!(ChallengeMessage::decode(bytes.as_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "e919fe7e8d7ac0038dcd4157ff2fa0fe2fc740494bcc328302b6959740a68b6d"` [INFO] running `"docker" "rm" "-f" "e919fe7e8d7ac0038dcd4157ff2fa0fe2fc740494bcc328302b6959740a68b6d"` [INFO] [stdout] e919fe7e8d7ac0038dcd4157ff2fa0fe2fc740494bcc328302b6959740a68b6d