[INFO] crate wikipedia 0.3.2 is already in cache [INFO] extracting crate wikipedia 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/wikipedia/0.3.2 [INFO] extracting crate wikipedia 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wikipedia/0.3.2 [INFO] validating manifest of wikipedia-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wikipedia-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wikipedia-0.3.2 [INFO] finished frobbing wikipedia-0.3.2 [INFO] frobbed toml for wikipedia-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/wikipedia/0.3.2/Cargo.toml [INFO] started frobbing wikipedia-0.3.2 [INFO] finished frobbing wikipedia-0.3.2 [INFO] frobbed toml for wikipedia-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wikipedia/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wikipedia-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wikipedia/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98e3eae71b8b4c793babf213ce67a568710a56400da51b2701cff76a538719a2 [INFO] running `"docker" "start" "-a" "98e3eae71b8b4c793babf213ce67a568710a56400da51b2701cff76a538719a2"` [INFO] [stderr] Checking wikipedia v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | cont: cont, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:318:16 [INFO] [stderr] | [INFO] [stderr] 318 | Page { wikipedia: wikipedia, identifier: TitlePageId::Title(title) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wikipedia` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:323:16 [INFO] [stderr] | [INFO] [stderr] 323 | Page { wikipedia: wikipedia, identifier: TitlePageId::PageId(pageid) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wikipedia` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | cont: cont, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:318:16 [INFO] [stderr] | [INFO] [stderr] 318 | Page { wikipedia: wikipedia, identifier: TitlePageId::Title(title) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wikipedia` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:323:16 [INFO] [stderr] | [INFO] [stderr] 323 | Page { wikipedia: wikipedia, identifier: TitlePageId::PageId(pageid) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wikipedia` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | const LANGUAGE_URL_MARKER:&'static str = "{language}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | const LANGUAGE_URL_MARKER:&'static str = "{language}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:841:38 [INFO] [stderr] | [INFO] [stderr] 841 | wikipedia.geosearch(-34.603333, -58.381667, 10).unwrap(), [INFO] [stderr] | ^^^^^^^^^ help: consider: `34.603_333` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:841:50 [INFO] [stderr] | [INFO] [stderr] 841 | wikipedia.geosearch(-34.603333, -58.381667, 10).unwrap(), [INFO] [stderr] | ^^^^^^^^^ help: consider: `58.381_667` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | -> Result<(Vec, Option>)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/iter.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/iter.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:184:16 [INFO] [stderr] | [INFO] [stderr] 184 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:155:14 [INFO] [stderr] | [INFO] [stderr] 155 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn page_from_title<'a>(&'a self, title: String) -> Page<'a, A> { [INFO] [stderr] 284 | | Page::from_title(self, title) [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:288:5 [INFO] [stderr] | [INFO] [stderr] 288 | / pub fn page_from_pageid<'a>(&'a self, pageid: String) -> Page<'a, A> { [INFO] [stderr] 289 | | Page::from_pageid(self, pageid) [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | / match self.redirect(&q) { [INFO] [stderr] 343 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_pageid(), [INFO] [stderr] 344 | | None => (), [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_pageid() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | / match self.redirect(&q) { [INFO] [stderr] 375 | | Some(r) => return Ok(r), [INFO] [stderr] 376 | | None => (), [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(r) = self.redirect(&q) { return Ok(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:406:29 [INFO] [stderr] | [INFO] [stderr] 406 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | / match self.redirect(&q) { [INFO] [stderr] 445 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_content(), [INFO] [stderr] 446 | | None => (), [INFO] [stderr] 447 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_content() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / match self.redirect(&q) { [INFO] [stderr] 472 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_html_content(), [INFO] [stderr] 473 | | None => (), [INFO] [stderr] 474 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_html_content() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:480:29 [INFO] [stderr] | [INFO] [stderr] 480 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | / match self.redirect(&q) { [INFO] [stderr] 502 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_summary(), [INFO] [stderr] 503 | | None => (), [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_summary() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:554:13 [INFO] [stderr] | [INFO] [stderr] 554 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:564:14 [INFO] [stderr] | [INFO] [stderr] 564 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 565 | | .as_object() [INFO] [stderr] 566 | | .and_then(|x| x.get("extlinks")) [INFO] [stderr] 567 | | .and_then(|x| x.as_array()) [INFO] [stderr] 568 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 569 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 564 | (page [INFO] [stderr] 565 | .as_object() [INFO] [stderr] 566 | .and_then(|x| x.get("extlinks")) [INFO] [stderr] 567 | .and_then(|x| x.as_array()) [INFO] [stderr] 568 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:568:28 [INFO] [stderr] | [INFO] [stderr] 568 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | -> Result<(Vec, Option>)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/iter.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/iter.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/iter.rs:184:16 [INFO] [stderr] | [INFO] [stderr] 184 | -> Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:590:14 [INFO] [stderr] | [INFO] [stderr] 590 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 591 | | .as_object() [INFO] [stderr] 592 | | .and_then(|x| x.get("links")) [INFO] [stderr] 593 | | .and_then(|x| x.as_array()) [INFO] [stderr] 594 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 595 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 590 | (page [INFO] [stderr] 591 | .as_object() [INFO] [stderr] 592 | .and_then(|x| x.get("links")) [INFO] [stderr] 593 | .and_then(|x| x.as_array()) [INFO] [stderr] 594 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:594:28 [INFO] [stderr] | [INFO] [stderr] 594 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:615:14 [INFO] [stderr] | [INFO] [stderr] 615 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 616 | | .as_object() [INFO] [stderr] 617 | | .and_then(|x| x.get("categories")) [INFO] [stderr] 618 | | .and_then(|x| x.as_array()) [INFO] [stderr] 619 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 620 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 615 | (page [INFO] [stderr] 616 | .as_object() [INFO] [stderr] 617 | .and_then(|x| x.get("categories")) [INFO] [stderr] 618 | .and_then(|x| x.as_array()) [INFO] [stderr] 619 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:619:28 [INFO] [stderr] | [INFO] [stderr] 619 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:630:13 [INFO] [stderr] | [INFO] [stderr] 630 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:155:14 [INFO] [stderr] | [INFO] [stderr] 155 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:640:14 [INFO] [stderr] | [INFO] [stderr] 640 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 641 | | .as_object() [INFO] [stderr] 642 | | .and_then(|x| x.get("langlinks")) [INFO] [stderr] 643 | | .and_then(|x| x.as_array()) [INFO] [stderr] 644 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 645 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 640 | (page [INFO] [stderr] 641 | .as_object() [INFO] [stderr] 642 | .and_then(|x| x.get("langlinks")) [INFO] [stderr] 643 | .and_then(|x| x.as_array()) [INFO] [stderr] 644 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:644:28 [INFO] [stderr] | [INFO] [stderr] 644 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:668:9 [INFO] [stderr] | [INFO] [stderr] 668 | / match self.redirect(&q) { [INFO] [stderr] 669 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_coordinates(), [INFO] [stderr] 670 | | None => (), [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_coordinates() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:677:33 [INFO] [stderr] | [INFO] [stderr] 677 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:706:14 [INFO] [stderr] | [INFO] [stderr] 706 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn page_from_title<'a>(&'a self, title: String) -> Page<'a, A> { [INFO] [stderr] 284 | | Page::from_title(self, title) [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:288:5 [INFO] [stderr] | [INFO] [stderr] 288 | / pub fn page_from_pageid<'a>(&'a self, pageid: String) -> Page<'a, A> { [INFO] [stderr] 289 | | Page::from_pageid(self, pageid) [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | / match self.redirect(&q) { [INFO] [stderr] 343 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_pageid(), [INFO] [stderr] 344 | | None => (), [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_pageid() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | / match self.redirect(&q) { [INFO] [stderr] 375 | | Some(r) => return Ok(r), [INFO] [stderr] 376 | | None => (), [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(r) = self.redirect(&q) { return Ok(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:406:29 [INFO] [stderr] | [INFO] [stderr] 406 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | / match self.redirect(&q) { [INFO] [stderr] 445 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_content(), [INFO] [stderr] 446 | | None => (), [INFO] [stderr] 447 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_content() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / match self.redirect(&q) { [INFO] [stderr] 472 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_html_content(), [INFO] [stderr] 473 | | None => (), [INFO] [stderr] 474 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_html_content() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:480:29 [INFO] [stderr] | [INFO] [stderr] 480 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | / match self.redirect(&q) { [INFO] [stderr] 502 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_summary(), [INFO] [stderr] 503 | | None => (), [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_summary() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:554:13 [INFO] [stderr] | [INFO] [stderr] 554 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:564:14 [INFO] [stderr] | [INFO] [stderr] 564 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 565 | | .as_object() [INFO] [stderr] 566 | | .and_then(|x| x.get("extlinks")) [INFO] [stderr] 567 | | .and_then(|x| x.as_array()) [INFO] [stderr] 568 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 569 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 564 | (page [INFO] [stderr] 565 | .as_object() [INFO] [stderr] 566 | .and_then(|x| x.get("extlinks")) [INFO] [stderr] 567 | .and_then(|x| x.as_array()) [INFO] [stderr] 568 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:568:28 [INFO] [stderr] | [INFO] [stderr] 568 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:590:14 [INFO] [stderr] | [INFO] [stderr] 590 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 591 | | .as_object() [INFO] [stderr] 592 | | .and_then(|x| x.get("links")) [INFO] [stderr] 593 | | .and_then(|x| x.as_array()) [INFO] [stderr] 594 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 595 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 590 | (page [INFO] [stderr] 591 | .as_object() [INFO] [stderr] 592 | .and_then(|x| x.get("links")) [INFO] [stderr] 593 | .and_then(|x| x.as_array()) [INFO] [stderr] 594 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:594:28 [INFO] [stderr] | [INFO] [stderr] 594 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:615:14 [INFO] [stderr] | [INFO] [stderr] 615 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 616 | | .as_object() [INFO] [stderr] 617 | | .and_then(|x| x.get("categories")) [INFO] [stderr] 618 | | .and_then(|x| x.as_array()) [INFO] [stderr] 619 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 620 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 615 | (page [INFO] [stderr] 616 | .as_object() [INFO] [stderr] 617 | .and_then(|x| x.get("categories")) [INFO] [stderr] 618 | .and_then(|x| x.as_array()) [INFO] [stderr] 619 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:619:28 [INFO] [stderr] | [INFO] [stderr] 619 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:630:13 [INFO] [stderr] | [INFO] [stderr] 630 | Result<(Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:640:14 [INFO] [stderr] | [INFO] [stderr] 640 | (page [INFO] [stderr] | ______________^ [INFO] [stderr] 641 | | .as_object() [INFO] [stderr] 642 | | .and_then(|x| x.get("langlinks")) [INFO] [stderr] 643 | | .and_then(|x| x.as_array()) [INFO] [stderr] 644 | | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] 645 | | .unwrap_or(Vec::new()), cont) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 640 | (page [INFO] [stderr] 641 | .as_object() [INFO] [stderr] 642 | .and_then(|x| x.get("langlinks")) [INFO] [stderr] 643 | .and_then(|x| x.as_array()) [INFO] [stderr] 644 | .map(|x| x.into_iter().cloned().collect()).unwrap_or_default(), cont) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:644:28 [INFO] [stderr] | [INFO] [stderr] 644 | .map(|x| x.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:668:9 [INFO] [stderr] | [INFO] [stderr] 668 | / match self.redirect(&q) { [INFO] [stderr] 669 | | Some(r) => return Page::from_title(&self.wikipedia, r).get_coordinates(), [INFO] [stderr] 670 | | None => (), [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(r) = self.redirect(&q) { return Page::from_title(&self.wikipedia, r).get_coordinates() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:677:33 [INFO] [stderr] | [INFO] [stderr] 677 | .and_then(|x| x.into_iter().next()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:706:14 [INFO] [stderr] | [INFO] [stderr] 706 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | let results = wikipedia.geosearch(-34.603333, -58.381667, 10).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `34.603_333` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration.rs:24:56 [INFO] [stderr] | [INFO] [stderr] 24 | let results = wikipedia.geosearch(-34.603333, -58.381667, 10).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `58.381_667` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/integration.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | assert!(results.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/integration.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | assert!(results.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in images.enumerate()` or similar iterators [INFO] [stderr] --> tests/integration.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for i in images { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/integration.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | assert!(i.title.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!i.title.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/integration.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | assert!(i.url.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!i.url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/integration.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | assert!(i.description_url.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!i.description_url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in references.enumerate()` or similar iterators [INFO] [stderr] --> tests/integration.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | for r in references { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in links.enumerate()` or similar iterators [INFO] [stderr] --> tests/integration.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | for r in links { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/integration.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / langlinks [INFO] [stderr] 179 | | .iter() [INFO] [stderr] 180 | | .filter(|ll| ll.lang == "nl".to_owned()) [INFO] [stderr] 181 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|ll| ll.lang == "nl".to_owned()).next()` with `find(|ll| ll.lang == "nl".to_owned())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/integration.rs:180:41 [INFO] [stderr] | [INFO] [stderr] 180 | .filter(|ll| ll.lang == "nl".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"nl"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/integration.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | / langlinks [INFO] [stderr] 188 | | .iter() [INFO] [stderr] 189 | | .filter(|ll| ll.lang == "fr".to_owned()) [INFO] [stderr] 190 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|ll| ll.lang == "fr".to_owned()).next()` with `find(|ll| ll.lang == "fr".to_owned())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/integration.rs:189:41 [INFO] [stderr] | [INFO] [stderr] 189 | .filter(|ll| ll.lang == "fr".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"fr"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in categories.enumerate()` or similar iterators [INFO] [stderr] --> tests/integration.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | for ca in categories { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.05s [INFO] running `"docker" "inspect" "98e3eae71b8b4c793babf213ce67a568710a56400da51b2701cff76a538719a2"` [INFO] running `"docker" "rm" "-f" "98e3eae71b8b4c793babf213ce67a568710a56400da51b2701cff76a538719a2"` [INFO] [stdout] 98e3eae71b8b4c793babf213ce67a568710a56400da51b2701cff76a538719a2