[INFO] crate wifi_drone 0.0.3 is already in cache
[INFO] extracting crate wifi_drone 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/wifi_drone/0.0.3
[INFO] extracting crate wifi_drone 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wifi_drone/0.0.3
[INFO] validating manifest of wifi_drone-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wifi_drone-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wifi_drone-0.0.3
[INFO] finished frobbing wifi_drone-0.0.3
[INFO] frobbed toml for wifi_drone-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/wifi_drone/0.0.3/Cargo.toml
[INFO] started frobbing wifi_drone-0.0.3
[INFO] finished frobbing wifi_drone-0.0.3
[INFO] frobbed toml for wifi_drone-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wifi_drone/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wifi_drone-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wifi_drone/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ed9e2034a7e6b22607f5332f22dc530bc366e09377c5f3193dba579f330d4967
[INFO] running `"docker" "start" "-a" "ed9e2034a7e6b22607f5332f22dc530bc366e09377c5f3193dba579f330d4967"`
[INFO] [stderr]    Compiling phf_shared v0.7.24
[INFO] [stderr]     Checking shared_library v0.1.9
[INFO] [stderr]    Compiling gl_generator v0.5.5
[INFO] [stderr]     Checking x11-dl v2.18.3
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]     Checking tempfile v2.2.0
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling phf_generator v0.7.24
[INFO] [stderr]    Compiling phf v0.7.24
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]    Compiling phf_codegen v0.7.24
[INFO] [stderr]    Compiling glutin v0.8.1
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.8.7
[INFO] [stderr]     Checking wayland-client v0.8.7
[INFO] [stderr]     Checking wayland-kbd v0.8.0
[INFO] [stderr]     Checking wayland-window v0.5.0
[INFO] [stderr]     Checking winit v0.6.4
[INFO] [stderr]     Checking wifi_drone v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gamepad.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Gamepad { socket: socket };
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/heartbeat.rs:23:28
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/heartbeat.rs:23:44
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:52
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:82
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gamepad.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Gamepad { socket: socket };
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/heartbeat.rs:23:28
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/heartbeat.rs:23:44
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:52
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/video.rs:32:82
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/command.rs:29:54
[INFO] [stderr]    |
[INFO] [stderr] 29 |             DroneMode::TakingOff => if is_toggling { () } else { self.mode = DroneMode::TookOff },
[INFO] [stderr]    |                                                      ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/command.rs:31:54
[INFO] [stderr]    |
[INFO] [stderr] 31 |             DroneMode::Landing   => if is_toggling { () } else { self.mode = DroneMode::Normal },
[INFO] [stderr]    |                                                      ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return read_data(HANDSHAKE);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(HANDSHAKE)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return read_data(VIDEO_1_1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_1_1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return read_data(VIDEO_1_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_1_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return read_data(VIDEO_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return read_data(HEARTBEAT);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(HEARTBEAT)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return data;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/gamepad.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Gamepad { socket: socket };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Gamepad { socket: socket }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/heartbeat.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Heartbeat { stream: stream, data: data }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/video.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Video { input_stream: input_stream, output_stream: output_stream, data: data }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `commands`
[INFO] [stderr]   --> src/command.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |         for i in 0..commands.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 50 |         for (i, <item>) in commands.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.as_array[1] ^ self.as_array[2] ^ self.as_array[3] ^ self.as_array[4] ^ self.as_array[5])`
[INFO] [stderr]   --> src/command.rs:59:28
[INFO] [stderr]    |
[INFO] [stderr] 59 |         self.as_array[6] = (self.as_array[1] ^ self.as_array[2] ^ self.as_array[3] ^ self.as_array[4] ^ self.as_array[5]) & 0xFF;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is used to index `functions`
[INFO] [stderr]   --> src/lib.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for index in 0..functions.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for (index, <item>) in functions.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/command.rs:29:54
[INFO] [stderr]    |
[INFO] [stderr] 29 |             DroneMode::TakingOff => if is_toggling { () } else { self.mode = DroneMode::TookOff },
[INFO] [stderr]    |                                                      ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/command.rs:31:54
[INFO] [stderr]    |
[INFO] [stderr] 31 |             DroneMode::Landing   => if is_toggling { () } else { self.mode = DroneMode::Normal },
[INFO] [stderr]    |                                                      ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return read_data(HANDSHAKE);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(HANDSHAKE)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return read_data(VIDEO_1_1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_1_1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return read_data(VIDEO_1_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_1_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return read_data(VIDEO_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(VIDEO_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return read_data(HEARTBEAT);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_data(HEARTBEAT)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constants.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return data;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/gamepad.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Gamepad { socket: socket };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Gamepad { socket: socket }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/heartbeat.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return Heartbeat { stream: stream, data: data };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Heartbeat { stream: stream, data: data }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/video.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return Video { input_stream: input_stream, output_stream: output_stream, data: data };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Video { input_stream: input_stream, output_stream: output_stream, data: data }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `commands`
[INFO] [stderr]   --> src/command.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |         for i in 0..commands.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 50 |         for (i, <item>) in commands.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.as_array[1] ^ self.as_array[2] ^ self.as_array[3] ^ self.as_array[4] ^ self.as_array[5])`
[INFO] [stderr]   --> src/command.rs:59:28
[INFO] [stderr]    |
[INFO] [stderr] 59 |         self.as_array[6] = (self.as_array[1] ^ self.as_array[2] ^ self.as_array[3] ^ self.as_array[4] ^ self.as_array[5]) & 0xFF;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is used to index `functions`
[INFO] [stderr]   --> src/lib.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for index in 0..functions.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for (index, <item>) in functions.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 31.07s
[INFO] running `"docker" "inspect" "ed9e2034a7e6b22607f5332f22dc530bc366e09377c5f3193dba579f330d4967"`
[INFO] running `"docker" "rm" "-f" "ed9e2034a7e6b22607f5332f22dc530bc366e09377c5f3193dba579f330d4967"`
[INFO] [stdout] ed9e2034a7e6b22607f5332f22dc530bc366e09377c5f3193dba579f330d4967