[INFO] crate wifi-rs 0.1.0 is already in cache [INFO] extracting crate wifi-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wifi-rs/0.1.0 [INFO] extracting crate wifi-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wifi-rs/0.1.0 [INFO] validating manifest of wifi-rs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wifi-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wifi-rs-0.1.0 [INFO] finished frobbing wifi-rs-0.1.0 [INFO] frobbed toml for wifi-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wifi-rs/0.1.0/Cargo.toml [INFO] started frobbing wifi-rs-0.1.0 [INFO] finished frobbing wifi-rs-0.1.0 [INFO] frobbed toml for wifi-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wifi-rs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wifi-rs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wifi-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 252c02acc50a8e7c73debbe4eea8dde4930b20878fb923005d4c518d1b607342 [INFO] running `"docker" "start" "-a" "252c02acc50a8e7c73debbe4eea8dde4930b20878fb923005d4c518d1b607342"` [INFO] [stderr] Checking wifi-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hotspot/providers/linux.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const HOTSPOT_GROUP: &'static str = "Hotspot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hotspot/providers/linux.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const HOTSPOT_GROUP: &'static str = "Hotspot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hotspot/providers/linux.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const HOTSPOT_GROUP: &'static str = "Hotspot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hotspot/providers/linux.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const HOTSPOT_GROUP: &'static str = "Hotspot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | if result == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hotspot/providers/linux.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | .map_err(|err| WifiHotspotError::FailedToStop(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiHotspotError::FailedToStop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platforms/linux.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|err| WifiError::IoError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WifiError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | if result == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.63s [INFO] running `"docker" "inspect" "252c02acc50a8e7c73debbe4eea8dde4930b20878fb923005d4c518d1b607342"` [INFO] running `"docker" "rm" "-f" "252c02acc50a8e7c73debbe4eea8dde4930b20878fb923005d4c518d1b607342"` [INFO] [stdout] 252c02acc50a8e7c73debbe4eea8dde4930b20878fb923005d4c518d1b607342