[INFO] crate widerwlock 0.5.0 is already in cache [INFO] extracting crate widerwlock 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/widerwlock/0.5.0 [INFO] extracting crate widerwlock 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/widerwlock/0.5.0 [INFO] validating manifest of widerwlock-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of widerwlock-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing widerwlock-0.5.0 [INFO] finished frobbing widerwlock-0.5.0 [INFO] frobbed toml for widerwlock-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/widerwlock/0.5.0/Cargo.toml [INFO] started frobbing widerwlock-0.5.0 [INFO] finished frobbing widerwlock-0.5.0 [INFO] frobbed toml for widerwlock-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/widerwlock/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting widerwlock-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/widerwlock/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78dca16d2b3c80041f94cb36d35364e63e63eca8d42136622948ec8ce1623cf9 [INFO] running `"docker" "start" "-a" "78dca16d2b3c80041f94cb36d35364e63e63eca8d42136622948ec8ce1623cf9"` [INFO] [stderr] Checking xoshiro v0.0.4 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking widerwlock v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:102:50 [INFO] [stderr] | [INFO] [stderr] 102 | UpgradeResult::AtomicUpgrade(_) => { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:103:53 [INFO] [stderr] | [INFO] [stderr] 103 | UpgradeResult::NonAtomicUpgrade(_) => { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:109:50 [INFO] [stderr] | [INFO] [stderr] 109 | UpgradeResult::AtomicUpgrade(w) => { return w; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:53 [INFO] [stderr] | [INFO] [stderr] 110 | UpgradeResult::NonAtomicUpgrade(w) => { return w; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / if !global_sync.try_fast_read_lock() { [INFO] [stderr] 168 | | if self.read_lock_slow(reader_id, &local_lock) { [INFO] [stderr] 169 | | return ReadGuard {lock: & self, reader_id } [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 167 | if !global_sync.try_fast_read_lock() && self.read_lock_slow(reader_id, &local_lock) { [INFO] [stderr] 168 | return ReadGuard {lock: & self, reader_id } [INFO] [stderr] 169 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:612:9 [INFO] [stderr] | [INFO] [stderr] 612 | return (false, false, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, false, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | / if (c & (WRITER_MASK | PREPARING_TO_GO_LOCAL)) == 0 { [INFO] [stderr] 605 | | if self.cas_state(c, (c & !GLOBAL_MASK) | PREPARING_TO_GO_LOCAL) { [INFO] [stderr] 606 | | return (true, true, false); [INFO] [stderr] 607 | | } [INFO] [stderr] 608 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 604 | if (c & (WRITER_MASK | PREPARING_TO_GO_LOCAL)) == 0 && self.cas_state(c, (c & !GLOBAL_MASK) | PREPARING_TO_GO_LOCAL) { [INFO] [stderr] 605 | return (true, true, false); [INFO] [stderr] 606 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:700:13 [INFO] [stderr] | [INFO] [stderr] 700 | / if c & (PREPARING_TO_GO_LOCAL | WRITER_MASK) == 0 { [INFO] [stderr] 701 | | if self.cas_state(c, c | WRITER_MASK | GLOBAL_MASK) { [INFO] [stderr] 702 | | return (true, c & GLOBAL_MASK == 0, c & READER_MASK != 0); [INFO] [stderr] 703 | | } [INFO] [stderr] 704 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 700 | if c & (PREPARING_TO_GO_LOCAL | WRITER_MASK) == 0 && self.cas_state(c, c | WRITER_MASK | GLOBAL_MASK) { [INFO] [stderr] 701 | return (true, c & GLOBAL_MASK == 0, c & READER_MASK != 0); [INFO] [stderr] 702 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:729:21 [INFO] [stderr] | [INFO] [stderr] 729 | return valid; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `valid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:778:21 [INFO] [stderr] | [INFO] [stderr] 778 | return valid; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `valid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:826:21 [INFO] [stderr] | [INFO] [stderr] 826 | return FilterOp::Unpark; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FilterOp::Unpark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:834:21 [INFO] [stderr] | [INFO] [stderr] 834 | return FilterOp::Skip; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FilterOp::Skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> src/lib.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | let ptr = alloc::alloc(layout) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:698:9 [INFO] [stderr] | [INFO] [stderr] 698 | / loop { [INFO] [stderr] 699 | | let c = self.load_state(); [INFO] [stderr] 700 | | if c & (PREPARING_TO_GO_LOCAL | WRITER_MASK) == 0 { [INFO] [stderr] 701 | | if self.cas_state(c, c | WRITER_MASK | GLOBAL_MASK) { [INFO] [stderr] ... | [INFO] [stderr] 705 | | return (false, false, false); [INFO] [stderr] 706 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:860:27 [INFO] [stderr] | [INFO] [stderr] 860 | (thread_id_as_u64() & LOCK_MASK as u64) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(LOCK_MASK)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `widerwlock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "78dca16d2b3c80041f94cb36d35364e63e63eca8d42136622948ec8ce1623cf9"` [INFO] running `"docker" "rm" "-f" "78dca16d2b3c80041f94cb36d35364e63e63eca8d42136622948ec8ce1623cf9"` [INFO] [stdout] 78dca16d2b3c80041f94cb36d35364e63e63eca8d42136622948ec8ce1623cf9