[INFO] crate whitespace_text_steganography 0.2.1 is already in cache [INFO] extracting crate whitespace_text_steganography 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/whitespace_text_steganography/0.2.1 [INFO] extracting crate whitespace_text_steganography 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/whitespace_text_steganography/0.2.1 [INFO] validating manifest of whitespace_text_steganography-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whitespace_text_steganography-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whitespace_text_steganography-0.2.1 [INFO] finished frobbing whitespace_text_steganography-0.2.1 [INFO] frobbed toml for whitespace_text_steganography-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/whitespace_text_steganography/0.2.1/Cargo.toml [INFO] started frobbing whitespace_text_steganography-0.2.1 [INFO] finished frobbing whitespace_text_steganography-0.2.1 [INFO] frobbed toml for whitespace_text_steganography-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/whitespace_text_steganography/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whitespace_text_steganography-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/whitespace_text_steganography/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94a7305799f0c92dc9c9819d100186407cb2f61daa762d3139749fe4fbfdc492 [INFO] running `"docker" "start" "-a" "94a7305799f0c92dc9c9819d100186407cb2f61daa762d3139749fe4fbfdc492"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking memchr v2.1.3 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking whitespace_text_steganography v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file_helpers/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn get_file_string<'a>(file_path: &'a str) -> String { [INFO] [stderr] 5 | | let mut f = File::open(file_path).expect("file not found"); [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | let mut contents = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 11 | | contents [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/revealer/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/file_helpers/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn get_file_string<'a>(file_path: &'a str) -> String { [INFO] [stderr] 5 | | let mut f = File::open(file_path).expect("file not found"); [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | let mut contents = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 11 | | contents [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/revealer/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/revealer/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / fn can_identify_zero_width_whitespace() { [INFO] [stderr] 46 | | assert!(is_zero_width_whitespace_character('​')) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::zero_width_space)] on by default [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] "fn can_identify_zero_width_whitespace() { [INFO] [stderr] assert!(is_zero_width_whitespace_character('\u{200B}')) [INFO] [stderr] }" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/revealer/mod.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | assert!(is_zero_width_whitespace_character('​')) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] "assert!(is_zero_width_whitespace_character('\u{200B}'))" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/revealer/mod.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / fn can_group_white_space() { [INFO] [stderr] 51 | | let whitespace_infested_text = String::from("W​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​h​​​​​​​​​​o​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​so list to hunt"); [INFO] [stderr] 52 | | let whitespace_groups_expected: Vec = vec![49, 10, 50]; [INFO] [stderr] 53 | | assert_eq!( [INFO] [stderr] ... | [INFO] [stderr] 56 | | ); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] "fn can_group_white_space() { [INFO] [stderr] let whitespace_infested_text = String::from("W\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}h\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}o\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}so list to hunt"); [INFO] [stderr] let whitespace_groups_expected: Vec = vec![49, 10, 50]; [INFO] [stderr] assert_eq!( [INFO] [stderr] get_whitespace_groups(whitespace_infested_text), [INFO] [stderr] whitespace_groups_expected [INFO] [stderr] ); [INFO] [stderr] }" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/revealer/mod.rs:51:53 [INFO] [stderr] | [INFO] [stderr] 51 | let whitespace_infested_text = String::from("W​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​h​​​​​​​​​​o​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​so list to hunt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] ""W\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}h\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}o\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}\u{200B}so list to hunt"" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `whitespace_text_steganography`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "94a7305799f0c92dc9c9819d100186407cb2f61daa762d3139749fe4fbfdc492"` [INFO] running `"docker" "rm" "-f" "94a7305799f0c92dc9c9819d100186407cb2f61daa762d3139749fe4fbfdc492"` [INFO] [stdout] 94a7305799f0c92dc9c9819d100186407cb2f61daa762d3139749fe4fbfdc492