[INFO] crate whiteread 0.4.4 is already in cache [INFO] extracting crate whiteread 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/whiteread/0.4.4 [INFO] extracting crate whiteread 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/whiteread/0.4.4 [INFO] validating manifest of whiteread-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of whiteread-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing whiteread-0.4.4 [INFO] finished frobbing whiteread-0.4.4 [INFO] frobbed toml for whiteread-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/whiteread/0.4.4/Cargo.toml [INFO] started frobbing whiteread-0.4.4 [INFO] finished frobbing whiteread-0.4.4 [INFO] frobbed toml for whiteread-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/whiteread/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting whiteread-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/whiteread/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c775a088172c7855ccbc9ebe9658991002cddc1521a6cb88a3bc637415ddb149 [INFO] running `"docker" "start" "-a" "c775a088172c7855ccbc9ebe9658991002cddc1521a6cb88a3bc637415ddb149"` [INFO] [stderr] Checking whiteread v0.4.4 (/opt/crater/workdir) [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:29:61 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(s: &'a str) -> Self { SplitAsciiWhitespace { s: s, position: 0 } } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | SplitAsciiWhitespace { s: s, position: position } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:38 [INFO] [stderr] | [INFO] [stderr] 34 | SplitAsciiWhitespace { s: s, position: position } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:654:9 [INFO] [stderr] | [INFO] [stderr] 654 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 229 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 230 | | }; [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 237 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 238 | | }; [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/reader.rs:264:16 [INFO] [stderr] | [INFO] [stderr] 264 | if let Some(_) = self.next_within_line() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 265 | | Err(Leftovers).add_lineinfo(self) [INFO] [stderr] 266 | | } else { [INFO] [stderr] 267 | | Ok(value) [INFO] [stderr] 268 | | } [INFO] [stderr] | |_________- help: try this: `if self.next_within_line().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:282:16 [INFO] [stderr] | [INFO] [stderr] 282 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 283 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:303:20 [INFO] [stderr] | [INFO] [stderr] 303 | if let None = self.read_line()? { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 304 | | return Ok(None); [INFO] [stderr] 305 | | }; [INFO] [stderr] | |_____________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/reader.rs:402:21 [INFO] [stderr] | [INFO] [stderr] 402 | pub fn to_owned(self) -> OwnedError { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:29:61 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(s: &'a str) -> Self { SplitAsciiWhitespace { s: s, position: 0 } } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | SplitAsciiWhitespace { s: s, position: position } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:38 [INFO] [stderr] | [INFO] [stderr] 34 | SplitAsciiWhitespace { s: s, position: position } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:654:9 [INFO] [stderr] | [INFO] [stderr] 654 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/misc.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let foo: ((i32, String), Vec>) = parse_string(data).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | && trimmed.ends_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | .split(";").nth(0).unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | for _ in 0 .. ident+1 { write!(w, " ")? } [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/reader.rs:186:38 [INFO] [stderr] | [INFO] [stderr] 186 | let x: i32 = reader.finish().expect(&format!("failed at: {:?}", input)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed at: {:?}", input))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 229 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 230 | | }; [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 237 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 238 | | }; [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/reader.rs:264:16 [INFO] [stderr] | [INFO] [stderr] 264 | if let Some(_) = self.next_within_line() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 265 | | Err(Leftovers).add_lineinfo(self) [INFO] [stderr] 266 | | } else { [INFO] [stderr] 267 | | Ok(value) [INFO] [stderr] 268 | | } [INFO] [stderr] | |_________- help: try this: `if self.next_within_line().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:282:16 [INFO] [stderr] | [INFO] [stderr] 282 | if let None = self.read_line()? { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 283 | | return Err(TooShort).add_lineinfo(self); [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/reader.rs:303:20 [INFO] [stderr] | [INFO] [stderr] 303 | if let None = self.read_line()? { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 304 | | return Ok(None); [INFO] [stderr] 305 | | }; [INFO] [stderr] | |_____________- help: try this: `if self.read_line()?.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/reader.rs:402:21 [INFO] [stderr] | [INFO] [stderr] 402 | pub fn to_owned(self) -> OwnedError { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | && trimmed.ends_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | .split(";").nth(0).unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | for _ in 0 .. ident+1 { write!(w, " ")? } [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `"docker" "inspect" "c775a088172c7855ccbc9ebe9658991002cddc1521a6cb88a3bc637415ddb149"` [INFO] running `"docker" "rm" "-f" "c775a088172c7855ccbc9ebe9658991002cddc1521a6cb88a3bc637415ddb149"` [INFO] [stdout] c775a088172c7855ccbc9ebe9658991002cddc1521a6cb88a3bc637415ddb149