[INFO] crate which 2.0.1 is already in cache [INFO] extracting crate which 2.0.1 into work/ex/clippy-test-run/sources/stable/reg/which/2.0.1 [INFO] extracting crate which 2.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/which/2.0.1 [INFO] validating manifest of which-2.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of which-2.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing which-2.0.1 [INFO] finished frobbing which-2.0.1 [INFO] frobbed toml for which-2.0.1 written to work/ex/clippy-test-run/sources/stable/reg/which/2.0.1/Cargo.toml [INFO] started frobbing which-2.0.1 [INFO] finished frobbing which-2.0.1 [INFO] frobbed toml for which-2.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/which/2.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting which-2.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/which/2.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0956703890ca682ede10f8c723302383354bd834e49e26f6e03bb116dbdfd34a [INFO] running `"docker" "start" "-a" "0956703890ca682ede10f8c723302383354bd834e49e26f6e03bb116dbdfd34a"` [INFO] [stderr] Checking which v2.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | tempdir: tempdir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tempdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | tempdir: tempdir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tempdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `empty_line_after_outer_attr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature = "cargo-clippy", allow(empty_line_after_outer_attr))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::empty_line_after_outer_attr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `empty_line_after_outer_attr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature = "cargo-clippy", allow(empty_line_after_outer_attr))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::empty_line_after_outer_attr` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/finder.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(ErrorKind::CannotFindBinaryPath.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::CannotFindBinaryPath.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `empty_line_after_outer_attr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature = "cargo-clippy", allow(empty_line_after_outer_attr))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::empty_line_after_outer_attr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `empty_line_after_outer_attr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature = "cargo-clippy", allow(empty_line_after_outer_attr))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::empty_line_after_outer_attr` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/finder.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(ErrorKind::CannotFindBinaryPath.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::CannotFindBinaryPath.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | const SUBDIRS: &'static [&'static str] = &["a", "b", "c"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | const SUBDIRS: &'static [&'static str] = &["a", "b", "c"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | const BIN_NAME: &'static str = "bin"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "0956703890ca682ede10f8c723302383354bd834e49e26f6e03bb116dbdfd34a"` [INFO] running `"docker" "rm" "-f" "0956703890ca682ede10f8c723302383354bd834e49e26f6e03bb116dbdfd34a"` [INFO] [stdout] 0956703890ca682ede10f8c723302383354bd834e49e26f6e03bb116dbdfd34a