[INFO] crate wham 0.9.4 is already in cache [INFO] extracting crate wham 0.9.4 into work/ex/clippy-test-run/sources/stable/reg/wham/0.9.4 [INFO] extracting crate wham 0.9.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wham/0.9.4 [INFO] validating manifest of wham-0.9.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wham-0.9.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wham-0.9.4 [INFO] finished frobbing wham-0.9.4 [INFO] frobbed toml for wham-0.9.4 written to work/ex/clippy-test-run/sources/stable/reg/wham/0.9.4/Cargo.toml [INFO] started frobbing wham-0.9.4 [INFO] finished frobbing wham-0.9.4 [INFO] frobbed toml for wham-0.9.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wham/0.9.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wham-0.9.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wham/0.9.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9dcb9e461d51274abbe2c1a7bcee961d9c37cee2ead64d33db6a1611e4dc83e [INFO] running `"docker" "start" "-a" "e9dcb9e461d51274abbe2c1a7bcee961d9c37cee2ead64d33db6a1611e4dc83e"` [INFO] [stderr] Checking c_vec v1.0.12 [INFO] [stderr] Compiling GSL v1.1.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking wham v0.9.4 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:58 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:73 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:80 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:95 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/histogram.rs:95:4 [INFO] [stderr] | [INFO] [stderr] 95 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:58 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:73 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:80 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:184:95 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/histogram.rs:95:4 [INFO] [stderr] | [INFO] [stderr] 95 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/histogram.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | bias_sum [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/histogram.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | let bias_sum = (-bias_sum/self.kT).exp(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error_analysis.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return weights [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `weights` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | static k_B: f64 = 0.0083144621; // kJ/mol*K [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.008_314_462_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/histogram.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | bias_sum [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/histogram.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | let bias_sum = (-bias_sum/self.kT).exp(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | assert_delta!(0.134722337796, ds.calc_bias(3, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.134_722_337_796` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:208:53 [INFO] [stderr] | [INFO] [stderr] 208 | assert_delta!(0.134722337796, ds.calc_bias(3, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | assert_delta!(0.134722337796, ds.calc_bias(3, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.134_722_337_796` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:211:41 [INFO] [stderr] | [INFO] [stderr] 211 | assert_delta!(1.0, ds.calc_bias(4,0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:214:41 [INFO] [stderr] | [INFO] [stderr] 214 | assert_delta!(0.0, ds.calc_bias(0,0), 0.0000001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | assert_delta!(0.134722337796, ds.calc_bias(3, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.134_722_337_796` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:223:53 [INFO] [stderr] | [INFO] [stderr] 223 | assert_delta!(0.134722337796, ds.calc_bias(3, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | assert_delta!(1.0, ds.calc_bias(4, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | assert_delta!(0.0000000000000117769, ds.calc_bias(0, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0.000_000_000_000_011_776_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:231:60 [INFO] [stderr] | [INFO] [stderr] 231 | assert_delta!(0.0000000000000117769, ds.calc_bias(0, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | assert_delta!(0.00000001, ds.calc_bias(1, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:234:49 [INFO] [stderr] | [INFO] [stderr] 234 | assert_delta!(0.00000001, ds.calc_bias(1, 0), 0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:261:52 [INFO] [stderr] | [INFO] [stderr] 261 | assert_delta!(2.0, ds.get_weighted_bin_count(0), 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:262:52 [INFO] [stderr] | [INFO] [stderr] 262 | assert_delta!(2.0, ds.get_weighted_bin_count(1), 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:263:52 [INFO] [stderr] | [INFO] [stderr] 263 | assert_delta!(6.0, ds.get_weighted_bin_count(2), 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:264:53 [INFO] [stderr] | [INFO] [stderr] 264 | assert_delta!(10.0, ds.get_weighted_bin_count(3), 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/histogram.rs:265:53 [INFO] [stderr] | [INFO] [stderr] 265 | assert_delta!(24.0, ds.get_weighted_bin_count(4), 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error_analysis.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return weights [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `weights` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | static k_B: f64 = 0.0083144621; // kJ/mol*K [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.008_314_462_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | let expected = vec!(0.0, 0.0825296687031316, 40.92355847097493, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.082_529_668_703_131_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:268:54 [INFO] [stderr] | [INFO] [stderr] 268 | let expected = vec!(0.0, 0.0825296687031316, 40.92355847097493, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `40.923_558_470_974_93` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:269:29 [INFO] [stderr] | [INFO] [stderr] 269 | 124226.70003377, 2308526035.5283747); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `124_226.700_033_77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:269:46 [INFO] [stderr] | [INFO] [stderr] 269 | 124226.70003377, 2308526035.5283747); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2_308_526_035.528_374_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:272:34 [INFO] [stderr] | [INFO] [stderr] 272 | assert_delta!(expected[b], p, 0.0000001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | let expected = vec!(15.927477169990633, 15.927477169990633); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `15.927_477_169_990_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:280:49 [INFO] [stderr] | [INFO] [stderr] 280 | let expected = vec!(15.927477169990633, 15.927477169990633); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `15.927_477_169_990_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:283:48 [INFO] [stderr] | [INFO] [stderr] 283 | assert_delta!(expected[window], F, 0.0000001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:295:30 [INFO] [stderr] | [INFO] [stderr] 295 | let expected_P = vec!(0.0, 0.0825296687031316, 40.92355847097493, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.082_529_668_703_131_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:295:50 [INFO] [stderr] | [INFO] [stderr] 295 | let expected_P = vec!(0.0, 0.0825296687031316, 40.92355847097493, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `40.923_558_470_974_93` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | 124226.70003377, 2308526035.5283747); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `124_226.700_033_77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | 124226.70003377, 2308526035.5283747); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2_308_526_035.528_374_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | let num_bins = cfg.num_bins.iter().fold(1, |state, &bins| state*bins); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `split`. [INFO] [stderr] --> src/io.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 1..cfg.dimens+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for in split.iter().skip(1).take(cfg.dimens) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/io.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 1..cfg.dimens+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=cfg.dimens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `split`. [INFO] [stderr] --> src/io.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in (1+cfg.dimens)..(1+2*cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in split.iter().take((1+2*cfg.dimens)).skip((1+cfg.dimens)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/io.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in (1+cfg.dimens)..(1+2*cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((1+cfg.dimens)..=2*cfg.dimens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if histograms.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!histograms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | fn flat_index(indeces: &Vec, lengths: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:94:46 [INFO] [stderr] | [INFO] [stderr] 94 | fn flat_index(indeces: &Vec, lengths: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:97:47 [INFO] [stderr] | [INFO] [stderr] 97 | idx += indeces[i]*lengths[0..i].iter() [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 98 | | .fold(1, |state, &l| { state * l }); [INFO] [stderr] | |_______________________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dimen` is used to index `values` [INFO] [stderr] --> src/io.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for dimen in 0..cfg.dimens { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for (dimen, ) in values.iter().enumerate().take(cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:128:41 [INFO] [stderr] | [INFO] [stderr] 128 | let total_bins = cfg.num_bins.iter().fold(1, |s, &x| { s*x }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:142:62 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:58 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:79 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:96 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:117 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/histogram.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn new(num_bins: usize, dimens_lengths: Vec, bin_width: Vec, hist_min: Vec, hist_max: Vec, bias_pos: Vec, bias_fc: Vec, kT: f64, histograms: Vec, cyclic: bool) -> Dataset { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | let num_windows = histograms.len(); [INFO] [stderr] 66 | | let bias: Vec = vec![0.0; num_bins*num_windows]; [INFO] [stderr] 67 | | let weights = vec![1.0; num_windows]; [INFO] [stderr] ... | [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/histogram.rs:108:48 [INFO] [stderr] | [INFO] [stderr] 108 | let denom = lengths.iter().take(dimen).fold(1, |s,&x| s*x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/histogram.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | tmp = tmp % denom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `tmp %= denom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bin` is only used to index `P_std`. [INFO] [stderr] --> src/error_analysis.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | for bin in 0..ds.num_bins { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in P_std.iter_mut().take(ds.num_bins) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:68:49 [INFO] [stderr] | [INFO] [stderr] 68 | denom_sum += (dataset.weights[window] * h.num_points as f64) * bias * F[window]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(h.num_points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | let free_energy_std: Vec; [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | if cfg.bootstrap > 0 { [INFO] [stderr] 165 | | let error_est = error_analysis::run_bootstrap(&cfg, dataset.clone(), &P, cfg.bootstrap); [INFO] [stderr] 166 | | P_std = error_est.0; [INFO] [stderr] ... | [INFO] [stderr] 170 | | free_energy_std = vec![0.0; P.len()]; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let free_energy_std = if cfg.bootstrap > 0 { ..; error_est.1 } else { ..; $ crate :: vec :: from_elem ( $ elem , $ n ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:218:2 [INFO] [stderr] | [INFO] [stderr] 218 | writeln!(lock, "# PMF"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:219:2 [INFO] [stderr] | [INFO] [stderr] 219 | writeln!(lock, "#bin\t\tFree Energy\t\t+/-\t\tP(x)\t\t+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:3 [INFO] [stderr] | [INFO] [stderr] 221 | writeln!(lock, "{:9.5}\t{:9.5}\t{:9.5}\t{:9.5}\t{:9.5}", bin, A[bin], A_std[bin], P[bin], P_std[bin]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:223:2 [INFO] [stderr] | [INFO] [stderr] 223 | writeln!(lock, "# Bias offsets"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:224:2 [INFO] [stderr] | [INFO] [stderr] 224 | writeln!(lock, "#Window\t\tF\t\tF_prev"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:226:3 [INFO] [stderr] | [INFO] [stderr] 226 | writeln!(lock, "{}\t{:9.5}\t{:8.8}", window, F[window], (F[window]-F_prev[window]).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | let num_bins = cfg.num_bins.iter().fold(1, |state, &bins| state*bins); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `split`. [INFO] [stderr] --> src/io.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 1..cfg.dimens+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for in split.iter().skip(1).take(cfg.dimens) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/io.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 1..cfg.dimens+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=cfg.dimens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `split`. [INFO] [stderr] --> src/io.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in (1+cfg.dimens)..(1+2*cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in split.iter().take((1+2*cfg.dimens)).skip((1+cfg.dimens)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/io.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in (1+cfg.dimens)..(1+2*cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((1+cfg.dimens)..=2*cfg.dimens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if histograms.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!histograms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | fn flat_index(indeces: &Vec, lengths: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:94:46 [INFO] [stderr] | [INFO] [stderr] 94 | fn flat_index(indeces: &Vec, lengths: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:97:47 [INFO] [stderr] | [INFO] [stderr] 97 | idx += indeces[i]*lengths[0..i].iter() [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 98 | | .fold(1, |state, &l| { state * l }); [INFO] [stderr] | |_______________________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dimen` is used to index `values` [INFO] [stderr] --> src/io.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for dimen in 0..cfg.dimens { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for (dimen, ) in values.iter().enumerate().take(cfg.dimens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/io.rs:128:41 [INFO] [stderr] | [INFO] [stderr] 128 | let total_bins = cfg.num_bins.iter().fold(1, |s, &x| { s*x }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/io.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:142:62 [INFO] [stderr] | [INFO] [stderr] 142 | if line.starts_with("#") || line.starts_with("@") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:58 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:79 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:96 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:177:117 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn write_results(out_file: &str, ds: &Dataset, free: &Vec, free_std: &Vec, prob: &Vec, prob_std: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | writeln!(buf, "#{} {} {} {} {}", header, "Free Energy", "+/-", "Probability", "+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/io.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | hist_min: vec![-3.14], [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/io.rs:204:28 [INFO] [stderr] | [INFO] [stderr] 204 | hist_max: vec![3.14], [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | assert_eq!(0.0, h.bins[2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | assert_eq!(0.0, h.bins[2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | assert_eq!(11.0, h.bins[3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | assert_eq!(11.0, h.bins[3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(2236.0, h.bins[4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(2236.0, h.bins[4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(2714.0, h.bins[5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(2714.0, h.bins[5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | assert_eq!(39.0, h.bins[6]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | assert_eq!(39.0, h.bins[6]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(0.0, h.bins[7]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(0.0, h.bins[7]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(cfg.temperature * k_B, ds.kT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(cfg.temperature * k_B, ds.kT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/histogram.rs:64:2 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn new(num_bins: usize, dimens_lengths: Vec, bin_width: Vec, hist_min: Vec, hist_max: Vec, bias_pos: Vec, bias_fc: Vec, kT: f64, histograms: Vec, cyclic: bool) -> Dataset { [INFO] [stderr] | _____^ [INFO] [stderr] 65 | | let num_windows = histograms.len(); [INFO] [stderr] 66 | | let bias: Vec = vec![0.0; num_bins*num_windows]; [INFO] [stderr] 67 | | let weights = vec![1.0; num_windows]; [INFO] [stderr] ... | [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/histogram.rs:108:48 [INFO] [stderr] | [INFO] [stderr] 108 | let denom = lengths.iter().take(dimen).fold(1, |s,&x| s*x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/histogram.rs:110:10 [INFO] [stderr] | [INFO] [stderr] 110 | tmp = tmp % denom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `tmp %= denom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:241:14 [INFO] [stderr] | [INFO] [stderr] 241 | .map(|x| *x as f64 + 0.5).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `expected` [INFO] [stderr] --> src/histogram.rs:242:12 [INFO] [stderr] | [INFO] [stderr] 242 | for i in 0..9 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 242 | for (i, ) in expected.iter().enumerate().take(9) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/histogram.rs:243:4 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(expected[i], ds.get_coords_for_bin(i)[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/histogram.rs:243:4 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(expected[i], ds.get_coords_for_bin(i)[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bin` is only used to index `P_std`. [INFO] [stderr] --> src/error_analysis.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | for bin in 0..ds.num_bins { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in P_std.iter_mut().take(ds.num_bins) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:68:49 [INFO] [stderr] | [INFO] [stderr] 68 | denom_sum += (dataset.weights[window] * h.num_points as f64) * bias * F[window]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(h.num_points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:163:2 [INFO] [stderr] | [INFO] [stderr] 163 | let free_energy_std: Vec; [INFO] [stderr] | _____^ [INFO] [stderr] 164 | | if cfg.bootstrap > 0 { [INFO] [stderr] 165 | | let error_est = error_analysis::run_bootstrap(&cfg, dataset.clone(), &P, cfg.bootstrap); [INFO] [stderr] 166 | | P_std = error_est.0; [INFO] [stderr] ... | [INFO] [stderr] 170 | | free_energy_std = vec![0.0; P.len()]; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let free_energy_std = if cfg.bootstrap > 0 { ..; error_est.1 } else { ..; $ crate :: vec :: from_elem ( $ elem , $ n ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:218:2 [INFO] [stderr] | [INFO] [stderr] 218 | writeln!(lock, "# PMF"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:219:2 [INFO] [stderr] | [INFO] [stderr] 219 | writeln!(lock, "#bin\t\tFree Energy\t\t+/-\t\tP(x)\t\t+/-"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:3 [INFO] [stderr] | [INFO] [stderr] 221 | writeln!(lock, "{:9.5}\t{:9.5}\t{:9.5}\t{:9.5}\t{:9.5}", bin, A[bin], A_std[bin], P[bin], P_std[bin]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:223:2 [INFO] [stderr] | [INFO] [stderr] 223 | writeln!(lock, "# Bias offsets"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:224:2 [INFO] [stderr] | [INFO] [stderr] 224 | writeln!(lock, "#Window\t\tF\t\tF_prev"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:226:3 [INFO] [stderr] | [INFO] [stderr] 226 | writeln!(lock, "{}\t{:9.5}\t{:8.8}", window, F[window], (F[window]-F_prev[window]).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `b` is used to index `expected` [INFO] [stderr] --> src/lib.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for b in 0..dataset.num_bins { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 270 | for (b, ) in expected.iter().enumerate().take(dataset.num_bins) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `window` is used to index `expected` [INFO] [stderr] --> src/lib.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | for window in 0..dataset.num_windows { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 281 | for (window, ) in expected.iter().enumerate().take(dataset.num_windows) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wham`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "e9dcb9e461d51274abbe2c1a7bcee961d9c37cee2ead64d33db6a1611e4dc83e"` [INFO] running `"docker" "rm" "-f" "e9dcb9e461d51274abbe2c1a7bcee961d9c37cee2ead64d33db6a1611e4dc83e"` [INFO] [stdout] e9dcb9e461d51274abbe2c1a7bcee961d9c37cee2ead64d33db6a1611e4dc83e