[INFO] crate wfst 0.6.0 is already in cache [INFO] extracting crate wfst 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/wfst/0.6.0 [INFO] extracting crate wfst 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wfst/0.6.0 [INFO] validating manifest of wfst-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wfst-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wfst-0.6.0 [INFO] finished frobbing wfst-0.6.0 [INFO] frobbed toml for wfst-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/wfst/0.6.0/Cargo.toml [INFO] started frobbing wfst-0.6.0 [INFO] finished frobbing wfst-0.6.0 [INFO] frobbed toml for wfst-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wfst/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wfst-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wfst/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 656f7be7a46b12213bc5e09eb650b7c5a76ad2f746d121ef114a17e3a61db06b [INFO] running `"docker" "start" "-a" "656f7be7a46b12213bc5e09eb650b7c5a76ad2f746d121ef114a17e3a61db06b"` [INFO] [stderr] Checking bincode v0.6.1 [INFO] [stderr] Checking wfst v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | TropicalWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | LogWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:302:23 [INFO] [stderr] | [INFO] [stderr] 302 | MinmaxWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | item: item [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithms/shortestpath.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let Pair(p, c) = pair.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithms/shortestpath.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | let Pair(p, c) = pair.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wfst_vec.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | VecState { finalweight: finalweight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `finalweight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | TropicalWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | LogWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semiring/floatweight.rs:302:23 [INFO] [stderr] | [INFO] [stderr] 302 | MinmaxWeight {val: val} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | item: item [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithms/shortestpath.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let Pair(p, c) = pair.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithms/shortestpath.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | let Pair(p, c) = pair.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wfst_vec.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | VecState { finalweight: finalweight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `finalweight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | d as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | DEFAULT_DELTA as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DEFAULT_DELTA)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | d as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | DEFAULT_DELTA as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DEFAULT_DELTA)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/semiring/float.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | self == f64::NAN [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cmp_nan)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | i as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/semiring/float.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | self == f32::NAN [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135| / impl> PartialEq for TropicalWeight { [INFO] [stderr] 136| | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 137| | if let Some(val) = self.val.clone() { [INFO] [stderr] 138| | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 146| | } [INFO] [stderr] 147| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:274:1 [INFO] [stderr] | [INFO] [stderr] 274 | / impl> PartialEq for LogWeight { [INFO] [stderr] 275 | | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 276 | | if let Some(val) = self.val.clone() { [INFO] [stderr] 277 | | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:389:1 [INFO] [stderr] | [INFO] [stderr] 389 | / impl> PartialEq for MinmaxWeight { [INFO] [stderr] 390 | | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 391 | | if let Some(val) = self.val.clone() { [INFO] [stderr] 392 | | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::LinkedHashSet` [INFO] [stderr] --> src/utils.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | LinkedHashSet(LinkedHashMap::new()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn peek<'b>(&'b self) -> Option<&'b T> { [INFO] [stderr] 150 | | match self.heap.peek() { [INFO] [stderr] 151 | | None => None, [INFO] [stderr] 152 | | Some(item) => Some(&item.item) [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/algorithms/shortestpath.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 158 | let mut r: Vec = Vec::with_capacity(nstates); [INFO] [stderr] | --------------------------- help: consider replace allocation with: `vec![0; nstates]` [INFO] [stderr] 159 | r.resize(nstates, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/shortestpath.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | let _ppair = previous.get(&pair).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&previous[&pair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/shortestpath.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | let pp = *statemap.get(&ppair).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statemap[&ppair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let last_path = paths.get(last_path_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | explored_arcs.get_mut(start).unwrap().as_mut().unwrap().push(arc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `explored_arcs[start]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithms/connect.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | for i in (0..index+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | paths.get_mut(last_path_idx).unwrap().push(start); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | paths.get_mut(last_path_idx).unwrap().push(start); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `wfst_vec::VecFst` [INFO] [stderr] --> src/wfst_vec.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Self { [INFO] [stderr] 116 | | VecFst { states: Vec::new(), [INFO] [stderr] 117 | | startstate: None, [INFO] [stderr] 118 | | isyms: None, [INFO] [stderr] 119 | | osyms: None } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wfst`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | d as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | DEFAULT_DELTA as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DEFAULT_DELTA)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | d as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | DEFAULT_DELTA as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DEFAULT_DELTA)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/semiring/float.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | self == f64::NAN [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cmp_nan)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/semiring/float.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | i as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/semiring/float.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | self == f32::NAN [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135| / impl> PartialEq for TropicalWeight { [INFO] [stderr] 136| | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 137| | if let Some(val) = self.val.clone() { [INFO] [stderr] 138| | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 146| | } [INFO] [stderr] 147| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:274:1 [INFO] [stderr] | [INFO] [stderr] 274 | / impl> PartialEq for LogWeight { [INFO] [stderr] 275 | | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 276 | | if let Some(val) = self.val.clone() { [INFO] [stderr] 277 | | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/semiring/floatweight.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Clone, Debug, Hash, RustcEncodable, RustcDecodable)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/semiring/floatweight.rs:389:1 [INFO] [stderr] | [INFO] [stderr] 389 | / impl> PartialEq for MinmaxWeight { [INFO] [stderr] 390 | | fn eq(&self, rhs: &Self) -> bool { [INFO] [stderr] 391 | | if let Some(val) = self.val.clone() { [INFO] [stderr] 392 | | if let Some(val2) = rhs.val.clone() { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::LinkedHashSet` [INFO] [stderr] --> src/utils.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | LinkedHashSet(LinkedHashMap::new()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn peek<'b>(&'b self) -> Option<&'b T> { [INFO] [stderr] 150 | | match self.heap.peek() { [INFO] [stderr] 151 | | None => None, [INFO] [stderr] 152 | | Some(item) => Some(&item.item) [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/algorithms/shortestpath.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 158 | let mut r: Vec = Vec::with_capacity(nstates); [INFO] [stderr] | --------------------------- help: consider replace allocation with: `vec![0; nstates]` [INFO] [stderr] 159 | r.resize(nstates, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/shortestpath.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | let _ppair = previous.get(&pair).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&previous[&pair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/shortestpath.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | let pp = *statemap.get(&ppair).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statemap[&ppair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let last_path = paths.get(last_path_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | explored_arcs.get_mut(start).unwrap().as_mut().unwrap().push(arc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `explored_arcs[start]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithms/connect.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | for i in (0..index+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | paths.get_mut(last_path_idx).unwrap().push(start); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithms/connect.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | paths.get_mut(last_path_idx).unwrap().push(start); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `paths[last_path_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `wfst_vec::VecFst` [INFO] [stderr] --> src/wfst_vec.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Self { [INFO] [stderr] 116 | | VecFst { states: Vec::new(), [INFO] [stderr] 117 | | startstate: None, [INFO] [stderr] 118 | | isyms: None, [INFO] [stderr] 119 | | osyms: None } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wfst`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "656f7be7a46b12213bc5e09eb650b7c5a76ad2f746d121ef114a17e3a61db06b"` [INFO] running `"docker" "rm" "-f" "656f7be7a46b12213bc5e09eb650b7c5a76ad2f746d121ef114a17e3a61db06b"` [INFO] [stdout] 656f7be7a46b12213bc5e09eb650b7c5a76ad2f746d121ef114a17e3a61db06b