[INFO] crate wesley 0.1.0 is already in cache [INFO] extracting crate wesley 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wesley/0.1.0 [INFO] extracting crate wesley 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wesley/0.1.0 [INFO] validating manifest of wesley-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wesley-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wesley-0.1.0 [INFO] finished frobbing wesley-0.1.0 [INFO] frobbed toml for wesley-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wesley/0.1.0/Cargo.toml [INFO] started frobbing wesley-0.1.0 [INFO] finished frobbing wesley-0.1.0 [INFO] frobbed toml for wesley-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wesley/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wesley-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wesley/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e7723bbbe0f37651f52f47ad936feb377f82789ebcc4b16e5a5e90d329785a28 [INFO] running `"docker" "start" "-a" "e7723bbbe0f37651f52f47ad936feb377f82789ebcc4b16e5a5e90d329785a28"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking wesley v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | only_paths: only_paths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `only_paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | exclude_paths: exclude_paths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exclude_paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:104:11 [INFO] [stderr] | [INFO] [stderr] 104 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | only_paths: only_paths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `only_paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | exclude_paths: exclude_paths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exclude_paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:104:11 [INFO] [stderr] | [INFO] [stderr] 104 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | return opts; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `opts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / return ProgramOpts { [INFO] [stderr] 51 | | help: matches.opt_present("h"), [INFO] [stderr] 52 | | only_paths: only_paths, [INFO] [stderr] 53 | | exclude_paths: exclude_paths, [INFO] [stderr] 54 | | command: matches.free [INFO] [stderr] 55 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | ProgramOpts { [INFO] [stderr] 51 | help: matches.opt_present("h"), [INFO] [stderr] 52 | only_paths: only_paths, [INFO] [stderr] 53 | exclude_paths: exclude_paths, [INFO] [stderr] 54 | command: matches.free [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:46:6 [INFO] [stderr] | [INFO] [stderr] 46 | if only_paths.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `only_paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match result { [INFO] [stderr] 86 | | Ok(Event{op: Ok(_), path: Some(path)}) => { [INFO] [stderr] 87 | | let matching_exclude = program_options.exclude_paths.iter() [INFO] [stderr] 88 | | .map(|exclude| { [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => () [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Ok(Event{op: Ok(_), path: Some(path)}) = result { [INFO] [stderr] 86 | let matching_exclude = program_options.exclude_paths.iter() [INFO] [stderr] 87 | .map(|exclude| { [INFO] [stderr] 88 | let exclude_path = exclude; [INFO] [stderr] 89 | [INFO] [stderr] 90 | let mut absolute_path = std::env::current_dir().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | return opts; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `opts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / return ProgramOpts { [INFO] [stderr] 51 | | help: matches.opt_present("h"), [INFO] [stderr] 52 | | only_paths: only_paths, [INFO] [stderr] 53 | | exclude_paths: exclude_paths, [INFO] [stderr] 54 | | command: matches.free [INFO] [stderr] 55 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | ProgramOpts { [INFO] [stderr] 51 | help: matches.opt_present("h"), [INFO] [stderr] 52 | only_paths: only_paths, [INFO] [stderr] 53 | exclude_paths: exclude_paths, [INFO] [stderr] 54 | command: matches.free [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:46:6 [INFO] [stderr] | [INFO] [stderr] 46 | if only_paths.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `only_paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match result { [INFO] [stderr] 86 | | Ok(Event{op: Ok(_), path: Some(path)}) => { [INFO] [stderr] 87 | | let matching_exclude = program_options.exclude_paths.iter() [INFO] [stderr] 88 | | .map(|exclude| { [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => () [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Ok(Event{op: Ok(_), path: Some(path)}) = result { [INFO] [stderr] 86 | let matching_exclude = program_options.exclude_paths.iter() [INFO] [stderr] 87 | .map(|exclude| { [INFO] [stderr] 88 | let exclude_path = exclude; [INFO] [stderr] 89 | [INFO] [stderr] 90 | let mut absolute_path = std::env::current_dir().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.05s [INFO] running `"docker" "inspect" "e7723bbbe0f37651f52f47ad936feb377f82789ebcc4b16e5a5e90d329785a28"` [INFO] running `"docker" "rm" "-f" "e7723bbbe0f37651f52f47ad936feb377f82789ebcc4b16e5a5e90d329785a28"` [INFO] [stdout] e7723bbbe0f37651f52f47ad936feb377f82789ebcc4b16e5a5e90d329785a28