[INFO] crate wemo 0.0.12 is already in cache [INFO] extracting crate wemo 0.0.12 into work/ex/clippy-test-run/sources/stable/reg/wemo/0.0.12 [INFO] extracting crate wemo 0.0.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wemo/0.0.12 [INFO] validating manifest of wemo-0.0.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wemo-0.0.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wemo-0.0.12 [INFO] finished frobbing wemo-0.0.12 [INFO] frobbed toml for wemo-0.0.12 written to work/ex/clippy-test-run/sources/stable/reg/wemo/0.0.12/Cargo.toml [INFO] started frobbing wemo-0.0.12 [INFO] finished frobbing wemo-0.0.12 [INFO] frobbed toml for wemo-0.0.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wemo/0.0.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wemo-0.0.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wemo/0.0.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 023037c94f37d0dc091fe2795fb8bfce3eae40a89b0880330f3d87a21b9b392c [INFO] running `"docker" "start" "-a" "023037c94f37d0dc091fe2795fb8bfce3eae40a89b0880330f3d87a21b9b392c"` [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking hpack v0.2.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking get_if_addrs v0.4.1 [INFO] [stderr] Checking solicit v0.4.4 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking hyper v0.9.18 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking persistent v0.2.1 [INFO] [stderr] Checking bodyparser v0.4.1 [INFO] [stderr] Checking urlencoded v0.4.1 [INFO] [stderr] Checking wemo v0.0.12 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | callback_port: callback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `callback_port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | subscription_ttl_sec: subscription_ttl_sec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscription_ttl_sec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:298:7 [INFO] [stderr] | [INFO] [stderr] 298 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/soap.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | stream_socket: stream_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/ssdp.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | callback_port: callback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `callback_port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | subscription_ttl_sec: subscription_ttl_sec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscription_ttl_sec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subscriptions.rs:298:7 [INFO] [stderr] | [INFO] [stderr] 298 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/soap.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | stream_socket: stream_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/ssdp.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/net/ssdp.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | } else if self.target_ip_address.is_some() { [INFO] [stderr] | ______________^ [INFO] [stderr] 192 | | if self.target_ip_address.as_ref().unwrap() == &ip_address { [INFO] [stderr] 193 | | event_loop.shutdown(); [INFO] [stderr] 194 | | return; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | } else if self.target_ip_address.is_some() && self.target_ip_address.as_ref().unwrap() == &ip_address { [INFO] [stderr] 192 | event_loop.shutdown(); [INFO] [stderr] 193 | return; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/net/ssdp.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | } else if self.target_ip_address.is_some() { [INFO] [stderr] | ______________^ [INFO] [stderr] 192 | | if self.target_ip_address.as_ref().unwrap() == &ip_address { [INFO] [stderr] 193 | | event_loop.shutdown(); [INFO] [stderr] 194 | | return; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | } else if self.target_ip_address.is_some() && self.target_ip_address.as_ref().unwrap() == &ip_address { [INFO] [stderr] 192 | event_loop.shutdown(); [INFO] [stderr] 193 | return; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xml.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const XML: &'static str = " \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/subscriptions.rs:268:3 [INFO] [stderr] | [INFO] [stderr] 268 | stream.write(header.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:162:44 [INFO] [stderr] | [INFO] [stderr] 162 | dynamic_ip_address: RwLock::new(Some(search_result.ip_address.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ip_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device/switch.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / match result { [INFO] [stderr] 370 | | Ok(r) => { return Ok(r); }, [INFO] [stderr] 371 | | Err(_) => {}, // TODO [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(r) = result { return Ok(r); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device/switch.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / match result { [INFO] [stderr] 415 | | Ok(r) => { return Ok(r); }, [INFO] [stderr] 416 | | Err(_) => {}, // TODO: Return type [INFO] [stderr] 417 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(r) = result { return Ok(r); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:456:46 [INFO] [stderr] | [INFO] [stderr] 456 | DeviceIdentifier::StaticIp(ip) => Some(ip.clone()), [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:460:28 [INFO] [stderr] | [INFO] [stderr] 460 | .and_then(|ip| ip.clone()) [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/net/soap.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | match self.stream_socket.write_all(&mut header.as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `net::ssdp::DeviceSearch` [INFO] [stderr] --> src/net/ssdp.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> DeviceSearch { [INFO] [stderr] 55 | | let socket = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)), 0); [INFO] [stderr] 56 | | let udp_socket = UdpSocket::v4().unwrap(); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for net::ssdp::DeviceSearch { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/net/ssdp.rs:86:47 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn search_for_serial(&mut self, target: &SerialNumber, timeout_ms: u64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/ssdp.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | self.target_ip_address = Some(target.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/net/ssdp.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | self.found_devices.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.found_devices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/net/ssdp.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | self.socket.send_to(&mut header.as_bytes(), &multicast_socket) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/net/ssdp.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | for i in 0 .. amt { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 165 | for in buf.iter().take(amt) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/ssdp.rs:180:32 [INFO] [stderr] | [INFO] [stderr] 180 | let ip_address: IpAddr = device.ip_address.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `device.ip_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:258:3 [INFO] [stderr] | [INFO] [stderr] 258 | if url_result.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `url_result?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:262:3 [INFO] [stderr] | [INFO] [stderr] 262 | if url.host().is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `url.host()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:281:3 [INFO] [stderr] | [INFO] [stderr] 281 | if serial_number.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `serial_number?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/xml.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / for capture in re.captures_iter(xml) { [INFO] [stderr] 12 | | return capture.at(1); [INFO] [stderr] 13 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wemo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/subscriptions.rs:268:3 [INFO] [stderr] | [INFO] [stderr] 268 | stream.write(header.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:162:44 [INFO] [stderr] | [INFO] [stderr] 162 | dynamic_ip_address: RwLock::new(Some(search_result.ip_address.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `search_result.ip_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device/switch.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / match result { [INFO] [stderr] 370 | | Ok(r) => { return Ok(r); }, [INFO] [stderr] 371 | | Err(_) => {}, // TODO [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(r) = result { return Ok(r); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/device/switch.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / match result { [INFO] [stderr] 415 | | Ok(r) => { return Ok(r); }, [INFO] [stderr] 416 | | Err(_) => {}, // TODO: Return type [INFO] [stderr] 417 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(r) = result { return Ok(r); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:456:46 [INFO] [stderr] | [INFO] [stderr] 456 | DeviceIdentifier::StaticIp(ip) => Some(ip.clone()), [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/device/switch.rs:460:28 [INFO] [stderr] | [INFO] [stderr] 460 | .and_then(|ip| ip.clone()) [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/net/soap.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | match self.stream_socket.write_all(&mut header.as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `net::ssdp::DeviceSearch` [INFO] [stderr] --> src/net/ssdp.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> DeviceSearch { [INFO] [stderr] 55 | | let socket = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)), 0); [INFO] [stderr] 56 | | let udp_socket = UdpSocket::v4().unwrap(); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for net::ssdp::DeviceSearch { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/net/ssdp.rs:86:47 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn search_for_serial(&mut self, target: &SerialNumber, timeout_ms: u64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/ssdp.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | self.target_ip_address = Some(target.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/net/ssdp.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | self.found_devices.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.found_devices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/net/ssdp.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | self.socket.send_to(&mut header.as_bytes(), &multicast_socket) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/net/ssdp.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | for i in 0 .. amt { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 165 | for in buf.iter().take(amt) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/ssdp.rs:180:32 [INFO] [stderr] | [INFO] [stderr] 180 | let ip_address: IpAddr = device.ip_address.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `device.ip_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:258:3 [INFO] [stderr] | [INFO] [stderr] 258 | if url_result.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `url_result?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:262:3 [INFO] [stderr] | [INFO] [stderr] 262 | if url.host().is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `url.host()?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/net/ssdp.rs:281:3 [INFO] [stderr] | [INFO] [stderr] 281 | if serial_number.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `serial_number?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/xml.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / for capture in re.captures_iter(xml) { [INFO] [stderr] 12 | | return capture.at(1); [INFO] [stderr] 13 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wemo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "023037c94f37d0dc091fe2795fb8bfce3eae40a89b0880330f3d87a21b9b392c"` [INFO] running `"docker" "rm" "-f" "023037c94f37d0dc091fe2795fb8bfce3eae40a89b0880330f3d87a21b9b392c"` [INFO] [stdout] 023037c94f37d0dc091fe2795fb8bfce3eae40a89b0880330f3d87a21b9b392c